From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Convert chdir01 to the new API
Date: Thu, 23 Jul 2020 13:33:17 +0200 [thread overview]
Message-ID: <20200723113317.GA18525@dell5510> (raw)
In-Reply-To: <2b209b61-2bbc-c35f-5704-7b84bab9254d@cn.fujitsu.com>
Hi,
> Honestly speak, I don't like merge chdir02 into chdir01 and we should
> cleanup chdir02 case individually.
chdir02.c tests chdir("/"); and chdir("/tmp"). Not sure whether full path is
more coverage than relative path from chdir01.c.
If we consider these useful, we can just add it into chdir01.c.
Although it looks a bit strange to chroot into root, I'd use just that and avoid
/tmp (it breaks at least for Android with no good reason).
It might makes sense to use .all_filesystems = 1.
> I prefer to merge chdir03 and chdir04 into chdir01 because they are all
> error test.
> Also, when tesing EACCES error,it succeeded.
> tst_test.c:1245: INFO: Timeout per run is 0h 05m 00s
> chdir01.c:68: PASS: chdir("testfile") returns correct value: ENOTDIR (20)
> chdir01.c:68: PASS: chdir("symloop") returns correct value: ELOOP (40)
> chdir01.c:61: FAIL: chdir("keep_out") returned unexpected value 0: SUCCESS
> (0)
Got the same problem on 5.8.0 (on all filesystems).
> chdir01.c:68: PASS: chdir("subdir") returns correct value: SUCCESS (0)
> chdir01.c:68: PASS: chdir(".") returns correct value: SUCCESS (0)
> chdir01.c:68: PASS: chdir("..") returns correct value: SUCCESS (0)
> chdir01.c:68: PASS: chdir("missing") returns correct value: ENOENT (2)
> Best regards
> Yang Xu
Kind regards,
Petr
next prev parent reply other threads:[~2020-07-23 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 15:24 [LTP] [PATCH] Convert chdir01 to the new API Martin Doucha
2020-07-22 8:52 ` Yang Xu
2020-07-23 11:33 ` Petr Vorel [this message]
2020-07-24 8:07 ` Cyril Hrubis
2020-07-24 12:36 ` Petr Vorel
2020-07-24 12:47 ` Martin Doucha
2020-07-24 13:26 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723113317.GA18525@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.