From: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs: balance root leak and runaway balance fix
Date: Thu, 23 Jul 2020 17:54:30 -0400 [thread overview]
Message-ID: <20200723215430.GC5890@hungrycats.org> (raw)
In-Reply-To: <20200522111347.GJ18421@twin.jikos.cz>
On Fri, May 22, 2020 at 01:13:47PM +0200, David Sterba wrote:
> On Wed, May 20, 2020 at 02:58:49PM +0800, Qu Wenruo wrote:
> > This patchset will fix the most wanted balance bug, runaway balance.
> > All my fault, and all small fixes.
>
> Well, that happens.
>
> d2311e698578 ("btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots")
>
> is the most broken patch in recent history (5.1+), there were so many
> fixups but hopefully this is the last one. I've tagged the patches for
> 5.1+ stable but we'll need manual backports due to the root refcount
> changes in 5.7.
The patch 1dae7e0e58b4 "btrfs: reloc: clear DEAD_RELOC_TREE bit for
orphan roots to prevent runaway balance" does apply to 5.7 itself, but
it is not present in 5.7.10. I've been running it in test (and even a
few pre-prod) systems since May.
We still get someone in IRC with a runaway balance every week or so.
Currently we can only tell them to wait for 5.8, or roll all the way
back to 4.19.
> I reproduced the umount crash and verified the fix, the runaway balance
> does not happen anymore in the test so I guess we have all the needed
> fixes in place to allow the fast balance cancel. Thanks.
next prev parent reply other threads:[~2020-07-23 21:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 6:58 [PATCH 0/2] btrfs: balance root leak and runaway balance fix Qu Wenruo
2020-05-20 6:58 ` [PATCH 1/2] btrfs: relocation: Fix reloc root leakage and the NULL pointer reference caused by the leakage Qu Wenruo
2020-05-20 6:58 ` [PATCH 2/2] btrfs: relocation: Clear the DEAD_RELOC_TREE bit for orphan roots to prevent runaway balance Qu Wenruo
2020-05-22 11:13 ` [PATCH 0/2] btrfs: balance root leak and runaway balance fix David Sterba
2020-07-23 21:54 ` Zygo Blaxell [this message]
2020-07-24 0:05 ` Qu Wenruo
2020-07-24 9:33 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723215430.GC5890@hungrycats.org \
--to=ce3g8jdj@umail.furryterror.org \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.