All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: George Shuklin <amarao@servers.com>
Cc: netdev@vger.kernel.org
Subject: Re: Bug in iproute2 man page (or in iproute itself)
Date: Fri, 24 Jul 2020 08:35:40 -0700	[thread overview]
Message-ID: <20200724083540.0d0df332@hermes.lan> (raw)
In-Reply-To: <869fed82-bb31-589f-bd26-591ccfa976ed@servers.com>

On Fri, 24 Jul 2020 15:45:20 +0300
George Shuklin <amarao@servers.com> wrote:

> Hello.
> 
> I'm writing Ansible module for iproute, and I found some discrepancies 
> between man page and actual behavior for ip link add type bridge.
> 
> man page said:
> 
> hello_time HELLO_TIME - set the time in seconds between hello packets 
> sent by the bridge, when it is a root bridge or a designated bridges.  
> Only relevant if STP
> is enabled. Valid values are between 1 and 10.
> 
> max_age MAX_AGE - set the hello packet timeout, ie the time in seconds 
> until another bridge in the spanning tree is assumed to be dead, after 
> reception of its
> last hello message. Only relevant if STP is enabled. Valid values are 
> between 6 and 40.
> 
> In reality 'ip link add type bridge' requires hello_time to be at least 
> 100, and max_age to be at least 600. I suspect there is a missing x100 
> multiplier, either in docs, or in the code.
> 
> (I'm not sure where I should send bugreports for iproute2).
> 

Good catch all the time related values in netlink API should be
scaled by the user hz value (which is 100).

  reply	other threads:[~2020-07-24 15:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 12:45 Bug in iproute2 man page (or in iproute itself) George Shuklin
2020-07-24 15:35 ` Stephen Hemminger [this message]
2020-07-24 16:15 ` [RFT iproute2] iplink_bridge: scale all time values by USER_HZ Stephen Hemminger
2020-07-24 16:24   ` nikolay
2020-07-24 19:05     ` Stephen Hemminger
2020-07-24 22:51       ` Nikolay Aleksandrov
2020-07-24 23:18         ` Vladimir Oltean
2020-07-25  0:31     ` David Miller
2020-07-26  3:17       ` Stephen Hemminger
2020-07-26 10:43         ` [RFC iproute2] ip: bridge: use -human to convert time-related values to seconds Nikolay Aleksandrov
2020-07-26 16:21           ` Vladimir Oltean
2020-07-26 16:34             ` Nikolay Aleksandrov
2020-07-26 16:50               ` Vladimir Oltean
2020-07-27 16:36                 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724083540.0d0df332@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=amarao@servers.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.