All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/4] libs: sigwait: Add SAFE_SIG*() macros
Date: Fri, 24 Jul 2020 10:43:31 +0200	[thread overview]
Message-ID: <20200724084331.GD9768@yuki.lan> (raw)
In-Reply-To: <8b0c584c86d4f45212ccf418e9840a53b6e62a09.1595511710.git.viresh.kumar@linaro.org>

Hi!
Pushed with a minor change, thanks.

diff --git a/include/tst_safe_macros.h b/include/tst_safe_macros.h
index 3fce473cc..f3f83cddd 100644
--- a/include/tst_safe_macros.h
+++ b/include/tst_safe_macros.h
@@ -438,8 +438,9 @@ static inline void safe_sigaddset(const char *file, const int lineno,
 
 	rval = sigaddset(sigs, signo);
 	if (rval == -1) {
-		tst_brk_(file, lineno, TBROK | TERRNO, "sigaddset(%d) failed",
-			 signo);
+		tst_brk_(file, lineno, TBROK | TERRNO,
+		         "sigaddset() %s (%i) failed",
+			 tst_strsig(signo), signo);
 	}
 }
 
@@ -453,8 +454,9 @@ static inline void safe_sigdelset(const char *file, const int lineno,
 
 	rval = sigdelset(sigs, signo);
 	if (rval == -1) {
-		tst_brk_(file, lineno, TBROK | TERRNO, "sigdelset(%d) failed",
-			 signo);
+		tst_brk_(file, lineno, TBROK | TERRNO,
+		         "sigdelset() %s (%i) failed",
+			 tst_strsig(signo), signo);
 	}
 }
 


-- 
Cyril Hrubis
chrubis@suse.cz

  parent reply	other threads:[~2020-07-24  8:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 13:42 [LTP] [PATCH 1/4] libs: sigwait: Use SAFE_FORK() Viresh Kumar
2020-07-23 13:42 ` [LTP] [PATCH 2/4] libs: sigwait: Add SAFE_SIG*() macros Viresh Kumar
2020-07-24  5:51   ` Petr Vorel
2020-07-24  8:43   ` Cyril Hrubis [this message]
2020-07-23 13:42 ` [LTP] [PATCH 3/4] libs: sigwait: Remove alarm() from setup() and cleanup() Viresh Kumar
2020-07-24  5:52   ` Petr Vorel
2020-07-24  8:44   ` Cyril Hrubis
2020-07-23 13:42 ` [LTP] [PATCH 4/4] libs: sigwait: Get rid of REPORT_SUCCESS() macro Viresh Kumar
2020-07-24  5:58   ` Petr Vorel
2020-07-24 10:34     ` Viresh Kumar
2020-07-24 12:20       ` Cyril Hrubis
2020-07-24 13:37       ` Petr Vorel
2020-07-24 12:32   ` Cyril Hrubis
2020-07-24 13:35     ` Petr Vorel
2020-07-24  5:49 ` [LTP] [PATCH 1/4] libs: sigwait: Use SAFE_FORK() Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724084331.GD9768@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.