From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, Larry Finger <Larry.Finger@lwfinger.net>,
Shreeya Patel <shreeya.patel23498@gmail.com>,
Julia Lawall <julia.lawall@inria.fr>,
Michael Straube <straube.linux@gmail.com>,
Stefano Brivio <sbrivio@redhat.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode
Date: Fri, 24 Jul 2020 15:28:36 +0200 [thread overview]
Message-ID: <20200724132836.GC316746@kroah.com> (raw)
In-Reply-To: <20200724122957.30411-1-dinghao.liu@zju.edu.cn>
On Fri, Jul 24, 2020 at 08:29:55PM +0800, Dinghao Liu wrote:
> The variable authmode will keep uninitialized if neither if
> statements used to initialize this variable are not triggered.
> Then authmode may contain a garbage value and influence the
> execution flow of this function.
>
> Fix this by initializing it to zero.
That does not fix anything, you just now are potentially setting a value
you really do not have.
Are you sure that this variable really will never be set? If so, please
fix it up with a "real" value that the code can handle properly.
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-24 13:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 12:29 [PATCH] Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode Dinghao Liu
2020-07-24 13:28 ` Greg Kroah-Hartman [this message]
2020-07-24 17:56 ` Larry Finger
2020-07-27 13:39 ` dinghao.liu
2020-07-27 11:44 ` Dan Carpenter
2020-07-27 13:23 ` Dan Carpenter
2020-07-27 14:45 ` dinghao.liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724132836.GC316746@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=julia.lawall@inria.fr \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=shreeya.patel23498@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.