From: Adam Borowski <kilobyte@angband.pl>
To: Ingo Molnar <mingo@kernel.org>
Cc: Nick Terrell <nickrterrell@gmail.com>,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Chris Mason <clm@fb.com>,
linux-kbuild@vger.kernel.org, x86@kernel.org,
gregkh@linuxfoundation.org, Petr Malat <oss@malat.biz>,
Kees Cook <keescook@chromium.org>,
Kernel Team <Kernel-team@fb.com>,
Patrick Williams <patrickw3@fb.com>,
rmikey@fb.com, Patrick Williams <patrick@stwcx.xyz>,
Sedat Dilek <sedat.dilek@gmail.com>,
Norbert Lange <nolange79@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alex Xu <alex_y_xu@yahoo.ca>,
Arvind Sankar <nivedita@alum.mit.edu>,
Nick Terrell <terrelln@fb.com>
Subject: Re: [PATCH v8 6/7] x86: Add support for ZSTD compressed kernel
Date: Fri, 24 Jul 2020 15:46:25 +0200 [thread overview]
Message-ID: <20200724134625.GA4100@angband.pl> (raw)
In-Reply-To: <20200724122640.GC632343@gmail.com>
On Fri, Jul 24, 2020 at 02:26:40PM +0200, Ingo Molnar wrote:
> > -#ifdef CONFIG_KERNEL_BZIP2
> > +#if defined(CONFIG_KERNEL_BZIP2)
> > # define BOOT_HEAP_SIZE 0x400000
> > -#else /* !CONFIG_KERNEL_BZIP2 */
> > +#elif defined(CONFIG_KERNEL_ZSTD)
> > +# define BOOT_HEAP_SIZE 0x30000
> > +#else
> > # define BOOT_HEAP_SIZE 0x10000
> > #endif
>
> So the other patches explain why the decompression buffer extra space
> was increased from 64k to 128k, but is there a similar
> calculation/estimate for bumping BOOT_HEAD_SIZE from 64k to 192k?
>
> Admittedly the BZ2 exception doesn't set a good example, but maybe we
> can do this for ZSTD?
By the way, I have a patchset on top of this, to drop BZ2 and LZMA(1)
support, that should clean up this code somewhat. And bring a lot of
lines of Linus happiness, as both bzip2 and lzma code are not used by
anything else in the kernel, unlike lzma2 (xz).
If you draw a speed-vs-size graph, at no point bzip2 or lzma are a good
choice, while zstd wins by a large margin for most of the range.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ It's time to migrate your Imaginary Protocol from version 4i to 6i.
⠈⠳⣄⠀⠀⠀⠀
next prev parent reply other threads:[~2020-07-24 14:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 19:27 [GIT PULL][PATCH v8 0/7] Add support for ZSTD-compressed kernel and initramfs Nick Terrell
2020-07-23 19:27 ` [PATCH v8 1/7] lib: prepare zstd for preboot environment Nick Terrell
2020-07-23 19:27 ` [PATCH v8 2/7] lib: add zstd support to decompress Nick Terrell
2020-07-24 12:12 ` Ingo Molnar
2020-07-23 19:27 ` [PATCH v8 3/7] init: add support for zstd compressed kernel Nick Terrell
2020-07-23 20:30 ` Randy Dunlap
2020-07-24 12:17 ` Ingo Molnar
2020-07-24 14:09 ` Randy Dunlap
2020-07-23 19:27 ` [PATCH v8 4/7] usr: add support for zstd compressed initramfs Nick Terrell
2020-07-23 19:27 ` [PATCH v8 5/7] x86: bump ZO_z_extra_bytes margin for zstd Nick Terrell
2020-07-23 19:28 ` [PATCH v8 6/7] x86: Add support for ZSTD compressed kernel Nick Terrell
2020-07-24 0:50 ` Sedat Dilek
2020-07-24 14:30 ` Arvind Sankar
2020-07-24 14:48 ` Sedat Dilek
2020-07-24 17:38 ` Arvind Sankar
2020-07-27 22:44 ` Nick Terrell
2020-07-24 12:26 ` Ingo Molnar
2020-07-24 13:46 ` Adam Borowski [this message]
2020-07-27 22:43 ` Nick Terrell
2020-07-23 19:28 ` [PATCH v8 7/7] .gitignore: add ZSTD-compressed files Nick Terrell
2020-07-24 0:49 ` [GIT PULL][PATCH v8 0/7] Add support for ZSTD-compressed kernel and initramfs Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724134625.GA4100@angband.pl \
--to=kilobyte@angband.pl \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=alex_y_xu@yahoo.ca \
--cc=bp@alien8.de \
--cc=clm@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nickrterrell@gmail.com \
--cc=nivedita@alum.mit.edu \
--cc=nolange79@gmail.com \
--cc=oss@malat.biz \
--cc=patrick@stwcx.xyz \
--cc=patrickw3@fb.com \
--cc=rmikey@fb.com \
--cc=sedat.dilek@gmail.com \
--cc=terrelln@fb.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.