All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: revert "i2c: core: Allow drivers to disable i2c-core irq mapping"
Date: Fri, 24 Jul 2020 21:56:42 +0200	[thread overview]
Message-ID: <20200724195642.GH1227@ninjato> (raw)
In-Reply-To: <02adeb3f-761a-32e8-6596-81ccb7cafa6e@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

Hi Hans,

> > Build tested only. Looking for Hans' opinion here.
> 
> I'm fine with removing this.

Thanks!

[semi off-topic case]

> So basically allow board_info to say:
> 
> "There is no IRQ and do not try to find one"
> 
> This could be as simple as having the instantiating code do:
> 
> 	board_info.irq = -ENOENT;

...

> ATM I do not have a use-case for this, still I think this would be
> useful to have. Would you be willing to take a patch with the above
> change for this?

I haven't checked your code change in detail to check for side-effects.
In general, I think we could have something like this. However, I am a
bit conservative when it comes to changing something without a use case.

All the best,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-07-24 19:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 16:24 [PATCH] i2c: revert "i2c: core: Allow drivers to disable i2c-core irq mapping" Wolfram Sang
2020-07-03 12:45 ` Hans de Goede
2020-07-24 19:56   ` Wolfram Sang [this message]
2020-07-24 19:52 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724195642.GH1227@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-i2c@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.