From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0B95C433E0 for ; Sun, 26 Jul 2020 12:04:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBAA52070A for ; Sun, 26 Jul 2020 12:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595765074; bh=LJxegL2P5hNKR910G8c/QDoI1uB2BfRFQ4PeiQJwStQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zoV4lCN8jgfLjjNkIczqd4EeS1D+Lx+wdYXxckRt6KWSZGPWuDokeYyzh/cgjogEr pCpYTe2BKpLuysA4YQjfGvVW7WTkMUxr1yaQfUH22uSJDU62oUClQYGADoFQvJWXAk 2+gE+2QRQOYnFzQ1xGEOmjznghqsf4ZGPpYeiMiM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726237AbgGZMEd (ORCPT ); Sun, 26 Jul 2020 08:04:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:43366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbgGZME1 (ORCPT ); Sun, 26 Jul 2020 08:04:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40BAB2065E; Sun, 26 Jul 2020 12:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595765065; bh=LJxegL2P5hNKR910G8c/QDoI1uB2BfRFQ4PeiQJwStQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xy0KtmyrKY0jX8tITQlUegCxmDYNtTsgBZMQUvwmUrdMbIF0cVKjshR0MQeIGNHRj u3dZWeWJc5V9C/OxmUSuefkUN6fX7aAq8RXQINPs/V1QurcwpCNTAP9KonYrK9ZOLC qACyVZsJwgPmYtOqUITCkz9UKqybv0a91ujrcAaY= Date: Sun, 26 Jul 2020 14:04:22 +0200 From: Greg Kroah-Hartman To: Konrad Dybcio Cc: Martin Botka , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , Vinod Koul , Michael Turquette , Stephen Boyd , Felipe Balbi , Jordan Crouse , zhengbin , Jeffrey Hugo , AngeloGioacchino Del Regno , Ben Dooks , Krzysztof Wilczynski , Harigovindan P , Brian Masney , Sam Ravnborg , Xiaozhe Shi , Manu Gautam , linux-arm-msm , "open list:DRM PANEL DRIVERS" , freedreno , DTML , Linux Kernel Mailing List , linux-usb@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 9/9] soc/qcom: Add REVID driver Message-ID: <20200726120422.GA1292190@kroah.com> References: <20200726111215.22361-1-konradybcio@gmail.com> <20200726111215.22361-10-konradybcio@gmail.com> <20200726112920.GA1286220@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun, Jul 26, 2020 at 01:40:46PM +0200, Konrad Dybcio wrote: > >Horrible global symbol name. Who calls this? > > Welcome to development on qcom platforms :D Yeah, I have seen :( > >This is the last patch in > >the series, so if there is no user for this, please don't export it. > > Other downstream drivers make use of it.. need to get this up first, sorry :V Then use a proper name for it, with a correct prefix, and export it with EXPORT_SYMBOL_GPL() please. > >Why do you need a .h file in the include directory if only a single .c > >file needs it? Just put that info in the .c file itself. > > Again, other downstream drivers which some people and I intend to > bring to upstream standards use that to access the PMIC model/hw revision. But all of those defines are not needed, just the function name, right? > >But again, who uses this module? If it's only good for a single line in > >the kernel log, that feels like a huge waste to me. > > downstream-kernel-dir$ rg -l qpnp-revid.h | wc -l > 25 > > So yeah, quite a bunch of other qcom-specific drivers. > > I'll try to fix these and send a v2. Hold off on this and wait until there is a real user for it, as we can not take api additions without a user, otherwise we will just come along and delete the code. Submit it as part of a series that actually uses the function, so we can at least see if the function makes sense to be used in that way as well, right now we have no clue. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62139C433E1 for ; Sun, 26 Jul 2020 12:04:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 346072070A for ; Sun, 26 Jul 2020 12:04:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xy0Ktmyr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 346072070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A55189DA4; Sun, 26 Jul 2020 12:04:26 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6457189DA4; Sun, 26 Jul 2020 12:04:25 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40BAB2065E; Sun, 26 Jul 2020 12:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595765065; bh=LJxegL2P5hNKR910G8c/QDoI1uB2BfRFQ4PeiQJwStQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xy0KtmyrKY0jX8tITQlUegCxmDYNtTsgBZMQUvwmUrdMbIF0cVKjshR0MQeIGNHRj u3dZWeWJc5V9C/OxmUSuefkUN6fX7aAq8RXQINPs/V1QurcwpCNTAP9KonYrK9ZOLC qACyVZsJwgPmYtOqUITCkz9UKqybv0a91ujrcAaY= Date: Sun, 26 Jul 2020 14:04:22 +0200 From: Greg Kroah-Hartman To: Konrad Dybcio Subject: Re: [PATCH 9/9] soc/qcom: Add REVID driver Message-ID: <20200726120422.GA1292190@kroah.com> References: <20200726111215.22361-1-konradybcio@gmail.com> <20200726111215.22361-10-konradybcio@gmail.com> <20200726112920.GA1286220@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof Wilczynski , Jeffrey Hugo , David Airlie , Michael Turquette , "open list:DRM PANEL DRIVERS" , Bjorn Andersson , AngeloGioacchino Del Regno , Sam Ravnborg , linux-clk@vger.kernel.org, Kishon Vijay Abraham I , Martin Botka , Andy Gross , Brian Masney , DTML , linux-arm-msm , Xiaozhe Shi , Rob Herring , Sean Paul , Ben Dooks , Felipe Balbi , Stephen Boyd , linux-usb@vger.kernel.org, Harigovindan P , Linux Kernel Mailing List , zhengbin , Manu Gautam , Vinod Koul , freedreno Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Jul 26, 2020 at 01:40:46PM +0200, Konrad Dybcio wrote: > >Horrible global symbol name. Who calls this? > > Welcome to development on qcom platforms :D Yeah, I have seen :( > >This is the last patch in > >the series, so if there is no user for this, please don't export it. > > Other downstream drivers make use of it.. need to get this up first, sorry :V Then use a proper name for it, with a correct prefix, and export it with EXPORT_SYMBOL_GPL() please. > >Why do you need a .h file in the include directory if only a single .c > >file needs it? Just put that info in the .c file itself. > > Again, other downstream drivers which some people and I intend to > bring to upstream standards use that to access the PMIC model/hw revision. But all of those defines are not needed, just the function name, right? > >But again, who uses this module? If it's only good for a single line in > >the kernel log, that feels like a huge waste to me. > > downstream-kernel-dir$ rg -l qpnp-revid.h | wc -l > 25 > > So yeah, quite a bunch of other qcom-specific drivers. > > I'll try to fix these and send a v2. Hold off on this and wait until there is a real user for it, as we can not take api additions without a user, otherwise we will just come along and delete the code. Submit it as part of a series that actually uses the function, so we can at least see if the function makes sense to be used in that way as well, right now we have no clue. thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel