Re: [PATCH 9/9] soc/qcom: Add REVID driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2872 bytes --]

Hi Konrad,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on clk/clk-next usb/usb-testing balbi-usb/testing/next linus/master v5.8-rc6 next-20200724]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Konrad-Dybcio/SDM630-36-60-driver-enablement/20200726-191809
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: parisc-allmodconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/soc/qcom/qpnp-revid.c:113:25: error: redefinition of 'get_revid_data'
     113 | struct pmic_revid_data *get_revid_data(struct device_node *dev_node)
         |                         ^~~~~~~~~~~~~~
   In file included from drivers/soc/qcom/qpnp-revid.c:19:
   include/linux/qpnp/qpnp-revid.h:364:25: note: previous definition of 'get_revid_data' was here
     364 | struct pmic_revid_data *get_revid_data(struct device_node *dev_node)
         |                         ^~~~~~~~~~~~~~

vim +/get_revid_data +113 drivers/soc/qcom/qpnp-revid.c

   102	
   103	/**
   104	 * get_revid_data - Return the revision information of PMIC
   105	 * @dev_node: Pointer to the revid peripheral of the PMIC for which
   106	 *		revision information is seeked
   107	 *
   108	 * CONTEXT: Should be called in non atomic context
   109	 *
   110	 * RETURNS: pointer to struct pmic_revid_data filled with the information
   111	 *		about the PMIC revision
   112	 */
 > 113	struct pmic_revid_data *get_revid_data(struct device_node *dev_node)
   114	{
   115		struct revid_chip *revid_chip;
   116	
   117		if (!dev_node)
   118			return ERR_PTR(-EINVAL);
   119	
   120		mutex_lock(&revid_chips_lock);
   121		list_for_each_entry(revid_chip, &revid_chips, link) {
   122			if (dev_node == revid_chip->dev_node) {
   123				mutex_unlock(&revid_chips_lock);
   124				return &revid_chip->data;
   125			}
   126		}
   127		mutex_unlock(&revid_chips_lock);
   128		return ERR_PTR(-EINVAL);
   129	}
   130	EXPORT_SYMBOL(get_revid_data);
   131	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65118 bytes --]