From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1431C433E3 for ; Mon, 27 Jul 2020 15:38:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92212206E7 for ; Mon, 27 Jul 2020 15:38:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92212206E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cox.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 37147899BE; Mon, 27 Jul 2020 15:38:59 +0000 (UTC) Received: from omta015.useast.a.cloudfilter.net (omta015.useast.a.cloudfilter.net [34.195.253.206]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F55A89A88; Mon, 27 Jul 2020 15:38:03 +0000 (UTC) Received: from cxr.smtp.a.cloudfilter.net ([10.0.16.145]) by cmsmtp with ESMTP id zy3xj7xIFxItl05CUkAVIl; Mon, 27 Jul 2020 15:38:03 +0000 Received: from ws ([68.106.48.162]) by cmsmtp with ESMTPSA id 05CIkRkFGKrUj05CJkzNoN; Mon, 27 Jul 2020 15:38:02 +0000 Authentication-Results: cox.net; auth=pass (LOGIN) smtp.auth=1i5t5.duncan@cox.net X-Authority-Analysis: v=2.4 cv=Wu6VjfTv c=1 sm=1 tr=0 ts=5f1ef4da a=fEuF7Lzz1MGHEe1xFtqdOg==:117 a=fEuF7Lzz1MGHEe1xFtqdOg==:17 a=IkcTkHD0fZMA:10 a=zd2uoN0lAAAA:8 a=VwQbUJbxAAAA:8 a=kviXuzpPAAAA:8 a=sfOm8-O8AAAA:8 a=GEFCdFOGbQv7mSB_pWQA:9 a=tqTlq1B0_eMsoCT5:21 a=h_W-Jm2LaEDf4Mgu:21 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=qrIFiuKZe2vaD64auk6j:22 a=TvTJqdcANYtsRzA46cdi:22 Date: Mon, 27 Jul 2020 08:37:49 -0700 From: Duncan <1i5t5.duncan@cox.net> To: "Kazlauskas, Nicholas" Subject: Re: [PATCH] drm/amd/display: Clear dm_state for fast updates Message-ID: <20200727083749.7b0fe41d@ws> In-Reply-To: References: X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CMAE-Envelope: MS4xfGkEX9Tay6GTZG9sI91aPbcWvbf0prl9drr0Vb6zi1HgHYrb/SN12LpKXhuWCazaf+qGdIhr0rDqn9HLwAXeM3wycfWeeljqu1boy1ql56iXYF2bAXJz 4PrWzP+Uy36trlqXirzeMrGeboMFt5LYoa6RHk/m4z70GBnLHEb6dD51SPsGoU4nyO9+XjhxIA7nzI+kH3dHHRcaTZJKCsWPmAKdNAFR85/ZzNe/G505umhL h5CVTpg7b1YPJw/h0qcK/1supgqADO8HdqrrhcUkwDxg0wBbbhtvN4knfxZ15D9ZP7Vdp3TwhRWBocd9U846F4Myu7GiNfD1fEPPgypGBriCShImbrMLiNMt I8jOgqdsreoANf1ywhz9Rmlj+/tPyho79HkyyOJslD72GwFlmp+FtkCAExRvUWW5o3PuuZ1k8068az/563afztRlxPOQjjl6JZlAwYnBQZBWcc2zGrVJLf21 A0WiYWxTG32RH9chFcrpewHDI5k9VQICRbmygXFqWm72nVjpGOXgsSEESMKBd7pC9eEmiuhV1gGAFrl2i6kuFALoqDWw22oWX4OE8XA3fSlsvUckRa429M7i F+PNepcnIOHv/i8opDVBn1KoLqr4xLXANds5JsRyi7cHs5Z1vOKxnyuCIJ7Ku+iNvZQikjzJ31959ojtKu9vJwdVZ04RpiXp0mpWHlVh4edw/Q== X-Mailman-Approved-At: Mon, 27 Jul 2020 15:38:57 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Menzel , "anthony.ruhier@gmail.com" , Kees Cook , "sunpeng.li@amd.com" , Mazin Rezk , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "regressions@leemhuis.info" , "amd-gfx@lists.freedesktop.org" , Alexander Deucher , Andrew Morton , "mphantomx@yahoo.com.br" , Harry Wentland , Christian =?UTF-8?B?S8O2bmln?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gTW9uLCAyNyBKdWwgMjAyMCAxMDowNTowMSAtMDQwMAoiS2F6bGF1c2thcywgTmljaG9sYXMi IDxuaWNob2xhcy5rYXpsYXVza2FzQGFtZC5jb20+IHdyb3RlOgoKPiBPbiAyMDIwLTA3LTI3IDk6 MzkgYS5tLiwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiA+IEFtIDI3LjA3LjIwIHVtIDA3OjQw IHNjaHJpZWIgTWF6aW4gUmV6azoKPiA+PiBUaGlzIHBhdGNoIGZpeGVzIGEgcmFjZSBjb25kaXRp b24gdGhhdCBjYXVzZXMgYSB1c2UtYWZ0ZXItZnJlZQo+ID4+IGR1cmluZyBhbWRncHVfZG1fYXRv bWljX2NvbW1pdF90YWlsLiBUaGlzIGNhbiBvY2N1ciB3aGVuIDIKPiA+PiBub24tYmxvY2tpbmcg Y29tbWl0cyBhcmUgcmVxdWVzdGVkIGFuZCB0aGUgc2Vjb25kIG9uZSBmaW5pc2hlcwo+ID4+IGJl Zm9yZSB0aGUgZmlyc3QuIEVzc2VudGlhbGx5LCB0aGlzIGJ1ZyBvY2N1cnMgd2hlbiB0aGUgZm9s bG93aW5nCj4gPj4gc2VxdWVuY2Ugb2YgZXZlbnRzIGhhcHBlbnM6Cj4gPj4KPiA+PiAxLiBOb24t YmxvY2tpbmcgY29tbWl0ICMxIGlzIHJlcXVlc3RlZCB3LyBhIG5ldyBkbV9zdGF0ZSAjMSBhbmQg aXMKPiA+PiBkZWZlcnJlZCB0byB0aGUgd29ya3F1ZXVlLgo+ID4+Cj4gPj4gMi4gTm9uLWJsb2Nr aW5nIGNvbW1pdCAjMiBpcyByZXF1ZXN0ZWQgdy8gYSBuZXcgZG1fc3RhdGUgIzIgYW5kIGlzCj4g Pj4gZGVmZXJyZWQgdG8gdGhlIHdvcmtxdWV1ZS4KPiA+Pgo+ID4+IDMuIENvbW1pdCAjMiBzdGFy dHMgYmVmb3JlIGNvbW1pdCAjMSwgZG1fc3RhdGUgIzEgaXMgdXNlZCBpbiB0aGUKPiA+PiBjb21t aXRfdGFpbCBhbmQgY29tbWl0ICMyIGNvbXBsZXRlcywgZnJlZWluZyBkbV9zdGF0ZSAjMS4KPiA+ Pgo+ID4+IDQuIENvbW1pdCAjMSBzdGFydHMgYWZ0ZXIgY29tbWl0ICMyIGNvbXBsZXRlcywgdXNl cyB0aGUgZnJlZWQKPiA+PiBkbV9zdGF0ZSAxIGFuZCBkZXJlZmVyZW5jZXMgYSBmcmVlbGlzdCBw b2ludGVyIHdoaWxlIHNldHRpbmcgdGhlCj4gPj4gY29udGV4dC4KPiA+IAo+ID4gV2VsbCBJIG9u bHkgaGF2ZSBhIG9uZSBtaWxlIGhpZ2ggdmlldyBvbiB0aGlzLCBidXQgd2h5IGRvbid0IHlvdQo+ ID4gbGV0IHRoZSB3b3JrIGl0ZW1zIGV4ZWN1dGUgaW4gb3JkZXI/Cj4gPiAKPiA+IFRoYXQgd291 bGQgYmUgYmV0dGVyIGFueXdheSBjYXVzZSB0aGlzIHdheSB3ZSBkb24ndCB0cmlnZ2VyIGEgY2Fj aGUKPiA+IGxpbmUgcGluZyBwb25nIGJldHdlZW4gQ1BVcy4KPiA+IAo+ID4gQ2hyaXN0aWFuLgo+ IAo+IFdlIHVzZSB0aGUgRFJNIGhlbHBlcnMgZm9yIG1hbmFnaW5nIGRybV9hdG9taWNfY29tbWl0 X3N0YXRlIGFuZCB0aG9zZSAKPiBoZWxwZXJzIGludGVybmFsbHkgcHVzaCBub24tYmxvY2tpbmcg Y29tbWl0IHdvcmsgaW50byB0aGUgc3lzdGVtCj4gdW5ib3VuZCB3b3JrIHF1ZXVlLgo+IAo+IFdo aWxlIHdlIGNvdWxkIGR1cGxpY2F0ZSBhIGNvcHkgb2YgdGhhdCBjb2RlIHdpdGggbm90aGluZyBi dXQgdGhlIAo+IHdvcmtxdWV1ZSBjaGFuZ2VkIHRoYXQgaXNuJ3Qgc29tZXRoaW5nIEknZCByZWFs bHkgbGlrZSB0byBtYWludGFpbgo+IGdvaW5nIGZvcndhcmQuCj4gCj4gUmVnYXJkcywKPiBOaWNo b2xhcyBLYXpsYXVza2FzCgpBZGRpdGlvbmFsbHksIEkgZG9uJ3Qgc2VlIG1lbnRpb25lZCBvbi10 aHJlYWQgKGl0J3Mgb24gdGhlIGJ1ZyBhbmQgbm93CmluIHRoZSBkZXRhaWxzIGJlbG93KSB0aGF0 IHdlJ3JlIHRhbGtpbmcgbXVsdGktbW9uaXRvciwgbm90CnNpbmdsZS1tb25pdG9yLiBQcmVzdW1h Ymx5IHRoYXQgZ29lcyBzb21lIHdheSB0b3dhcmQgYW5zd2VyaW5nIHRoZSAid2h5Cm5vdCBmb3Jj ZSBvcmRlcj8iIHF1ZXN0aW9uLCBjb25zaWRlcmluZyB0aGUgb3V0cHV0cyBtYXkgYmUgcnVubmlu ZyBhdApkaWZmZXJlbnQgcmVmcmVzaCBmcmVxdWVuY2llcywgZXRjLi4uCgpBbGwgdGhlIHJlcG9y dHMgb24gdGhlIGJ1ZyBzZWVtIHRvIGJlIG11bHRpLW1vbml0b3IgKGFmdGVyIHNlZWluZwptdWx0 aS1tb25pdG9yL291dHB1dCBpbiBzZXZlcmFsIHJlcG9ydHMgSSBhc2tlZCBpZiBhbnlvbmUgd2Fz IHNlZWluZyBpdAp3aXRoIG9ubHkgb25lIG1vbml0b3IgYW5kIG5vIGFuc3dlcnMpLCBhbmQgYXMg eW91IGNvbW1lbnRlZCBvbiB0aGUgYnVnCmZvciB5b3VyIHByb3Bvc2VkIHBhdGNoIGJ1dCBzZWVt cyBtaXNzaW5nIGZyb20gdGhpcyBvbmUgaGVyZSAoZGlmZmVyZW50CmF1dGhvci9wcm9wb3NhbCkg Li4uCgpDb21taXRzICMxIGFuZCAjMiBkb24ndCB0b3VjaCBhbnkgb2YgdGhlIHNhbWUgY29yZSBE Uk0gb2JqZWN0cyAoQ1JUQ3MsClBsYW5lcywgQ29ubmVjdG9ycykgc28gQ29tbWl0ICMyIGRvZXMg bm90IHN0YWxsIGZvciBDb21taXQgIzEuIERSTQpQcml2YXRlIE9iamVjdHMgaGF2ZSBhbHdheXMg YmVlbiBhdm9pZGVkIGluIHN0YWxsIGNoZWNrcywgc28gd2UgaGF2ZSBubwpzYWZldHkgZnJvbSBE Uk0gY29yZSBpbiB0aGlzIHJlZ2FyZC4KCj4gPj4KPiA+PiBTaW5jZSB0aGlzIGJ1ZyBoYXMgb25s eSBiZWVuIHNwb3R0ZWQgd2l0aCBmYXN0IGNvbW1pdHMsIHRoaXMgcGF0Y2gKPiA+PiBmaXhlcyB0 aGUgYnVnIGJ5IGNsZWFyaW5nIHRoZSBkbV9zdGF0ZSBpbnN0ZWFkIG9mIHVzaW5nIHRoZSBvbGQK PiA+PiBkY19zdGF0ZSBmb3IgZmFzdCB1cGRhdGVzLiBJbiBhZGRpdGlvbiwgc2luY2UgZG1fc3Rh dGUgaXMgb25seQo+ID4+IHVzZWQgZm9yIGl0cyBkY19zdGF0ZSBhbmQgYW1kZ3B1X2RtX2F0b21p Y19jb21taXRfdGFpbCB3aWxsIHJldGFpbgo+ID4+IHRoZSBkY19zdGF0ZSBpZiBub25lIGlzIGZv dW5kLAo+ID4+IHJlbW92aW5nIHRoZSBkbV9zdGF0ZSBzaG91bGQgbm90IGhhdmUgYW55IGNvbnNl cXVlbmNlcyBpbiBmYXN0Cj4gPj4gdXBkYXRlcy4KPiA+Pgo+ID4+IFRoaXMgdXNlLWFmdGVyLWZy ZWUgYnVnIGhhcyBleGlzdGVkIGZvciBhIHdoaWxlIG5vdywgYnV0IG9ubHkKPiA+PiBjYXVzZWQg YSBub3RpY2VhYmxlIGlzc3VlIHN0YXJ0aW5nIGZyb20gNS43LXJjMSBkdWUgdG8gMzIwMmZhNjJm Cj4gPj4gKCJzbHViOiByZWxvY2F0ZSBmcmVlbGlzdCBwb2ludGVyIHRvIG1pZGRsZSBvZiBvYmpl Y3QiKSBtb3ZpbmcgdGhlCj4gPj4gZnJlZWxpc3QgcG9pbnRlciBmcm9tIGRtX3N0YXRlLT5iYXNl ICh3aGljaCB3YXMgdW51c2VkKSB0bwo+ID4+IGRtX3N0YXRlLT5jb250ZXh0ICh3aGljaCBpcyBk ZXJlZmVyZW5jZWQpLgo+ID4+Cj4gPj4gQnVnemlsbGE6IAo+ID4+IGh0dHBzOi8vYnVnemlsbGEu a2VybmVsLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MzgzIAo+ID4+Cj4gPj4gRml4ZXM6IGJkMjAw ZDE5MGY0NSAoImRybS9hbWQvZGlzcGxheTogRG9uJ3QgcmVwbGFjZSB0aGUgZGNfc3RhdGUKPiA+ PiBmb3IgZmFzdCB1cGRhdGVzIikKPiA+PiBSZXBvcnRlZC1ieTogRHVuY2FuIDwxaTV0NS5kdW5j YW5AY294Lm5ldD4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBNYXppbiBSZXprIDxtbnJ6a0Bwcm90b25t YWlsLmNvbT4KPiA+PiAtLS0KPiA+PiDCoCAuLi4vZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVf ZG0vYW1kZ3B1X2RtLmMgfCAzNgo+ID4+ICsrKysrKysrKysrKysrLS0tLS0gMSBmaWxlIGNoYW5n ZWQsIDI3IGluc2VydGlvbnMoKyksIDkKPiA+PiBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5j IAo+ID4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0u Ywo+ID4+IGluZGV4IDg2ZmZhMGMyODgwZi4uNzEwZWRjNzBlMzdlIDEwMDY0NAo+ID4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKPiA+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jCj4g Pj4gQEAgLTg3MTcsMjAgKzg3MTcsMzggQEAgc3RhdGljIGludCBhbWRncHVfZG1fYXRvbWljX2No ZWNrKHN0cnVjdCAKPiA+PiBkcm1fZGV2aWNlICpkZXYsCj4gPj4gwqDCoMKgwqDCoMKgwqDCoMKg wqAgKiB0aGUgc2FtZSByZXNvdXJjZS4gSWYgd2UgaGF2ZSBhIG5ldyBEQyBjb250ZXh0IGFzCj4g Pj4gcGFydCBvZgo+ID4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgICogdGhlIERNIGF0b21pYyBzdGF0 ZSBmcm9tIHZhbGlkYXRpb24gd2UgbmVlZCB0byBmcmVlCj4gPj4gaXQgYW5kCj4gPj4gwqDCoMKg wqDCoMKgwqDCoMKgwqAgKiByZXRhaW4gdGhlIGV4aXN0aW5nIG9uZSBpbnN0ZWFkLgo+ID4+ICvC oMKgwqDCoMKgwqDCoMKgICoKPiA+PiArwqDCoMKgwqDCoMKgwqDCoCAqIEZ1cnRoZXJtb3JlLCBz aW5jZSB0aGUgRE0gYXRvbWljIHN0YXRlIG9ubHkgY29udGFpbnMKPiA+PiB0aGUgREMKPiA+PiAr wqDCoMKgwqDCoMKgwqDCoCAqIGNvbnRleHQgYW5kIGNhbiBzYWZlbHkgYmUgYW5udWxsZWQsIHdl IGNhbiBmcmVlIHRoZQo+ID4+IHN0YXRlCj4gPj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBhbmQgY2xl YXIgdGhlIGFzc29jaWF0ZWQgcHJpdmF0ZSBvYmplY3Qgbm93IHRvIGZyZWUKPiA+PiArwqDCoMKg wqDCoMKgwqDCoCAqIHNvbWUgbWVtb3J5IGFuZCBhdm9pZCBhIHBvc3NpYmxlIHVzZS1hZnRlci1m cmVlIGxhdGVyLgo+ID4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgICovCj4gPj4gLcKgwqDCoMKgwqDC oMKgIHN0cnVjdCBkbV9hdG9taWNfc3RhdGUgKm5ld19kbV9zdGF0ZSwgKm9sZF9kbV9zdGF0ZTsK PiA+Pgo+ID4+IC3CoMKgwqDCoMKgwqDCoCBuZXdfZG1fc3RhdGUgPSBkbV9hdG9taWNfZ2V0X25l d19zdGF0ZShzdGF0ZSk7Cj4gPj4gLcKgwqDCoMKgwqDCoMKgIG9sZF9kbV9zdGF0ZSA9IGRtX2F0 b21pY19nZXRfb2xkX3N0YXRlKHN0YXRlKTsKPiA+PiArwqDCoMKgwqDCoMKgwqAgZm9yIChpID0g MDsgaSA8IHN0YXRlLT5udW1fcHJpdmF0ZV9vYmpzOyBpKyspIHsKPiA+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBzdHJ1Y3QgZHJtX3ByaXZhdGVfb2JqICpvYmogPQo+ID4+IHN0YXRlLT5wcml2 YXRlX29ianNbaV0ucHRyOwo+ID4+Cj4gPj4gLcKgwqDCoMKgwqDCoMKgIGlmIChuZXdfZG1fc3Rh dGUgJiYgb2xkX2RtX3N0YXRlKSB7Cj4gPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKG5l d19kbV9zdGF0ZS0+Y29udGV4dCkKPiA+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGRjX3JlbGVhc2Vfc3RhdGUobmV3X2RtX3N0YXRlLT5jb250ZXh0KTsKPiA+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBpZiAob2JqLT5mdW5jcyA9PSBhZGV2LT5kbS5hdG9taWNfb2JqLmZ1bmNz KSB7Cj4gPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpbnQgaiA9IHN0YXRlLT5u dW1fcHJpdmF0ZV9vYmpzLTE7Cj4gPj4KPiA+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBuZXdf ZG1fc3RhdGUtPmNvbnRleHQgPSBvbGRfZG1fc3RhdGUtPmNvbnRleHQ7Cj4gPj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkbV9hdG9taWNfZGVzdHJveV9zdGF0ZShvYmosCj4gPj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RhdGUtPnBy aXZhdGVfb2Jqc1tpXS5zdGF0ZSk7Cj4gPj4gKwo+ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgLyogSWYgaSBpcyBub3QgYXQgdGhlIGVuZCBvZiB0aGUgYXJyYXkgdGhlbiB0aGUK PiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKiBsYXN0IGVsZW1lbnQgbmVl ZHMgdG8gYmUgbW92ZWQgdG8gd2hlcmUgaSB3YXMKPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgKiBiZWZvcmUgdGhlIGFycmF5IGNhbiBzYWZlbHkgYmUgdHJ1bmNhdGVkLgo+ ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAqLwo+ID4+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKGkgIT0gaikKPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RhdGUtPnByaXZhdGVfb2Jqc1tpXSA9Cj4gPj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RhdGUtPnByaXZhdGVf b2Jqc1tqXTsKPiA+Pgo+ID4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChvbGRfZG1fc3Rh dGUtPmNvbnRleHQpCj4gPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkY19yZXRh aW5fc3RhdGUob2xkX2RtX3N0YXRlLT5jb250ZXh0KTsKPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHN0YXRlLT5wcml2YXRlX29ianNbal0ucHRyID0gTlVMTDsKPiA+PiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0YXRlLT5wcml2YXRlX29ianNbal0uc3RhdGUg PSBOVUxMOwo+ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RhdGUtPnByaXZh dGVfb2Jqc1tqXS5vbGRfc3RhdGUgPSBOVUxMOwo+ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgc3RhdGUtPnByaXZhdGVfb2Jqc1tqXS5uZXdfc3RhdGUgPSBOVUxMOwo+ID4+ICsK PiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0YXRlLT5udW1fcHJpdmF0ZV9v YmpzID0gajsKPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOwo+ID4+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPiA+PiDCoMKgwqDCoMKgwqDCoMKgwqAgfQo+ID4+ IMKgwqDCoMKgwqAgfQo+ID4+Cj4gPj4gLS0gCj4gPj4gMi4yNy4wCj4gPj4KPiA+IAo+IAoKLS0g CkR1bmNhbiAtIE5vIEhUTUwgbWVzc2FnZXMgcGxlYXNlOyB0aGV5IGFyZSBmaWx0ZXJlZCBhcyBz cGFtLgoiRXZlcnkgbm9uZnJlZSBwcm9ncmFtIGhhcyBhIGxvcmQsIGEgbWFzdGVyIC0tCmFuZCBp ZiB5b3UgdXNlIHRoZSBwcm9ncmFtLCBoZSBpcyB5b3VyIG1hc3Rlci4iICBSaWNoYXJkIFN0YWxs bWFuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1n ZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56DBC43445 for ; Mon, 27 Jul 2020 23:33:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8516520809 for ; Mon, 27 Jul 2020 23:33:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8516520809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cox.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C7D06E113; Mon, 27 Jul 2020 23:32:47 +0000 (UTC) Received: from omta015.useast.a.cloudfilter.net (omta015.useast.a.cloudfilter.net [34.195.253.206]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F55A89A88; Mon, 27 Jul 2020 15:38:03 +0000 (UTC) Received: from cxr.smtp.a.cloudfilter.net ([10.0.16.145]) by cmsmtp with ESMTP id zy3xj7xIFxItl05CUkAVIl; Mon, 27 Jul 2020 15:38:03 +0000 Received: from ws ([68.106.48.162]) by cmsmtp with ESMTPSA id 05CIkRkFGKrUj05CJkzNoN; Mon, 27 Jul 2020 15:38:02 +0000 Authentication-Results: cox.net; auth=pass (LOGIN) smtp.auth=1i5t5.duncan@cox.net X-Authority-Analysis: v=2.4 cv=Wu6VjfTv c=1 sm=1 tr=0 ts=5f1ef4da a=fEuF7Lzz1MGHEe1xFtqdOg==:117 a=fEuF7Lzz1MGHEe1xFtqdOg==:17 a=IkcTkHD0fZMA:10 a=zd2uoN0lAAAA:8 a=VwQbUJbxAAAA:8 a=kviXuzpPAAAA:8 a=sfOm8-O8AAAA:8 a=GEFCdFOGbQv7mSB_pWQA:9 a=tqTlq1B0_eMsoCT5:21 a=h_W-Jm2LaEDf4Mgu:21 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=qrIFiuKZe2vaD64auk6j:22 a=TvTJqdcANYtsRzA46cdi:22 Date: Mon, 27 Jul 2020 08:37:49 -0700 From: Duncan <1i5t5.duncan@cox.net> To: "Kazlauskas, Nicholas" Subject: Re: [PATCH] drm/amd/display: Clear dm_state for fast updates Message-ID: <20200727083749.7b0fe41d@ws> In-Reply-To: References: X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CMAE-Envelope: MS4xfGkEX9Tay6GTZG9sI91aPbcWvbf0prl9drr0Vb6zi1HgHYrb/SN12LpKXhuWCazaf+qGdIhr0rDqn9HLwAXeM3wycfWeeljqu1boy1ql56iXYF2bAXJz 4PrWzP+Uy36trlqXirzeMrGeboMFt5LYoa6RHk/m4z70GBnLHEb6dD51SPsGoU4nyO9+XjhxIA7nzI+kH3dHHRcaTZJKCsWPmAKdNAFR85/ZzNe/G505umhL h5CVTpg7b1YPJw/h0qcK/1supgqADO8HdqrrhcUkwDxg0wBbbhtvN4knfxZ15D9ZP7Vdp3TwhRWBocd9U846F4Myu7GiNfD1fEPPgypGBriCShImbrMLiNMt I8jOgqdsreoANf1ywhz9Rmlj+/tPyho79HkyyOJslD72GwFlmp+FtkCAExRvUWW5o3PuuZ1k8068az/563afztRlxPOQjjl6JZlAwYnBQZBWcc2zGrVJLf21 A0WiYWxTG32RH9chFcrpewHDI5k9VQICRbmygXFqWm72nVjpGOXgsSEESMKBd7pC9eEmiuhV1gGAFrl2i6kuFALoqDWw22oWX4OE8XA3fSlsvUckRa429M7i F+PNepcnIOHv/i8opDVBn1KoLqr4xLXANds5JsRyi7cHs5Z1vOKxnyuCIJ7Ku+iNvZQikjzJ31959ojtKu9vJwdVZ04RpiXp0mpWHlVh4edw/Q== X-Mailman-Approved-At: Mon, 27 Jul 2020 23:32:42 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Menzel , "anthony.ruhier@gmail.com" , Kees Cook , "sunpeng.li@amd.com" , Mazin Rezk , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "regressions@leemhuis.info" , "amd-gfx@lists.freedesktop.org" , Alexander Deucher , Andrew Morton , "mphantomx@yahoo.com.br" , Christian =?UTF-8?B?S8O2bmln?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAyNyBKdWwgMjAyMCAxMDowNTowMSAtMDQwMAoiS2F6bGF1c2thcywgTmljaG9sYXMi IDxuaWNob2xhcy5rYXpsYXVza2FzQGFtZC5jb20+IHdyb3RlOgoKPiBPbiAyMDIwLTA3LTI3IDk6 MzkgYS5tLiwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiA+IEFtIDI3LjA3LjIwIHVtIDA3OjQw IHNjaHJpZWIgTWF6aW4gUmV6azoKPiA+PiBUaGlzIHBhdGNoIGZpeGVzIGEgcmFjZSBjb25kaXRp b24gdGhhdCBjYXVzZXMgYSB1c2UtYWZ0ZXItZnJlZQo+ID4+IGR1cmluZyBhbWRncHVfZG1fYXRv bWljX2NvbW1pdF90YWlsLiBUaGlzIGNhbiBvY2N1ciB3aGVuIDIKPiA+PiBub24tYmxvY2tpbmcg Y29tbWl0cyBhcmUgcmVxdWVzdGVkIGFuZCB0aGUgc2Vjb25kIG9uZSBmaW5pc2hlcwo+ID4+IGJl Zm9yZSB0aGUgZmlyc3QuIEVzc2VudGlhbGx5LCB0aGlzIGJ1ZyBvY2N1cnMgd2hlbiB0aGUgZm9s bG93aW5nCj4gPj4gc2VxdWVuY2Ugb2YgZXZlbnRzIGhhcHBlbnM6Cj4gPj4KPiA+PiAxLiBOb24t YmxvY2tpbmcgY29tbWl0ICMxIGlzIHJlcXVlc3RlZCB3LyBhIG5ldyBkbV9zdGF0ZSAjMSBhbmQg aXMKPiA+PiBkZWZlcnJlZCB0byB0aGUgd29ya3F1ZXVlLgo+ID4+Cj4gPj4gMi4gTm9uLWJsb2Nr aW5nIGNvbW1pdCAjMiBpcyByZXF1ZXN0ZWQgdy8gYSBuZXcgZG1fc3RhdGUgIzIgYW5kIGlzCj4g Pj4gZGVmZXJyZWQgdG8gdGhlIHdvcmtxdWV1ZS4KPiA+Pgo+ID4+IDMuIENvbW1pdCAjMiBzdGFy dHMgYmVmb3JlIGNvbW1pdCAjMSwgZG1fc3RhdGUgIzEgaXMgdXNlZCBpbiB0aGUKPiA+PiBjb21t aXRfdGFpbCBhbmQgY29tbWl0ICMyIGNvbXBsZXRlcywgZnJlZWluZyBkbV9zdGF0ZSAjMS4KPiA+ Pgo+ID4+IDQuIENvbW1pdCAjMSBzdGFydHMgYWZ0ZXIgY29tbWl0ICMyIGNvbXBsZXRlcywgdXNl cyB0aGUgZnJlZWQKPiA+PiBkbV9zdGF0ZSAxIGFuZCBkZXJlZmVyZW5jZXMgYSBmcmVlbGlzdCBw b2ludGVyIHdoaWxlIHNldHRpbmcgdGhlCj4gPj4gY29udGV4dC4KPiA+IAo+ID4gV2VsbCBJIG9u bHkgaGF2ZSBhIG9uZSBtaWxlIGhpZ2ggdmlldyBvbiB0aGlzLCBidXQgd2h5IGRvbid0IHlvdQo+ ID4gbGV0IHRoZSB3b3JrIGl0ZW1zIGV4ZWN1dGUgaW4gb3JkZXI/Cj4gPiAKPiA+IFRoYXQgd291 bGQgYmUgYmV0dGVyIGFueXdheSBjYXVzZSB0aGlzIHdheSB3ZSBkb24ndCB0cmlnZ2VyIGEgY2Fj aGUKPiA+IGxpbmUgcGluZyBwb25nIGJldHdlZW4gQ1BVcy4KPiA+IAo+ID4gQ2hyaXN0aWFuLgo+ IAo+IFdlIHVzZSB0aGUgRFJNIGhlbHBlcnMgZm9yIG1hbmFnaW5nIGRybV9hdG9taWNfY29tbWl0 X3N0YXRlIGFuZCB0aG9zZSAKPiBoZWxwZXJzIGludGVybmFsbHkgcHVzaCBub24tYmxvY2tpbmcg Y29tbWl0IHdvcmsgaW50byB0aGUgc3lzdGVtCj4gdW5ib3VuZCB3b3JrIHF1ZXVlLgo+IAo+IFdo aWxlIHdlIGNvdWxkIGR1cGxpY2F0ZSBhIGNvcHkgb2YgdGhhdCBjb2RlIHdpdGggbm90aGluZyBi dXQgdGhlIAo+IHdvcmtxdWV1ZSBjaGFuZ2VkIHRoYXQgaXNuJ3Qgc29tZXRoaW5nIEknZCByZWFs bHkgbGlrZSB0byBtYWludGFpbgo+IGdvaW5nIGZvcndhcmQuCj4gCj4gUmVnYXJkcywKPiBOaWNo b2xhcyBLYXpsYXVza2FzCgpBZGRpdGlvbmFsbHksIEkgZG9uJ3Qgc2VlIG1lbnRpb25lZCBvbi10 aHJlYWQgKGl0J3Mgb24gdGhlIGJ1ZyBhbmQgbm93CmluIHRoZSBkZXRhaWxzIGJlbG93KSB0aGF0 IHdlJ3JlIHRhbGtpbmcgbXVsdGktbW9uaXRvciwgbm90CnNpbmdsZS1tb25pdG9yLiBQcmVzdW1h Ymx5IHRoYXQgZ29lcyBzb21lIHdheSB0b3dhcmQgYW5zd2VyaW5nIHRoZSAid2h5Cm5vdCBmb3Jj ZSBvcmRlcj8iIHF1ZXN0aW9uLCBjb25zaWRlcmluZyB0aGUgb3V0cHV0cyBtYXkgYmUgcnVubmlu ZyBhdApkaWZmZXJlbnQgcmVmcmVzaCBmcmVxdWVuY2llcywgZXRjLi4uCgpBbGwgdGhlIHJlcG9y dHMgb24gdGhlIGJ1ZyBzZWVtIHRvIGJlIG11bHRpLW1vbml0b3IgKGFmdGVyIHNlZWluZwptdWx0 aS1tb25pdG9yL291dHB1dCBpbiBzZXZlcmFsIHJlcG9ydHMgSSBhc2tlZCBpZiBhbnlvbmUgd2Fz IHNlZWluZyBpdAp3aXRoIG9ubHkgb25lIG1vbml0b3IgYW5kIG5vIGFuc3dlcnMpLCBhbmQgYXMg eW91IGNvbW1lbnRlZCBvbiB0aGUgYnVnCmZvciB5b3VyIHByb3Bvc2VkIHBhdGNoIGJ1dCBzZWVt cyBtaXNzaW5nIGZyb20gdGhpcyBvbmUgaGVyZSAoZGlmZmVyZW50CmF1dGhvci9wcm9wb3NhbCkg Li4uCgpDb21taXRzICMxIGFuZCAjMiBkb24ndCB0b3VjaCBhbnkgb2YgdGhlIHNhbWUgY29yZSBE Uk0gb2JqZWN0cyAoQ1JUQ3MsClBsYW5lcywgQ29ubmVjdG9ycykgc28gQ29tbWl0ICMyIGRvZXMg bm90IHN0YWxsIGZvciBDb21taXQgIzEuIERSTQpQcml2YXRlIE9iamVjdHMgaGF2ZSBhbHdheXMg YmVlbiBhdm9pZGVkIGluIHN0YWxsIGNoZWNrcywgc28gd2UgaGF2ZSBubwpzYWZldHkgZnJvbSBE Uk0gY29yZSBpbiB0aGlzIHJlZ2FyZC4KCj4gPj4KPiA+PiBTaW5jZSB0aGlzIGJ1ZyBoYXMgb25s eSBiZWVuIHNwb3R0ZWQgd2l0aCBmYXN0IGNvbW1pdHMsIHRoaXMgcGF0Y2gKPiA+PiBmaXhlcyB0 aGUgYnVnIGJ5IGNsZWFyaW5nIHRoZSBkbV9zdGF0ZSBpbnN0ZWFkIG9mIHVzaW5nIHRoZSBvbGQK PiA+PiBkY19zdGF0ZSBmb3IgZmFzdCB1cGRhdGVzLiBJbiBhZGRpdGlvbiwgc2luY2UgZG1fc3Rh dGUgaXMgb25seQo+ID4+IHVzZWQgZm9yIGl0cyBkY19zdGF0ZSBhbmQgYW1kZ3B1X2RtX2F0b21p Y19jb21taXRfdGFpbCB3aWxsIHJldGFpbgo+ID4+IHRoZSBkY19zdGF0ZSBpZiBub25lIGlzIGZv dW5kLAo+ID4+IHJlbW92aW5nIHRoZSBkbV9zdGF0ZSBzaG91bGQgbm90IGhhdmUgYW55IGNvbnNl cXVlbmNlcyBpbiBmYXN0Cj4gPj4gdXBkYXRlcy4KPiA+Pgo+ID4+IFRoaXMgdXNlLWFmdGVyLWZy ZWUgYnVnIGhhcyBleGlzdGVkIGZvciBhIHdoaWxlIG5vdywgYnV0IG9ubHkKPiA+PiBjYXVzZWQg YSBub3RpY2VhYmxlIGlzc3VlIHN0YXJ0aW5nIGZyb20gNS43LXJjMSBkdWUgdG8gMzIwMmZhNjJm Cj4gPj4gKCJzbHViOiByZWxvY2F0ZSBmcmVlbGlzdCBwb2ludGVyIHRvIG1pZGRsZSBvZiBvYmpl Y3QiKSBtb3ZpbmcgdGhlCj4gPj4gZnJlZWxpc3QgcG9pbnRlciBmcm9tIGRtX3N0YXRlLT5iYXNl ICh3aGljaCB3YXMgdW51c2VkKSB0bwo+ID4+IGRtX3N0YXRlLT5jb250ZXh0ICh3aGljaCBpcyBk ZXJlZmVyZW5jZWQpLgo+ID4+Cj4gPj4gQnVnemlsbGE6IAo+ID4+IGh0dHBzOi8vYnVnemlsbGEu a2VybmVsLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA3MzgzIAo+ID4+Cj4gPj4gRml4ZXM6IGJkMjAw ZDE5MGY0NSAoImRybS9hbWQvZGlzcGxheTogRG9uJ3QgcmVwbGFjZSB0aGUgZGNfc3RhdGUKPiA+ PiBmb3IgZmFzdCB1cGRhdGVzIikKPiA+PiBSZXBvcnRlZC1ieTogRHVuY2FuIDwxaTV0NS5kdW5j YW5AY294Lm5ldD4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBNYXppbiBSZXprIDxtbnJ6a0Bwcm90b25t YWlsLmNvbT4KPiA+PiAtLS0KPiA+PiDCoCAuLi4vZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVf ZG0vYW1kZ3B1X2RtLmMgfCAzNgo+ID4+ICsrKysrKysrKysrKysrLS0tLS0gMSBmaWxlIGNoYW5n ZWQsIDI3IGluc2VydGlvbnMoKyksIDkKPiA+PiBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5j IAo+ID4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0u Ywo+ID4+IGluZGV4IDg2ZmZhMGMyODgwZi4uNzEwZWRjNzBlMzdlIDEwMDY0NAo+ID4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKPiA+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jCj4g Pj4gQEAgLTg3MTcsMjAgKzg3MTcsMzggQEAgc3RhdGljIGludCBhbWRncHVfZG1fYXRvbWljX2No ZWNrKHN0cnVjdCAKPiA+PiBkcm1fZGV2aWNlICpkZXYsCj4gPj4gwqDCoMKgwqDCoMKgwqDCoMKg wqAgKiB0aGUgc2FtZSByZXNvdXJjZS4gSWYgd2UgaGF2ZSBhIG5ldyBEQyBjb250ZXh0IGFzCj4g Pj4gcGFydCBvZgo+ID4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgICogdGhlIERNIGF0b21pYyBzdGF0 ZSBmcm9tIHZhbGlkYXRpb24gd2UgbmVlZCB0byBmcmVlCj4gPj4gaXQgYW5kCj4gPj4gwqDCoMKg wqDCoMKgwqDCoMKgwqAgKiByZXRhaW4gdGhlIGV4aXN0aW5nIG9uZSBpbnN0ZWFkLgo+ID4+ICvC oMKgwqDCoMKgwqDCoMKgICoKPiA+PiArwqDCoMKgwqDCoMKgwqDCoCAqIEZ1cnRoZXJtb3JlLCBz aW5jZSB0aGUgRE0gYXRvbWljIHN0YXRlIG9ubHkgY29udGFpbnMKPiA+PiB0aGUgREMKPiA+PiAr wqDCoMKgwqDCoMKgwqDCoCAqIGNvbnRleHQgYW5kIGNhbiBzYWZlbHkgYmUgYW5udWxsZWQsIHdl IGNhbiBmcmVlIHRoZQo+ID4+IHN0YXRlCj4gPj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBhbmQgY2xl YXIgdGhlIGFzc29jaWF0ZWQgcHJpdmF0ZSBvYmplY3Qgbm93IHRvIGZyZWUKPiA+PiArwqDCoMKg wqDCoMKgwqDCoCAqIHNvbWUgbWVtb3J5IGFuZCBhdm9pZCBhIHBvc3NpYmxlIHVzZS1hZnRlci1m cmVlIGxhdGVyLgo+ID4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgICovCj4gPj4gLcKgwqDCoMKgwqDC oMKgIHN0cnVjdCBkbV9hdG9taWNfc3RhdGUgKm5ld19kbV9zdGF0ZSwgKm9sZF9kbV9zdGF0ZTsK PiA+Pgo+ID4+IC3CoMKgwqDCoMKgwqDCoCBuZXdfZG1fc3RhdGUgPSBkbV9hdG9taWNfZ2V0X25l d19zdGF0ZShzdGF0ZSk7Cj4gPj4gLcKgwqDCoMKgwqDCoMKgIG9sZF9kbV9zdGF0ZSA9IGRtX2F0 b21pY19nZXRfb2xkX3N0YXRlKHN0YXRlKTsKPiA+PiArwqDCoMKgwqDCoMKgwqAgZm9yIChpID0g MDsgaSA8IHN0YXRlLT5udW1fcHJpdmF0ZV9vYmpzOyBpKyspIHsKPiA+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBzdHJ1Y3QgZHJtX3ByaXZhdGVfb2JqICpvYmogPQo+ID4+IHN0YXRlLT5wcml2 YXRlX29ianNbaV0ucHRyOwo+ID4+Cj4gPj4gLcKgwqDCoMKgwqDCoMKgIGlmIChuZXdfZG1fc3Rh dGUgJiYgb2xkX2RtX3N0YXRlKSB7Cj4gPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKG5l d19kbV9zdGF0ZS0+Y29udGV4dCkKPiA+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGRjX3JlbGVhc2Vfc3RhdGUobmV3X2RtX3N0YXRlLT5jb250ZXh0KTsKPiA+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBpZiAob2JqLT5mdW5jcyA9PSBhZGV2LT5kbS5hdG9taWNfb2JqLmZ1bmNz KSB7Cj4gPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpbnQgaiA9IHN0YXRlLT5u dW1fcHJpdmF0ZV9vYmpzLTE7Cj4gPj4KPiA+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBuZXdf ZG1fc3RhdGUtPmNvbnRleHQgPSBvbGRfZG1fc3RhdGUtPmNvbnRleHQ7Cj4gPj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkbV9hdG9taWNfZGVzdHJveV9zdGF0ZShvYmosCj4gPj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RhdGUtPnBy aXZhdGVfb2Jqc1tpXS5zdGF0ZSk7Cj4gPj4gKwo+ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgLyogSWYgaSBpcyBub3QgYXQgdGhlIGVuZCBvZiB0aGUgYXJyYXkgdGhlbiB0aGUK PiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKiBsYXN0IGVsZW1lbnQgbmVl ZHMgdG8gYmUgbW92ZWQgdG8gd2hlcmUgaSB3YXMKPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgKiBiZWZvcmUgdGhlIGFycmF5IGNhbiBzYWZlbHkgYmUgdHJ1bmNhdGVkLgo+ ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAqLwo+ID4+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKGkgIT0gaikKPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RhdGUtPnByaXZhdGVfb2Jqc1tpXSA9Cj4gPj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RhdGUtPnByaXZhdGVf b2Jqc1tqXTsKPiA+Pgo+ID4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChvbGRfZG1fc3Rh dGUtPmNvbnRleHQpCj4gPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkY19yZXRh aW5fc3RhdGUob2xkX2RtX3N0YXRlLT5jb250ZXh0KTsKPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHN0YXRlLT5wcml2YXRlX29ianNbal0ucHRyID0gTlVMTDsKPiA+PiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0YXRlLT5wcml2YXRlX29ianNbal0uc3RhdGUg PSBOVUxMOwo+ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RhdGUtPnByaXZh dGVfb2Jqc1tqXS5vbGRfc3RhdGUgPSBOVUxMOwo+ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgc3RhdGUtPnByaXZhdGVfb2Jqc1tqXS5uZXdfc3RhdGUgPSBOVUxMOwo+ID4+ICsK PiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0YXRlLT5udW1fcHJpdmF0ZV9v YmpzID0gajsKPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOwo+ID4+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPiA+PiDCoMKgwqDCoMKgwqDCoMKgwqAgfQo+ID4+ IMKgwqDCoMKgwqAgfQo+ID4+Cj4gPj4gLS0gCj4gPj4gMi4yNy4wCj4gPj4KPiA+IAo+IAoKLS0g CkR1bmNhbiAtIE5vIEhUTUwgbWVzc2FnZXMgcGxlYXNlOyB0aGV5IGFyZSBmaWx0ZXJlZCBhcyBz cGFtLgoiRXZlcnkgbm9uZnJlZSBwcm9ncmFtIGhhcyBhIGxvcmQsIGEgbWFzdGVyIC0tCmFuZCBp ZiB5b3UgdXNlIHRoZSBwcm9ncmFtLCBoZSBpcyB5b3VyIG1hc3Rlci4iICBSaWNoYXJkIFN0YWxs bWFuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F175C433E0 for ; Mon, 27 Jul 2020 15:45:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F906206E7 for ; Mon, 27 Jul 2020 15:45:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730993AbgG0PpM convert rfc822-to-8bit (ORCPT ); Mon, 27 Jul 2020 11:45:12 -0400 Received: from omta012.uswest2.a.cloudfilter.net ([35.164.127.235]:56223 "EHLO omta012.uswest2.a.cloudfilter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728015AbgG0PpL (ORCPT ); Mon, 27 Jul 2020 11:45:11 -0400 X-Greylist: delayed 428 seconds by postgrey-1.27 at vger.kernel.org; Mon, 27 Jul 2020 11:45:10 EDT Received: from cxr.smtp.a.cloudfilter.net ([10.0.16.145]) by cmsmtp with ESMTP id 00M5kTac7mUuy05CUkkwzh; Mon, 27 Jul 2020 15:38:02 +0000 Received: from ws ([68.106.48.162]) by cmsmtp with ESMTPSA id 05CIkRkFGKrUj05CJkzNoN; Mon, 27 Jul 2020 15:38:02 +0000 Authentication-Results: cox.net; auth=pass (LOGIN) smtp.auth=1i5t5.duncan@cox.net X-Authority-Analysis: v=2.4 cv=Wu6VjfTv c=1 sm=1 tr=0 ts=5f1ef4da a=fEuF7Lzz1MGHEe1xFtqdOg==:117 a=fEuF7Lzz1MGHEe1xFtqdOg==:17 a=IkcTkHD0fZMA:10 a=zd2uoN0lAAAA:8 a=VwQbUJbxAAAA:8 a=kviXuzpPAAAA:8 a=sfOm8-O8AAAA:8 a=GEFCdFOGbQv7mSB_pWQA:9 a=tqTlq1B0_eMsoCT5:21 a=h_W-Jm2LaEDf4Mgu:21 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=qrIFiuKZe2vaD64auk6j:22 a=TvTJqdcANYtsRzA46cdi:22 Date: Mon, 27 Jul 2020 08:37:49 -0700 From: Duncan <1i5t5.duncan@cox.net> To: "Kazlauskas, Nicholas" Cc: Christian =?UTF-8?B?S8O2bmln?= , Mazin Rezk , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , Andrew Morton , Harry Wentland , "sunpeng.li@amd.com" , Kees Cook , Alexander Deucher , "mphantomx@yahoo.com.br" , "regressions@leemhuis.info" , "anthony.ruhier@gmail.com" , Paul Menzel Subject: Re: [PATCH] drm/amd/display: Clear dm_state for fast updates Message-ID: <20200727083749.7b0fe41d@ws> In-Reply-To: References: X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-CMAE-Envelope: MS4xfGkEX9Tay6GTZG9sI91aPbcWvbf0prl9drr0Vb6zi1HgHYrb/SN12LpKXhuWCazaf+qGdIhr0rDqn9HLwAXeM3wycfWeeljqu1boy1ql56iXYF2bAXJz 4PrWzP+Uy36trlqXirzeMrGeboMFt5LYoa6RHk/m4z70GBnLHEb6dD51SPsGoU4nyO9+XjhxIA7nzI+kH3dHHRcaTZJKCsWPmAKdNAFR85/ZzNe/G505umhL h5CVTpg7b1YPJw/h0qcK/1supgqADO8HdqrrhcUkwDxg0wBbbhtvN4knfxZ15D9ZP7Vdp3TwhRWBocd9U846F4Myu7GiNfD1fEPPgypGBriCShImbrMLiNMt I8jOgqdsreoANf1ywhz9Rmlj+/tPyho79HkyyOJslD72GwFlmp+FtkCAExRvUWW5o3PuuZ1k8068az/563afztRlxPOQjjl6JZlAwYnBQZBWcc2zGrVJLf21 A0WiYWxTG32RH9chFcrpewHDI5k9VQICRbmygXFqWm72nVjpGOXgsSEESMKBd7pC9eEmiuhV1gGAFrl2i6kuFALoqDWw22oWX4OE8XA3fSlsvUckRa429M7i F+PNepcnIOHv/i8opDVBn1KoLqr4xLXANds5JsRyi7cHs5Z1vOKxnyuCIJ7Ku+iNvZQikjzJ31959ojtKu9vJwdVZ04RpiXp0mpWHlVh4edw/Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jul 2020 10:05:01 -0400 "Kazlauskas, Nicholas" wrote: > On 2020-07-27 9:39 a.m., Christian König wrote: > > Am 27.07.20 um 07:40 schrieb Mazin Rezk: > >> This patch fixes a race condition that causes a use-after-free > >> during amdgpu_dm_atomic_commit_tail. This can occur when 2 > >> non-blocking commits are requested and the second one finishes > >> before the first. Essentially, this bug occurs when the following > >> sequence of events happens: > >> > >> 1. Non-blocking commit #1 is requested w/ a new dm_state #1 and is > >> deferred to the workqueue. > >> > >> 2. Non-blocking commit #2 is requested w/ a new dm_state #2 and is > >> deferred to the workqueue. > >> > >> 3. Commit #2 starts before commit #1, dm_state #1 is used in the > >> commit_tail and commit #2 completes, freeing dm_state #1. > >> > >> 4. Commit #1 starts after commit #2 completes, uses the freed > >> dm_state 1 and dereferences a freelist pointer while setting the > >> context. > > > > Well I only have a one mile high view on this, but why don't you > > let the work items execute in order? > > > > That would be better anyway cause this way we don't trigger a cache > > line ping pong between CPUs. > > > > Christian. > > We use the DRM helpers for managing drm_atomic_commit_state and those > helpers internally push non-blocking commit work into the system > unbound work queue. > > While we could duplicate a copy of that code with nothing but the > workqueue changed that isn't something I'd really like to maintain > going forward. > > Regards, > Nicholas Kazlauskas Additionally, I don't see mentioned on-thread (it's on the bug and now in the details below) that we're talking multi-monitor, not single-monitor. Presumably that goes some way toward answering the "why not force order?" question, considering the outputs may be running at different refresh frequencies, etc... All the reports on the bug seem to be multi-monitor (after seeing multi-monitor/output in several reports I asked if anyone was seeing it with only one monitor and no answers), and as you commented on the bug for your proposed patch but seems missing from this one here (different author/proposal) ... Commits #1 and #2 don't touch any of the same core DRM objects (CRTCs, Planes, Connectors) so Commit #2 does not stall for Commit #1. DRM Private Objects have always been avoided in stall checks, so we have no safety from DRM core in this regard. > >> > >> Since this bug has only been spotted with fast commits, this patch > >> fixes the bug by clearing the dm_state instead of using the old > >> dc_state for fast updates. In addition, since dm_state is only > >> used for its dc_state and amdgpu_dm_atomic_commit_tail will retain > >> the dc_state if none is found, > >> removing the dm_state should not have any consequences in fast > >> updates. > >> > >> This use-after-free bug has existed for a while now, but only > >> caused a noticeable issue starting from 5.7-rc1 due to 3202fa62f > >> ("slub: relocate freelist pointer to middle of object") moving the > >> freelist pointer from dm_state->base (which was unused) to > >> dm_state->context (which is dereferenced). > >> > >> Bugzilla: > >> https://bugzilla.kernel.org/show_bug.cgi?id=207383 > >> > >> Fixes: bd200d190f45 ("drm/amd/display: Don't replace the dc_state > >> for fast updates") > >> Reported-by: Duncan <1i5t5.duncan@cox.net> > >> Signed-off-by: Mazin Rezk > >> --- > >>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 36 > >> ++++++++++++++----- 1 file changed, 27 insertions(+), 9 > >> deletions(-) > >> > >> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > >> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > >> index 86ffa0c2880f..710edc70e37e 100644 > >> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > >> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > >> @@ -8717,20 +8717,38 @@ static int amdgpu_dm_atomic_check(struct > >> drm_device *dev, > >>            * the same resource. If we have a new DC context as > >> part of > >>            * the DM atomic state from validation we need to free > >> it and > >>            * retain the existing one instead. > >> +         * > >> +         * Furthermore, since the DM atomic state only contains > >> the DC > >> +         * context and can safely be annulled, we can free the > >> state > >> +         * and clear the associated private object now to free > >> +         * some memory and avoid a possible use-after-free later. > >>            */ > >> -        struct dm_atomic_state *new_dm_state, *old_dm_state; > >> > >> -        new_dm_state = dm_atomic_get_new_state(state); > >> -        old_dm_state = dm_atomic_get_old_state(state); > >> +        for (i = 0; i < state->num_private_objs; i++) { > >> +            struct drm_private_obj *obj = > >> state->private_objs[i].ptr; > >> > >> -        if (new_dm_state && old_dm_state) { > >> -            if (new_dm_state->context) > >> -                dc_release_state(new_dm_state->context); > >> +            if (obj->funcs == adev->dm.atomic_obj.funcs) { > >> +                int j = state->num_private_objs-1; > >> > >> -            new_dm_state->context = old_dm_state->context; > >> +                dm_atomic_destroy_state(obj, > >> +                        state->private_objs[i].state); > >> + > >> +                /* If i is not at the end of the array then the > >> +                 * last element needs to be moved to where i was > >> +                 * before the array can safely be truncated. > >> +                 */ > >> +                if (i != j) > >> +                    state->private_objs[i] = > >> +                        state->private_objs[j]; > >> > >> -            if (old_dm_state->context) > >> -                dc_retain_state(old_dm_state->context); > >> +                state->private_objs[j].ptr = NULL; > >> +                state->private_objs[j].state = NULL; > >> +                state->private_objs[j].old_state = NULL; > >> +                state->private_objs[j].new_state = NULL; > >> + > >> +                state->num_private_objs = j; > >> +                break; > >> +            } > >>           } > >>       } > >> > >> -- > >> 2.27.0 > >> > > > -- Duncan - No HTML messages please; they are filtered as spam. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman