From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH RFC 08/11] tcp: syncookies: keep mptcp option enabled
Date: Mon, 27 Jul 2020 10:57:28 +0200 [thread overview]
Message-ID: <20200727085728.GH23458@breakpoint.cc> (raw)
In-Reply-To: 377c3773a4003f9667c9f03fad2e7537a3fdb1ba.camel@redhat.com
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
Paolo Abeni <pabeni(a)redhat.com> wrote:
> > treq = tcp_rsk(req);
> > treq->tfo_listener = false;
> >
> > - if (IS_ENABLED(CONFIG_MPTCP))
> > - treq->is_mptcp = 0;
> > + if (treq->is_mptcp) {
> > + int err = mptcp_subflow_init_cookie_req(req, sk, skb);
> > +
> > + if (err)
> > + goto out_free;
> > + }
>
> It looks like 'treq->is_mptcp' is not initialized here ?
Yes, this is resolved now.
> What about moving the whole oops selection, init_reqsk_alloc() call,
> is_mptcp init and mptcp_subflow_init_cookie_req() call in an header
> only helper? (say tcp_reqsk_alloc() or the like)
ipv6 uses tcp6_request_sock_ops, so they are not 100% the same,
unfortunately.
What did you have in mind?
next reply other threads:[~2020-07-27 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 8:57 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-27 9:13 [MPTCP] Re: [PATCH RFC 08/11] tcp: syncookies: keep mptcp option enabled Paolo Abeni
2020-07-15 14:50 Christoph Paasch
2020-07-15 13:22 Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727085728.GH23458@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.