All of lore.kernel.org
 help / color / mirror / Atom feed
From: Forest Crossman <cyrozap@gmail.com>
To: linux-usb@vger.kernel.org
Cc: Forest Crossman <cyrozap@gmail.com>,
	mathias.nyman@intel.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] usb: xhci: Fix ASMedia ASM1142 DMA addressing
Date: Mon, 27 Jul 2020 04:06:29 -0500	[thread overview]
Message-ID: <20200727090629.169701-3-cyrozap@gmail.com> (raw)
In-Reply-To: <20200727090629.169701-1-cyrozap@gmail.com>

I've confirmed that the ASMedia ASM1142 has the same problem as the
ASM2142/ASM3142, in that it too reports that it supports 64-bit DMA
addresses when in fact it does not. As with the ASM2142/ASM3142, this
can cause problems on systems where the upper bits matter, and adding
the XHCI_NO_64BIT_SUPPORT quirk completely fixes the issue.

Signed-off-by: Forest Crossman <cyrozap@gmail.com>
---
 drivers/usb/host/xhci-pci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index baa5af88ca67..3feaafebfe58 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -59,6 +59,7 @@
 #define PCI_DEVICE_ID_AMD_PROMONTORYA_1			0x43bc
 #define PCI_DEVICE_ID_ASMEDIA_1042_XHCI			0x1042
 #define PCI_DEVICE_ID_ASMEDIA_1042A_XHCI		0x1142
+#define PCI_DEVICE_ID_ASMEDIA_1142_XHCI			0x1242
 #define PCI_DEVICE_ID_ASMEDIA_2142_XHCI			0x2142
 
 static const char hcd_name[] = "xhci_hcd";
@@ -268,7 +269,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 		pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI)
 		xhci->quirks |= XHCI_TRUST_TX_LENGTH;
 	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
-		pdev->device == PCI_DEVICE_ID_ASMEDIA_2142_XHCI)
+	    (pdev->device == PCI_DEVICE_ID_ASMEDIA_1142_XHCI ||
+	     pdev->device == PCI_DEVICE_ID_ASMEDIA_2142_XHCI))
 		xhci->quirks |= XHCI_NO_64BIT_SUPPORT;
 
 	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
-- 
2.20.1


  parent reply	other threads:[~2020-07-27  9:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  9:06 [PATCH 0/2] Small fixes for ASMedia host controllers Forest Crossman
2020-07-27  9:06 ` [PATCH 1/2] usb: xhci: define IDs for various " Forest Crossman
2020-07-27  9:26   ` Greg KH
2020-07-27 10:03     ` Forest Crossman
2020-07-27 10:12       ` Greg KH
2020-07-27  9:06 ` Forest Crossman [this message]
2020-07-28  4:24 ` [PATCH v2 0/2] Small fixes for " Forest Crossman
2020-07-28  4:24   ` [PATCH v2 1/2] usb: xhci: define IDs for various " Forest Crossman
2020-07-29 18:08     ` Sergei Shtylyov
2020-07-28  4:24   ` [PATCH v2 2/2] usb: xhci: Fix ASMedia ASM1142 DMA addressing Forest Crossman
2020-07-28 11:16   ` [PATCH v2 0/2] Small fixes for ASMedia host controllers Greg KH
2020-07-28 12:40     ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727090629.169701-3-cyrozap@gmail.com \
    --to=cyrozap@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.