From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F18C433EC for ; Mon, 27 Jul 2020 14:06:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D1B52078E for ; Mon, 27 Jul 2020 14:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595858794; bh=PUSF2uKY6ZSg2dfEurFMvzgYDI1RG5wqluUewKxwnVg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cefqMlx6pTZ8cxNH+79Jfs3Bd2sEMhl6fOoRgs7pTnkxRlqSxx2rkxJ2rMyNWWL6p 4yuGey8YXy8+VoFpc9hQAdrC2SFqDD+H5jHIwXD3OjDrku8tFBlvH+4SchOZeZrsMW kiXVFGkx6I3fRf1tu2JSslkVJw6NoqDei48faV0A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728830AbgG0OGd (ORCPT ); Mon, 27 Jul 2020 10:06:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:54474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728731AbgG0OGb (ORCPT ); Mon, 27 Jul 2020 10:06:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C485C2073E; Mon, 27 Jul 2020 14:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595858791; bh=PUSF2uKY6ZSg2dfEurFMvzgYDI1RG5wqluUewKxwnVg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pQ7Z0F1TbhcwwdiUz5kmn1noBJmmqxVqPy6CHkZgjLzq2MV9uC1S6ZuJevyZlykEi B0sm9AJGOBhYekHJre5P9sZNXpBQF/tHQPmDkvjKWExHdC0wa90R2FZHVKITXuodZf OwA5iQiXZFMhBn0XjxwnJ3vvQAE0E1jlNaZiLScA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vladimir Oltean , Mark Brown , Guenter Roeck Subject: [PATCH 4.14 13/64] spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when its not ours Date: Mon, 27 Jul 2020 16:03:52 +0200 Message-Id: <20200727134911.689399235@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134911.020675249@linuxfoundation.org> References: <20200727134911.020675249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vladimir Oltean commit d41f36a6464a85c06ad920703d878e4491d2c023 upstream. The DSPI interrupt can be shared between two controllers at least on the LX2160A. In that case, the driver for one controller might misbehave and consume the other's interrupt. Fix this by actually checking if any of the bits in the status register have been asserted. Fixes: 13aed2392741 ("spi: spi-fsl-dspi: use IRQF_SHARED mode to request IRQ") Signed-off-by: Vladimir Oltean Link: https://lore.kernel.org/r/20190822212450.21420-2-olteanv@gmail.com Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Cc: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-fsl-dspi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -886,9 +886,11 @@ static irqreturn_t dspi_interrupt(int ir trans_mode); } } + + return IRQ_HANDLED; } - return IRQ_HANDLED; + return IRQ_NONE; } static const struct of_device_id fsl_dspi_dt_ids[] = {