All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 7/9] package/efl: depend on lua ABI version 5.1
Date: Mon, 27 Jul 2020 21:19:40 +0200	[thread overview]
Message-ID: <20200727191940.GI19818@scaer> (raw)
In-Reply-To: <20200525004845.3019642-7-james.hilliard1@gmail.com>

James, All,

On 2020-05-24 18:48 -0600, James Hilliard spake thusly:
> Since efl is compatible with lua interpreters that provide the
> version 5.1 ABI we should depend on that instead of unconditionally
> selecting luajit.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
[--SNIP--]
> @@ -379,6 +385,14 @@ else
>  HOST_EFL_CONF_OPTS += --disable-cxx-bindings
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LUAJIT),y)
> +HOST_EFL_CONF_OPTS += --disable-lua-old
> +HOST_EFL_DEPENDENCIES += host-luajit
> +else ifeq ($(BR2_PACKAGE_LUA),y)
> +HOST_EFL_CONF_OPTS += --enable-lua-old
> +HOST_EFL_DEPENDENCIES += host-lua
> +endif

Why does the host variant need to build against the same as the target
variant?

It is very unusual that a target option (here, the target Lua
interpreter) drives the compilation and dependencies of a host package,
so this warrants a bit of explanations.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2020-07-27 19:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25  0:48 [Buildroot] [PATCH v3 1/9] package/luainterpreter: add abi version options James Hilliard
2020-05-25  0:48 ` [Buildroot] [PATCH v3 2/9] package/sysdig: depend on lua ABI version 5.1 James Hilliard
2020-05-25  0:48 ` [Buildroot] [PATCH v3 3/9] package/collectd: depend on luainterpreter for lua support James Hilliard
2020-05-25  7:10   ` Thomas Petazzoni
2020-05-25  8:05     ` James Hilliard
2020-05-25  0:48 ` [Buildroot] [PATCH v3 4/9] package/solarus: depend on lua ABI version 5.1 James Hilliard
2020-05-25  0:48 ` [Buildroot] [PATCH v3 5/9] package/luaposix: select bit32 based " James Hilliard
2020-05-25  0:48 ` [Buildroot] [PATCH v3 6/9] package/minetest: do not select luajit James Hilliard
2020-06-06 17:05   ` Romain Naour
2020-06-06 22:43     ` James Hilliard
2020-07-27 20:11       ` Yann E. MORIN
2020-07-27 20:39         ` James Hilliard
2020-05-25  0:48 ` [Buildroot] [PATCH v3 7/9] package/efl: depend on lua ABI version 5.1 James Hilliard
2020-06-06 16:36   ` Romain Naour
2020-07-27 19:16     ` Yann E. MORIN
2020-07-27 19:19   ` Yann E. MORIN [this message]
2020-07-27 19:23     ` James Hilliard
2020-07-27 19:29       ` Yann E. MORIN
2020-07-27 19:36         ` James Hilliard
2020-07-27 19:44           ` Yann E. MORIN
2020-05-25  0:48 ` [Buildroot] [PATCH v3 8/9] package/prosody: don't depend on !lua 5.3 James Hilliard
2020-05-25  0:48 ` [Buildroot] [PATCH v3 9/9] package/luajit: depend on !BR2_PACKAGE_LUA James Hilliard
2020-07-27 20:37   ` Yann E. MORIN
2020-07-27 21:12     ` James Hilliard
2020-06-06 21:59 ` [Buildroot] [PATCH v3 1/9] package/luainterpreter: add abi version options Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727191940.GI19818@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.