From: Christoph Hellwig <hch@lst.de>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty/synclink: remove leftover bits of non-PCI card support
Date: Tue, 28 Jul 2020 08:20:45 +0200 [thread overview]
Message-ID: <20200728062045.GA20992@lst.de> (raw)
In-Reply-To: <8a015ca4-e837-8fa5-684c-46fca8104ea5@kernel.org>
On Tue, Jul 28, 2020 at 08:05:36AM +0200, Jiri Slaby wrote:
> On 27. 07. 20, 15:05, Christoph Hellwig wrote:
> > Since commit 1355cba9c3ba ("tty/synclink: remove ISA support"), the
> > synlink driver only supports PCI card. Remove any leftover dead code
> > to support other cards.
>
> So now you can remove also the defines and bus_type completely:
> $ git grep -E 'MGSL_BUS_TYPE_(E?ISA|PCI)'
> drivers/tty/synclink_gt.c: info->bus_type = MGSL_BUS_TYPE_PCI;
> drivers/tty/synclinkmp.c: info->bus_type = MGSL_BUS_TYPE_PCI;
> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_ISA 1
> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_EISA 2
> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_PCI 5
This is in a uapi header, so I didn't dare to touch it.
>
> $ git grep -w bus_type drivers/tty/synclink*
> drivers/tty/synclink_gt.c: unsigned int bus_type;
> drivers/tty/synclink_gt.c: info->bus_type = MGSL_BUS_TYPE_PCI;
> drivers/tty/synclinkmp.c: unsigned int bus_type;
> /* expansion bus type (ISA,EISA,PCI) */
> drivers/tty/synclinkmp.c: info->bus_type = MGSL_BUS_TYPE_PCI;
Despite the similar names these are actually two drivers entirely
separate form the main synclink one.
next prev parent reply other threads:[~2020-07-28 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 13:05 [PATCH] tty/synclink: remove leftover bits of non-PCI card support Christoph Hellwig
2020-07-28 6:05 ` Jiri Slaby
2020-07-28 6:09 ` Jiri Slaby
2020-07-28 6:20 ` Christoph Hellwig [this message]
2020-07-28 6:40 ` Jiri Slaby
2020-07-28 7:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728062045.GA20992@lst.de \
--to=hch@lst.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.