From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21BEC433E1 for ; Tue, 28 Jul 2020 06:56:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D96D207F5 for ; Tue, 28 Jul 2020 06:56:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qbti0MHE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AN/2BJ8f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D96D207F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tyjcDZIMKEHy1SijpmdpLwhZhRGswAgvYVdtAXpXyEI=; b=qbti0MHEU/dIBOmVXJ8r2g/oA adZfak6nqxMvbLiLcX4uJqRHDQ/skFXwHwvkWn/kQOOQhgo/iZx4rmdu+rBBDt1DfKfSZXWaKcF03 zXTr8UpcKQ6gb2ftSNC/rRwgFIkbJ7c0lNxZwsChda/GlkPY/TpsDimHrpUMNkPe5ysk71f0C+661 cK0gHJCv4tUBZBYFgz9RZRsMNgshXTih8+M10AXZ6HtjtkpCNl1bnjrrQ4W+u5LORuRS/IiRIxN1d jaRa37to+iSf/g4PRAHD/hfeTeaTcJhz6JJbpV5Q16Cc2ZPPzTo+2/7DcYQbM/N3dmm7Cwcg6DDC2 EJx3RZMSw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0JXK-0005eU-TY; Tue, 28 Jul 2020 06:56:30 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0JXF-0005c4-3D for linux-mediatek@lists.infradead.org; Tue, 28 Jul 2020 06:56:26 +0000 Received: by mail-wm1-x344.google.com with SMTP id g10so14874698wmc.1 for ; Mon, 27 Jul 2020 23:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=EzvrXWpHQNdpSbezzz5RHbcrWIdGyn8mBuYW7/LNbzE=; b=AN/2BJ8ftihaC5U7VYaGUe51vSbgZBy0qgZKto5kdNZYHnMMU0klhv9/thZCz2DkDt dDxR2di/EgMBX5g/fOZXZcBeU6DbcT57YbEGbJG/kTWUuSOzJzV8O4RMU0+EmduM9cMg 2YrS+SqmfKDxhdBRo9CudmQrzMu35wRH3I1IJhs5caPwQ/jktBAkwH5iELcp/UkXRYWm S+Nr7PQ10VU16ICkcXkIjg2pYuJo9zNlFLGGib/eOzI2BX80dftzNtJBkpsj+WGeqrUR KHX2zV1SA8I2AjT0Eh4rPiWPbMSSyEu8lfLb+CgqlqnkZpfy93Xsa3lnz7qGBm64apHu 76sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=EzvrXWpHQNdpSbezzz5RHbcrWIdGyn8mBuYW7/LNbzE=; b=j3OG2P2SQG1rPjaLI8PqDAA599zIYP9gVlht09gP2GuIlfk8IW3vmCbjWmBF5vibwc xZDD+0beaoHZu0d4E5PamM7pIl6+qz0lCSWR4QP5BrB3/zYzzIW1rybUAfU6VkWz43xi PO4ZiA3ZF/rVnZvoVYfBYbkQKXAbREi7r14i06WDhphyTwGRsWaifyU5DXT7vgMT/32W eIcfxr68z/gt3xDzvIchvXLlc5JgdzOokvCfj1Xt6J2epieVsefYoS7hOhmlSLqQSq9Y S4Ooq75hUwPbiKMWM+/BUm+PvURd8z40EqOqPigQ1+t5Pxc6Sjgf1ZQX6SiXMnNnGcyl Ld9w== X-Gm-Message-State: AOAM5331CEvdOckiK+APA1Wc3pLjKVFuqrC6SWoIDB6Kx+21KN08R8nr hpxbET66foPtH0ISTIkHlRc1Jw== X-Google-Smtp-Source: ABdhPJz2E995BnQURgOq+VOSHacfZHoxet9ax0lW2Q3YzkefTZM18rSXI9SMEvORfr9BIIubRt2bgA== X-Received: by 2002:a1c:2d89:: with SMTP id t131mr2655127wmt.151.1595919383931; Mon, 27 Jul 2020 23:56:23 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id 78sm2777722wma.31.2020.07.27.23.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 23:56:23 -0700 (PDT) Date: Tue, 28 Jul 2020 07:56:21 +0100 From: Lee Jones To: Gene Chen Subject: Re: [PATCH v2 1/9] mfd: mt6360: Rearrange include file Message-ID: <20200728065621.GC1850026@dell> References: <1594983811-25908-1-git-send-email-gene.chen.richtek@gmail.com> <1594983811-25908-2-git-send-email-gene.chen.richtek@gmail.com> <20200727110821.GH1850026@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_025625_462694_BA2D58C8 X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gene Chen , linux-kernel@vger.kernel.org, cy_huang@richtek.com, benjamin.chao@mediatek.com, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyOCBKdWwgMjAyMCwgR2VuZSBDaGVuIHdyb3RlOgoKPiBMZWUgSm9uZXMgPGxlZS5q b25lc0BsaW5hcm8ub3JnPiDmlrwgMjAyMOW5tDfmnIgyN+aXpSDpgLHkuIAg5LiL5Y2INzowOOWv q+mBk++8mgo+ID4KPiA+IE9uIEZyaSwgMTcgSnVsIDIwMjAsIEdlbmUgQ2hlbiB3cm90ZToKPiA+ Cj4gPiA+IEZyb206IEdlbmUgQ2hlbiA8Z2VuZV9jaGVuQHJpY2h0ZWsuY29tPgo+ID4gPgo+ID4g PiBSZWFycmFuZ2UgaW5jbHVkZSBmaWxlIHdpdGhvdXQgc29ydGluZyBieSBhbHBoYWJldC4KPiA+ Cj4gPiBXaHkgYXJlIHlvdSBtYWtpbmcgdGhpcyBjaGFuZ2U/Cj4gPgo+IAo+IFBlcnNvbmFsIGNv ZGluZyBzdHlsZSByZWZlcmVuY2VzIGZyb20gdXBzdHJlYW0gY29kZS4KPiBJIGNhbiBkaXNjYXJk IHRoaXMgY2hhbmdlIGlmIGl0IGRvZXNuJ3QgbWFrZSBzZW5zZS4KClRoYXQgaXMgcmVhbGx5IHdy b25nLgoKVGhpcyBpcyB1cHN0cmVhbSBjb2RlLiAgWW91IHNob3VsZCBhYmlkZSBieSB0aGUgY29k aW5nIHN0eWxlLgoKSW5jbHVkZSBmaWxlcyBzaG91bGQgYmUgYXJyYW5nZWQgYWxwaGFiZXRpY2Fs bHksIG5vdCBhcmJpdHJhcmlseS4KCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEdlbmUgQ2hlbiA8Z2Vu ZV9jaGVuQHJpY2h0ZWsuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvbWZkL210NjM2MC1j b3JlLmMgfCAxMSArKysrKy0tLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9u cygrKSwgNiBkZWxldGlvbnMoLSkKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZk L210NjM2MC1jb3JlLmMgYi9kcml2ZXJzL21mZC9tdDYzNjAtY29yZS5jCj4gPiA+IGluZGV4IGU5 Y2FjYzIuLmRmNDUwNmYgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvbWZkL210NjM2MC1jb3Jl LmMKPiA+ID4gKysrIGIvZHJpdmVycy9tZmQvbXQ2MzYwLWNvcmUuYwo+ID4gPiBAQCAtNSwxNSAr NSwxNCBAQAo+ID4gPiAgICogQXV0aG9yOiBHZW5lIENoZW4gPGdlbmVfY2hlbkByaWNodGVrLmNv bT4KPiA+ID4gICAqLwo+ID4gPgo+ID4gPiArI2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgo+ID4g PiArI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ID4gPiAgI2luY2x1ZGUgPGxpbnV4L2kyYy5o Pgo+ID4gPiAtI2luY2x1ZGUgPGxpbnV4L2luaXQuaD4KPiA+ID4gKyNpbmNsdWRlIDxsaW51eC9j cmM4Lmg+Cj4gPiA+ICsjaW5jbHVkZSA8bGludXgvc2xhYi5oPgo+ID4gPiArI2luY2x1ZGUgPGxp bnV4L3JlZ21hcC5oPgo+ID4gPiAgI2luY2x1ZGUgPGxpbnV4L2ludGVycnVwdC5oPgo+ID4gPiAt I2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgo+ID4gPiAgI2luY2x1ZGUgPGxpbnV4L21mZC9jb3Jl Lmg+Cj4gPiA+IC0jaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+Cj4gPiA+IC0jaW5jbHVkZSA8bGlu dXgvb2ZfaXJxLmg+Cj4gPiA+IC0jaW5jbHVkZSA8bGludXgvb2ZfcGxhdGZvcm0uaD4KPiA+ID4g LSNpbmNsdWRlIDxsaW51eC92ZXJzaW9uLmg+Cj4gPiA+Cj4gPiA+ICAjaW5jbHVkZSA8bGludXgv bWZkL210NjM2MC5oPgo+ID4gPgo+ID4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9y IFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4g c291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3 aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpMaW51eC1tZWRpYXRlayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1671CC433E1 for ; Tue, 28 Jul 2020 06:57:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4EC6207F5 for ; Tue, 28 Jul 2020 06:57:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q8HPMH8H"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AN/2BJ8f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4EC6207F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OnjkPrbjsiWxY3woSLQm4sbJy3PAH2M24a6Ls1ijfyI=; b=q8HPMH8HKG8SKF+Lj8cXPWrO2 eIpk9rnfWqpp2jXnuno+QjKzF758ivv2hcCzPByfCqOLYyzI2HvXZTKqNsTZE1Ug4aMSgtRleT4u9 Up4u2S2zkPOsHNZrxj3IC9vsskOu/u2wM9mLO7w1bqdAt5oKujDg22uoRmBBlm8T1ympgsf3xpqyG klFF9InOx62cO4hzYiDqR4vfBxlFilRc5TsoAxDRWH9QyRxWYhpt7Vn1uh0A5vi8ss68npSuJZl8Z SMVyyyTTVlYO3PSZIBzgGdXl6B412LmaRUWg/aYFya3mOvKHM/yXZG2JlQBEuF28l6YdaPHtFdy4y hBdDPRDbg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0JXJ-0005dw-0g; Tue, 28 Jul 2020 06:56:29 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0JXF-0005c5-71 for linux-arm-kernel@lists.infradead.org; Tue, 28 Jul 2020 06:56:26 +0000 Received: by mail-wm1-x342.google.com with SMTP id c80so16225026wme.0 for ; Mon, 27 Jul 2020 23:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=EzvrXWpHQNdpSbezzz5RHbcrWIdGyn8mBuYW7/LNbzE=; b=AN/2BJ8ftihaC5U7VYaGUe51vSbgZBy0qgZKto5kdNZYHnMMU0klhv9/thZCz2DkDt dDxR2di/EgMBX5g/fOZXZcBeU6DbcT57YbEGbJG/kTWUuSOzJzV8O4RMU0+EmduM9cMg 2YrS+SqmfKDxhdBRo9CudmQrzMu35wRH3I1IJhs5caPwQ/jktBAkwH5iELcp/UkXRYWm S+Nr7PQ10VU16ICkcXkIjg2pYuJo9zNlFLGGib/eOzI2BX80dftzNtJBkpsj+WGeqrUR KHX2zV1SA8I2AjT0Eh4rPiWPbMSSyEu8lfLb+CgqlqnkZpfy93Xsa3lnz7qGBm64apHu 76sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=EzvrXWpHQNdpSbezzz5RHbcrWIdGyn8mBuYW7/LNbzE=; b=Es4quCJiDW7Nr9PfICM2DrEtL8VZEDsYFfejbSMS/sqsxoWlvA9ZfGd6Er+bOZ3qmk DALO/51Yh82sgVRiXkJ9Pm8dUSeSM60L2v1/EyczixXbBj0HfS6njc3jHeFbbwfbeSHb qQ7OLBW73vC/jixVSgHBptHTlNVYzP6NIqE3sXJTpEkw8Gwf9+dikwUioItJ5HxYo7q0 vhGle6bpY2nbi221aC1ONrvkYDOYpRZQv+3WHbUxAgTYSr/nZMgGKis0k9Z2O9/yIoYu LLqdFkOcOS8v3IA++oUlei5oYAioNaHlBAVtpPgqAiOubN7nLqGuon+6Tye8UUbY4jd2 sNzw== X-Gm-Message-State: AOAM531aJKHw3Qj+unFapLDOzKP6wvVfWrzBnNdfXZLflmE8Fy/rxr7F e3e72n7nW+6C2Oa1NiELpv8AgvMHT/I= X-Google-Smtp-Source: ABdhPJz2E995BnQURgOq+VOSHacfZHoxet9ax0lW2Q3YzkefTZM18rSXI9SMEvORfr9BIIubRt2bgA== X-Received: by 2002:a1c:2d89:: with SMTP id t131mr2655127wmt.151.1595919383931; Mon, 27 Jul 2020 23:56:23 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id 78sm2777722wma.31.2020.07.27.23.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 23:56:23 -0700 (PDT) Date: Tue, 28 Jul 2020 07:56:21 +0100 From: Lee Jones To: Gene Chen Subject: Re: [PATCH v2 1/9] mfd: mt6360: Rearrange include file Message-ID: <20200728065621.GC1850026@dell> References: <1594983811-25908-1-git-send-email-gene.chen.richtek@gmail.com> <1594983811-25908-2-git-send-email-gene.chen.richtek@gmail.com> <20200727110821.GH1850026@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_025625_459501_33C23F1F X-CRM114-Status: GOOD ( 19.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gene Chen , linux-kernel@vger.kernel.org, cy_huang@richtek.com, benjamin.chao@mediatek.com, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyOCBKdWwgMjAyMCwgR2VuZSBDaGVuIHdyb3RlOgoKPiBMZWUgSm9uZXMgPGxlZS5q b25lc0BsaW5hcm8ub3JnPiDmlrwgMjAyMOW5tDfmnIgyN+aXpSDpgLHkuIAg5LiL5Y2INzowOOWv q+mBk++8mgo+ID4KPiA+IE9uIEZyaSwgMTcgSnVsIDIwMjAsIEdlbmUgQ2hlbiB3cm90ZToKPiA+ Cj4gPiA+IEZyb206IEdlbmUgQ2hlbiA8Z2VuZV9jaGVuQHJpY2h0ZWsuY29tPgo+ID4gPgo+ID4g PiBSZWFycmFuZ2UgaW5jbHVkZSBmaWxlIHdpdGhvdXQgc29ydGluZyBieSBhbHBoYWJldC4KPiA+ Cj4gPiBXaHkgYXJlIHlvdSBtYWtpbmcgdGhpcyBjaGFuZ2U/Cj4gPgo+IAo+IFBlcnNvbmFsIGNv ZGluZyBzdHlsZSByZWZlcmVuY2VzIGZyb20gdXBzdHJlYW0gY29kZS4KPiBJIGNhbiBkaXNjYXJk IHRoaXMgY2hhbmdlIGlmIGl0IGRvZXNuJ3QgbWFrZSBzZW5zZS4KClRoYXQgaXMgcmVhbGx5IHdy b25nLgoKVGhpcyBpcyB1cHN0cmVhbSBjb2RlLiAgWW91IHNob3VsZCBhYmlkZSBieSB0aGUgY29k aW5nIHN0eWxlLgoKSW5jbHVkZSBmaWxlcyBzaG91bGQgYmUgYXJyYW5nZWQgYWxwaGFiZXRpY2Fs bHksIG5vdCBhcmJpdHJhcmlseS4KCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEdlbmUgQ2hlbiA8Z2Vu ZV9jaGVuQHJpY2h0ZWsuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvbWZkL210NjM2MC1j b3JlLmMgfCAxMSArKysrKy0tLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9u cygrKSwgNiBkZWxldGlvbnMoLSkKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZk L210NjM2MC1jb3JlLmMgYi9kcml2ZXJzL21mZC9tdDYzNjAtY29yZS5jCj4gPiA+IGluZGV4IGU5 Y2FjYzIuLmRmNDUwNmYgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvbWZkL210NjM2MC1jb3Jl LmMKPiA+ID4gKysrIGIvZHJpdmVycy9tZmQvbXQ2MzYwLWNvcmUuYwo+ID4gPiBAQCAtNSwxNSAr NSwxNCBAQAo+ID4gPiAgICogQXV0aG9yOiBHZW5lIENoZW4gPGdlbmVfY2hlbkByaWNodGVrLmNv bT4KPiA+ID4gICAqLwo+ID4gPgo+ID4gPiArI2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgo+ID4g PiArI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ID4gPiAgI2luY2x1ZGUgPGxpbnV4L2kyYy5o Pgo+ID4gPiAtI2luY2x1ZGUgPGxpbnV4L2luaXQuaD4KPiA+ID4gKyNpbmNsdWRlIDxsaW51eC9j cmM4Lmg+Cj4gPiA+ICsjaW5jbHVkZSA8bGludXgvc2xhYi5oPgo+ID4gPiArI2luY2x1ZGUgPGxp bnV4L3JlZ21hcC5oPgo+ID4gPiAgI2luY2x1ZGUgPGxpbnV4L2ludGVycnVwdC5oPgo+ID4gPiAt I2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgo+ID4gPiAgI2luY2x1ZGUgPGxpbnV4L21mZC9jb3Jl Lmg+Cj4gPiA+IC0jaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+Cj4gPiA+IC0jaW5jbHVkZSA8bGlu dXgvb2ZfaXJxLmg+Cj4gPiA+IC0jaW5jbHVkZSA8bGludXgvb2ZfcGxhdGZvcm0uaD4KPiA+ID4g LSNpbmNsdWRlIDxsaW51eC92ZXJzaW9uLmg+Cj4gPiA+Cj4gPiA+ICAjaW5jbHVkZSA8bGludXgv bWZkL210NjM2MC5oPgo+ID4gPgo+ID4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9y IFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4g c291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3 aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D8FC433E3 for ; Tue, 28 Jul 2020 06:56:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDC17207F5 for ; Tue, 28 Jul 2020 06:56:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AN/2BJ8f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727072AbgG1G40 (ORCPT ); Tue, 28 Jul 2020 02:56:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbgG1G4Z (ORCPT ); Tue, 28 Jul 2020 02:56:25 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 342B1C061794 for ; Mon, 27 Jul 2020 23:56:25 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id p14so15882962wmg.1 for ; Mon, 27 Jul 2020 23:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=EzvrXWpHQNdpSbezzz5RHbcrWIdGyn8mBuYW7/LNbzE=; b=AN/2BJ8ftihaC5U7VYaGUe51vSbgZBy0qgZKto5kdNZYHnMMU0klhv9/thZCz2DkDt dDxR2di/EgMBX5g/fOZXZcBeU6DbcT57YbEGbJG/kTWUuSOzJzV8O4RMU0+EmduM9cMg 2YrS+SqmfKDxhdBRo9CudmQrzMu35wRH3I1IJhs5caPwQ/jktBAkwH5iELcp/UkXRYWm S+Nr7PQ10VU16ICkcXkIjg2pYuJo9zNlFLGGib/eOzI2BX80dftzNtJBkpsj+WGeqrUR KHX2zV1SA8I2AjT0Eh4rPiWPbMSSyEu8lfLb+CgqlqnkZpfy93Xsa3lnz7qGBm64apHu 76sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=EzvrXWpHQNdpSbezzz5RHbcrWIdGyn8mBuYW7/LNbzE=; b=FXC650nw4a4XwsQDmaHLLVquHnryAwJx+ZbPK1n97yRFEGtlIrhzo7JHG4OtXYq/c3 LFCY9u9EcMjApolkLQr82lU/HveDKYCIN80HGnoQ04vPw1mQUqbfhIdIvDN26S4KJkmH PGHKidTQIh2N6agnxVcTHMM7mS8GMuKl8ksOaXHj60Fhz01jxO1cjWkDiGOqb/hgrzDY Cl06zbhNCoz3ojNlOGy62ieCVtVtiByXhYKcBxNGaZIl/KJkgFR8pzE6cYJk7nfHzD1/ KbiXOdeqxUtcxWV7bm7DBv3W8Ei3aHVms9joOwOj+xZ2+FgX7v35Vn81k89yzZ4Q5u+j FsMw== X-Gm-Message-State: AOAM5311qa4nbXyJ4zflEvQsKXmhWcvJsgXAIN7V+0raoeZ487I0e3nq +2/ziRH+Y7OkS7DrhhxH7xqGSA== X-Google-Smtp-Source: ABdhPJz2E995BnQURgOq+VOSHacfZHoxet9ax0lW2Q3YzkefTZM18rSXI9SMEvORfr9BIIubRt2bgA== X-Received: by 2002:a1c:2d89:: with SMTP id t131mr2655127wmt.151.1595919383931; Mon, 27 Jul 2020 23:56:23 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id 78sm2777722wma.31.2020.07.27.23.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 23:56:23 -0700 (PDT) Date: Tue, 28 Jul 2020 07:56:21 +0100 From: Lee Jones To: Gene Chen Cc: Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Gene Chen , benjamin.chao@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com Subject: Re: [PATCH v2 1/9] mfd: mt6360: Rearrange include file Message-ID: <20200728065621.GC1850026@dell> References: <1594983811-25908-1-git-send-email-gene.chen.richtek@gmail.com> <1594983811-25908-2-git-send-email-gene.chen.richtek@gmail.com> <20200727110821.GH1850026@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jul 2020, Gene Chen wrote: > Lee Jones 於 2020年7月27日 週一 下午7:08寫道： > > > > On Fri, 17 Jul 2020, Gene Chen wrote: > > > > > From: Gene Chen > > > > > > Rearrange include file without sorting by alphabet. > > > > Why are you making this change? > > > > Personal coding style references from upstream code. > I can discard this change if it doesn't make sense. That is really wrong. This is upstream code. You should abide by the coding style. Include files should be arranged alphabetically, not arbitrarily. > > > Signed-off-by: Gene Chen > > > --- > > > drivers/mfd/mt6360-core.c | 11 +++++------ > > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c > > > index e9cacc2..df4506f 100644 > > > --- a/drivers/mfd/mt6360-core.c > > > +++ b/drivers/mfd/mt6360-core.c > > > @@ -5,15 +5,14 @@ > > > * Author: Gene Chen > > > */ > > > > > > +#include > > > +#include > > > #include > > > -#include > > > +#include > > > +#include > > > +#include > > > #include > > > -#include > > > #include > > > -#include > > > -#include > > > -#include > > > -#include > > > > > > #include > > > > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog