From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26521C433E3 for ; Tue, 28 Jul 2020 08:57:38 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E083220775 for ; Tue, 28 Jul 2020 08:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="tAh81aGE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E083220775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id AEFC52284F; Tue, 28 Jul 2020 08:57:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6syI2TiDhdhF; Tue, 28 Jul 2020 08:57:37 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 0280222718; Tue, 28 Jul 2020 08:57:36 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D78D5C0050; Tue, 28 Jul 2020 08:57:36 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0F9EEC004D for ; Tue, 28 Jul 2020 08:57:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0275422844 for ; Tue, 28 Jul 2020 08:57:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OP8AUiOODz8p for ; Tue, 28 Jul 2020 08:57:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by silver.osuosl.org (Postfix) with ESMTPS id F2E5F22718 for ; Tue, 28 Jul 2020 08:57:33 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06S8v27H068443; Tue, 28 Jul 2020 08:57:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=g2iu+QCMgXo2sAT2PlgYuqn3NjqPMtQtGppvStDwUPE=; b=tAh81aGE6m22XiJtNJu46kyd6LUJKwYgqSAfh30pZxnKOIkMYvA1ul7oQMyJAEhEFKN/ ssDLycHG+IAh38HY99EZ6MB+MrIiltVB/hkg+733Ejni9W3PTyvGkZZ2eo3sUVaoOx0h 2hyIMdAwNfik2n0UmJcjpuPa1MBJ+bdwWpsamoRvkWQgI1jVuILselkLeWNdVcXewKNp ykbSVcIR3sFO+Fbe9aZWUH+PP/hLc6RgqVslOFP4XbTNruDCy4FM71cKXylPEyoO2S4l nA8NWcW8r+eL7L00W21sORJBuuuL0p1huyg9BR7iFGkEIIfe+/jjOTin0W7cmdV407KD 6A== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 32hu1j68ag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 Jul 2020 08:57:24 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06S8qhKL136632; Tue, 28 Jul 2020 08:57:23 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 32hu5tunf3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Jul 2020 08:57:23 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 06S8vLQ8014135; Tue, 28 Jul 2020 08:57:21 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 28 Jul 2020 01:57:20 -0700 Date: Tue, 28 Jul 2020 11:57:12 +0300 From: Dan Carpenter To: Peilin Ye Message-ID: <20200728085712.GE2571@kadam> References: <20200727210235.327835-1-yepeilin.cs@gmail.com> <20200728084137.GC2571@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200728084137.GC2571@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9695 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 spamscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007280067 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9695 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 clxscore=1015 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007280068 Cc: "Martin K. Petersen" , Arnd Bergmann , Shivasharan S , "James E.J. Bottomley" , linux-kernel@vger.kernel.org, Kashyap Desai , Sumit Saxena , linux-scsi@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, megaraidlinux.pdl@broadcom.com Subject: Re: [Linux-kernel-mentees] [PATCH] scsi/megaraid: Prevent kernel-infoleak in kioc_to_mimd() X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Tue, Jul 28, 2020 at 11:41:37AM +0300, Dan Carpenter wrote: > Generally, don't silence static checker warnings unless it makes the > code more readable. It's the checker writer's job to fix their own code. > In this case, that's me, but parsing the code is quite complicated and I > don't have a plan for how to fix it. Actually, looking at this some more, it's not so complicated. By this time next year hopefully this warning will be silenced. regards, dan carpenter _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE319C433E3 for ; Tue, 28 Jul 2020 08:58:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D6132083E for ; Tue, 28 Jul 2020 08:58:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="tAh81aGE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728232AbgG1I5f (ORCPT ); Tue, 28 Jul 2020 04:57:35 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:53546 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726032AbgG1I5f (ORCPT ); Tue, 28 Jul 2020 04:57:35 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06S8v27H068443; Tue, 28 Jul 2020 08:57:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=g2iu+QCMgXo2sAT2PlgYuqn3NjqPMtQtGppvStDwUPE=; b=tAh81aGE6m22XiJtNJu46kyd6LUJKwYgqSAfh30pZxnKOIkMYvA1ul7oQMyJAEhEFKN/ ssDLycHG+IAh38HY99EZ6MB+MrIiltVB/hkg+733Ejni9W3PTyvGkZZ2eo3sUVaoOx0h 2hyIMdAwNfik2n0UmJcjpuPa1MBJ+bdwWpsamoRvkWQgI1jVuILselkLeWNdVcXewKNp ykbSVcIR3sFO+Fbe9aZWUH+PP/hLc6RgqVslOFP4XbTNruDCy4FM71cKXylPEyoO2S4l nA8NWcW8r+eL7L00W21sORJBuuuL0p1huyg9BR7iFGkEIIfe+/jjOTin0W7cmdV407KD 6A== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 32hu1j68ag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 Jul 2020 08:57:24 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06S8qhKL136632; Tue, 28 Jul 2020 08:57:23 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 32hu5tunf3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Jul 2020 08:57:23 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 06S8vLQ8014135; Tue, 28 Jul 2020 08:57:21 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 28 Jul 2020 01:57:20 -0700 Date: Tue, 28 Jul 2020 11:57:12 +0300 From: Dan Carpenter To: Peilin Ye Cc: Kashyap Desai , Sumit Saxena , Arnd Bergmann , Greg Kroah-Hartman , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , linux-kernel-mentees@lists.linuxfoundation.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH] scsi/megaraid: Prevent kernel-infoleak in kioc_to_mimd() Message-ID: <20200728085712.GE2571@kadam> References: <20200727210235.327835-1-yepeilin.cs@gmail.com> <20200728084137.GC2571@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200728084137.GC2571@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9695 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 spamscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007280067 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9695 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 clxscore=1015 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007280068 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Tue, Jul 28, 2020 at 11:41:37AM +0300, Dan Carpenter wrote: > Generally, don't silence static checker warnings unless it makes the > code more readable. It's the checker writer's job to fix their own code. > In this case, that's me, but parsing the code is quite complicated and I > don't have a plan for how to fix it. Actually, looking at this some more, it's not so complicated. By this time next year hopefully this warning will be silenced. regards, dan carpenter