From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09123C433EB for ; Tue, 28 Jul 2020 10:51:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD0FD20656 for ; Tue, 28 Jul 2020 10:51:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vDkkyU+5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728912AbgG1Kv0 (ORCPT ); Tue, 28 Jul 2020 06:51:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728900AbgG1KvZ (ORCPT ); Tue, 28 Jul 2020 06:51:25 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52ED3C0619D4 for ; Tue, 28 Jul 2020 03:51:25 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id r2so12738090wrs.8 for ; Tue, 28 Jul 2020 03:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LzOc135fINoaOyyxwY4N4SP5+/4WZUgI3XQn3ZBQrDA=; b=vDkkyU+5XaTOEmRQYW0CYyR4mlMX1mtnZDopRBrR16WWZAymHLppooL3WbRsemUOlF 7JAG9CCFFBkNo1ck8oAFsHnGGCFpddbJZI4FvPPe/5vgXZIxS7pdXreW0pAmXl4fefVk uemgsa2HPMS2pgMJSiY5gsoUuJ22Uc9FFMkDS50upr4Y5t/bruJsOn96uJd/Xej/4+wJ r3z4kV7L9g728y5x+aNOBIj6JRK/2vA+lFuGJCCKMNnmmCY7vsMSYcIdJpOO1Lj/2Nk6 unQbNqxObw8nTIlx8MnFNeMtUIVxddRTqJvHuyaU1npKp/UQnousCC6p6CUsu9YCp0JA N8gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LzOc135fINoaOyyxwY4N4SP5+/4WZUgI3XQn3ZBQrDA=; b=cuHOz+Ay0j82NyF/rwx4wGS1e397u5Kp2+GD/jufpybB861kzHPoBWV6llFLn9F8We vcjbTreP0XIe63qvM97Uu9StlU/4fFQ50P7DIRr+abnaqPIN7LK/HlInmMd3JhKFDCgZ TRGQiTpbQ9tUnt28Ul2ZCrCPQV1Y+AHxW7F91PqU5bnO6qlN+stbNyw/P3Ukr5bXihP1 W/uyE3jZ0mgdkxLwGGE6MPVfD3oU3sacDxrTAIPOgsyEUY8GR5uvuUB+v0fwRfWdaEQK wia8Z3RjxzenXMr8pzYKUd3b31rU7xjdMb6ZXLypErxel2FGqGCKVj1MRebYxOPlGSMS ihTA== X-Gm-Message-State: AOAM531glUnbEABm+zlEbonfupel+6Qlla/mgURvrVX7sPrf661FH9mm mmJmED/g84jO2KbSx1tu56zgFQ== X-Google-Smtp-Source: ABdhPJyXBEeI4zvLVf/tRWpqopuL2jSNCu4L9LZnKQaZP1mCTaWKou6fjAB0L+zVU5NonfUp5NxoSw== X-Received: by 2002:a5d:4a90:: with SMTP id o16mr23540803wrq.87.1595933483925; Tue, 28 Jul 2020 03:51:23 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id y189sm4194196wmd.27.2020.07.28.03.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2020 03:51:23 -0700 (PDT) Date: Tue, 28 Jul 2020 11:51:21 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Michael Walle , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , Andy Shevchenko , Catalin Marinas , Will Deacon , Pavel Machek Subject: Re: [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller Message-ID: <20200728105121.GG2419169@dell> References: <20200725231834.25642-1-michael@walle.cc> <20200725231834.25642-7-michael@walle.cc> <20200728074352.ckyfso5zwsfgupjx@pengutronix.de> <58b53cacc5289f17f669159beeeada03@walle.cc> <20200728094720.x6pucwxsfwvz6nvv@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200728094720.x6pucwxsfwvz6nvv@pengutronix.de> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, 28 Jul 2020, Uwe Kleine-König wrote: > On Tue, Jul 28, 2020 at 10:21:22AM +0200, Michael Walle wrote: > > Am 2020-07-28 09:43, schrieb Uwe Kleine-König: > > > On Sun, Jul 26, 2020 at 01:18:27AM +0200, Michael Walle wrote: > > > > +static int sl28cpld_pwm_probe(struct platform_device *pdev) > > > > +{ > > > > + struct sl28cpld_pwm *priv; > > > > + struct pwm_chip *chip; > > > > + int ret; > > > > + > > > > + if (!pdev->dev.parent) > > > > + return -ENODEV; > > > > + > > > > + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > > > > + if (!priv) > > > > + return -ENOMEM; > > > > + > > > > + priv->regmap = dev_get_regmap(pdev->dev.parent, NULL); > > > > + if (!priv->regmap) > > > > > > Error message here? > > > > This shouldn't really happen and I put it into the same category > > as the two above and report no error. But I can add it. > > For kzalloc it is right to not emit an error because a failing kzalloc > is already loud on its own. I missed the first error path, that should > get a message, too. > > > Generally, it looked to me that more and more drivers don't > > really report errors anymore, but just return with an -EWHATEVER. > > So if someone can shed some light here, I'm all ears. > > IMHO it's wrong not to add error messages. At one point in time it will > fail and then you're happy if you don't have to add printks all over the > place first to debug that. Error messages should only be omitted for -ENOMEM and if something is already being printed out, ideally by the sub-system API. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FCA1C433E1 for ; Tue, 28 Jul 2020 10:52:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C5D720656 for ; Tue, 28 Jul 2020 10:52:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mTirKS4W"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vDkkyU+5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C5D720656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OVUJbizcrc+UOD7vco2ky+UM84oD2xtQmOcfBjWiS2U=; b=mTirKS4WYtYl/mMuocCE350ag 7xfayhAO2PZ34/Hv7bPeip1zjffAYRAJqEVG3Oq07U8kbCx55Wzl+KmVe90hGVLL4luL7s5EXQ/gI iMZDCPhc+FNv06HJktRMYlMlRuUP4fjUak8ver0TApOCEGAl4ZVS7cVsrWoGwQgQqhUohs2AAcoad ibdmbxf67HUD2Z8H/HDmHlIHUHaay0l5xU0Lp657vSFJZdGWRewdEaokHP8qArxxF4d0HU4Yyc5YX nVWMuM826EDdzS6AhSJQLk3MTh+sfsausfzMzRE7m8Z3NMR2czDfBmAjBhG55X7+On6H+T/FC6bZE ygi/6bINw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0NCi-0002BP-4s; Tue, 28 Jul 2020 10:51:28 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0NCe-0002A3-Su for linux-arm-kernel@lists.infradead.org; Tue, 28 Jul 2020 10:51:26 +0000 Received: by mail-wr1-x441.google.com with SMTP id a5so7846997wrm.6 for ; Tue, 28 Jul 2020 03:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LzOc135fINoaOyyxwY4N4SP5+/4WZUgI3XQn3ZBQrDA=; b=vDkkyU+5XaTOEmRQYW0CYyR4mlMX1mtnZDopRBrR16WWZAymHLppooL3WbRsemUOlF 7JAG9CCFFBkNo1ck8oAFsHnGGCFpddbJZI4FvPPe/5vgXZIxS7pdXreW0pAmXl4fefVk uemgsa2HPMS2pgMJSiY5gsoUuJ22Uc9FFMkDS50upr4Y5t/bruJsOn96uJd/Xej/4+wJ r3z4kV7L9g728y5x+aNOBIj6JRK/2vA+lFuGJCCKMNnmmCY7vsMSYcIdJpOO1Lj/2Nk6 unQbNqxObw8nTIlx8MnFNeMtUIVxddRTqJvHuyaU1npKp/UQnousCC6p6CUsu9YCp0JA N8gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LzOc135fINoaOyyxwY4N4SP5+/4WZUgI3XQn3ZBQrDA=; b=XssXY+aOgao838qgdY27SKSs/1zY6v1jnnSnOT0NGNzytabXFbIIJpBo5ME7elLBTl qXbzG9boZ/KtcKGy8nfgwXzUdtnuz70aDYJ0e5+dtMowxezTkmnfx5EwWK6FKCnvo+Fm UIUrmxQb1cjyRLa52RhLx+hhFA0qoOlEjYmZYrwuOMeQkRrXGygXezlFB0LA2uJ5Jipq E4gN5GFbOIi9GXSA91RIu+lh4NggDHxvNcf/70dCeWgVD26pSDL8rP7/q58i+xgsr7zg 835xFl/H2c7Oun6rHmQSIZlzU99N1RLCXnq0bAHFvN9naJ+6pemnd+kb3FWD0ZC733x4 3SuQ== X-Gm-Message-State: AOAM533IXFGkYL7+amsdCi4uk7goG3oZFcJt2G2E8bG/7uO0K8HUnguE RTxfl2QGD9nxryUc+slvK+1aaw== X-Google-Smtp-Source: ABdhPJyXBEeI4zvLVf/tRWpqopuL2jSNCu4L9LZnKQaZP1mCTaWKou6fjAB0L+zVU5NonfUp5NxoSw== X-Received: by 2002:a5d:4a90:: with SMTP id o16mr23540803wrq.87.1595933483925; Tue, 28 Jul 2020 03:51:23 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id y189sm4194196wmd.27.2020.07.28.03.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2020 03:51:23 -0700 (PDT) Date: Tue, 28 Jul 2020 11:51:21 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller Message-ID: <20200728105121.GG2419169@dell> References: <20200725231834.25642-1-michael@walle.cc> <20200725231834.25642-7-michael@walle.cc> <20200728074352.ckyfso5zwsfgupjx@pengutronix.de> <58b53cacc5289f17f669159beeeada03@walle.cc> <20200728094720.x6pucwxsfwvz6nvv@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200728094720.x6pucwxsfwvz6nvv@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_065125_702035_C57EBE87 X-CRM114-Status: GOOD ( 25.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Catalin Marinas , Linus Walleij , Thierry Reding , Pavel Machek , Will Deacon , Jason Cooper , Andy Shevchenko , Marc Zyngier , Bartosz Golaszewski , Guenter Roeck , linux-pwm@vger.kernel.org, Jean Delvare , linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org, Mark Brown , Thomas Gleixner , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Li Yang , Michael Walle , Rob Herring , Shawn Guo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyOCBKdWwgMjAyMCwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4gT24gVHVlLCBK dWwgMjgsIDIwMjAgYXQgMTA6MjE6MjJBTSArMDIwMCwgTWljaGFlbCBXYWxsZSB3cm90ZToKPiA+ IEFtIDIwMjAtMDctMjggMDk6NDMsIHNjaHJpZWIgVXdlIEtsZWluZS1Lw7ZuaWc6Cj4gPiA+IE9u IFN1biwgSnVsIDI2LCAyMDIwIGF0IDAxOjE4OjI3QU0gKzAyMDAsIE1pY2hhZWwgV2FsbGUgd3Jv dGU6Cj4gPiA+ID4gK3N0YXRpYyBpbnQgc2wyOGNwbGRfcHdtX3Byb2JlKHN0cnVjdCBwbGF0Zm9y bV9kZXZpY2UgKnBkZXYpCj4gPiA+ID4gK3sKPiA+ID4gPiArCXN0cnVjdCBzbDI4Y3BsZF9wd20g KnByaXY7Cj4gPiA+ID4gKwlzdHJ1Y3QgcHdtX2NoaXAgKmNoaXA7Cj4gPiA+ID4gKwlpbnQgcmV0 Owo+ID4gPiA+ICsKPiA+ID4gPiArCWlmICghcGRldi0+ZGV2LnBhcmVudCkKPiA+ID4gPiArCQly ZXR1cm4gLUVOT0RFVjsKPiA+ID4gPiArCj4gPiA+ID4gKwlwcml2ID0gZGV2bV9remFsbG9jKCZw ZGV2LT5kZXYsIHNpemVvZigqcHJpdiksIEdGUF9LRVJORUwpOwo+ID4gPiA+ICsJaWYgKCFwcml2 KQo+ID4gPiA+ICsJCXJldHVybiAtRU5PTUVNOwo+ID4gPiA+ICsKPiA+ID4gPiArCXByaXYtPnJl Z21hcCA9IGRldl9nZXRfcmVnbWFwKHBkZXYtPmRldi5wYXJlbnQsIE5VTEwpOwo+ID4gPiA+ICsJ aWYgKCFwcml2LT5yZWdtYXApCj4gPiA+IAo+ID4gPiBFcnJvciBtZXNzYWdlIGhlcmU/Cj4gPiAK PiA+IFRoaXMgc2hvdWxkbid0IHJlYWxseSBoYXBwZW4gYW5kIEkgcHV0IGl0IGludG8gdGhlIHNh bWUgY2F0ZWdvcnkKPiA+IGFzIHRoZSB0d28gYWJvdmUgYW5kIHJlcG9ydCBubyBlcnJvci4gQnV0 IEkgY2FuIGFkZCBpdC4KPiAKPiBGb3Iga3phbGxvYyBpdCBpcyByaWdodCB0byBub3QgZW1pdCBh biBlcnJvciBiZWNhdXNlIGEgZmFpbGluZyBremFsbG9jCj4gaXMgYWxyZWFkeSBsb3VkIG9uIGl0 cyBvd24uIEkgbWlzc2VkIHRoZSBmaXJzdCBlcnJvciBwYXRoLCB0aGF0IHNob3VsZAo+IGdldCBh IG1lc3NhZ2UsIHRvby4KPiAKPiA+IEdlbmVyYWxseSwgaXQgbG9va2VkIHRvIG1lIHRoYXQgbW9y ZSBhbmQgbW9yZSBkcml2ZXJzIGRvbid0Cj4gPiByZWFsbHkgcmVwb3J0IGVycm9ycyBhbnltb3Jl LCBidXQganVzdCByZXR1cm4gd2l0aCBhbiAtRVdIQVRFVkVSLgo+ID4gU28gaWYgc29tZW9uZSBj YW4gc2hlZCBzb21lIGxpZ2h0IGhlcmUsIEknbSBhbGwgZWFycy4KPiAKPiBJTUhPIGl0J3Mgd3Jv bmcgbm90IHRvIGFkZCBlcnJvciBtZXNzYWdlcy4gQXQgb25lIHBvaW50IGluIHRpbWUgaXQgd2ls bAo+IGZhaWwgYW5kIHRoZW4geW91J3JlIGhhcHB5IGlmIHlvdSBkb24ndCBoYXZlIHRvIGFkZCBw cmludGtzIGFsbCBvdmVyIHRoZQo+IHBsYWNlIGZpcnN0IHRvIGRlYnVnIHRoYXQuCgpFcnJvciBt ZXNzYWdlcyBzaG91bGQgb25seSBiZSBvbWl0dGVkIGZvciAtRU5PTUVNIGFuZCBpZiBzb21ldGhp bmcgaXMKYWxyZWFkeSBiZWluZyBwcmludGVkIG91dCwgaWRlYWxseSBieSB0aGUgc3ViLXN5c3Rl bSBBUEkuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAt IERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm b3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=