All of lore.kernel.org
 help / color / mirror / Atom feed
From: <dan.carpenter@oracle.com>
To: zhouyanjie@wanyeetech.com
Cc: linux-usb@vger.kernel.org
Subject: [bug report] USB: PHY: JZ4770: Add support for new Ingenic SoCs.
Date: Tue, 28 Jul 2020 14:51:48 +0300	[thread overview]
Message-ID: <20200728115148.GA425911@mwanda> (raw)

Hello 周琰杰 (Zhou Yanjie),

The patch 2a6c0b82e651: "USB: PHY: JZ4770: Add support for new
Ingenic SoCs." from Jul 23, 2020, leads to the following static
checker warning:

	drivers/usb/phy/phy-jz4770.c:179 ingenic_usb_phy_init()
	error: uninitialized symbol 'reg'.

drivers/usb/phy/phy-jz4770.c
   157  static int ingenic_usb_phy_init(struct usb_phy *phy)
   158  {
   159          struct jz4770_phy *priv = phy_to_jz4770_phy(phy);
   160          int err;
   161          u32 reg;
                    ^^^
   162  
   163          err = regulator_enable(priv->vcc_supply);
   164          if (err) {
   165                  dev_err(priv->dev, "Unable to enable VCC: %d\n", err);
   166                  return err;
   167          }
   168  
   169          err = clk_prepare_enable(priv->clk);
   170          if (err) {
   171                  dev_err(priv->dev, "Unable to start clock: %d\n", err);
   172                  return err;
   173          }
   174  
   175          priv->soc_info->usb_phy_init(phy);
   176  
   177          /* Wait for PHY to reset */
   178          usleep_range(30, 300);
   179          writel(reg & ~USBPCR_POR, priv->base + REG_USBPCR_OFFSET);
                       ^^^
Not initialized any more.

   180          usleep_range(300, 1000);
   181  
   182          return 0;
   183  }

regards,
dan carpenter

             reply	other threads:[~2020-07-28 11:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 11:51 dan.carpenter [this message]
2020-07-28 15:47 ` [bug report] USB: PHY: JZ4770: Add support for new Ingenic SoCs Zhou Yanjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200728115148.GA425911@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=zhouyanjie@wanyeetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.