From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C1CCC433E0 for ; Tue, 28 Jul 2020 18:10:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C79C2070B for ; Tue, 28 Jul 2020 18:10:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C79C2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF50C6E226; Tue, 28 Jul 2020 18:10:19 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8CAC36E226 for ; Tue, 28 Jul 2020 18:10:17 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8E31B20032; Tue, 28 Jul 2020 20:10:15 +0200 (CEST) Date: Tue, 28 Jul 2020 20:10:14 +0200 From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH 00/13] drm/ast: Convert to managed initialization Message-ID: <20200728181014.GE1114934@ravnborg.org> References: <20200728074425.2749-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200728074425.2749-1-tzimmermann@suse.de> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=eUHSAhIiOE0y8qXsivgA:9 a=X5xXI9eioqIVaYD0:21 a=wMNijA9QX2g1taFi:21 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org, kraxel@redhat.com, airlied@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas. On Tue, Jul 28, 2020 at 09:44:12AM +0200, Thomas Zimmermann wrote: > This is the final patchset for converting ast to managed initialization. > > Patches #1 to #4 address I2C helpers. The structures are being stored > in struct ast_connector. The initialization and cleanups is being converted > to managed release helpers. > > Patches #5 to #10 address modesetting and device structures. All are > being embedded into struct ast_private. With struct ast_private being > a subclass of struct drm_device, patch #10 switches ast to DRM's managed- > allocation helpers. > > Patches #11 and #12 address firmware memory that ast allocates > internally. > > Finally, patch #13 removes ast's destroy function in favor of managed > release helpers. > > Tested on AST 2100 HW. > > Thomas Zimmermann (13): > drm/ast: Move I2C code within ast_mode.c > drm/ast: Test if I2C support has been initialized > drm/ast: Embed I2C fields in struct ast_connector > drm/ast: Managed release of I2C adapter > drm/ast: Embed CRTC and connector in struct ast_private > drm/ast: Separate DRM driver from PCI code > drm/ast: Replace driver load/unload functions with device > create/destroy > drm/ast: Replace struct_drm_device.dev_private with to_ast_private() > drm/ast: Don't use ast->dev if dev is available > drm/ast: Embed struct drm_device in struct ast_private > drm/ast: Managed release of ast firmware > drm/ast: Manage release of firmware backup memory > drm/ast: Managed device release A few nits posted to a few patches. Patch 1-11 are all: Acked-by: Sam Ravnborg I did not look at 12 and did not follow all the changes in 13. Not that I found 13 faulty - just lost track and -ENOTIME Sam > > drivers/gpu/drm/ast/ast_cursor.c | 8 +- > drivers/gpu/drm/ast/ast_dp501.c | 23 ++- > drivers/gpu/drm/ast/ast_drv.c | 82 ++++---- > drivers/gpu/drm/ast/ast_drv.h | 43 +++-- > drivers/gpu/drm/ast/ast_main.c | 74 ++++---- > drivers/gpu/drm/ast/ast_mm.c | 2 +- > drivers/gpu/drm/ast/ast_mode.c | 310 ++++++++++++++----------------- > drivers/gpu/drm/ast/ast_post.c | 6 +- > 8 files changed, 263 insertions(+), 285 deletions(-) > > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel