From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Tue, 28 Jul 2020 21:36:17 +0200 Subject: [Buildroot] [PATCH 1/1] package/minetest: don't depend on luajit In-Reply-To: <20200728134847.5f7e7401@windsurf.home> References: <20200727205621.2556101-1-james.hilliard1@gmail.com> <20200728090907.4f093194@windsurf.home> <20200728134847.5f7e7401@windsurf.home> Message-ID: <20200728193617.GA19695@scaer> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net James, All, On 2020-07-28 13:48 +0200, Thomas Petazzoni spake thusly: > On Tue, 28 Jul 2020 04:17:26 -0600 > James Hilliard wrote: > > On Tue, Jul 28, 2020 at 1:09 AM Thomas Petazzoni > > wrote: > > > On Mon, 27 Jul 2020 14:56:21 -0600 > > > James Hilliard wrote: > > > > Since minetest has a fallback to a bundled lua when luajit is not > > > > available we don't need to depend on luajit or any lua version at all. > > > In general, I think we try to not use bundled libraries even when they > > > exist. If minetest needs a Lua interpreter, it should always use an > > > external Lua interpreter, I believe. > > From my understanding luajit is the only supported external lua > > interpreter for minetest. So I think it makes sense to not require > > a specific lua interpreter for flexibility. > I don't understand your reply, as I was not talking about using other > Lua interpreters. > What I'm saying is that if minetest has a mandatory dependency on > LuaJIT, then it should *always* use the external LuaJIT and never use > the bundled one. We prefer external libraries over bundled libraries in > general in the context of Buildroot. James, I think both Thomas and I understand your point of view. However, I do agree with Thomas on that topic, that we do use external libraries over bundled ones, even if that restricts the possibilities. Besides, minetest is a game; it is not a critical component for which we could consider bending the rules. Restricting minetest to use the external luajit will not be a major hindrance for the overwhelming majority of bBuildroot users, if at all (sorry Romain! ;-] ). So I've marked this patch as rejected in patchwork. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'