All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: zlang@redhat.com, fstests <fstests@vger.kernel.org>
Subject: [PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl
Date: Wed, 29 Jul 2020 09:14:43 -0700	[thread overview]
Message-ID: <20200729161443.GA7600@magnolia> (raw)

From: Darrick J. Wong <darrick.wong@oracle.com>

In xfs/030, we zero the entire AGFL which makes it corrupt because the
AG superblock block is /never/ free.  In commit dcd6c2e1 ("xfs_repair:
convert to libxfs_verify_agbno") we enhanced repair to complain about
zeroed entries in the AGFL, so add that to the golden output.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
v2: point out which commit we're testing
---
 tests/xfs/030.out |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/xfs/030.out b/tests/xfs/030.out
index 4a7c4b8b..53299438 100644
--- a/tests/xfs/030.out
+++ b/tests/xfs/030.out
@@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
 Phase 2 - using <TYPEOF> log
         - zero log...
         - scan filesystem freespace and inode maps...
+bad agbno AGBNO in agfl, agno 0
         - found root inode chunk
 Phase 3 - for each AG...
         - scan and clear agi unlinked lists...

             reply	other threads:[~2020-07-29 16:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 16:14 Darrick J. Wong [this message]
2020-07-29 17:08 ` [PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729161443.GA7600@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.