From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E224C433DF for ; Wed, 29 Jul 2020 19:25:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CEB42082E for ; Wed, 29 Jul 2020 19:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596050735; bh=3OhFxQx609IH8cb01dyUUQVVDn693vwGyKyQHVz30aw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=U75OZ0FlJ2FMo16xS238N/ALQvtL49HqnrneGwbUtLqxs7kb6Niitf/D+z4NOe5EL NubGoJocqVExfzL5aSi0MUsJfTKiaN8jeYOnPnBGHsagwzS69Kvq0uwXnjl7VBrfVW Upgb8K/MNSuNXFXCZBDcyTQiv6jTWwNxGYf0YSXU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbgG2TZe convert rfc822-to-8bit (ORCPT ); Wed, 29 Jul 2020 15:25:34 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:42221 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgG2TZe (ORCPT ); Wed, 29 Jul 2020 15:25:34 -0400 Received: by mail-ej1-f66.google.com with SMTP id g19so11703585ejc.9; Wed, 29 Jul 2020 12:25:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=CmAQyQEsBUyJQN6hEUiDapNhkNDUo7y7bkwW8nuWOU8=; b=bj6Qx+zN4IGanHJK5xzQUgipmJfi5H11FyVrQLWMpPZ+DPZhj2hFwcNT/GSsI2jG8S FbB+FgteJUeMdSUaG5VW2dkz9nC/WRRSp7BXnvq9cq5398Qi5A0EcR9GKxsal4//Jlai zs4xD4neLXzcluc2rELwnaB/cXuFEmIbePbGp2KgWGSVAbTL5ZBEf77Re3CGX7oXAjn8 IC7rlPc/TNS5fKsk38IJlvDKqoF6Tjuxej7DnLlDLkFhIau4HxD+znzBgQDasRl1oRyd 6iJxOv5zObHgmHLwL5eAeuT97OQT8e6Qd1EtM59SKnJOHEmDQ+40j0rmxkrgJ6VwaBFv X21w== X-Gm-Message-State: AOAM533RuGHWKbFmmWOQS526VaquQjpVX54B0qgjBmjQqlF5VNYjDF9B alCfNhR7mtTaLfkzz9cYx58= X-Google-Smtp-Source: ABdhPJwt7up6V3K0cn4gBLX1DJbgxEvaRU0wmBfm55EGTCBcmZQF20hrqkbhzb0vbUqglSjhMpBhhg== X-Received: by 2002:a17:906:ca11:: with SMTP id jt17mr13004151ejb.148.1596050731072; Wed, 29 Jul 2020 12:25:31 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id m12sm1579672edv.94.2020.07.29.12.25.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Jul 2020 12:25:30 -0700 (PDT) Date: Wed, 29 Jul 2020 21:25:27 +0200 From: Krzysztof Kozlowski To: Tomasz Figa Cc: Russell King , Kukjin Kim , Vincent Sanders , Simtec Linux Team , Kyungmin Park , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Chanwoo Choi , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , Guenter Roeck , Arnd Bergmann , Linus Walleij , linux-kernel , linux-arm-kernel , "moderated list:SAMSUNG SOC CLOCK DRIVERS" , linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, "open list:COMMON CLK FRAMEWORK" , linux-watchdog@vger.kernel.org, Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao Subject: Re: [PATCH 6/7] ARM: s3c64xx: Switch to generic watchdog driver reset Message-ID: <20200729192527.GA7351@kozik-lap> References: <20200729160942.28867-1-krzk@kernel.org> <20200729160942.28867-7-krzk@kernel.org> <20200729191544.GB5822@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200729191544.GB5822@kozik-lap> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed, Jul 29, 2020 at 09:15:44PM +0200, Krzysztof Kozlowski wrote: > On Wed, Jul 29, 2020 at 07:33:33PM +0200, Tomasz Figa wrote: > > Hi Krzysztof, > > > > 2020年7月29日(水) 18:11 Krzysztof Kozlowski : > > > > > > Similarly to commit f6361c6b3880 ("ARM: S3C24XX: remove separate restart > > > code"), the platform watchdog reset code can be removed in favor of > > > a generic watchdog driver which already handles reset. > > > > > > This allows removal of a bunch of machine code and fixes also W=1 > > > compile warnings: > > > > > > arch/arm/plat-samsung/watchdog-reset.c:29:6: warning: no previous prototype for 'samsung_wdt_reset' [-Wmissing-prototypes] > > > 29 | void samsung_wdt_reset(void) > > > | ^~~~~~~~~~~~~~~~~ > > > arch/arm/plat-samsung/watchdog-reset.c:69:13: warning: no previous prototype for 'samsung_wdt_reset_of_init' [-Wmissing-prototypes] > > > 69 | void __init samsung_wdt_reset_of_init(void) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > arch/arm/plat-samsung/watchdog-reset.c:89:13: warning: no previous prototype for 'samsung_wdt_reset_init' [-Wmissing-prototypes] > > > 89 | void __init samsung_wdt_reset_init(void __iomem *base) > > > > > > Signed-off-by: Krzysztof Kozlowski > > > --- > > > arch/arm/mach-s3c64xx/Kconfig | 3 +- > > > arch/arm/mach-s3c64xx/common.c | 15 +--- > > > arch/arm/mach-s3c64xx/common.h | 2 - > > > arch/arm/mach-s3c64xx/mach-anw6410.c | 1 - > > > arch/arm/mach-s3c64xx/mach-crag6410.c | 1 - > > > arch/arm/mach-s3c64xx/mach-hmt.c | 1 - > > > arch/arm/mach-s3c64xx/mach-mini6410.c | 1 - > > > arch/arm/mach-s3c64xx/mach-ncp.c | 1 - > > > arch/arm/mach-s3c64xx/mach-real6410.c | 1 - > > > arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 17 ----- > > > arch/arm/mach-s3c64xx/mach-smartq5.c | 1 - > > > arch/arm/mach-s3c64xx/mach-smartq7.c | 1 - > > > arch/arm/mach-s3c64xx/mach-smdk6400.c | 1 - > > > arch/arm/mach-s3c64xx/mach-smdk6410.c | 1 - > > > arch/arm/mach-s3c64xx/watchdog-reset.h | 16 ----- > > > arch/arm/plat-samsung/Kconfig | 6 -- > > > arch/arm/plat-samsung/Makefile | 1 - > > > arch/arm/plat-samsung/watchdog-reset.c | 93 ------------------------- > > > 18 files changed, 5 insertions(+), 158 deletions(-) > > > delete mode 100644 arch/arm/mach-s3c64xx/watchdog-reset.h > > > delete mode 100644 arch/arm/plat-samsung/watchdog-reset.c > > > > > > > Thanks for the patch! Please see my comments inline. > > > > > diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig > > > index e208c2b48853..f3fcb570edf5 100644 > > > --- a/arch/arm/mach-s3c64xx/Kconfig > > > +++ b/arch/arm/mach-s3c64xx/Kconfig > > > @@ -18,9 +18,10 @@ menuconfig ARCH_S3C64XX > > > select PM_GENERIC_DOMAINS if PM > > > select S3C_DEV_NAND if ATAGS > > > select S3C_GPIO_TRACK if ATAGS > > > + select S3C2410_WATCHDOG > > > select SAMSUNG_ATAGS if ATAGS > > > select SAMSUNG_WAKEMASK if PM > > > - select SAMSUNG_WDT_RESET > > > + select WATCHDOG > > > help > > > Samsung S3C64XX series based systems > > > > > > diff --git a/arch/arm/mach-s3c64xx/common.c b/arch/arm/mach-s3c64xx/common.c > > > index a655bf0c7802..42e96d196f61 100644 > > > --- a/arch/arm/mach-s3c64xx/common.c > > > +++ b/arch/arm/mach-s3c64xx/common.c > > > @@ -50,7 +50,6 @@ > > > > > > #include "common.h" > > > #include "irq-uart.h" > > > -#include "watchdog-reset.h" > > > > > > /* External clock frequency */ > > > static unsigned long xtal_f __ro_after_init = 12000000; > > > @@ -232,10 +231,11 @@ void __init s3c64xx_init_irq(u32 vic0_valid, u32 vic1_valid) > > > /* > > > * FIXME: there is no better place to put this at the moment > > > * (s3c64xx_clk_init needs ioremap and must happen before init_time > > > - * samsung_wdt_reset_init needs clocks) > > > + * samsung_wdt_reset_init needs clocks). However > > > + * samsung_wdt_reset_init() was removed in favor of watchdog driver > > > + * so this should be revised. > > > > This leaves the comment referring to an inexistent function. > > Yes, I left it as a reference/reason. Although might be quite confusing > now... > > > > > I wonder if this being here is actually a problem at all. It's legacy > > code and probably there isn't much value in reshuffling it further. > > Rather than that, we would probably want to make sure that everything > > migrated to DT and just drop the board files. > > Maybe let's remove the FIXME and leave the clock init. Since all these > times no one fixed the FIXME, so now with limited hardware access I do > not expect any movements here. > > > > > > */ > > > s3c64xx_clk_init(NULL, xtal_f, xusbxti_f, soc_is_s3c6400(), S3C_VA_SYS); > > > - samsung_wdt_reset_init(S3C_VA_WATCHDOG); > > > > > > printk(KERN_DEBUG "%s: initialising interrupts\n", __func__); > > > > > > @@ -429,12 +429,3 @@ static int __init s3c64xx_init_irq_eint(void) > > > return 0; > > > } > > > arch_initcall(s3c64xx_init_irq_eint); > > > - > > > -void s3c64xx_restart(enum reboot_mode mode, const char *cmd) > > > -{ > > > - if (mode != REBOOT_SOFT) > > > - samsung_wdt_reset(); > > > - > > > - /* if all else fails, or mode was for soft, jump to 0 */ > > > - soft_restart(0); > > > > Does this remove the soft reboot capability? I'm not sure how much of > > a problem that would be, though. > > 1. No one cared about it in f6361c6b3880 :) > 2. Exynos does not have it > 3. Does soft_restart really work? It would be worth to keep it if more > or less it was working. ... and one more reason: 4. Look how much code I removed: 5 insertions(+), 158 deletions(-) Isn't it nice? :) Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A87C4C433E0 for ; Wed, 29 Jul 2020 19:27:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 696112068F for ; Wed, 29 Jul 2020 19:27:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ln/wlyQA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 696112068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TDsXx61aPio0Xbvg8sxjE7RwrI4aIQpc4TNBQofI2Z8=; b=Ln/wlyQALVSTEpIs7Z3BSFkP1 /5UNfNQjCoWWV6YgySJ7JOAEvjPLRqJhR9xxCUYfz1FFnHrvUK2Dj8hTRZgWy2E36nD8DnRnStd37 Vj16xC5zYhj1YmEuZ40W8Id51aGUZuQY4k3WJF7arCGpxuokjDPJc/fgPc4OzFffNj2cec/EowVsH LEHuMcRybWnSvOL3tZHe5XV0ptyUfyjAumFeIQmlKIBnVaQbqQPUDdjVcfZLm1ipTlI0zs23leLZ7 nuToHeziXjbxETvP0DU47wk7E1VkMkq7UIJSmGWZMndFcbC7xjqTHDmL7OQCQYzTHqrbPlSW2GpJ9 W5fXT8GBA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0rhn-0006MO-D6; Wed, 29 Jul 2020 19:25:35 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0rhk-0006LI-Nf for linux-arm-kernel@lists.infradead.org; Wed, 29 Jul 2020 19:25:33 +0000 Received: by mail-ej1-f68.google.com with SMTP id bo3so2875828ejb.11 for ; Wed, 29 Jul 2020 12:25:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=CmAQyQEsBUyJQN6hEUiDapNhkNDUo7y7bkwW8nuWOU8=; b=kSQWeL5ywOpLaFEhvmbKhiRQ1qaaCkChmoJ6v2+sVp1AJ/6WkwcmDIiEeJ0x6kV9zN +riNOkqHnZpcmAm6hzBlaKOdUMW6YdN4UF8UPv+AMcbdrv6YNU7BsXzLjiUeERhh/iRB yS+ulEatUKahiWhra/9sNiq2GlLYrQEbnqlsgBwMD27XM8DSOa0Wj+0ANANhbTPOICHF MejTb4mGyvutwA3JoQZXGROPtAurrvfNhhdnOnrm91iE8tkSnKJCwoCkfsVETEQek2h7 344wXl++RDYjd+rd40BkHbIdlGhZGZ/rpWSlOXIXVynFamKkdl7aYUlE8Ydvoz8L2JEw b8Ig== X-Gm-Message-State: AOAM531SuBbLJYTM/NMPNX193Fq3lMwr6N/ZIO8H2U9gBpUb7hwFe7M+ 8EZhAa/DFHXSK7Q/bbJ+Vis= X-Google-Smtp-Source: ABdhPJwt7up6V3K0cn4gBLX1DJbgxEvaRU0wmBfm55EGTCBcmZQF20hrqkbhzb0vbUqglSjhMpBhhg== X-Received: by 2002:a17:906:ca11:: with SMTP id jt17mr13004151ejb.148.1596050731072; Wed, 29 Jul 2020 12:25:31 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id m12sm1579672edv.94.2020.07.29.12.25.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Jul 2020 12:25:30 -0700 (PDT) Date: Wed, 29 Jul 2020 21:25:27 +0200 From: Krzysztof Kozlowski To: Tomasz Figa Subject: Re: [PATCH 6/7] ARM: s3c64xx: Switch to generic watchdog driver reset Message-ID: <20200729192527.GA7351@kozik-lap> References: <20200729160942.28867-1-krzk@kernel.org> <20200729160942.28867-7-krzk@kernel.org> <20200729191544.GB5822@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200729191544.GB5822@kozik-lap> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200729_152532_846398_1CD19C2B X-CRM114-Status: GOOD ( 40.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Linus Walleij , Sylwester Nawrocki , Will Deacon , linux-stm32@st-md-mailman.stormreply.com, Marek Szyprowski , "moderated list:SAMSUNG SOC CLOCK DRIVERS" , Sylwester Nawrocki , Cedric Roux , Russell King , "open list:COMMON CLK FRAMEWORK" , Lihua Yao , Chanwoo Choi , Kukjin Kim , Michael Turquette , Guenter Roeck , Sergio Prado , linux-watchdog@vger.kernel.org, Arnd Bergmann , Wim Van Sebroeck , Simtec Linux Team , linux-arm-kernel , Stephen Boyd , patches@opensource.cirrus.com, Vincent Sanders , linux-kernel , Kyungmin Park Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMjksIDIwMjAgYXQgMDk6MTU6NDRQTSArMDIwMCwgS3J6eXN6dG9mIEtvemxv d3NraSB3cm90ZToKPiBPbiBXZWQsIEp1bCAyOSwgMjAyMCBhdCAwNzozMzozM1BNICswMjAwLCBU b21hc3ogRmlnYSB3cm90ZToKPiA+IEhpIEtyenlzenRvZiwKPiA+IAo+ID4gMjAyMOW5tDfmnIgy OeaXpSjmsLQpIDE4OjExIEtyenlzenRvZiBLb3psb3dza2kgPGtyemtAa2VybmVsLm9yZz46Cj4g PiA+Cj4gPiA+IFNpbWlsYXJseSB0byBjb21taXQgZjYzNjFjNmIzODgwICgiQVJNOiBTM0MyNFhY OiByZW1vdmUgc2VwYXJhdGUgcmVzdGFydAo+ID4gPiBjb2RlIiksIHRoZSBwbGF0Zm9ybSB3YXRj aGRvZyByZXNldCBjb2RlIGNhbiBiZSByZW1vdmVkIGluIGZhdm9yIG9mCj4gPiA+IGEgZ2VuZXJp YyB3YXRjaGRvZyBkcml2ZXIgd2hpY2ggYWxyZWFkeSBoYW5kbGVzIHJlc2V0Lgo+ID4gPgo+ID4g PiBUaGlzIGFsbG93cyByZW1vdmFsIG9mIGEgYnVuY2ggb2YgbWFjaGluZSBjb2RlIGFuZCBmaXhl cyBhbHNvIFc9MQo+ID4gPiBjb21waWxlIHdhcm5pbmdzOgo+ID4gPgo+ID4gPiAgICAgYXJjaC9h cm0vcGxhdC1zYW1zdW5nL3dhdGNoZG9nLXJlc2V0LmM6Mjk6Njogd2FybmluZzogbm8gcHJldmlv dXMgcHJvdG90eXBlIGZvciAnc2Ftc3VuZ193ZHRfcmVzZXQnIFstV21pc3NpbmctcHJvdG90eXBl c10KPiA+ID4gICAgICAgIDI5IHwgdm9pZCBzYW1zdW5nX3dkdF9yZXNldCh2b2lkKQo+ID4gPiAg ICAgICAgICAgfCAgICAgIF5+fn5+fn5+fn5+fn5+fn5+Cj4gPiA+ICAgICBhcmNoL2FybS9wbGF0 LXNhbXN1bmcvd2F0Y2hkb2ctcmVzZXQuYzo2OToxMzogd2FybmluZzogbm8gcHJldmlvdXMgcHJv dG90eXBlIGZvciAnc2Ftc3VuZ193ZHRfcmVzZXRfb2ZfaW5pdCcgWy1XbWlzc2luZy1wcm90b3R5 cGVzXQo+ID4gPiAgICAgICAgNjkgfCB2b2lkIF9faW5pdCBzYW1zdW5nX3dkdF9yZXNldF9vZl9p bml0KHZvaWQpCj4gPiA+ICAgICAgICAgICB8ICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn4KPiA+ID4gICAgIGFyY2gvYXJtL3BsYXQtc2Ftc3VuZy93YXRjaGRvZy1yZXNldC5j Ojg5OjEzOiB3YXJuaW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICdzYW1zdW5nX3dkdF9y ZXNldF9pbml0JyBbLVdtaXNzaW5nLXByb3RvdHlwZXNdCj4gPiA+ICAgICAgICA4OSB8IHZvaWQg X19pbml0IHNhbXN1bmdfd2R0X3Jlc2V0X2luaXQodm9pZCBfX2lvbWVtICpiYXNlKQo+ID4gPgo+ ID4gPiBTaWduZWQtb2ZmLWJ5OiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+ Cj4gPiA+IC0tLQo+ID4gPiAgYXJjaC9hcm0vbWFjaC1zM2M2NHh4L0tjb25maWcgICAgICAgICAg IHwgIDMgKy0KPiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9jb21tb24uYyAgICAgICAgICB8 IDE1ICstLS0KPiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9jb21tb24uaCAgICAgICAgICB8 ICAyIC0KPiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9tYWNoLWFudzY0MTAuYyAgICB8ICAx IC0KPiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9tYWNoLWNyYWc2NDEwLmMgICB8ICAxIC0K PiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9tYWNoLWhtdC5jICAgICAgICB8ICAxIC0KPiA+ ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9tYWNoLW1pbmk2NDEwLmMgICB8ICAxIC0KPiA+ID4g IGFyY2gvYXJtL21hY2gtczNjNjR4eC9tYWNoLW5jcC5jICAgICAgICB8ICAxIC0KPiA+ID4gIGFy Y2gvYXJtL21hY2gtczNjNjR4eC9tYWNoLXJlYWw2NDEwLmMgICB8ICAxIC0KPiA+ID4gIGFyY2gv YXJtL21hY2gtczNjNjR4eC9tYWNoLXMzYzY0eHgtZHQuYyB8IDE3IC0tLS0tCj4gPiA+ICBhcmNo L2FybS9tYWNoLXMzYzY0eHgvbWFjaC1zbWFydHE1LmMgICAgfCAgMSAtCj4gPiA+ICBhcmNoL2Fy bS9tYWNoLXMzYzY0eHgvbWFjaC1zbWFydHE3LmMgICAgfCAgMSAtCj4gPiA+ICBhcmNoL2FybS9t YWNoLXMzYzY0eHgvbWFjaC1zbWRrNjQwMC5jICAgfCAgMSAtCj4gPiA+ICBhcmNoL2FybS9tYWNo LXMzYzY0eHgvbWFjaC1zbWRrNjQxMC5jICAgfCAgMSAtCj4gPiA+ICBhcmNoL2FybS9tYWNoLXMz YzY0eHgvd2F0Y2hkb2ctcmVzZXQuaCAgfCAxNiAtLS0tLQo+ID4gPiAgYXJjaC9hcm0vcGxhdC1z YW1zdW5nL0tjb25maWcgICAgICAgICAgIHwgIDYgLS0KPiA+ID4gIGFyY2gvYXJtL3BsYXQtc2Ft c3VuZy9NYWtlZmlsZSAgICAgICAgICB8ICAxIC0KPiA+ID4gIGFyY2gvYXJtL3BsYXQtc2Ftc3Vu Zy93YXRjaGRvZy1yZXNldC5jICB8IDkzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ID4g IDE4IGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMTU4IGRlbGV0aW9ucygtKQo+ID4g PiAgZGVsZXRlIG1vZGUgMTAwNjQ0IGFyY2gvYXJtL21hY2gtczNjNjR4eC93YXRjaGRvZy1yZXNl dC5oCj4gPiA+ICBkZWxldGUgbW9kZSAxMDA2NDQgYXJjaC9hcm0vcGxhdC1zYW1zdW5nL3dhdGNo ZG9nLXJlc2V0LmMKPiA+ID4KPiA+IAo+ID4gVGhhbmtzIGZvciB0aGUgcGF0Y2ghIFBsZWFzZSBz ZWUgbXkgY29tbWVudHMgaW5saW5lLgo+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9t YWNoLXMzYzY0eHgvS2NvbmZpZyBiL2FyY2gvYXJtL21hY2gtczNjNjR4eC9LY29uZmlnCj4gPiA+ IGluZGV4IGUyMDhjMmI0ODg1My4uZjNmY2I1NzBlZGY1IDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNo L2FybS9tYWNoLXMzYzY0eHgvS2NvbmZpZwo+ID4gPiArKysgYi9hcmNoL2FybS9tYWNoLXMzYzY0 eHgvS2NvbmZpZwo+ID4gPiBAQCAtMTgsOSArMTgsMTAgQEAgbWVudWNvbmZpZyBBUkNIX1MzQzY0 WFgKPiA+ID4gICAgICAgICBzZWxlY3QgUE1fR0VORVJJQ19ET01BSU5TIGlmIFBNCj4gPiA+ICAg ICAgICAgc2VsZWN0IFMzQ19ERVZfTkFORCBpZiBBVEFHUwo+ID4gPiAgICAgICAgIHNlbGVjdCBT M0NfR1BJT19UUkFDSyBpZiBBVEFHUwo+ID4gPiArICAgICAgIHNlbGVjdCBTM0MyNDEwX1dBVENI RE9HCj4gPiA+ICAgICAgICAgc2VsZWN0IFNBTVNVTkdfQVRBR1MgaWYgQVRBR1MKPiA+ID4gICAg ICAgICBzZWxlY3QgU0FNU1VOR19XQUtFTUFTSyBpZiBQTQo+ID4gPiAtICAgICAgIHNlbGVjdCBT QU1TVU5HX1dEVF9SRVNFVAo+ID4gPiArICAgICAgIHNlbGVjdCBXQVRDSERPRwo+ID4gPiAgICAg ICAgIGhlbHAKPiA+ID4gICAgICAgICAgIFNhbXN1bmcgUzNDNjRYWCBzZXJpZXMgYmFzZWQgc3lz dGVtcwo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC1zM2M2NHh4L2NvbW1v bi5jIGIvYXJjaC9hcm0vbWFjaC1zM2M2NHh4L2NvbW1vbi5jCj4gPiA+IGluZGV4IGE2NTViZjBj NzgwMi4uNDJlOTZkMTk2ZjYxIDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNoL2FybS9tYWNoLXMzYzY0 eHgvY29tbW9uLmMKPiA+ID4gKysrIGIvYXJjaC9hcm0vbWFjaC1zM2M2NHh4L2NvbW1vbi5jCj4g PiA+IEBAIC01MCw3ICs1MCw2IEBACj4gPiA+Cj4gPiA+ICAjaW5jbHVkZSAiY29tbW9uLmgiCj4g PiA+ICAjaW5jbHVkZSAiaXJxLXVhcnQuaCIKPiA+ID4gLSNpbmNsdWRlICJ3YXRjaGRvZy1yZXNl dC5oIgo+ID4gPgo+ID4gPiAgLyogRXh0ZXJuYWwgY2xvY2sgZnJlcXVlbmN5ICovCj4gPiA+ICBz dGF0aWMgdW5zaWduZWQgbG9uZyB4dGFsX2YgX19yb19hZnRlcl9pbml0ID0gMTIwMDAwMDA7Cj4g PiA+IEBAIC0yMzIsMTAgKzIzMSwxMSBAQCB2b2lkIF9faW5pdCBzM2M2NHh4X2luaXRfaXJxKHUz MiB2aWMwX3ZhbGlkLCB1MzIgdmljMV92YWxpZCkKPiA+ID4gICAgICAgICAvKgo+ID4gPiAgICAg ICAgICAqIEZJWE1FOiB0aGVyZSBpcyBubyBiZXR0ZXIgcGxhY2UgdG8gcHV0IHRoaXMgYXQgdGhl IG1vbWVudAo+ID4gPiAgICAgICAgICAqIChzM2M2NHh4X2Nsa19pbml0IG5lZWRzIGlvcmVtYXAg YW5kIG11c3QgaGFwcGVuIGJlZm9yZSBpbml0X3RpbWUKPiA+ID4gLSAgICAgICAgKiBzYW1zdW5n X3dkdF9yZXNldF9pbml0IG5lZWRzIGNsb2NrcykKPiA+ID4gKyAgICAgICAgKiBzYW1zdW5nX3dk dF9yZXNldF9pbml0IG5lZWRzIGNsb2NrcykuICBIb3dldmVyCj4gPiA+ICsgICAgICAgICogc2Ft c3VuZ193ZHRfcmVzZXRfaW5pdCgpIHdhcyByZW1vdmVkIGluIGZhdm9yIG9mIHdhdGNoZG9nIGRy aXZlcgo+ID4gPiArICAgICAgICAqIHNvIHRoaXMgc2hvdWxkIGJlIHJldmlzZWQuCj4gPiAKPiA+ IFRoaXMgbGVhdmVzIHRoZSBjb21tZW50IHJlZmVycmluZyB0byBhbiBpbmV4aXN0ZW50IGZ1bmN0 aW9uLgo+IAo+IFllcywgSSBsZWZ0IGl0IGFzIGEgcmVmZXJlbmNlL3JlYXNvbi4gQWx0aG91Z2gg bWlnaHQgYmUgcXVpdGUgY29uZnVzaW5nCj4gbm93Li4uCj4gCj4gPiAKPiA+IEkgd29uZGVyIGlm IHRoaXMgYmVpbmcgaGVyZSBpcyBhY3R1YWxseSBhIHByb2JsZW0gYXQgYWxsLiBJdCdzIGxlZ2Fj eQo+ID4gY29kZSBhbmQgcHJvYmFibHkgdGhlcmUgaXNuJ3QgbXVjaCB2YWx1ZSBpbiByZXNodWZm bGluZyBpdCBmdXJ0aGVyLgo+ID4gUmF0aGVyIHRoYW4gdGhhdCwgd2Ugd291bGQgcHJvYmFibHkg d2FudCB0byBtYWtlIHN1cmUgdGhhdCBldmVyeXRoaW5nCj4gPiBtaWdyYXRlZCB0byBEVCBhbmQg anVzdCBkcm9wIHRoZSBib2FyZCBmaWxlcy4KPiAKPiBNYXliZSBsZXQncyByZW1vdmUgdGhlIEZJ WE1FIGFuZCBsZWF2ZSB0aGUgY2xvY2sgaW5pdC4gU2luY2UgYWxsIHRoZXNlCj4gdGltZXMgbm8g b25lIGZpeGVkIHRoZSBGSVhNRSwgc28gbm93IHdpdGggbGltaXRlZCBoYXJkd2FyZSBhY2Nlc3Mg SSBkbwo+IG5vdCBleHBlY3QgYW55IG1vdmVtZW50cyBoZXJlLgo+IAo+ID4gCj4gPiA+ICAgICAg ICAgICovCj4gPiA+ICAgICAgICAgczNjNjR4eF9jbGtfaW5pdChOVUxMLCB4dGFsX2YsIHh1c2J4 dGlfZiwgc29jX2lzX3MzYzY0MDAoKSwgUzNDX1ZBX1NZUyk7Cj4gPiA+IC0gICAgICAgc2Ftc3Vu Z193ZHRfcmVzZXRfaW5pdChTM0NfVkFfV0FUQ0hET0cpOwo+ID4gPgo+ID4gPiAgICAgICAgIHBy aW50ayhLRVJOX0RFQlVHICIlczogaW5pdGlhbGlzaW5nIGludGVycnVwdHNcbiIsIF9fZnVuY19f KTsKPiA+ID4KPiA+ID4gQEAgLTQyOSwxMiArNDI5LDMgQEAgc3RhdGljIGludCBfX2luaXQgczNj NjR4eF9pbml0X2lycV9laW50KHZvaWQpCj4gPiA+ICAgICAgICAgcmV0dXJuIDA7Cj4gPiA+ICB9 Cj4gPiA+ICBhcmNoX2luaXRjYWxsKHMzYzY0eHhfaW5pdF9pcnFfZWludCk7Cj4gPiA+IC0KPiA+ ID4gLXZvaWQgczNjNjR4eF9yZXN0YXJ0KGVudW0gcmVib290X21vZGUgbW9kZSwgY29uc3QgY2hh ciAqY21kKQo+ID4gPiAtewo+ID4gPiAtICAgICAgIGlmIChtb2RlICE9IFJFQk9PVF9TT0ZUKQo+ ID4gPiAtICAgICAgICAgICAgICAgc2Ftc3VuZ193ZHRfcmVzZXQoKTsKPiA+ID4gLQo+ID4gPiAt ICAgICAgIC8qIGlmIGFsbCBlbHNlIGZhaWxzLCBvciBtb2RlIHdhcyBmb3Igc29mdCwganVtcCB0 byAwICovCj4gPiA+IC0gICAgICAgc29mdF9yZXN0YXJ0KDApOwo+ID4gCj4gPiBEb2VzIHRoaXMg cmVtb3ZlIHRoZSBzb2Z0IHJlYm9vdCBjYXBhYmlsaXR5PyBJJ20gbm90IHN1cmUgaG93IG11Y2gg b2YKPiA+IGEgcHJvYmxlbSB0aGF0IHdvdWxkIGJlLCB0aG91Z2guCj4gCj4gMS4gTm8gb25lIGNh cmVkIGFib3V0IGl0IGluIGY2MzYxYzZiMzg4MCA6KQo+IDIuIEV4eW5vcyBkb2VzIG5vdCBoYXZl IGl0Cj4gMy4gRG9lcyBzb2Z0X3Jlc3RhcnQgcmVhbGx5IHdvcms/IEl0IHdvdWxkIGJlIHdvcnRo IHRvIGtlZXAgaXQgaWYgbW9yZQo+ICAgIG9yIGxlc3MgaXQgd2FzIHdvcmtpbmcuCgouLi4gYW5k IG9uZSBtb3JlIHJlYXNvbjoKNC4gTG9vayBob3cgbXVjaCBjb2RlIEkgcmVtb3ZlZDoKICAgICAg IDUgaW5zZXJ0aW9ucygrKSwgMTU4IGRlbGV0aW9ucygtKQogICBJc24ndCBpdCBuaWNlPyA6KQoK QmVzdCByZWdhcmRzLApLcnp5c3p0b2YKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK