From: Eddie James <eajames@linux.ibm.com>
To: openbmc@lists.ozlabs.org
Cc: joel@jms.id.au, Brad Bishop <bradleyb@fuzziesquirrel.com>,
Eddie James <eajames@linux.ibm.com>
Subject: [PATCH linux dev-5.7 2/6] spi: fsi: Fix clock running too fast
Date: Wed, 29 Jul 2020 15:45:24 -0500 [thread overview]
Message-ID: <20200729204528.15157-3-eajames@linux.ibm.com> (raw)
In-Reply-To: <20200729204528.15157-1-eajames@linux.ibm.com>
From: Brad Bishop <bradleyb@fuzziesquirrel.com>
Use a clock divider tuned to a 200MHz FSI clock. Use of the previous
divider at 200MHz results in corrupt data from endpoint devices. Ideally
the clock divider would be calculated from the FSI clock, but that
would require some significant work on the FSI driver.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
---
drivers/spi/spi-fsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c
index 8f64af0140e0..559d0ff981f3 100644
--- a/drivers/spi/spi-fsi.c
+++ b/drivers/spi/spi-fsi.c
@@ -350,7 +350,7 @@ static int fsi_spi_transfer_init(struct fsi_spi *ctx)
u64 status = 0ULL;
u64 wanted_clock_cfg = SPI_FSI_CLOCK_CFG_ECC_DISABLE |
SPI_FSI_CLOCK_CFG_SCK_NO_DEL |
- FIELD_PREP(SPI_FSI_CLOCK_CFG_SCK_DIV, 4);
+ FIELD_PREP(SPI_FSI_CLOCK_CFG_SCK_DIV, 19);
end = jiffies + msecs_to_jiffies(SPI_FSI_INIT_TIMEOUT_MS);
do {
--
2.24.0
next prev parent reply other threads:[~2020-07-29 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 20:45 [PATCH linux dev-5.7 0/6] spi: Fix FSI-attached controller and AT25 drivers Eddie James
2020-07-29 20:45 ` [PATCH linux dev-5.7 1/6] spi: fsi: Handle 9 to 15 byte transfers lengths Eddie James
2020-07-29 23:41 ` Joel Stanley
2020-07-29 20:45 ` Eddie James [this message]
2020-07-29 23:25 ` [PATCH linux dev-5.7 2/6] spi: fsi: Fix clock running too fast Joel Stanley
2020-07-30 21:31 ` Eddie James
2020-07-29 20:45 ` [PATCH linux dev-5.7 3/6] spi: fsi: Fix use of the bneq+ sequencer instruction Eddie James
2020-07-29 23:27 ` Joel Stanley
2020-07-29 20:45 ` [PATCH linux dev-5.7 4/6] dt-bindings: fsi: fsi2spi: Document new restricted property Eddie James
2020-07-29 23:27 ` Joel Stanley
2020-07-29 20:45 ` [PATCH linux dev-5.7 5/6] spi: fsi: Implement restricted size for certain controllers Eddie James
2020-07-29 23:33 ` Joel Stanley
2020-07-29 20:45 ` [PATCH linux dev-5.7 6/6] eeprom: at25: Split reads into chunks and cap write size Eddie James
2020-07-29 23:28 ` Milton Miller II
2020-07-29 23:35 ` [PATCH linux dev-5.7 0/6] spi: Fix FSI-attached controller and AT25 drivers Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729204528.15157-3-eajames@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=bradleyb@fuzziesquirrel.com \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.