From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA73C433E1 for ; Thu, 30 Jul 2020 11:45:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 773C22064B for ; Thu, 30 Jul 2020 11:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596109526; bh=pH5APXiQmq/QGaslXmX2nDejuDct70Gh+6dclYCHOUA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=itqo6IzKrm6FmTwvDE18bhxJvoIYFXq5o5WM+Y7hbfKYqWkGOqaiZ1BJlAhmL9aGR MAR/Zx9w2NI58uhxDLxVH/jLjUbOluZ0UygeiWwj59pw4ONl+ZF3WFXCqUiByiDRUJ Xm3q6qrR7qdhcZ8l86lNBsCN/bIDzNI5SBekZUsc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727877AbgG3Lp0 convert rfc822-to-8bit (ORCPT ); Thu, 30 Jul 2020 07:45:26 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:33995 "EHLO mail-ej1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgG3LpZ (ORCPT ); Thu, 30 Jul 2020 07:45:25 -0400 Received: by mail-ej1-f68.google.com with SMTP id o23so183424ejr.1; Thu, 30 Jul 2020 04:45:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=dmIx6K39AwVClBedb7QkpR0HhfnQSCjcLCYyud3CBv4=; b=iE/NNV7zTGzRl8FAj6VR0lC86+5TkKuHPVT0PK+6S57ujDEq6i/gzAo/TLibq5GDgk mhqv8ki48eNvvEs5eF3y0fjigV7ScfVelG+XrE+s+Em7rLUIBSD/j6orl05YEW94xo2M f+WQ/i2bnRYsgvSNrQlDcDevzJVV+sWEtGeiUjA5nM2ULVrKaTim1eN7RT0y47rQ7Lw6 9Y3LLs9UmCyrWG14JxKa6iB89XrdMg9lEy25RgKk8MDh7FpLa8ufAoSobr6XxzNjC+w0 YIGB+0aPH1VTcK74HpFGHliOjGE+WytfbLGsa7dY1/ws4kmSiAjMrjkYRkfaR3slc7+Q Ybug== X-Gm-Message-State: AOAM5327pELRF0a+qzf1Is4t1jCgumvoERAjnk9LI3GLEyUXHLQ9flwY qXAC9a7FXV2POYfSBDX0jh0= X-Google-Smtp-Source: ABdhPJw5Nk510vllHk10fhn8xgW3ei+PX5ztO4fQj7uiS9l3iTHjtMnKWBz5JnnoLkSsrfF2wmI07w== X-Received: by 2002:a17:906:6dd1:: with SMTP id j17mr2282792ejt.272.1596109521064; Thu, 30 Jul 2020 04:45:21 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id e26sm3161870edq.23.2020.07.30.04.45.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Jul 2020 04:45:19 -0700 (PDT) Date: Thu, 30 Jul 2020 13:45:15 +0200 From: Krzysztof Kozlowski To: Tomasz Figa Cc: Russell King , Kukjin Kim , Vincent Sanders , Simtec Linux Team , Kyungmin Park , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Chanwoo Choi , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , Guenter Roeck , Arnd Bergmann , Linus Walleij , linux-kernel , linux-arm-kernel , "moderated list:SAMSUNG SOC CLOCK DRIVERS" , linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, "open list:COMMON CLK FRAMEWORK" , linux-watchdog@vger.kernel.org, Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao Subject: Re: [PATCH 6/7] ARM: s3c64xx: Switch to generic watchdog driver reset Message-ID: <20200730114515.GA20438@kozik-lap> References: <20200729160942.28867-1-krzk@kernel.org> <20200729160942.28867-7-krzk@kernel.org> <20200729191544.GB5822@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, Jul 30, 2020 at 01:34:38PM +0200, Tomasz Figa wrote: > 2020年7月29日(水) 21:15 Krzysztof Kozlowski : > > > > On Wed, Jul 29, 2020 at 07:33:33PM +0200, Tomasz Figa wrote: > > > Hi Krzysztof, > > > > > > 2020年7月29日(水) 18:11 Krzysztof Kozlowski : > > > > > > > > Similarly to commit f6361c6b3880 ("ARM: S3C24XX: remove separate restart > > > > code"), the platform watchdog reset code can be removed in favor of > > > > a generic watchdog driver which already handles reset. > > > > > > > > This allows removal of a bunch of machine code and fixes also W=1 > > > > compile warnings: > > > > > > > > arch/arm/plat-samsung/watchdog-reset.c:29:6: warning: no previous prototype for 'samsung_wdt_reset' [-Wmissing-prototypes] > > > > 29 | void samsung_wdt_reset(void) > > > > | ^~~~~~~~~~~~~~~~~ > > > > arch/arm/plat-samsung/watchdog-reset.c:69:13: warning: no previous prototype for 'samsung_wdt_reset_of_init' [-Wmissing-prototypes] > > > > 69 | void __init samsung_wdt_reset_of_init(void) > > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > > arch/arm/plat-samsung/watchdog-reset.c:89:13: warning: no previous prototype for 'samsung_wdt_reset_init' [-Wmissing-prototypes] > > > > 89 | void __init samsung_wdt_reset_init(void __iomem *base) > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > arch/arm/mach-s3c64xx/Kconfig | 3 +- > > > > arch/arm/mach-s3c64xx/common.c | 15 +--- > > > > arch/arm/mach-s3c64xx/common.h | 2 - > > > > arch/arm/mach-s3c64xx/mach-anw6410.c | 1 - > > > > arch/arm/mach-s3c64xx/mach-crag6410.c | 1 - > > > > arch/arm/mach-s3c64xx/mach-hmt.c | 1 - > > > > arch/arm/mach-s3c64xx/mach-mini6410.c | 1 - > > > > arch/arm/mach-s3c64xx/mach-ncp.c | 1 - > > > > arch/arm/mach-s3c64xx/mach-real6410.c | 1 - > > > > arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 17 ----- > > > > arch/arm/mach-s3c64xx/mach-smartq5.c | 1 - > > > > arch/arm/mach-s3c64xx/mach-smartq7.c | 1 - > > > > arch/arm/mach-s3c64xx/mach-smdk6400.c | 1 - > > > > arch/arm/mach-s3c64xx/mach-smdk6410.c | 1 - > > > > arch/arm/mach-s3c64xx/watchdog-reset.h | 16 ----- > > > > arch/arm/plat-samsung/Kconfig | 6 -- > > > > arch/arm/plat-samsung/Makefile | 1 - > > > > arch/arm/plat-samsung/watchdog-reset.c | 93 ------------------------- > > > > 18 files changed, 5 insertions(+), 158 deletions(-) > > > > delete mode 100644 arch/arm/mach-s3c64xx/watchdog-reset.h > > > > delete mode 100644 arch/arm/plat-samsung/watchdog-reset.c > > > > > > > > > > Thanks for the patch! Please see my comments inline. > > > > > > > diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig > > > > index e208c2b48853..f3fcb570edf5 100644 > > > > --- a/arch/arm/mach-s3c64xx/Kconfig > > > > +++ b/arch/arm/mach-s3c64xx/Kconfig > > > > @@ -18,9 +18,10 @@ menuconfig ARCH_S3C64XX > > > > select PM_GENERIC_DOMAINS if PM > > > > select S3C_DEV_NAND if ATAGS > > > > select S3C_GPIO_TRACK if ATAGS > > > > + select S3C2410_WATCHDOG > > > > select SAMSUNG_ATAGS if ATAGS > > > > select SAMSUNG_WAKEMASK if PM > > > > - select SAMSUNG_WDT_RESET > > > > + select WATCHDOG > > > > help > > > > Samsung S3C64XX series based systems > > > > > > > > diff --git a/arch/arm/mach-s3c64xx/common.c b/arch/arm/mach-s3c64xx/common.c > > > > index a655bf0c7802..42e96d196f61 100644 > > > > --- a/arch/arm/mach-s3c64xx/common.c > > > > +++ b/arch/arm/mach-s3c64xx/common.c > > > > @@ -50,7 +50,6 @@ > > > > > > > > #include "common.h" > > > > #include "irq-uart.h" > > > > -#include "watchdog-reset.h" > > > > > > > > /* External clock frequency */ > > > > static unsigned long xtal_f __ro_after_init = 12000000; > > > > @@ -232,10 +231,11 @@ void __init s3c64xx_init_irq(u32 vic0_valid, u32 vic1_valid) > > > > /* > > > > * FIXME: there is no better place to put this at the moment > > > > * (s3c64xx_clk_init needs ioremap and must happen before init_time > > > > - * samsung_wdt_reset_init needs clocks) > > > > + * samsung_wdt_reset_init needs clocks). However > > > > + * samsung_wdt_reset_init() was removed in favor of watchdog driver > > > > + * so this should be revised. > > > > > > This leaves the comment referring to an inexistent function. > > > > Yes, I left it as a reference/reason. Although might be quite confusing > > now... > > > > > > > > I wonder if this being here is actually a problem at all. It's legacy > > > code and probably there isn't much value in reshuffling it further. > > > Rather than that, we would probably want to make sure that everything > > > migrated to DT and just drop the board files. > > > > Maybe let's remove the FIXME and leave the clock init. Since all these > > times no one fixed the FIXME, so now with limited hardware access I do > > not expect any movements here. > > > > I think that would be fairly uncontroversial at this point. > > > > > > > > */ > > > > s3c64xx_clk_init(NULL, xtal_f, xusbxti_f, soc_is_s3c6400(), S3C_VA_SYS); > > > > - samsung_wdt_reset_init(S3C_VA_WATCHDOG); > > > > > > > > printk(KERN_DEBUG "%s: initialising interrupts\n", __func__); > > > > > > > > @@ -429,12 +429,3 @@ static int __init s3c64xx_init_irq_eint(void) > > > > return 0; > > > > } > > > > arch_initcall(s3c64xx_init_irq_eint); > > > > - > > > > -void s3c64xx_restart(enum reboot_mode mode, const char *cmd) > > > > -{ > > > > - if (mode != REBOOT_SOFT) > > > > - samsung_wdt_reset(); > > > > - > > > > - /* if all else fails, or mode was for soft, jump to 0 */ > > > > - soft_restart(0); > > > > > > Does this remove the soft reboot capability? I'm not sure how much of > > > a problem that would be, though. > > > > 1. No one cared about it in f6361c6b3880 :) > > That was a different SoC family, though. > > > 2. Exynos does not have it > > 3. Does soft_restart really work? It would be worth to keep it if more > > or less it was working. > > Anyway, I guess there is no way to know other than just removing it. > It can be always brought back if it turns out that someone needs it. > Please just mention that in the commit message. > > With that addressed: > > Reviewed-by: Tomasz Figa Sure, I'll do it. Thanks for review. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E88C433E0 for ; Thu, 30 Jul 2020 11:46:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B58A2082E for ; Thu, 30 Jul 2020 11:46:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yZEGLSde" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B58A2082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/u/xdg9omXQX2c+RLiVG5WT1FhUavWoVOuRoAYX1hoE=; b=yZEGLSdetftZ1PXGGra+B1lx2 6QR03itQEbk0OoclMo0qbSuok/GfaTvdteWfTWvr5v2BIr8VlM+EeO9OWSTzfiHDmcctwdTAkaJtO s//1voGAT7nyrCt/PeQMWAQcTYxVsB6HSEpHWulyDztUHotE/wwftW+QcDpFIZzxJBFeIPdAAkfJt e/qkl9TUMbuTXO501BNrjk3OnVAXQyuoWgy30M49sKOll8mRwUwbbYeDkmnor/ymlbcY8iWLHQfIk cpziRYZ1wzJL+neDk3DBYyW3dn18b30wurpVXbZ4k6uIQH81dKDRcWyegUtzG6R8wCjC8ptIG7VH0 9lOg9JTbQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1701-0006s7-EA; Thu, 30 Jul 2020 11:45:25 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k16zy-0006rM-M9 for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 11:45:23 +0000 Received: by mail-ej1-f65.google.com with SMTP id w9so27617529ejc.8 for ; Thu, 30 Jul 2020 04:45:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=dmIx6K39AwVClBedb7QkpR0HhfnQSCjcLCYyud3CBv4=; b=hU6zdx3yAtG/kdS0WE8Lci0zfZWqQkW4uEMTdgErFwJXpOUXrNCJRRRTUfY4Ks0Kcn zamOzZILWy5+5Y6fcliEkcmIeC+gNWXitCFI3sQ0hRtV96MLKqBs0/VKwndjEBbUaPHA jnfDqRQKtzl93liwXZKdwJu3qT7KoxzbaVsY+aKCeAC+y9sLY9st9Z6aH91eJREEsfQp yylpd09pd1FcDrIllEp/Ro3sLFGTQlU3ywfTqpBnn0DBrY6jgTN9XmD/tu+gg59f4NhG D1Jm/7oeUzpcDeQkZMhO3go13dGvJt6UmkyDq+7MdEBQKJh35Vro6IcgiKHh3lLvLf6Q qg3A== X-Gm-Message-State: AOAM530jf7TlTyUwlId+JIz++an1l272T9OQrBq1tp7R6LGtWp38ZNYx uyifW9LpZubpEvAuaCOBJOw= X-Google-Smtp-Source: ABdhPJw5Nk510vllHk10fhn8xgW3ei+PX5ztO4fQj7uiS9l3iTHjtMnKWBz5JnnoLkSsrfF2wmI07w== X-Received: by 2002:a17:906:6dd1:: with SMTP id j17mr2282792ejt.272.1596109521064; Thu, 30 Jul 2020 04:45:21 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id e26sm3161870edq.23.2020.07.30.04.45.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Jul 2020 04:45:19 -0700 (PDT) Date: Thu, 30 Jul 2020 13:45:15 +0200 From: Krzysztof Kozlowski To: Tomasz Figa Subject: Re: [PATCH 6/7] ARM: s3c64xx: Switch to generic watchdog driver reset Message-ID: <20200730114515.GA20438@kozik-lap> References: <20200729160942.28867-1-krzk@kernel.org> <20200729160942.28867-7-krzk@kernel.org> <20200729191544.GB5822@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_074522_745685_35E2D43C X-CRM114-Status: GOOD ( 47.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Linus Walleij , Sylwester Nawrocki , Will Deacon , linux-stm32@st-md-mailman.stormreply.com, Marek Szyprowski , "moderated list:SAMSUNG SOC CLOCK DRIVERS" , Sylwester Nawrocki , Cedric Roux , Russell King , "open list:COMMON CLK FRAMEWORK" , Lihua Yao , Chanwoo Choi , Kukjin Kim , Michael Turquette , Guenter Roeck , Sergio Prado , linux-watchdog@vger.kernel.org, Arnd Bergmann , Wim Van Sebroeck , Simtec Linux Team , linux-arm-kernel , Stephen Boyd , patches@opensource.cirrus.com, Vincent Sanders , linux-kernel , Kyungmin Park Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdWwgMzAsIDIwMjAgYXQgMDE6MzQ6MzhQTSArMDIwMCwgVG9tYXN6IEZpZ2Egd3Jv dGU6Cj4gMjAyMOW5tDfmnIgyOeaXpSjmsLQpIDIxOjE1IEtyenlzenRvZiBLb3psb3dza2kgPGty emtAa2VybmVsLm9yZz46Cj4gPgo+ID4gT24gV2VkLCBKdWwgMjksIDIwMjAgYXQgMDc6MzM6MzNQ TSArMDIwMCwgVG9tYXN6IEZpZ2Egd3JvdGU6Cj4gPiA+IEhpIEtyenlzenRvZiwKPiA+ID4KPiA+ ID4gMjAyMOW5tDfmnIgyOeaXpSjmsLQpIDE4OjExIEtyenlzenRvZiBLb3psb3dza2kgPGtyemtA a2VybmVsLm9yZz46Cj4gPiA+ID4KPiA+ID4gPiBTaW1pbGFybHkgdG8gY29tbWl0IGY2MzYxYzZi Mzg4MCAoIkFSTTogUzNDMjRYWDogcmVtb3ZlIHNlcGFyYXRlIHJlc3RhcnQKPiA+ID4gPiBjb2Rl IiksIHRoZSBwbGF0Zm9ybSB3YXRjaGRvZyByZXNldCBjb2RlIGNhbiBiZSByZW1vdmVkIGluIGZh dm9yIG9mCj4gPiA+ID4gYSBnZW5lcmljIHdhdGNoZG9nIGRyaXZlciB3aGljaCBhbHJlYWR5IGhh bmRsZXMgcmVzZXQuCj4gPiA+ID4KPiA+ID4gPiBUaGlzIGFsbG93cyByZW1vdmFsIG9mIGEgYnVu Y2ggb2YgbWFjaGluZSBjb2RlIGFuZCBmaXhlcyBhbHNvIFc9MQo+ID4gPiA+IGNvbXBpbGUgd2Fy bmluZ3M6Cj4gPiA+ID4KPiA+ID4gPiAgICAgYXJjaC9hcm0vcGxhdC1zYW1zdW5nL3dhdGNoZG9n LXJlc2V0LmM6Mjk6Njogd2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBlIGZvciAnc2Ftc3Vu Z193ZHRfcmVzZXQnIFstV21pc3NpbmctcHJvdG90eXBlc10KPiA+ID4gPiAgICAgICAgMjkgfCB2 b2lkIHNhbXN1bmdfd2R0X3Jlc2V0KHZvaWQpCj4gPiA+ID4gICAgICAgICAgIHwgICAgICBefn5+ fn5+fn5+fn5+fn5+fgo+ID4gPiA+ICAgICBhcmNoL2FybS9wbGF0LXNhbXN1bmcvd2F0Y2hkb2ct cmVzZXQuYzo2OToxMzogd2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBlIGZvciAnc2Ftc3Vu Z193ZHRfcmVzZXRfb2ZfaW5pdCcgWy1XbWlzc2luZy1wcm90b3R5cGVzXQo+ID4gPiA+ICAgICAg ICA2OSB8IHZvaWQgX19pbml0IHNhbXN1bmdfd2R0X3Jlc2V0X29mX2luaXQodm9pZCkKPiA+ID4g PiAgICAgICAgICAgfCAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4gPiA+ ID4gICAgIGFyY2gvYXJtL3BsYXQtc2Ftc3VuZy93YXRjaGRvZy1yZXNldC5jOjg5OjEzOiB3YXJu aW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICdzYW1zdW5nX3dkdF9yZXNldF9pbml0JyBb LVdtaXNzaW5nLXByb3RvdHlwZXNdCj4gPiA+ID4gICAgICAgIDg5IHwgdm9pZCBfX2luaXQgc2Ft c3VuZ193ZHRfcmVzZXRfaW5pdCh2b2lkIF9faW9tZW0gKmJhc2UpCj4gPiA+ID4KPiA+ID4gPiBT aWduZWQtb2ZmLWJ5OiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+Cj4gPiA+ ID4gLS0tCj4gPiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9LY29uZmlnICAgICAgICAgICB8 ICAzICstCj4gPiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9jb21tb24uYyAgICAgICAgICB8 IDE1ICstLS0KPiA+ID4gPiAgYXJjaC9hcm0vbWFjaC1zM2M2NHh4L2NvbW1vbi5oICAgICAgICAg IHwgIDIgLQo+ID4gPiA+ICBhcmNoL2FybS9tYWNoLXMzYzY0eHgvbWFjaC1hbnc2NDEwLmMgICAg fCAgMSAtCj4gPiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9tYWNoLWNyYWc2NDEwLmMgICB8 ICAxIC0KPiA+ID4gPiAgYXJjaC9hcm0vbWFjaC1zM2M2NHh4L21hY2gtaG10LmMgICAgICAgIHwg IDEgLQo+ID4gPiA+ICBhcmNoL2FybS9tYWNoLXMzYzY0eHgvbWFjaC1taW5pNjQxMC5jICAgfCAg MSAtCj4gPiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9tYWNoLW5jcC5jICAgICAgICB8ICAx IC0KPiA+ID4gPiAgYXJjaC9hcm0vbWFjaC1zM2M2NHh4L21hY2gtcmVhbDY0MTAuYyAgIHwgIDEg LQo+ID4gPiA+ICBhcmNoL2FybS9tYWNoLXMzYzY0eHgvbWFjaC1zM2M2NHh4LWR0LmMgfCAxNyAt LS0tLQo+ID4gPiA+ICBhcmNoL2FybS9tYWNoLXMzYzY0eHgvbWFjaC1zbWFydHE1LmMgICAgfCAg MSAtCj4gPiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC9tYWNoLXNtYXJ0cTcuYyAgICB8ICAx IC0KPiA+ID4gPiAgYXJjaC9hcm0vbWFjaC1zM2M2NHh4L21hY2gtc21kazY0MDAuYyAgIHwgIDEg LQo+ID4gPiA+ICBhcmNoL2FybS9tYWNoLXMzYzY0eHgvbWFjaC1zbWRrNjQxMC5jICAgfCAgMSAt Cj4gPiA+ID4gIGFyY2gvYXJtL21hY2gtczNjNjR4eC93YXRjaGRvZy1yZXNldC5oICB8IDE2IC0t LS0tCj4gPiA+ID4gIGFyY2gvYXJtL3BsYXQtc2Ftc3VuZy9LY29uZmlnICAgICAgICAgICB8ICA2 IC0tCj4gPiA+ID4gIGFyY2gvYXJtL3BsYXQtc2Ftc3VuZy9NYWtlZmlsZSAgICAgICAgICB8ICAx IC0KPiA+ID4gPiAgYXJjaC9hcm0vcGxhdC1zYW1zdW5nL3dhdGNoZG9nLXJlc2V0LmMgIHwgOTMg LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiA+ICAxOCBmaWxlcyBjaGFuZ2VkLCA1IGlu c2VydGlvbnMoKyksIDE1OCBkZWxldGlvbnMoLSkKPiA+ID4gPiAgZGVsZXRlIG1vZGUgMTAwNjQ0 IGFyY2gvYXJtL21hY2gtczNjNjR4eC93YXRjaGRvZy1yZXNldC5oCj4gPiA+ID4gIGRlbGV0ZSBt b2RlIDEwMDY0NCBhcmNoL2FybS9wbGF0LXNhbXN1bmcvd2F0Y2hkb2ctcmVzZXQuYwo+ID4gPiA+ Cj4gPiA+Cj4gPiA+IFRoYW5rcyBmb3IgdGhlIHBhdGNoISBQbGVhc2Ugc2VlIG15IGNvbW1lbnRz IGlubGluZS4KPiA+ID4KPiA+ID4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC1zM2M2NHh4 L0tjb25maWcgYi9hcmNoL2FybS9tYWNoLXMzYzY0eHgvS2NvbmZpZwo+ID4gPiA+IGluZGV4IGUy MDhjMmI0ODg1My4uZjNmY2I1NzBlZGY1IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2FyY2gvYXJtL21h Y2gtczNjNjR4eC9LY29uZmlnCj4gPiA+ID4gKysrIGIvYXJjaC9hcm0vbWFjaC1zM2M2NHh4L0tj b25maWcKPiA+ID4gPiBAQCAtMTgsOSArMTgsMTAgQEAgbWVudWNvbmZpZyBBUkNIX1MzQzY0WFgK PiA+ID4gPiAgICAgICAgIHNlbGVjdCBQTV9HRU5FUklDX0RPTUFJTlMgaWYgUE0KPiA+ID4gPiAg ICAgICAgIHNlbGVjdCBTM0NfREVWX05BTkQgaWYgQVRBR1MKPiA+ID4gPiAgICAgICAgIHNlbGVj dCBTM0NfR1BJT19UUkFDSyBpZiBBVEFHUwo+ID4gPiA+ICsgICAgICAgc2VsZWN0IFMzQzI0MTBf V0FUQ0hET0cKPiA+ID4gPiAgICAgICAgIHNlbGVjdCBTQU1TVU5HX0FUQUdTIGlmIEFUQUdTCj4g PiA+ID4gICAgICAgICBzZWxlY3QgU0FNU1VOR19XQUtFTUFTSyBpZiBQTQo+ID4gPiA+IC0gICAg ICAgc2VsZWN0IFNBTVNVTkdfV0RUX1JFU0VUCj4gPiA+ID4gKyAgICAgICBzZWxlY3QgV0FUQ0hE T0cKPiA+ID4gPiAgICAgICAgIGhlbHAKPiA+ID4gPiAgICAgICAgICAgU2Ftc3VuZyBTM0M2NFhY IHNlcmllcyBiYXNlZCBzeXN0ZW1zCj4gPiA+ID4KPiA+ID4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9h cm0vbWFjaC1zM2M2NHh4L2NvbW1vbi5jIGIvYXJjaC9hcm0vbWFjaC1zM2M2NHh4L2NvbW1vbi5j Cj4gPiA+ID4gaW5kZXggYTY1NWJmMGM3ODAyLi40MmU5NmQxOTZmNjEgMTAwNjQ0Cj4gPiA+ID4g LS0tIGEvYXJjaC9hcm0vbWFjaC1zM2M2NHh4L2NvbW1vbi5jCj4gPiA+ID4gKysrIGIvYXJjaC9h cm0vbWFjaC1zM2M2NHh4L2NvbW1vbi5jCj4gPiA+ID4gQEAgLTUwLDcgKzUwLDYgQEAKPiA+ID4g Pgo+ID4gPiA+ICAjaW5jbHVkZSAiY29tbW9uLmgiCj4gPiA+ID4gICNpbmNsdWRlICJpcnEtdWFy dC5oIgo+ID4gPiA+IC0jaW5jbHVkZSAid2F0Y2hkb2ctcmVzZXQuaCIKPiA+ID4gPgo+ID4gPiA+ ICAvKiBFeHRlcm5hbCBjbG9jayBmcmVxdWVuY3kgKi8KPiA+ID4gPiAgc3RhdGljIHVuc2lnbmVk IGxvbmcgeHRhbF9mIF9fcm9fYWZ0ZXJfaW5pdCA9IDEyMDAwMDAwOwo+ID4gPiA+IEBAIC0yMzIs MTAgKzIzMSwxMSBAQCB2b2lkIF9faW5pdCBzM2M2NHh4X2luaXRfaXJxKHUzMiB2aWMwX3ZhbGlk LCB1MzIgdmljMV92YWxpZCkKPiA+ID4gPiAgICAgICAgIC8qCj4gPiA+ID4gICAgICAgICAgKiBG SVhNRTogdGhlcmUgaXMgbm8gYmV0dGVyIHBsYWNlIHRvIHB1dCB0aGlzIGF0IHRoZSBtb21lbnQK PiA+ID4gPiAgICAgICAgICAqIChzM2M2NHh4X2Nsa19pbml0IG5lZWRzIGlvcmVtYXAgYW5kIG11 c3QgaGFwcGVuIGJlZm9yZSBpbml0X3RpbWUKPiA+ID4gPiAtICAgICAgICAqIHNhbXN1bmdfd2R0 X3Jlc2V0X2luaXQgbmVlZHMgY2xvY2tzKQo+ID4gPiA+ICsgICAgICAgICogc2Ftc3VuZ193ZHRf cmVzZXRfaW5pdCBuZWVkcyBjbG9ja3MpLiAgSG93ZXZlcgo+ID4gPiA+ICsgICAgICAgICogc2Ft c3VuZ193ZHRfcmVzZXRfaW5pdCgpIHdhcyByZW1vdmVkIGluIGZhdm9yIG9mIHdhdGNoZG9nIGRy aXZlcgo+ID4gPiA+ICsgICAgICAgICogc28gdGhpcyBzaG91bGQgYmUgcmV2aXNlZC4KPiA+ID4K PiA+ID4gVGhpcyBsZWF2ZXMgdGhlIGNvbW1lbnQgcmVmZXJyaW5nIHRvIGFuIGluZXhpc3RlbnQg ZnVuY3Rpb24uCj4gPgo+ID4gWWVzLCBJIGxlZnQgaXQgYXMgYSByZWZlcmVuY2UvcmVhc29uLiBB bHRob3VnaCBtaWdodCBiZSBxdWl0ZSBjb25mdXNpbmcKPiA+IG5vdy4uLgo+ID4KPiA+ID4KPiA+ ID4gSSB3b25kZXIgaWYgdGhpcyBiZWluZyBoZXJlIGlzIGFjdHVhbGx5IGEgcHJvYmxlbSBhdCBh bGwuIEl0J3MgbGVnYWN5Cj4gPiA+IGNvZGUgYW5kIHByb2JhYmx5IHRoZXJlIGlzbid0IG11Y2gg dmFsdWUgaW4gcmVzaHVmZmxpbmcgaXQgZnVydGhlci4KPiA+ID4gUmF0aGVyIHRoYW4gdGhhdCwg d2Ugd291bGQgcHJvYmFibHkgd2FudCB0byBtYWtlIHN1cmUgdGhhdCBldmVyeXRoaW5nCj4gPiA+ IG1pZ3JhdGVkIHRvIERUIGFuZCBqdXN0IGRyb3AgdGhlIGJvYXJkIGZpbGVzLgo+ID4KPiA+IE1h eWJlIGxldCdzIHJlbW92ZSB0aGUgRklYTUUgYW5kIGxlYXZlIHRoZSBjbG9jayBpbml0LiBTaW5j ZSBhbGwgdGhlc2UKPiA+IHRpbWVzIG5vIG9uZSBmaXhlZCB0aGUgRklYTUUsIHNvIG5vdyB3aXRo IGxpbWl0ZWQgaGFyZHdhcmUgYWNjZXNzIEkgZG8KPiA+IG5vdCBleHBlY3QgYW55IG1vdmVtZW50 cyBoZXJlLgo+ID4KPiAKPiBJIHRoaW5rIHRoYXQgd291bGQgYmUgZmFpcmx5IHVuY29udHJvdmVy c2lhbCBhdCB0aGlzIHBvaW50Lgo+IAo+ID4gPgo+ID4gPiA+ICAgICAgICAgICovCj4gPiA+ID4g ICAgICAgICBzM2M2NHh4X2Nsa19pbml0KE5VTEwsIHh0YWxfZiwgeHVzYnh0aV9mLCBzb2NfaXNf czNjNjQwMCgpLCBTM0NfVkFfU1lTKTsKPiA+ID4gPiAtICAgICAgIHNhbXN1bmdfd2R0X3Jlc2V0 X2luaXQoUzNDX1ZBX1dBVENIRE9HKTsKPiA+ID4gPgo+ID4gPiA+ICAgICAgICAgcHJpbnRrKEtF Uk5fREVCVUcgIiVzOiBpbml0aWFsaXNpbmcgaW50ZXJydXB0c1xuIiwgX19mdW5jX18pOwo+ID4g PiA+Cj4gPiA+ID4gQEAgLTQyOSwxMiArNDI5LDMgQEAgc3RhdGljIGludCBfX2luaXQgczNjNjR4 eF9pbml0X2lycV9laW50KHZvaWQpCj4gPiA+ID4gICAgICAgICByZXR1cm4gMDsKPiA+ID4gPiAg fQo+ID4gPiA+ICBhcmNoX2luaXRjYWxsKHMzYzY0eHhfaW5pdF9pcnFfZWludCk7Cj4gPiA+ID4g LQo+ID4gPiA+IC12b2lkIHMzYzY0eHhfcmVzdGFydChlbnVtIHJlYm9vdF9tb2RlIG1vZGUsIGNv bnN0IGNoYXIgKmNtZCkKPiA+ID4gPiAtewo+ID4gPiA+IC0gICAgICAgaWYgKG1vZGUgIT0gUkVC T09UX1NPRlQpCj4gPiA+ID4gLSAgICAgICAgICAgICAgIHNhbXN1bmdfd2R0X3Jlc2V0KCk7Cj4g PiA+ID4gLQo+ID4gPiA+IC0gICAgICAgLyogaWYgYWxsIGVsc2UgZmFpbHMsIG9yIG1vZGUgd2Fz IGZvciBzb2Z0LCBqdW1wIHRvIDAgKi8KPiA+ID4gPiAtICAgICAgIHNvZnRfcmVzdGFydCgwKTsK PiA+ID4KPiA+ID4gRG9lcyB0aGlzIHJlbW92ZSB0aGUgc29mdCByZWJvb3QgY2FwYWJpbGl0eT8g SSdtIG5vdCBzdXJlIGhvdyBtdWNoIG9mCj4gPiA+IGEgcHJvYmxlbSB0aGF0IHdvdWxkIGJlLCB0 aG91Z2guCj4gPgo+ID4gMS4gTm8gb25lIGNhcmVkIGFib3V0IGl0IGluIGY2MzYxYzZiMzg4MCA6 KQo+IAo+IFRoYXQgd2FzIGEgZGlmZmVyZW50IFNvQyBmYW1pbHksIHRob3VnaC4KPiAKPiA+IDIu IEV4eW5vcyBkb2VzIG5vdCBoYXZlIGl0Cj4gPiAzLiBEb2VzIHNvZnRfcmVzdGFydCByZWFsbHkg d29yaz8gSXQgd291bGQgYmUgd29ydGggdG8ga2VlcCBpdCBpZiBtb3JlCj4gPiAgICBvciBsZXNz IGl0IHdhcyB3b3JraW5nLgo+IAo+IEFueXdheSwgSSBndWVzcyB0aGVyZSBpcyBubyB3YXkgdG8g a25vdyBvdGhlciB0aGFuIGp1c3QgcmVtb3ZpbmcgaXQuCj4gSXQgY2FuIGJlIGFsd2F5cyBicm91 Z2h0IGJhY2sgaWYgaXQgdHVybnMgb3V0IHRoYXQgc29tZW9uZSBuZWVkcyBpdC4KPiBQbGVhc2Ug anVzdCBtZW50aW9uIHRoYXQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLgo+IAo+IFdpdGggdGhhdCBh ZGRyZXNzZWQ6Cj4gCj4gUmV2aWV3ZWQtYnk6IFRvbWFzeiBGaWdhIDx0b21hc3ouZmlnYUBnbWFp bC5jb20+CgpTdXJlLCBJJ2xsIGRvIGl0LiBUaGFua3MgZm9yIHJldmlldy4KCkJlc3QgcmVnYXJk cywKS3J6eXN6dG9mCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==