From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 3/5] include/u-boot, lib/zlib: add sources for zlib decompression
Date: Thu, 30 Jul 2020 08:17:59 -0400 [thread overview]
Message-ID: <20200730121759.GE6965@bill-the-cat> (raw)
In-Reply-To: <20200730141003.531e1b1b@joaomcosta-Latitude-E7470>
On Thu, Jul 30, 2020 at 02:10:03PM +0200, Joao Marcos Costa wrote:
> On Wed, 29 Jul 2020 12:54:23 -0400
> Tom Rini <trini@konsulko.com> wrote:
>
> > On Wed, Jul 29, 2020 at 06:00:57PM +0200, Joao Marcos Costa wrote:
> > > On Wed, 29 Jul 2020 11:27:45 -0400
> > > Tom Rini <trini@konsulko.com> wrote:
> > >
> > > > On Tue, Jul 21, 2020 at 11:22:57AM +0200, Joao Marcos Costa wrote:
> > > >
> > > > > Add zlib (v1.2.11) uncompr() function to U-Boot. SquashFS
> > > > > depends on this function to decompress data from a raw disk
> > > > > image. The actual support for zlib into SquashFS sources will
> > > > > be added in a follow-up commit.
> > > > >
> > > > > Signed-off-by: Joao Marcos Costa <joaomarcos.costa@bootlin.com>
> > > > > ---
> > > > > Changes in v3:
> > > > > - No changes since v2.
> > > > > Changes in v2:
> > > > > - Changed commit title and message, which were wrong
> > > > > and/or misleading in v1.
> > > > > include/u-boot/zlib.h | 32 ++++++++++++++
> > > > > lib/zlib/uncompr.c | 97
> > > > > +++++++++++++++++++++++++++++++++++++++++++ lib/zlib/zlib.c
> > > > > | 1 + 3 files changed, 130 insertions(+)
> > > > > create mode 100644 lib/zlib/uncompr.c
> > > >
> > > > Can you confirm that on a platform where we aren't enabling
> > > > squashfs the new zlib functionality ends up being discarded at
> > > > link time? Thanks!
> > > >
> > >
> > > I dumped lib/zlib/zlib.o with readelf and the new functionality is
> > > not discarded, even though the SquashFS support is not enabled, but
> > > this issue will be fixed in the next version (v4). Thank you!
> >
> > Well, don't dump lib/zlib/zlib.o, that won't say. Check u-boot.map :)
> >
>
> Thanks for the tip! Now I can confirm that the functionality is
> discarded when squashfs is not enabled. I just would like to know if I
> should send the tests in the same patch as the SquashFS commands, or
> should it be into a separate patch?
A separate patch, and are you able to run them on sandbox then? So it
should also enable squashfs on that target. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200730/3294f73f/attachment.sig>
next prev parent reply other threads:[~2020-07-30 12:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 9:22 [PATCH v3 0/5] Add support for the SquashFS filesystem Joao Marcos Costa
2020-07-21 9:22 ` [PATCH v3 1/5] fs/squashfs: new filesystem Joao Marcos Costa
2020-07-21 9:22 ` [PATCH v3 2/5] fs/squashfs: add filesystem commands Joao Marcos Costa
2020-07-21 9:22 ` [PATCH v3 3/5] include/u-boot, lib/zlib: add sources for zlib decompression Joao Marcos Costa
2020-07-29 15:27 ` Tom Rini
2020-07-29 16:00 ` Joao Marcos Costa
2020-07-29 16:54 ` Tom Rini
2020-07-30 12:10 ` Joao Marcos Costa
2020-07-30 12:17 ` Tom Rini [this message]
2020-07-30 13:27 ` Joao Marcos Costa
2020-07-21 9:22 ` [PATCH v3 4/5] fs/squashfs: add support " Joao Marcos Costa
2020-07-21 9:22 ` [PATCH v3 5/5] fs/fs.c: add symbolic link case to fs_ls_generic() Joao Marcos Costa
2020-07-29 12:54 ` [PATCH v3 0/5] Add support for the SquashFS filesystem Joao Marcos Costa
2020-07-29 15:21 ` Tom Rini
2020-07-29 16:02 ` Joao Marcos Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730121759.GE6965@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.