From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E032C433DF for ; Fri, 31 Jul 2020 05:33:13 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53FD9208E4 for ; Fri, 31 Jul 2020 05:33:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="kFeznJvl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53FD9208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3368586890; Fri, 31 Jul 2020 05:33:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xw9SlxLh3FNr; Fri, 31 Jul 2020 05:33:12 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id CC19C86881; Fri, 31 Jul 2020 05:33:12 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C4424C004F; Fri, 31 Jul 2020 05:33:12 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id C2D32C004D for ; Fri, 31 Jul 2020 05:33:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B2A9286879 for ; Fri, 31 Jul 2020 05:33:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Po_mXErisEdu for ; Fri, 31 Jul 2020 05:33:10 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 4CAAF860C2 for ; Fri, 31 Jul 2020 05:33:10 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76248208E4; Fri, 31 Jul 2020 05:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596173590; bh=Ey9Sbx63l35tpZRAlTqbhj39QlhEfAk6lnnRJ0GbmKc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kFeznJvlJLIKGU7a+xR/vPryMW1/HRaqLnnUF8/Qo9g6GwLSGNzszKYgVuTEhqbG6 0/R1y0qxc/7LAYy7huXZwxN+Y9gTkHmcNjKtknfvJBjTzGimo7HvXBtoTBhj+Fgb1a vbwF4a5Fi9jQ/BLnkYOhKx9ZOxfSppQidXBY8AvU= Date: Fri, 31 Jul 2020 07:33:06 +0200 From: Greg Kroah-Hartman To: Leon Romanovsky Message-ID: <20200731053306.GA466103@kroah.com> References: <20200730192026.110246-1-yepeilin.cs@gmail.com> <20200731045301.GI75549@unreal> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200731045301.GI75549@unreal> Cc: rds-devel@oss.oracle.com, Arnd Bergmann , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Santosh Shilimkar , linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , linux-kernel-mentees@lists.linuxfoundation.org, Peilin Ye , Dan Carpenter Subject: Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get() X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Fri, Jul 31, 2020 at 07:53:01AM +0300, Leon Romanovsky wrote: > On Thu, Jul 30, 2020 at 03:20:26PM -0400, Peilin Ye wrote: > > rds_notify_queue_get() is potentially copying uninitialized kernel stack > > memory to userspace since the compiler may leave a 4-byte hole at the end > > of `cmsg`. > > > > In 2016 we tried to fix this issue by doing `= { 0 };` on `cmsg`, which > > unfortunately does not always initialize that 4-byte hole. Fix it by using > > memset() instead. > > Of course, this is the difference between "{ 0 }" and "{}" initializations. Really? Neither will handle structures with holes in it, try it and see. thanks, greg k-h _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0E4C433DF for ; Fri, 31 Jul 2020 05:33:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BA4F208E4 for ; Fri, 31 Jul 2020 05:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596173596; bh=Ey9Sbx63l35tpZRAlTqbhj39QlhEfAk6lnnRJ0GbmKc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BbFGSIkIkEFqu9vZldSsAPWpR21J9qG9T99HpfYdBgvIPVJpd77omdKydokjpe/sY p3v0aFlnp+u0/9rD2x4L7YTNYcA2kTrlu6E9odDWwDp2/Ho99KEZ4G4gljsz4ZoUQO C3ws4pDyi4czJxRBE4yRJ31UU/zZutHlbxU6F4hc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728206AbgGaFdK (ORCPT ); Fri, 31 Jul 2020 01:33:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:38384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726972AbgGaFdK (ORCPT ); Fri, 31 Jul 2020 01:33:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76248208E4; Fri, 31 Jul 2020 05:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596173590; bh=Ey9Sbx63l35tpZRAlTqbhj39QlhEfAk6lnnRJ0GbmKc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kFeznJvlJLIKGU7a+xR/vPryMW1/HRaqLnnUF8/Qo9g6GwLSGNzszKYgVuTEhqbG6 0/R1y0qxc/7LAYy7huXZwxN+Y9gTkHmcNjKtknfvJBjTzGimo7HvXBtoTBhj+Fgb1a vbwF4a5Fi9jQ/BLnkYOhKx9ZOxfSppQidXBY8AvU= Date: Fri, 31 Jul 2020 07:33:06 +0200 From: Greg Kroah-Hartman To: Leon Romanovsky Cc: Peilin Ye , Santosh Shilimkar , "David S. Miller" , Jakub Kicinski , Dan Carpenter , Arnd Bergmann , linux-kernel-mentees@lists.linuxfoundation.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get() Message-ID: <20200731053306.GA466103@kroah.com> References: <20200730192026.110246-1-yepeilin.cs@gmail.com> <20200731045301.GI75549@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200731045301.GI75549@unreal> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Jul 31, 2020 at 07:53:01AM +0300, Leon Romanovsky wrote: > On Thu, Jul 30, 2020 at 03:20:26PM -0400, Peilin Ye wrote: > > rds_notify_queue_get() is potentially copying uninitialized kernel stack > > memory to userspace since the compiler may leave a 4-byte hole at the end > > of `cmsg`. > > > > In 2016 we tried to fix this issue by doing `= { 0 };` on `cmsg`, which > > unfortunately does not always initialize that 4-byte hole. Fix it by using > > memset() instead. > > Of course, this is the difference between "{ 0 }" and "{}" initializations. Really? Neither will handle structures with holes in it, try it and see. thanks, greg k-h