From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C79A6C433E1 for ; Fri, 31 Jul 2020 08:19:21 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 5028421883 for ; Fri, 31 Jul 2020 08:19:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="HKkCROCg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5028421883 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E2A7D4B3D6; Fri, 31 Jul 2020 04:19:20 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W2iak+k8h6CQ; Fri, 31 Jul 2020 04:19:19 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E67C54B464; Fri, 31 Jul 2020 04:19:19 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2BF584B3D4 for ; Fri, 31 Jul 2020 04:19:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nZQf0r3R0I7q for ; Fri, 31 Jul 2020 04:19:17 -0400 (EDT) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id F3FF74B3D6 for ; Fri, 31 Jul 2020 04:19:16 -0400 (EDT) Received: by mail-wm1-f67.google.com with SMTP id d190so7804303wmd.4 for ; Fri, 31 Jul 2020 01:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Q8OpMiJ+z4ZHwmpiATogVeChudpSi8OJUrMWzrMdEXE=; b=HKkCROCgWVfB5Zs1f7eEF5gOlL3UGVnCFzaPZgvCjZAgU2+U3MHRKopkOrVZeyR3vf vjudcrXjbLvmNlu7/eZbioHE81Ouw2sKkbTh/Kj9d0qisV8UZIamJehMXRAEKBhfP0yJ o2WEioVtsuTNBdPDxVhLkq/4iWGa4i8OhZO8zvrv2Al+dBmSxBDj+LRKycrsrooeLEFT gCw+E9gzfz5m/00SouG06jEsh+F5Wvse1G1rUJ1lHsFBEr41wEZV+RNxptyA5W2TgVvl 6abSqymXPVo+6IRpqlLE0W5xc/txiifofJQasl9SzvsE8/apY7eqtw0ejGSS6/IvlOqB tKeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q8OpMiJ+z4ZHwmpiATogVeChudpSi8OJUrMWzrMdEXE=; b=G6ic/GjRAk2aHLWYlasZzTt/iiDZPAYsx6NFPTaW+JLZArXkY/jNS9w+2ATs4CXiFd eAGhfw0bXklcDgBnBrmHKjZGZ+rbPlFbbXgAxy9lThukc07jgRBaV3M7oOoZC0u0edbV KQ8By3A3cNz5eHr3Lqb6SiTszNzXR4XjakCUnkppZtRVlCyyUGMMqPEldEQXKK5KHWHu odZBzIdQ5+m3WTpHcJ/rzF5MSojlFl0EKpyBAg01rnNIOIgzOKYAMMjpj17EnJrbQdhM I6geoAikswcWZumnmc8wHxE9sNm6vUJF1eNs1Y18uXgO++LPCQSxbjHegER7RR+feNmw SFyA== X-Gm-Message-State: AOAM530oAQCVbQrHxhjVDwluztVF3qqrYYiaWUpJHEJg6CNP7E4FFth+ vuie+YvuOUvMURoAw+UhYZFfpw== X-Google-Smtp-Source: ABdhPJw2xNbOV3xC63XD4TJSfkwYZDWWkbXBDvb97fYK764gELmnXWQ3+iN4lpi1f/3Ln4sCAR25GQ== X-Received: by 2002:a7b:cf0c:: with SMTP id l12mr2884769wmg.77.1596183555084; Fri, 31 Jul 2020 01:19:15 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id g16sm12171266wrs.88.2020.07.31.01.19.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 01:19:14 -0700 (PDT) Date: Fri, 31 Jul 2020 09:19:11 +0100 From: Quentin Perret To: Will Deacon Subject: Re: [PATCH 02/20] KVM: arm64: Add support for creating kernel-agnostic stage-1 page tables Message-ID: <20200731081911.GB3201636@google.com> References: <20200730153406.25136-1-will@kernel.org> <20200730153406.25136-3-will@kernel.org> <20200731081436.GA3201636@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200731081436.GA3201636@google.com> Cc: Marc Zyngier , Catalin Marinas , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Friday 31 Jul 2020 at 09:14:36 (+0100), Quentin Perret wrote: > Hey Will, > > On Thursday 30 Jul 2020 at 16:33:48 (+0100), Will Deacon wrote: > > +void *kvm_pgtable_hyp_alloc_cookie(u32 va_bits) > > +{ > > + struct kvm_pgtable *pgt = kzalloc(sizeof(*pgt), GFP_KERNEL); > > + > > + if (!pgt) > > + return NULL; > > + > > + pgt->ia_bits = va_bits; > > + pgt->start_level = kvm_start_level(va_bits); > > + > > + pgt->pgd = (kvm_pte_t *)get_zeroed_page(GFP_KERNEL); > > + if (!pgt->pgd) { > > + kfree(pgt); > > + pgt = NULL; > > + } > > + > > + return pgt; > > +} > > + > > +static int hyp_free_walker(u64 addr, u64 end, u32 level, kvm_pte_t *ptep, > > + enum kvm_pgtable_walk_flags flag, void * const arg) > > +{ > > + free_page((unsigned long)kvm_pte_follow(*ptep)); > > + return 0; > > +} > > + > > +void kvm_pgtable_hyp_free_cookie(void *cookie) > > +{ > > + size_t pgd_sz; > > + struct kvm_pgtable *pgt = cookie; > > + struct kvm_pgtable_walker walker = { > > + .cb = hyp_free_walker, > > + .flags = KVM_PGTABLE_WALK_TABLE_POST, > > + }; > > + > > + if (kvm_pgtable_walk(cookie, 0, BIT(pgt->ia_bits), &walker)) > > + kvm_err("Failed to free page-table pages\n"); > > + > > + pgd_sz = kvm_pgd_pages(pgt) * PAGE_SIZE; > > + free_pages_exact(pgt->pgd, pgd_sz); > > Given that the pgd is unconditionally a single page for the stage 1 case > (as per kvm_pgtable_hyp_alloc_cookie() above), should we simplify this > to a simple free_page()? Or did you want to factorize this with the > stage 2 free path? Hmm, or maybe it's the alloc() path that needs fixing actually ... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B997C433DF for ; Fri, 31 Jul 2020 08:21:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDBD42072A for ; Fri, 31 Jul 2020 08:21:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jFq2XRaf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="HKkCROCg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDBD42072A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Sjj9I9dgllzwTO/v8ZJDmupl2gjGYXPoRLoKdFDLSac=; b=jFq2XRaf4JZgdlxdJo1deZd5d r0HPTDw6W7mFVdyeULUEcq83+tue0om5Q6wDFPFQxndg5cLSJpGKt8D0heuMDfpfny4fjI+4WIefU 4tdGEWnO5JFdcwU/ppXf8CAmQGJZj62px2d7X14Up87HnzNH3emd2ASQaE3c2Qu19RTXYT08D5sIq uu4b5yh+5X/obzBLPDz0hoGoCF3aEL62Y0ijJNq49wnJTCWgzWhilozzlOg8vZ6pOP9/HptWYQyu0 INt7tF4uVHv6lLBB7N6fx1J8mIkdqvXHagtcIFSnX3alELcIMUXNXRlN4IVjtuyFg7g5mHG32zx6I CTqaKCzvg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1QG7-00021w-8Y; Fri, 31 Jul 2020 08:19:19 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1QG4-00020v-Ia for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 08:19:17 +0000 Received: by mail-wm1-x342.google.com with SMTP id k20so8407351wmi.5 for ; Fri, 31 Jul 2020 01:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Q8OpMiJ+z4ZHwmpiATogVeChudpSi8OJUrMWzrMdEXE=; b=HKkCROCgWVfB5Zs1f7eEF5gOlL3UGVnCFzaPZgvCjZAgU2+U3MHRKopkOrVZeyR3vf vjudcrXjbLvmNlu7/eZbioHE81Ouw2sKkbTh/Kj9d0qisV8UZIamJehMXRAEKBhfP0yJ o2WEioVtsuTNBdPDxVhLkq/4iWGa4i8OhZO8zvrv2Al+dBmSxBDj+LRKycrsrooeLEFT gCw+E9gzfz5m/00SouG06jEsh+F5Wvse1G1rUJ1lHsFBEr41wEZV+RNxptyA5W2TgVvl 6abSqymXPVo+6IRpqlLE0W5xc/txiifofJQasl9SzvsE8/apY7eqtw0ejGSS6/IvlOqB tKeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q8OpMiJ+z4ZHwmpiATogVeChudpSi8OJUrMWzrMdEXE=; b=atri5VgJTHCxSZk3X6oSdDazKCoEwRH4P1fMLoQWDa6RYwAUGfTqXWLBdt0fb3j6I9 lyfTjWyVeKrf+7JhihNRlhYX+QnIJaTpkzhK6G/40X8NHX3y/p1Q31OpNBLvxeDKRGrs 8+V3TSj0iQ/sMOssemGuSWg8B3Vdh+OCOsl6YgUu+e5h3OjMC8VGD7/GYtGsa+3u3yWB 7308uGUib4qy8skc7sySmRs+EBbIuYHGus7jMesuZXDAlIkQlORmbzlwirMOcC761NKa aOEEKizmnSdFDKA4wolhRgGpVrd2MUEgKW7BRvU7kcKAbtAtZZ4Zitfgus9FpiJ8owfJ gFNA== X-Gm-Message-State: AOAM531821MqnyfMaPT301xfpQgo0Kq5tzWjKUW8YH3/XqT7ii/WSsd2 vSnVNxa59CvUJ1fx+LgSc0+5IXJLufg= X-Google-Smtp-Source: ABdhPJw2xNbOV3xC63XD4TJSfkwYZDWWkbXBDvb97fYK764gELmnXWQ3+iN4lpi1f/3Ln4sCAR25GQ== X-Received: by 2002:a7b:cf0c:: with SMTP id l12mr2884769wmg.77.1596183555084; Fri, 31 Jul 2020 01:19:15 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id g16sm12171266wrs.88.2020.07.31.01.19.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 01:19:14 -0700 (PDT) Date: Fri, 31 Jul 2020 09:19:11 +0100 From: Quentin Perret To: Will Deacon Subject: Re: [PATCH 02/20] KVM: arm64: Add support for creating kernel-agnostic stage-1 page tables Message-ID: <20200731081911.GB3201636@google.com> References: <20200730153406.25136-1-will@kernel.org> <20200730153406.25136-3-will@kernel.org> <20200731081436.GA3201636@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200731081436.GA3201636@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_041916_677107_D2C936DE X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki Poulose , Marc Zyngier , James Morse , Catalin Marinas , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday 31 Jul 2020 at 09:14:36 (+0100), Quentin Perret wrote: > Hey Will, > > On Thursday 30 Jul 2020 at 16:33:48 (+0100), Will Deacon wrote: > > +void *kvm_pgtable_hyp_alloc_cookie(u32 va_bits) > > +{ > > + struct kvm_pgtable *pgt = kzalloc(sizeof(*pgt), GFP_KERNEL); > > + > > + if (!pgt) > > + return NULL; > > + > > + pgt->ia_bits = va_bits; > > + pgt->start_level = kvm_start_level(va_bits); > > + > > + pgt->pgd = (kvm_pte_t *)get_zeroed_page(GFP_KERNEL); > > + if (!pgt->pgd) { > > + kfree(pgt); > > + pgt = NULL; > > + } > > + > > + return pgt; > > +} > > + > > +static int hyp_free_walker(u64 addr, u64 end, u32 level, kvm_pte_t *ptep, > > + enum kvm_pgtable_walk_flags flag, void * const arg) > > +{ > > + free_page((unsigned long)kvm_pte_follow(*ptep)); > > + return 0; > > +} > > + > > +void kvm_pgtable_hyp_free_cookie(void *cookie) > > +{ > > + size_t pgd_sz; > > + struct kvm_pgtable *pgt = cookie; > > + struct kvm_pgtable_walker walker = { > > + .cb = hyp_free_walker, > > + .flags = KVM_PGTABLE_WALK_TABLE_POST, > > + }; > > + > > + if (kvm_pgtable_walk(cookie, 0, BIT(pgt->ia_bits), &walker)) > > + kvm_err("Failed to free page-table pages\n"); > > + > > + pgd_sz = kvm_pgd_pages(pgt) * PAGE_SIZE; > > + free_pages_exact(pgt->pgd, pgd_sz); > > Given that the pgd is unconditionally a single page for the stage 1 case > (as per kvm_pgtable_hyp_alloc_cookie() above), should we simplify this > to a simple free_page()? Or did you want to factorize this with the > stage 2 free path? Hmm, or maybe it's the alloc() path that needs fixing actually ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel