From: Patrick Williams <patrick@stwcx.xyz>
To: Vijay Khemka <vijaykhemka@fb.com>
Cc: Nancy Yuen <yuenn@google.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: using third party library
Date: Fri, 31 Jul 2020 08:08:06 -0500 [thread overview]
Message-ID: <20200731130806.GS3922@heinlein> (raw)
In-Reply-To: <A698A001-88FC-464E-9D56-E7EFB69624DE@fb.com>
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
On Thu, Jul 30, 2020 at 08:32:00PM +0000, Vijay Khemka wrote:
> There is no recipe available. It is just a github project and either we can add as a SRC_URI+ into our recipe or write a new recipe to build a package. This is header only library, all sources are in header file itself. So we should be able to just add as SRC_URI. I have no idea about how licensing will work here.
>
I don't think you should add an additional SRC_URI onto your package in
order to get this dependency even though it is header-only. There are
other header-only repositories that have recipes, such as nlohmann-json.
If you were to add this as an SRC_URI it would complicate the LICENSE
setting in your recipe because your code is Apache but you're also
including an MIT component. It is clearer to simply have another recipe
that is MIT licensed, as appropriate.
The recommendation that "this belongs in openembedded" means we probably
shouldn't be carrying around the recipe for it ourselves since it has
potentially wider applicability than OpenBMC. We [you] can contribute
the recipe upstream to OE and we'll get it indirectly that way. We
similarlly did this for 'libmimetic' recently.
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-31 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 19:50 using third party library Vijay Khemka
2020-07-29 20:04 ` Nancy Yuen
2020-07-30 20:32 ` Vijay Khemka
2020-07-31 13:08 ` Patrick Williams [this message]
2020-07-31 16:30 ` Vijay Khemka
2020-07-30 4:58 ` Ed Tanous
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731130806.GS3922@heinlein \
--to=patrick@stwcx.xyz \
--cc=openbmc@lists.ozlabs.org \
--cc=vijaykhemka@fb.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.