All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Vivien Didelot <vivien.didelot@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+
Date: Fri, 31 Jul 2020 12:07:55 -0500	[thread overview]
Message-ID: <20200731170755.GB1726@embeddedor> (raw)
In-Reply-To: <4e30e2df7bec0fedf1a29f7825fbb4c12593eac9.camel@perches.com>

On Fri, Jul 31, 2020 at 09:35:42AM -0700, Joe Perches wrote:
> On Fri, 2020-07-31 at 11:33 -0500, Gustavo A. R. Silva wrote:
> > Increase columns highlighting to 100+ once the 80-column warning has
> > been deprecated in the Linux kernel[1].
> > 
> > [1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
> > 
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > ---
> >  plugin/linuxsty.vim | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
> > index 6f7e331..c42ce72 100644
> > --- a/plugin/linuxsty.vim
> > +++ b/plugin/linuxsty.vim
> > @@ -62,7 +62,7 @@ function s:LinuxFormatting()
> >      setlocal tabstop=8
> >      setlocal shiftwidth=8
> >      setlocal softtabstop=8
> > -    setlocal textwidth=80
> > +    setlocal textwidth=100
> 
> This is not a good change.
> 80 columns is still _preferred_.
> 

Now that you mention that, I have mixed feelings about this.
Let's see if we can get more opinions...

--
Gustavo

> 
> >      setlocal noexpandtab
> >  
> >      setlocal cindent
> > @@ -80,7 +80,7 @@ function s:LinuxHighlighting()
> >      highlight default link LinuxError ErrorMsg
> >  
> >      syn match LinuxError / \+\ze\t/     " spaces before tab
> > -    syn match LinuxError /\%>80v[^()\{\}\[\]<>]\+/ " virtual column 81 and more
> > +    syn match LinuxError /\%>100v[^()\{\}\[\]<>]\+/ " virtual column 101 and more
> >  
> >      " Highlight trailing whitespace, unless we're in insert mode and the
> >      " cursor's placed right after the whitespace. This prevents us from having
> 

  reply	other threads:[~2020-07-31 17:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 16:33 [PATCH] vim: linux-kernel: Increase columns highlighting to 100+ Gustavo A. R. Silva
2020-07-31 16:35 ` Joe Perches
2020-07-31 17:07   ` Gustavo A. R. Silva [this message]
2020-07-31 17:17     ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2020-07-31 16:30 Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200731170755.GB1726@embeddedor \
    --to=gustavoars@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.