All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [RFC PATCH 04/12] mptcp: basic sndbuf autotuning
Date: Sun, 02 Aug 2020 00:45:03 +0200	[thread overview]
Message-ID: <20200801224503.GC29169@breakpoint.cc> (raw)
In-Reply-To: f82128dc0044d0a52ba11940b57f18f3630076f5.1596216310.git.pabeni@redhat.com

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Paolo Abeni <pabeni(a)redhat.com> wrote:
> Let the msk sendbuf track the size of the larger subflow's
> send buffer.
>
> The update is performed just before try to send any data.

Looks good, small nit:

> +	/* do auto tuning */
> +	if (!(sk->sk_userlocks & SOCK_RCVBUF_LOCK) &&
> +	    sndbuf > READ_ONCE(sk->sk_sndbuf))
> +		WRITE_ONCE(sk->sk_sndbuf, sndbuf);

SOCK_SNDBUF_LOCK

                 reply	other threads:[~2020-08-01 22:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200801224503.GC29169@breakpoint.cc \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.