From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041C1C433E0 for ; Sun, 2 Aug 2020 11:25:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D731B2075A for ; Sun, 2 Aug 2020 11:25:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D731B2075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D7D46E0FF; Sun, 2 Aug 2020 11:25:32 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 413966E0FF; Sun, 2 Aug 2020 11:25:30 +0000 (UTC) IronPort-SDR: H5sM5qUnI1i9g+Mb4SN+wegLE9MloZf8GoD7tIMOlCDNZGVyraHuTlC1T/vyx6PqXFN82T/Lmj JjUNZCU9ETmw== X-IronPort-AV: E=McAfee;i="6000,8403,9700"; a="213523576" X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="213523576" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2020 04:25:28 -0700 IronPort-SDR: UTOmpJ4fZQD2Rw5VNiUh+1mVo9aD5GDEpqPm95/RPFxD7Iwv7woQUiF1/Rm20KQhIGKuCd79wP imQWstfJClOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="305523573" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2020 04:25:25 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k2C7I-005iAE-LN; Sun, 02 Aug 2020 14:25:24 +0300 Date: Sun, 2 Aug 2020 14:25:24 +0300 From: Andy Shevchenko To: Hans de Goede Message-ID: <20200802112524.GS3703480@smile.fi.intel.com> References: <20200717133753.127282-1-hdegoede@redhat.com> <20200729105436.GT3703480@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Subject: Re: [Intel-gfx] [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, intel-gfx , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mika Westerberg , Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Aug 01, 2020 at 04:38:16PM +0200, Hans de Goede wrote: > On 7/29/20 12:54 PM, Andy Shevchenko wrote: > > On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: ... > > One comment to consider, though. There are three channels in that PWM AFAIU. > > One of them is backlight control, another one can be attached to haptics. The > > concern is how this series may (or may not?) affect haptics behaviour. > > When you say "in that PWM" do you mean the LPSS one or the CRC one ? CRC one. I have read it from PMIC spec, that's why the question. > The CRC PWM driver patches do make it honor the requested output frequency, > where before, because of a bug, it would stick with the out frequency > setup by the firmware (or the power-on-reset value if no value is set > by the firmware). This fix causing this is very clearly correct, but > it could have unexpected side-effects. -- With Best Regards, Andy Shevchenko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F1F0C433E0 for ; Sun, 2 Aug 2020 11:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0869A2075A for ; Sun, 2 Aug 2020 11:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726827AbgHBLZ3 (ORCPT ); Sun, 2 Aug 2020 07:25:29 -0400 Received: from mga09.intel.com ([134.134.136.24]:62423 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbgHBLZ3 (ORCPT ); Sun, 2 Aug 2020 07:25:29 -0400 IronPort-SDR: WLBEzmGVIdbCvgfxqMsVqFsU5RLKV/HUWmsrWO6im9Iwo0u6LdVkdl3Z8UqhkDK5peErRePqA6 ORf54cfbr15w== X-IronPort-AV: E=McAfee;i="6000,8403,9700"; a="153201450" X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="153201450" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2020 04:25:28 -0700 IronPort-SDR: UTOmpJ4fZQD2Rw5VNiUh+1mVo9aD5GDEpqPm95/RPFxD7Iwv7woQUiF1/Rm20KQhIGKuCd79wP imQWstfJClOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="305523573" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2020 04:25:25 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k2C7I-005iAE-LN; Sun, 02 Aug 2020 14:25:24 +0300 Date: Sun, 2 Aug 2020 14:25:24 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , "Rafael J . Wysocki" , Len Brown , linux-pwm@vger.kernel.org, intel-gfx , dri-devel@lists.freedesktop.org, Mika Westerberg , linux-acpi@vger.kernel.org Subject: Re: [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API Message-ID: <20200802112524.GS3703480@smile.fi.intel.com> References: <20200717133753.127282-1-hdegoede@redhat.com> <20200729105436.GT3703480@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Sat, Aug 01, 2020 at 04:38:16PM +0200, Hans de Goede wrote: > On 7/29/20 12:54 PM, Andy Shevchenko wrote: > > On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: ... > > One comment to consider, though. There are three channels in that PWM AFAIU. > > One of them is backlight control, another one can be attached to haptics. The > > concern is how this series may (or may not?) affect haptics behaviour. > > When you say "in that PWM" do you mean the LPSS one or the CRC one ? CRC one. I have read it from PMIC spec, that's why the question. > The CRC PWM driver patches do make it honor the requested output frequency, > where before, because of a bug, it would stick with the out frequency > setup by the firmware (or the power-on-reset value if no value is set > by the firmware). This fix causing this is very clearly correct, but > it could have unexpected side-effects. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABB34C433E3 for ; Mon, 3 Aug 2020 08:21:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88E8E206E2 for ; Mon, 3 Aug 2020 08:21:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88E8E206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 38378891CC; Mon, 3 Aug 2020 08:20:39 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 413966E0FF; Sun, 2 Aug 2020 11:25:30 +0000 (UTC) IronPort-SDR: H5sM5qUnI1i9g+Mb4SN+wegLE9MloZf8GoD7tIMOlCDNZGVyraHuTlC1T/vyx6PqXFN82T/Lmj JjUNZCU9ETmw== X-IronPort-AV: E=McAfee;i="6000,8403,9700"; a="213523576" X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="213523576" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2020 04:25:28 -0700 IronPort-SDR: UTOmpJ4fZQD2Rw5VNiUh+1mVo9aD5GDEpqPm95/RPFxD7Iwv7woQUiF1/Rm20KQhIGKuCd79wP imQWstfJClOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="305523573" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2020 04:25:25 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k2C7I-005iAE-LN; Sun, 02 Aug 2020 14:25:24 +0300 Date: Sun, 2 Aug 2020 14:25:24 +0300 From: Andy Shevchenko To: Hans de Goede Subject: Re: [PATCH v5 00/16] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API Message-ID: <20200802112524.GS3703480@smile.fi.intel.com> References: <20200717133753.127282-1-hdegoede@redhat.com> <20200729105436.GT3703480@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Mailman-Approved-At: Mon, 03 Aug 2020 08:20:37 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, intel-gfx , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, Thierry Reding , dri-devel@lists.freedesktop.org, Rodrigo Vivi , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mika Westerberg , Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Aug 01, 2020 at 04:38:16PM +0200, Hans de Goede wrote: > On 7/29/20 12:54 PM, Andy Shevchenko wrote: > > On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: ... > > One comment to consider, though. There are three channels in that PWM AFAIU. > > One of them is backlight control, another one can be attached to haptics. The > > concern is how this series may (or may not?) affect haptics behaviour. > > When you say "in that PWM" do you mean the LPSS one or the CRC one ? CRC one. I have read it from PMIC spec, that's why the question. > The CRC PWM driver patches do make it honor the requested output frequency, > where before, because of a bug, it would stick with the out frequency > setup by the firmware (or the power-on-reset value if no value is set > by the firmware). This fix causing this is very clearly correct, but > it could have unexpected side-effects. -- With Best Regards, Andy Shevchenko _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel