From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4879C433E1 for ; Sun, 2 Aug 2020 14:26:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8421120759 for ; Sun, 2 Aug 2020 14:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="swSpXiix" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8421120759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=ZwO07RLyAVdGxqLPDjd67uM5PQ3u/xq36C2AZ0KABrc=; b=swSpXiixhNh6mEbhHomschZas3 xGQFcXbhbKXgKRlNUwfbH97TiZyz4/tqF5yTsC2FOraUjUZjZsKWbvuFsmDtpv+5fAw3AcrbPh1e/ XrLA5HTf4cSDW5u4fYzrg3hVM+LExm8rp1/zivWE2sAcqcI5qein/cqIbtWcQQIyG/+qaJG3xjFNv VvgsoG4eWLwBlkMtHtpUmgurIEYTeJsius91BlLgpTnAd68zf7kcC7kllWi9RGuX4qWfSKIBPSeyS UPbXUepSqYu+fXlFb9pvfq5aMVkxPVFOmCIn62S6Ck3vIEN5T/mNlqlb5qCtzK4zntqhAJLsohloc 7PL5eaTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2EwF-00070y-3C; Sun, 02 Aug 2020 14:26:11 +0000 Received: from mail-lj1-f171.google.com ([209.85.208.171]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2EwB-0006zB-QC; Sun, 02 Aug 2020 14:26:08 +0000 Received: by mail-lj1-f171.google.com with SMTP id x9so37042889ljc.5; Sun, 02 Aug 2020 07:26:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zeiAgJxHrPijvNQknHHdvjYtJyFN1FT1e2QzBTPsm24=; b=B8sVxf6RowCYAGQOlvb2k5Kal91vhbXwufnmyPE6PUcLDrrGd7CM2OToLShVJ0H4rH 4XMaj1IiPQfV7TN3EbI2mf6kGBfZAiHuMqda9qxKf20sWvkB1kaWNUlEuEuDsqN9xo9u fTRW8ZVX8UAdlc1xs0AvpQKaBjcco0nr8hzYQ5swk/jdD98i7cy5jjar4iTOPjHBasNl 1Wev0XR/LbVGjVe4z5GLm3IqcPYBkI2ExzBeoP2w7V4znUf2ah/QTLZYGO/LxHl8oJ7+ W6okwYT7PdOw60EKtOxs2GDF0DxrHDdXK0vzvzPVZYjzFRGRY2KUzr5twCL0sZo256HS h0YA== X-Gm-Message-State: AOAM530H86xogbxwY2Ra1fCF2L5RBsp8JhLnNwEtHKlEEPKYxl/6lDb1 DEEXWkaPcUKPsFuii2/Lh8E= X-Google-Smtp-Source: ABdhPJz3cgcIo8JIidtc9NrocQlQwtKoNwLE3saIsQCJHhsMNawOby6x6eEuxlT5d67lW0jGLW6Kmg== X-Received: by 2002:a2e:94d5:: with SMTP id r21mr6223757ljh.424.1596378363688; Sun, 02 Aug 2020 07:26:03 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id 193sm4214136lfa.90.2020.08.02.07.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 07:26:02 -0700 (PDT) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Subject: [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Date: Sun, 2 Aug 2020 14:25:52 +0000 Message-Id: <20200802142601.1635926-1-kw@linux.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200802_102607_891399_E43CFC3E X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-pci@vger.kernel.org, Shawn Lin , Binghui Wang , linux-arm-kernel@axis.com, Ley Foon Tan , Thomas Petazzoni , Toan Le , Jesper Nilsson , linux-samsung-soc@vger.kernel.org, Kevin Hilman , Pratyush Anand , Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Kukjin Kim , Xiaowei Song , Hou Zhiqiang , Linus Walleij , Richard Zhu , Sascha Hauer , Yue Wang , Murali Karicheri , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingoo Han , rfi@lists.rocketboards.org, Shawn Guo , Lucas Stach Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org QXQgdGhlIG1vbWVudCBhIGxvdCBvZiBlcnJvciBoYW5kbGluZyBjb2RlIHdvdWxkIHByaW50IGEg ZHVwbGljYXRlZAplcnJvciBtZXNzYWdlIHNob3VsZCBlaXRoZXIgdGhlIHBsYXRmb3JtX2dldF9p cnEoKSBvcgpwbGF0Zm9ybV9nZXRfaXJxX2J5bmFtZSgpIGZ1bmN0aW9uIGZhaWxzIHRvIG9idGFp biBhbiBJUlEgZm9yIGEgZGV2aWNlLgoKVGhlcmUgaXMgbm8gbmVlZCB0byBjYWxsIHRoZSBkZXZf ZXJyKCkgZnVuY3Rpb24gZGlyZWN0bHkgdG8gcHJpbnQKYSBjdXN0b20gbWVzc2FnZSB3aGVuIGhh bmRsaW5nIGFuIGVycm9yIGZyb20gZWl0aGVyIG9mIHRoZXNlIGZ1bmN0aW9ucwphcyBib3RoIGFy ZSBnb2luZyB0byBkaXNwbGF5IGFuIGFwcHJvcHJpYXRlIGVycm9yIG1lc3NhZ2UgaW4gY2FzZSBv ZgphIGZhaWx1cmUuCgpUaGlzIHNlcmllcyBhaW1zIHRvIHJlbW92ZSBzdXJwbHVzIGNhbGwgdG8g ZGV2X2VycigpIHdoZW4gaGFuZGluZyBhbgplcnJvciBvcmlnaW5hdGluZyBmcm9tIGVpdGhlciBw bGF0Zm9ybV9nZXRfaXJxKCkgb3IKcGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUoKSBmdW5jdGlvbiBh cyBwZXIgc3VnZ2VzdGlvbiBmcm9tIENvY2NpbmVsbGUuCgpSZWxhdGVkIGNvbW1pdHMgYXJlIGNv bW1pdCA3NzIzZjRjNWVjZGIgKCJkcml2ZXIgY29yZTogcGxhdGZvcm06IEFkZCBhbgplcnJvciBt ZXNzYWdlIHRvIHBsYXRmb3JtX2dldF9pcnEqKCkiKSBhbmQgY29tbWl0IDk4MDUxYmEyYjI4Ygoo ImNvY2NpbmVsbGU6IEFkZCBzY3JpcHQgdG8gY2hlY2sgZm9yIHBsYXRmb3JtX2dldF9pcnEoKSBl eGNlc3NpdmUKcHJpbnRzIikuCgpLcnp5c3p0b2YgV2lsY3p5xYRza2kgKDEwKToKICBQQ0k6IGR3 YzogUmVtb3ZlIGRldl9lcnIoKSB3aGVuIGhhbmRpbmcgYW4gZXJyb3IgZnJvbQogICAgcGxhdGZv cm1fZ2V0X2lycSgpCiAgUENJOiBtb2JpdmVpbDogUmVtb3ZlIGRldl9lcnIoKSB3aGVuIGhhbmRp bmcgYW4gZXJyb3IgZnJvbQogICAgcGxhdGZvcm1fZ2V0X2lycSgpCiAgUENJOiB0ZWdyYTogUmVt b3ZlIGRldl9lcnIoKSB3aGVuIGhhbmRpbmcgYW4gZXJyb3IgZnJvbQogICAgcGxhdGZvcm1fZ2V0 X2lycSgpCiAgUENJOiBhbHRlcmE6IFJlbW92ZSBkZXZfZXJyKCkgd2hlbiBoYW5kaW5nIGFuIGVy cm9yIGZyb20KICAgIHBsYXRmb3JtX2dldF9pcnEoKQogIFBDSTogaG9zdC1nZW5lcmljOiBSZW1v dmUgZGV2X2VycigpIHdoZW4gaGFuZGluZyBhbiBlcnJvciBmcm9tCiAgICBwbGF0Zm9ybV9nZXRf aXJxKCkKICBQQ0k6IHYzLXNlbWk6IFJlbW92ZSBkZXZfZXJyKCkgd2hlbiBoYW5kaW5nIGFuIGVy cm9yIGZyb20KICAgIHBsYXRmb3JtX2dldF9pcnEoKQogIFBDSTogYWx0ZXJhLW1zaTogUmVtb3Zl IGRldl9lcnIoKSB3aGVuIGhhbmRpbmcgYW4gZXJyb3IgZnJvbQogICAgcGxhdGZvcm1fZ2V0X2ly cSgpCiAgUENJOiB4Z2VuZS1tc2k6IFJlbW92ZSBkZXZfZXJyKCkgd2hlbiBoYW5kaW5nIGFuIGVy cm9yIGZyb20KICAgIHBsYXRmb3JtX2dldF9pcnEoKQogIFBDSTogcm9ja2NoaXA6IFJlbW92ZSBk ZXZfZXJyKCkgd2hlbiBoYW5kaW5nIGFuIGVycm9yIGZyb20KICAgIHBsYXRmb3JtX2dldF9pcnEo KQogIFBDSTogeGlsaW54LW53bDogUmVtb3ZlIGRldl9lcnIoKSB3aGVuIGhhbmRpbmcgYW4gZXJy b3IgZnJvbQogICAgcGxhdGZvcm1fZ2V0X2lycSgpCgogZHJpdmVycy9wY2kvY29udHJvbGxlci9k d2MvcGNpLWRyYTd4eC5jICAgICAgICAgICAgICB8ICA4ICsrLS0tLS0tCiBkcml2ZXJzL3BjaS9j b250cm9sbGVyL2R3Yy9wY2ktZXh5bm9zLmMgICAgICAgICAgICAgIHwgIDkgKysrLS0tLS0tCiBk cml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jICAgICAgICAgICAgICAgIHwgIDQg Ky0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWtleXN0b25lLmMgICAgICAgICAg ICB8ICA0ICstLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1tZXNvbi5jICAgICAg ICAgICAgICAgfCAgNCArLS0tCiBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWFybWFk YThrLmMgICAgICAgICAgIHwgIDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNp ZS1hcnRwZWM2LmMgICAgICAgICAgICB8ICA0ICstLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIv ZHdjL3BjaWUtaGlzdGIuYyAgICAgICAgICAgICAgfCAgNCArLS0tCiBkcml2ZXJzL3BjaS9jb250 cm9sbGVyL2R3Yy9wY2llLWtpcmluLmMgICAgICAgICAgICAgIHwgIDUgKy0tLS0KIGRyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtc3BlYXIxM3h4LmMgICAgICAgICAgfCAgNSArKy0tLQog ZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS10ZWdyYTE5NC5jICAgICAgICAgICB8ICA0 ICstLS0KIC4uLi9wY2kvY29udHJvbGxlci9tb2JpdmVpbC9wY2llLWxheWVyc2NhcGUtZ2VuNC5j ICAgfCAgNSArKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9tb2JpdmVpbC9wY2llLW1vYml2 ZWlsLWhvc3QuYyB8ICA0ICstLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLXRlZ3JhLmMg ICAgICAgICAgICAgICAgICAgfCAgOCArKy0tLS0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9w Y2ktdjMtc2VtaS5jICAgICAgICAgICAgICAgICB8ICA1ICsrLS0tCiBkcml2ZXJzL3BjaS9jb250 cm9sbGVyL3BjaS14Z2VuZS1tc2kuYyAgICAgICAgICAgICAgIHwgIDIgLS0KIGRyaXZlcnMvcGNp L2NvbnRyb2xsZXIvcGNpZS1hbHRlcmEtbXNpLmMgICAgICAgICAgICAgfCAgMSAtCiBkcml2ZXJz L3BjaS9jb250cm9sbGVyL3BjaWUtYWx0ZXJhLmMgICAgICAgICAgICAgICAgIHwgIDQgKy0tLQog ZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2llLXJvY2tjaGlwLWhvc3QuYyAgICAgICAgICB8IDEy ICsrKy0tLS0tLS0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2llLXRhbmdvLmMgICAgICAg ICAgICAgICAgICB8ICA0ICstLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpZS14aWxpbngt bndsLmMgICAgICAgICAgICAgfCAxMSArKy0tLS0tLS0tLQogMjEgZmlsZXMgY2hhbmdlZCwgMjkg aW5zZXJ0aW9ucygrKSwgODIgZGVsZXRpb25zKC0pCgotLSAKMi4yNy4wCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5n IGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3107C433E0 for ; Sun, 2 Aug 2020 14:26:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E3162075A for ; Sun, 2 Aug 2020 14:26:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726323AbgHBO0G (ORCPT ); Sun, 2 Aug 2020 10:26:06 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:34712 "EHLO mail-lj1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgHBO0G (ORCPT ); Sun, 2 Aug 2020 10:26:06 -0400 Received: by mail-lj1-f177.google.com with SMTP id q7so37010850ljm.1; Sun, 02 Aug 2020 07:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zeiAgJxHrPijvNQknHHdvjYtJyFN1FT1e2QzBTPsm24=; b=IHxpd+9SwtctYq+2qUbmhS2GVrZwFbbtOnDIOWWCVSr5gVtLd8XXEjSq/+0qA4+j2H Sun37G5GM3LyEWWVFm0/9oN8ErxA6UeXyRirnvgka7BSQOtFKLJmNwmpT0+D0f/SbvgZ WS8E8v1UjoYEZKyE5dh8krKABQhbT/6ZgKOumEmvPIGAcsWzMKAUgXQM/NcD8cBtThDc 34EuDS8nN+BNmLFgP5DmVdRIzbrk5d8y+J5ICCIlSA3A7O/GyKt7KH9bGjd50m5bzdLy j60sWTTKcXUt8j+3iilSAgQl0rNPnFvekzj5QXOhP0n8Gs/BbV1IpZiWR+MPp50aXmlP YCWQ== X-Gm-Message-State: AOAM5300QtaptUzlR8BKNxMkGLlsCKyztYxnSl//2nBwb90T7d+GOOxv Vo6Q8sEnTOPURhcl4aRwkeg= X-Google-Smtp-Source: ABdhPJz3cgcIo8JIidtc9NrocQlQwtKoNwLE3saIsQCJHhsMNawOby6x6eEuxlT5d67lW0jGLW6Kmg== X-Received: by 2002:a2e:94d5:: with SMTP id r21mr6223757ljh.424.1596378363688; Sun, 02 Aug 2020 07:26:03 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id 193sm4214136lfa.90.2020.08.02.07.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 07:26:02 -0700 (PDT) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Jingoo Han , Kukjin Kim , Krzysztof Kozlowski , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Murali Karicheri , Yue Wang , Kevin Hilman , Thomas Petazzoni , Jesper Nilsson , Xiaowei Song , Binghui Wang , Pratyush Anand , Hou Zhiqiang , Linus Walleij , Toan Le , Ley Foon Tan , Shawn Lin , Heiko Stuebner , linux-amlogic@lists.infradead.org, linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, rfi@lists.rocketboards.org Subject: [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Date: Sun, 2 Aug 2020 14:25:52 +0000 Message-Id: <20200802142601.1635926-1-kw@linux.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org At the moment a lot of error handling code would print a duplicated error message should either the platform_get_irq() or platform_get_irq_byname() function fails to obtain an IRQ for a device. There is no need to call the dev_err() function directly to print a custom message when handling an error from either of these functions as both are going to display an appropriate error message in case of a failure. This series aims to remove surplus call to dev_err() when handing an error originating from either platform_get_irq() or platform_get_irq_byname() function as per suggestion from Coccinelle. Related commits are commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") and commit 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints"). Krzysztof Wilczyński (10): PCI: dwc: Remove dev_err() when handing an error from platform_get_irq() PCI: mobiveil: Remove dev_err() when handing an error from platform_get_irq() PCI: tegra: Remove dev_err() when handing an error from platform_get_irq() PCI: altera: Remove dev_err() when handing an error from platform_get_irq() PCI: host-generic: Remove dev_err() when handing an error from platform_get_irq() PCI: v3-semi: Remove dev_err() when handing an error from platform_get_irq() PCI: altera-msi: Remove dev_err() when handing an error from platform_get_irq() PCI: xgene-msi: Remove dev_err() when handing an error from platform_get_irq() PCI: rockchip: Remove dev_err() when handing an error from platform_get_irq() PCI: xilinx-nwl: Remove dev_err() when handing an error from platform_get_irq() drivers/pci/controller/dwc/pci-dra7xx.c | 8 ++------ drivers/pci/controller/dwc/pci-exynos.c | 9 +++------ drivers/pci/controller/dwc/pci-imx6.c | 4 +--- drivers/pci/controller/dwc/pci-keystone.c | 4 +--- drivers/pci/controller/dwc/pci-meson.c | 4 +--- drivers/pci/controller/dwc/pcie-armada8k.c | 4 +--- drivers/pci/controller/dwc/pcie-artpec6.c | 4 +--- drivers/pci/controller/dwc/pcie-histb.c | 4 +--- drivers/pci/controller/dwc/pcie-kirin.c | 5 +---- drivers/pci/controller/dwc/pcie-spear13xx.c | 5 ++--- drivers/pci/controller/dwc/pcie-tegra194.c | 4 +--- .../pci/controller/mobiveil/pcie-layerscape-gen4.c | 5 ++--- drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 4 +--- drivers/pci/controller/pci-tegra.c | 8 ++------ drivers/pci/controller/pci-v3-semi.c | 5 ++--- drivers/pci/controller/pci-xgene-msi.c | 2 -- drivers/pci/controller/pcie-altera-msi.c | 1 - drivers/pci/controller/pcie-altera.c | 4 +--- drivers/pci/controller/pcie-rockchip-host.c | 12 +++--------- drivers/pci/controller/pcie-tango.c | 4 +--- drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++--------- 21 files changed, 29 insertions(+), 82 deletions(-) -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= Subject: [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Date: Sun, 2 Aug 2020 14:25:52 +0000 Message-ID: <20200802142601.1635926-1-kw@linux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: Sender: linux-samsung-soc-owner@vger.kernel.org To: Bjorn Helgaas Cc: Jingoo Han , Kukjin Kim , Krzysztof Kozlowski , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Murali Karicheri , Yue Wang , Kevin Hilman , Thomas Petazzoni , Jesper Nilsson , Xiaowei Song , Binghui Wang , Pratyush Anand , Hou Zhiqiang , Linus Walleij , Toan Le , Ley Foon Tan Shawn Lin List-Id: linux-rockchip.vger.kernel.org At the moment a lot of error handling code would print a duplicated error message should either the platform_get_irq() or platform_get_irq_byname() function fails to obtain an IRQ for a device. There is no need to call the dev_err() function directly to print a custom message when handling an error from either of these functions as both are going to display an appropriate error message in case of a failure. This series aims to remove surplus call to dev_err() when handing an error originating from either platform_get_irq() or platform_get_irq_byname() function as per suggestion from Coccinelle. Related commits are commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") and commit 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints"). Krzysztof Wilczyński (10): PCI: dwc: Remove dev_err() when handing an error from platform_get_irq() PCI: mobiveil: Remove dev_err() when handing an error from platform_get_irq() PCI: tegra: Remove dev_err() when handing an error from platform_get_irq() PCI: altera: Remove dev_err() when handing an error from platform_get_irq() PCI: host-generic: Remove dev_err() when handing an error from platform_get_irq() PCI: v3-semi: Remove dev_err() when handing an error from platform_get_irq() PCI: altera-msi: Remove dev_err() when handing an error from platform_get_irq() PCI: xgene-msi: Remove dev_err() when handing an error from platform_get_irq() PCI: rockchip: Remove dev_err() when handing an error from platform_get_irq() PCI: xilinx-nwl: Remove dev_err() when handing an error from platform_get_irq() drivers/pci/controller/dwc/pci-dra7xx.c | 8 ++------ drivers/pci/controller/dwc/pci-exynos.c | 9 +++------ drivers/pci/controller/dwc/pci-imx6.c | 4 +--- drivers/pci/controller/dwc/pci-keystone.c | 4 +--- drivers/pci/controller/dwc/pci-meson.c | 4 +--- drivers/pci/controller/dwc/pcie-armada8k.c | 4 +--- drivers/pci/controller/dwc/pcie-artpec6.c | 4 +--- drivers/pci/controller/dwc/pcie-histb.c | 4 +--- drivers/pci/controller/dwc/pcie-kirin.c | 5 +---- drivers/pci/controller/dwc/pcie-spear13xx.c | 5 ++--- drivers/pci/controller/dwc/pcie-tegra194.c | 4 +--- .../pci/controller/mobiveil/pcie-layerscape-gen4.c | 5 ++--- drivers/pci/controller/mobiveil/pcie-mobiveil-host.c | 4 +--- drivers/pci/controller/pci-tegra.c | 8 ++------ drivers/pci/controller/pci-v3-semi.c | 5 ++--- drivers/pci/controller/pci-xgene-msi.c | 2 -- drivers/pci/controller/pcie-altera-msi.c | 1 - drivers/pci/controller/pcie-altera.c | 4 +--- drivers/pci/controller/pcie-rockchip-host.c | 12 +++--------- drivers/pci/controller/pcie-tango.c | 4 +--- drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++--------- 21 files changed, 29 insertions(+), 82 deletions(-) -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E35C433DF for ; Sun, 2 Aug 2020 14:28:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 655E020759 for ; Sun, 2 Aug 2020 14:28:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uMIhrnTH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 655E020759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=sL1uGsOjySdrqhZzuMU6FU7C+DLgxHjHfYQUbd95I6o=; b=uMIhrnTHLg8Kmt5NhaTVGBik+U RKZVT2vW1q4Oi2vi3YhqTsHF93horA56UizK5RK8IBYeE9Nm3QTBJM4lHeDZftFZ6RrvAh4yuu7Nj RktGDszDi443mcS769szlLQZX/HMN7WViUAp3OtT03S46q6wcfUMONDyWAu7GD2GGaafljkB9hJPc jPWT7uhr3oBNvhlihft4Ty5SE0w+YixCSLiGdP1T7aPddLcL4BoySwn3+tMhRIkzji63RCg2C9btU YqMYPBMl2Uz+MSD38x0NPq+njqztSawwgw3x5J+fPiGHlvTjBuqJv5fSlUV8oEbzKfBrR7YTHA9Ta 2IFqzyXQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2EwG-00071m-DD; Sun, 02 Aug 2020 14:26:12 +0000 Received: from mail-lj1-f171.google.com ([209.85.208.171]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2EwB-0006zB-QC; Sun, 02 Aug 2020 14:26:08 +0000 Received: by mail-lj1-f171.google.com with SMTP id x9so37042889ljc.5; Sun, 02 Aug 2020 07:26:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zeiAgJxHrPijvNQknHHdvjYtJyFN1FT1e2QzBTPsm24=; b=B8sVxf6RowCYAGQOlvb2k5Kal91vhbXwufnmyPE6PUcLDrrGd7CM2OToLShVJ0H4rH 4XMaj1IiPQfV7TN3EbI2mf6kGBfZAiHuMqda9qxKf20sWvkB1kaWNUlEuEuDsqN9xo9u fTRW8ZVX8UAdlc1xs0AvpQKaBjcco0nr8hzYQ5swk/jdD98i7cy5jjar4iTOPjHBasNl 1Wev0XR/LbVGjVe4z5GLm3IqcPYBkI2ExzBeoP2w7V4znUf2ah/QTLZYGO/LxHl8oJ7+ W6okwYT7PdOw60EKtOxs2GDF0DxrHDdXK0vzvzPVZYjzFRGRY2KUzr5twCL0sZo256HS h0YA== X-Gm-Message-State: AOAM530H86xogbxwY2Ra1fCF2L5RBsp8JhLnNwEtHKlEEPKYxl/6lDb1 DEEXWkaPcUKPsFuii2/Lh8E= X-Google-Smtp-Source: ABdhPJz3cgcIo8JIidtc9NrocQlQwtKoNwLE3saIsQCJHhsMNawOby6x6eEuxlT5d67lW0jGLW6Kmg== X-Received: by 2002:a2e:94d5:: with SMTP id r21mr6223757ljh.424.1596378363688; Sun, 02 Aug 2020 07:26:03 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id 193sm4214136lfa.90.2020.08.02.07.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 07:26:02 -0700 (PDT) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Subject: [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Date: Sun, 2 Aug 2020 14:25:52 +0000 Message-Id: <20200802142601.1635926-1-kw@linux.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200802_102607_891399_E43CFC3E X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-pci@vger.kernel.org, Shawn Lin , Binghui Wang , linux-arm-kernel@axis.com, Ley Foon Tan , Thomas Petazzoni , Toan Le , Jesper Nilsson , linux-samsung-soc@vger.kernel.org, Kevin Hilman , Pratyush Anand , Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Kukjin Kim , Xiaowei Song , Hou Zhiqiang , Linus Walleij , Richard Zhu , Sascha Hauer , Yue Wang , Murali Karicheri , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingoo Han , rfi@lists.rocketboards.org, Shawn Guo , Lucas Stach Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QXQgdGhlIG1vbWVudCBhIGxvdCBvZiBlcnJvciBoYW5kbGluZyBjb2RlIHdvdWxkIHByaW50IGEg ZHVwbGljYXRlZAplcnJvciBtZXNzYWdlIHNob3VsZCBlaXRoZXIgdGhlIHBsYXRmb3JtX2dldF9p cnEoKSBvcgpwbGF0Zm9ybV9nZXRfaXJxX2J5bmFtZSgpIGZ1bmN0aW9uIGZhaWxzIHRvIG9idGFp biBhbiBJUlEgZm9yIGEgZGV2aWNlLgoKVGhlcmUgaXMgbm8gbmVlZCB0byBjYWxsIHRoZSBkZXZf ZXJyKCkgZnVuY3Rpb24gZGlyZWN0bHkgdG8gcHJpbnQKYSBjdXN0b20gbWVzc2FnZSB3aGVuIGhh bmRsaW5nIGFuIGVycm9yIGZyb20gZWl0aGVyIG9mIHRoZXNlIGZ1bmN0aW9ucwphcyBib3RoIGFy ZSBnb2luZyB0byBkaXNwbGF5IGFuIGFwcHJvcHJpYXRlIGVycm9yIG1lc3NhZ2UgaW4gY2FzZSBv ZgphIGZhaWx1cmUuCgpUaGlzIHNlcmllcyBhaW1zIHRvIHJlbW92ZSBzdXJwbHVzIGNhbGwgdG8g ZGV2X2VycigpIHdoZW4gaGFuZGluZyBhbgplcnJvciBvcmlnaW5hdGluZyBmcm9tIGVpdGhlciBw bGF0Zm9ybV9nZXRfaXJxKCkgb3IKcGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUoKSBmdW5jdGlvbiBh cyBwZXIgc3VnZ2VzdGlvbiBmcm9tIENvY2NpbmVsbGUuCgpSZWxhdGVkIGNvbW1pdHMgYXJlIGNv bW1pdCA3NzIzZjRjNWVjZGIgKCJkcml2ZXIgY29yZTogcGxhdGZvcm06IEFkZCBhbgplcnJvciBt ZXNzYWdlIHRvIHBsYXRmb3JtX2dldF9pcnEqKCkiKSBhbmQgY29tbWl0IDk4MDUxYmEyYjI4Ygoo ImNvY2NpbmVsbGU6IEFkZCBzY3JpcHQgdG8gY2hlY2sgZm9yIHBsYXRmb3JtX2dldF9pcnEoKSBl eGNlc3NpdmUKcHJpbnRzIikuCgpLcnp5c3p0b2YgV2lsY3p5xYRza2kgKDEwKToKICBQQ0k6IGR3 YzogUmVtb3ZlIGRldl9lcnIoKSB3aGVuIGhhbmRpbmcgYW4gZXJyb3IgZnJvbQogICAgcGxhdGZv cm1fZ2V0X2lycSgpCiAgUENJOiBtb2JpdmVpbDogUmVtb3ZlIGRldl9lcnIoKSB3aGVuIGhhbmRp bmcgYW4gZXJyb3IgZnJvbQogICAgcGxhdGZvcm1fZ2V0X2lycSgpCiAgUENJOiB0ZWdyYTogUmVt b3ZlIGRldl9lcnIoKSB3aGVuIGhhbmRpbmcgYW4gZXJyb3IgZnJvbQogICAgcGxhdGZvcm1fZ2V0 X2lycSgpCiAgUENJOiBhbHRlcmE6IFJlbW92ZSBkZXZfZXJyKCkgd2hlbiBoYW5kaW5nIGFuIGVy cm9yIGZyb20KICAgIHBsYXRmb3JtX2dldF9pcnEoKQogIFBDSTogaG9zdC1nZW5lcmljOiBSZW1v dmUgZGV2X2VycigpIHdoZW4gaGFuZGluZyBhbiBlcnJvciBmcm9tCiAgICBwbGF0Zm9ybV9nZXRf aXJxKCkKICBQQ0k6IHYzLXNlbWk6IFJlbW92ZSBkZXZfZXJyKCkgd2hlbiBoYW5kaW5nIGFuIGVy cm9yIGZyb20KICAgIHBsYXRmb3JtX2dldF9pcnEoKQogIFBDSTogYWx0ZXJhLW1zaTogUmVtb3Zl IGRldl9lcnIoKSB3aGVuIGhhbmRpbmcgYW4gZXJyb3IgZnJvbQogICAgcGxhdGZvcm1fZ2V0X2ly cSgpCiAgUENJOiB4Z2VuZS1tc2k6IFJlbW92ZSBkZXZfZXJyKCkgd2hlbiBoYW5kaW5nIGFuIGVy cm9yIGZyb20KICAgIHBsYXRmb3JtX2dldF9pcnEoKQogIFBDSTogcm9ja2NoaXA6IFJlbW92ZSBk ZXZfZXJyKCkgd2hlbiBoYW5kaW5nIGFuIGVycm9yIGZyb20KICAgIHBsYXRmb3JtX2dldF9pcnEo KQogIFBDSTogeGlsaW54LW53bDogUmVtb3ZlIGRldl9lcnIoKSB3aGVuIGhhbmRpbmcgYW4gZXJy b3IgZnJvbQogICAgcGxhdGZvcm1fZ2V0X2lycSgpCgogZHJpdmVycy9wY2kvY29udHJvbGxlci9k d2MvcGNpLWRyYTd4eC5jICAgICAgICAgICAgICB8ICA4ICsrLS0tLS0tCiBkcml2ZXJzL3BjaS9j b250cm9sbGVyL2R3Yy9wY2ktZXh5bm9zLmMgICAgICAgICAgICAgIHwgIDkgKysrLS0tLS0tCiBk cml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jICAgICAgICAgICAgICAgIHwgIDQg Ky0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWtleXN0b25lLmMgICAgICAgICAg ICB8ICA0ICstLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1tZXNvbi5jICAgICAg ICAgICAgICAgfCAgNCArLS0tCiBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWFybWFk YThrLmMgICAgICAgICAgIHwgIDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNp ZS1hcnRwZWM2LmMgICAgICAgICAgICB8ICA0ICstLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIv ZHdjL3BjaWUtaGlzdGIuYyAgICAgICAgICAgICAgfCAgNCArLS0tCiBkcml2ZXJzL3BjaS9jb250 cm9sbGVyL2R3Yy9wY2llLWtpcmluLmMgICAgICAgICAgICAgIHwgIDUgKy0tLS0KIGRyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtc3BlYXIxM3h4LmMgICAgICAgICAgfCAgNSArKy0tLQog ZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS10ZWdyYTE5NC5jICAgICAgICAgICB8ICA0 ICstLS0KIC4uLi9wY2kvY29udHJvbGxlci9tb2JpdmVpbC9wY2llLWxheWVyc2NhcGUtZ2VuNC5j ICAgfCAgNSArKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9tb2JpdmVpbC9wY2llLW1vYml2 ZWlsLWhvc3QuYyB8ICA0ICstLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLXRlZ3JhLmMg ICAgICAgICAgICAgICAgICAgfCAgOCArKy0tLS0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9w Y2ktdjMtc2VtaS5jICAgICAgICAgICAgICAgICB8ICA1ICsrLS0tCiBkcml2ZXJzL3BjaS9jb250 cm9sbGVyL3BjaS14Z2VuZS1tc2kuYyAgICAgICAgICAgICAgIHwgIDIgLS0KIGRyaXZlcnMvcGNp L2NvbnRyb2xsZXIvcGNpZS1hbHRlcmEtbXNpLmMgICAgICAgICAgICAgfCAgMSAtCiBkcml2ZXJz L3BjaS9jb250cm9sbGVyL3BjaWUtYWx0ZXJhLmMgICAgICAgICAgICAgICAgIHwgIDQgKy0tLQog ZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2llLXJvY2tjaGlwLWhvc3QuYyAgICAgICAgICB8IDEy ICsrKy0tLS0tLS0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2llLXRhbmdvLmMgICAgICAg ICAgICAgICAgICB8ICA0ICstLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpZS14aWxpbngt bndsLmMgICAgICAgICAgICAgfCAxMSArKy0tLS0tLS0tLQogMjEgZmlsZXMgY2hhbmdlZCwgMjkg aW5zZXJ0aW9ucygrKSwgODIgZGVsZXRpb25zKC0pCgotLSAKMi4yNy4wCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=