From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43776C433E0 for ; Sun, 2 Aug 2020 14:26:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 062BC20759 for ; Sun, 2 Aug 2020 14:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T+59EXIY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 062BC20759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DswWQWoh+SEluEDpHzbIAXdI5ow6xk+0z3O8TXukG+M=; b=T+59EXIYUTSFHb+EbYeb1xoLI 3AHZWU2FGwgMwUHy4Gkks0m1scgppXCEf2fY5sCWFFQMUMZY+kemaJWUCx9UxosR6nfpFUQDjSF6x ZeGSUfaj+Yciy7qBrcK9y/gkr3UKwaoOXDp/pnkFEBLDpcqt/IVr5wYf5Ng6DtBpS2K1c82yzqjf/ JedSgWL4b2UxvKYTBXhcwlkwWiHrRtQHw7jlDWqkf21t+jzRvM5jpDzdwKIvizeu8HFsr469qp1jk QhTJe4ylxyF2f7m1jjoOsKfzSwNGxhWfgzmg6h7wl+50UOXfIeUxJNVIcHrE1Utclg31IxkSQU6/E WarD87E8g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2EwK-00073T-JH; Sun, 02 Aug 2020 14:26:16 +0000 Received: from mail-lj1-f195.google.com ([209.85.208.195]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2EwC-0006zF-Eh; Sun, 02 Aug 2020 14:26:09 +0000 Received: by mail-lj1-f195.google.com with SMTP id v9so2518269ljk.6; Sun, 02 Aug 2020 07:26:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SHzQyIKtZT048lWcLoYtmM5+43kERVs82uFH/nxs4dE=; b=k2pcYRi+7E7uW442xq2GYSdDfs0TsfdKvFMqjbJNJZD4wwimV9HO3QuRddXwHTtMaq x4DMQezplxBD6H5g7pPZDPAFLvRJBMt/ugCmGi6BNPXMvZpXvCSSHrDL/Et//h48gMKq lJ6FzoAKjj+VXDeqRI9Pn0xaR+pX/FHaA8krA43XvlRFtAY5x2jiOc5q7JzeAZdbgIOc ShWqFe9w22Om7/mS6pad6S/Evp6oQxLbiKBxjEhMNY9qnhISjrcGd6R8GsHd/lYcf5VJ FfYbwEK3GmKtwGHKOgIhDMTJSjLgz3fnZFCaynbD7Tg4AYuYAO2twtVbGZm+qmyflwHs EsPg== X-Gm-Message-State: AOAM531Zgo7HuEJ5eTonpSuHm95/3YiZokdO3Tr94fuk8YlCA/zfBIy/ /BBXugWzpzmDrjp5T6nTILw= X-Google-Smtp-Source: ABdhPJw9KYywa8ZVGNdkCZs9dJSVD2eLeBxLICm3DHiWvDH9oOY7/rpOjkFQkoP+VW0PAFb9uso9fw== X-Received: by 2002:a2e:9dd3:: with SMTP id x19mr2085928ljj.459.1596378365310; Sun, 02 Aug 2020 07:26:05 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id 193sm4214136lfa.90.2020.08.02.07.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 07:26:04 -0700 (PDT) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Subject: [PATCH 01/10] PCI: dwc: Remove dev_err() when handing an error from platform_get_irq() Date: Sun, 2 Aug 2020 14:25:53 +0000 Message-Id: <20200802142601.1635926-2-kw@linux.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200802142601.1635926-1-kw@linux.com> References: <20200802142601.1635926-1-kw@linux.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200802_102608_591821_960D1295 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-pci@vger.kernel.org, Shawn Lin , Binghui Wang , linux-arm-kernel@axis.com, Ley Foon Tan , Thomas Petazzoni , Toan Le , Jesper Nilsson , linux-samsung-soc@vger.kernel.org, Kevin Hilman , Pratyush Anand , Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Kukjin Kim , Xiaowei Song , Hou Zhiqiang , Linus Walleij , Richard Zhu , Sascha Hauer , Yue Wang , Murali Karicheri , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingoo Han , rfi@lists.rocketboards.org, Shawn Guo , Lucas Stach Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhlcmUgaXMgbm8gbmVlZCB0byBjYWxsIHRoZSBkZXZfZXJyKCkgZnVuY3Rpb24gZGlyZWN0bHkg dG8gcHJpbnQgYQpjdXN0b20gbWVzc2FnZSB3aGVuIGhhbmRsaW5nIGFuIGVycm9yIGZyb20gZWl0 aGVyIHRoZSBwbGF0Zm9ybV9nZXRfaXJxKCkKb3IgcGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUoKSBm dW5jdGlvbnMgYXMgYm90aCBhcmUgZ29pbmcgdG8gZGlzcGxheSBhbgphcHByb3ByaWF0ZSBlcnJv ciBtZXNzYWdlIGluIGNhc2Ugb2YgYSBmYWlsdXJlLgoKVGhpcyBjaGFuZ2UgaXMgYXMgcGVyIHN1 Z2dlc3Rpb24gZnJvbSBDb2NjaW5lbGxlOgoKICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2llLWFybWFkYThrLmM6MjUyOjItOTogbGluZSAyNTIgaXMKICByZWR1bmRhbnQgYmVjYXVzZSBw bGF0Zm9ybV9nZXRfaXJxKCkgYWxyZWFkeSBwcmludHMgYW4gZXJyb3IKCiAgZHJpdmVycy9wY2kv Y29udHJvbGxlci9kd2MvcGNpZS1raXJpbi5jOjQ1OTozLTEwOiBsaW5lIDQ1OSBpcwogIHJlZHVu ZGFudCBiZWNhdXNlIHBsYXRmb3JtX2dldF9pcnEoKSBhbHJlYWR5IHByaW50cyBhbiBlcnJvcgoK ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jOjg3MjozLTEwOiBsaW5lIDg3 MiBpcyByZWR1bmRhbnQKICBiZWNhdXNlIHBsYXRmb3JtX2dldF9pcnEoKSBhbHJlYWR5IHByaW50 cyBhbiBlcnJvcgoKICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWFydHBlYzYuYzoz OTE6My0xMDogbGluZSAzOTEgaXMKICByZWR1bmRhbnQgYmVjYXVzZSBwbGF0Zm9ybV9nZXRfaXJx KCkgYWxyZWFkeSBwcmludHMgYW4gZXJyb3IKCiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2Mv cGNpZS1zcGVhcjEzeHguYzoyMDI6Mi05OiBsaW5lIDIwMiBpcwogIHJlZHVuZGFudCBiZWNhdXNl IHBsYXRmb3JtX2dldF9pcnEoKSBhbHJlYWR5IHByaW50cyBhbiBlcnJvcgoKICBkcml2ZXJzL3Bj aS9jb250cm9sbGVyL2R3Yy9wY2kta2V5c3RvbmUuYzoxMjU0OjItOTogbGluZSAxMjU0IGlzCiAg cmVkdW5kYW50IGJlY2F1c2UgcGxhdGZvcm1fZ2V0X2lycSgpIGFscmVhZHkgcHJpbnRzIGFuIGVy cm9yCgogIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1leHlub3MuYzo0MDY6Mi05OiBs aW5lIDQwNiBpcyByZWR1bmRhbnQKICBiZWNhdXNlIHBsYXRmb3JtX2dldF9pcnEoKSBhbHJlYWR5 IHByaW50cyBhbiBlcnJvcgoKICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktZXh5bm9z LmM6NDE5OjMtMTA6IGxpbmUgNDE5IGlzCiAgcmVkdW5kYW50IGJlY2F1c2UgcGxhdGZvcm1fZ2V0 X2lycSgpIGFscmVhZHkgcHJpbnRzIGFuIGVycm9yCgogIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIv ZHdjL3BjaWUtdGVncmExOTQuYzoyMTkzOjItOTogbGluZSAyMTkzIGlzCiAgcmVkdW5kYW50IGJl Y2F1c2UgcGxhdGZvcm1fZ2V0X2lycSgpIGFscmVhZHkgcHJpbnRzIGFuIGVycm9yCgogIGRyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtaGlzdGIuYzo0MDY6My0xMDogbGluZSA0MDYgaXMK ICByZWR1bmRhbnQgYmVjYXVzZSBwbGF0Zm9ybV9nZXRfaXJxKCkgYWxyZWFkeSBwcmludHMgYW4g ZXJyb3IKCiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLW1lc29uLmM6NDkyOjMtMTA6 IGxpbmUgNDkyIGlzIHJlZHVuZGFudAogIGJlY2F1c2UgcGxhdGZvcm1fZ2V0X2lycSgpIGFscmVh ZHkgcHJpbnRzIGFuIGVycm9yCgogIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1kcmE3 eHguYzo2MzM6Mi05OiBsaW5lIDYzMyBpcyByZWR1bmRhbnQKICBiZWNhdXNlIHBsYXRmb3JtX2dl dF9pcnEoKSBhbHJlYWR5IHByaW50cyBhbiBlcnJvcgoKICBkcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2ktZHJhN3h4LmM6ODc1OjItOTogbGluZSA4NzUgaXMgcmVkdW5kYW50CiAgYmVjYXVz ZSBwbGF0Zm9ybV9nZXRfaXJxKCkgYWxyZWFkeSBwcmludHMgYW4gZXJyb3IKClN1Z2dlc3RlZC1i eTogQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNvbT4KU2lnbmVkLW9mZi1ieTogS3J6 eXN6dG9mIFdpbGN6ecWEc2tpIDxrd0BsaW51eC5jb20+Ci0tLQogZHJpdmVycy9wY2kvY29udHJv bGxlci9kd2MvcGNpLWRyYTd4eC5jICAgICB8IDggKystLS0tLS0KIGRyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaS1leHlub3MuYyAgICAgfCA5ICsrKy0tLS0tLQogZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpLWlteDYuYyAgICAgICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJv bGxlci9kd2MvcGNpLWtleXN0b25lLmMgICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxl ci9kd2MvcGNpLW1lc29uLmMgICAgICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9k d2MvcGNpZS1hcm1hZGE4ay5jICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2Mv cGNpZS1hcnRwZWM2LmMgICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNp ZS1oaXN0Yi5jICAgICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1r aXJpbi5jICAgICB8IDUgKy0tLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtc3Bl YXIxM3h4LmMgfCA1ICsrLS0tCiBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXRlZ3Jh MTk0LmMgIHwgNCArLS0tCiAxMSBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA0MCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2kt ZHJhN3h4LmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktZHJhN3h4LmMKaW5kZXgg NjE4NGViYzkzOTJkLi42NjQ2NWRkNjk4NTggMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaS1kcmE3eHguYworKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2ktZHJhN3h4LmMKQEAgLTYyOSwxMCArNjI5LDggQEAgc3RhdGljIGludCBfX2luaXQgZHJhN3h4 X2FkZF9wY2llX3BvcnQoc3RydWN0IGRyYTd4eF9wY2llICpkcmE3eHgsCiAJc3RydWN0IHJlc291 cmNlICpyZXM7CiAKIAlwcC0+aXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAxKTsKLQlpZiAo cHAtPmlycSA8IDApIHsKLQkJZGV2X2VycihkZXYsICJtaXNzaW5nIElSUSByZXNvdXJjZVxuIik7 CisJaWYgKHBwLT5pcnEgPCAwKQogCQlyZXR1cm4gcHAtPmlycTsKLQl9CiAKIAlyZXQgPSBkcmE3 eHhfcGNpZV9pbml0X2lycV9kb21haW4ocHApOwogCWlmIChyZXQgPCAwKQpAQCAtODcxLDEwICs4 NjksOCBAQCBzdGF0aWMgaW50IF9faW5pdCBkcmE3eHhfcGNpZV9wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQogCXBjaS0+b3BzID0gJmR3X3BjaWVfb3BzOwogCiAJaXJxID0gcGxh dGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKLQlpZiAoaXJxIDwgMCkgewotCQlkZXZfZXJyKGRldiwg Im1pc3NpbmcgSVJRIHJlc291cmNlOiAlZFxuIiwgaXJxKTsKKwlpZiAoaXJxIDwgMCkKIAkJcmV0 dXJuIGlycTsKLQl9CiAKIAliYXNlID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlX2J5 bmFtZShwZGV2LCAidGlfY29uZiIpOwogCWlmIChJU19FUlIoYmFzZSkpCmRpZmYgLS1naXQgYS9k cml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktZXh5bm9zLmMgYi9kcml2ZXJzL3BjaS9jb250 cm9sbGVyL2R3Yy9wY2ktZXh5bm9zLmMKaW5kZXggYzUwNDNkOTUxZTgwLi5mNzIxZmRkYzUyMWUg MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1leHlub3MuYworKysg Yi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktZXh5bm9zLmMKQEAgLTQwMiwxMCArNDAy LDkgQEAgc3RhdGljIGludCBfX2luaXQgZXh5bm9zX2FkZF9wY2llX3BvcnQoc3RydWN0IGV4eW5v c19wY2llICplcCwKIAlpbnQgcmV0OwogCiAJcHAtPmlycSA9IHBsYXRmb3JtX2dldF9pcnEocGRl diwgMSk7Ci0JaWYgKHBwLT5pcnEgPCAwKSB7Ci0JCWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIGdl dCBpcnFcbiIpOworCWlmIChwcC0+aXJxIDwgMCkKIAkJcmV0dXJuIHBwLT5pcnE7Ci0JfQorCiAJ cmV0ID0gZGV2bV9yZXF1ZXN0X2lycShkZXYsIHBwLT5pcnEsIGV4eW5vc19wY2llX2lycV9oYW5k bGVyLAogCQkJCUlSUUZfU0hBUkVELCAiZXh5bm9zLXBjaWUiLCBlcCk7CiAJaWYgKHJldCkgewpA QCAtNDE1LDEwICs0MTQsOCBAQCBzdGF0aWMgaW50IF9faW5pdCBleHlub3NfYWRkX3BjaWVfcG9y dChzdHJ1Y3QgZXh5bm9zX3BjaWUgKmVwLAogCiAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1BDSV9N U0kpKSB7CiAJCXBwLT5tc2lfaXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKLQkJaWYg KHBwLT5tc2lfaXJxIDwgMCkgewotCQkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gZ2V0IG1zaSBp cnFcbiIpOworCQlpZiAocHAtPm1zaV9pcnEgPCAwKQogCQkJcmV0dXJuIHBwLT5tc2lfaXJxOwot CQl9CiAJfQogCiAJcHAtPm9wcyA9ICZleHlub3NfcGNpZV9ob3N0X29wczsKZGlmZiAtLWdpdCBh L2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMgYi9kcml2ZXJzL3BjaS9jb250 cm9sbGVyL2R3Yy9wY2ktaW14Ni5jCmluZGV4IDhmMDhhZTUzZjUzZS4uYWJhMGExNTE0YTg2IDEw MDY0NAotLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jCisrKyBiL2Ry aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMKQEAgLTg2OCwxMCArODY4LDggQEAg c3RhdGljIGludCBpbXg2X2FkZF9wY2llX3BvcnQoc3RydWN0IGlteDZfcGNpZSAqaW14Nl9wY2ll LAogCiAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1BDSV9NU0kpKSB7CiAJCXBwLT5tc2lfaXJxID0g cGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUocGRldiwgIm1zaSIpOwotCQlpZiAocHAtPm1zaV9pcnEg PCAwKSB7Ci0JCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgTVNJIGlycVxuIik7CisJCWlm IChwcC0+bXNpX2lycSA8IDApCiAJCQlyZXR1cm4gcHAtPm1zaV9pcnE7Ci0JCX0KIAl9CiAKIAlw cC0+b3BzID0gJmlteDZfcGNpZV9ob3N0X29wczsKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2Nv bnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2Mv cGNpLWtleXN0b25lLmMKaW5kZXggNzkwNjc5ZmRmYTQ4Li45OWRmOWFlZWNlMWYgMTAwNjQ0Ci0t LSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5jCisrKyBiL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5jCkBAIC0xMjUwLDEwICsxMjUwLDgg QEAgc3RhdGljIGludCBfX2luaXQga3NfcGNpZV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQogCXBjaS0+dmVyc2lvbiA9IHZlcnNpb247CiAKIAlpcnEgPSBwbGF0Zm9ybV9nZXRf aXJxKHBkZXYsIDApOwotCWlmIChpcnEgPCAwKSB7Ci0JCWRldl9lcnIoZGV2LCAibWlzc2luZyBJ UlEgcmVzb3VyY2U6ICVkXG4iLCBpcnEpOworCWlmIChpcnEgPCAwKQogCQlyZXR1cm4gaXJxOwot CX0KIAogCXJldCA9IHJlcXVlc3RfaXJxKGlycSwga3NfcGNpZV9lcnJfaXJxX2hhbmRsZXIsIElS UUZfU0hBUkVELAogCQkJICAia3MtcGNpZS1lcnJvci1pcnEiLCBrc19wY2llKTsKZGlmZiAtLWdp dCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1tZXNvbi5jIGIvZHJpdmVycy9wY2kv Y29udHJvbGxlci9kd2MvcGNpLW1lc29uLmMKaW5kZXggY2E1OWJhOWUwZWNkLi40ZjE4M2I5NmFm YmIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1tZXNvbi5jCisr KyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1tZXNvbi5jCkBAIC00ODgsMTAgKzQ4 OCw4IEBAIHN0YXRpYyBpbnQgbWVzb25fYWRkX3BjaWVfcG9ydChzdHJ1Y3QgbWVzb25fcGNpZSAq bXAsCiAKIAlpZiAoSVNfRU5BQkxFRChDT05GSUdfUENJX01TSSkpIHsKIAkJcHAtPm1zaV9pcnEg PSBwbGF0Zm9ybV9nZXRfaXJxKHBkZXYsIDApOwotCQlpZiAocHAtPm1zaV9pcnEgPCAwKSB7Ci0J CQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgTVNJIElSUVxuIik7CisJCWlmIChwcC0+bXNp X2lycSA8IDApCiAJCQlyZXR1cm4gcHAtPm1zaV9pcnE7Ci0JCX0KIAl9CiAKIAlwcC0+b3BzID0g Jm1lc29uX3BjaWVfaG9zdF9vcHM7CmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2llLWFybWFkYThrLmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWFy bWFkYThrLmMKaW5kZXggNDk1OTY1NDdlOGMyLi42NmVjMjFjZDk0ODcgMTAwNjQ0Ci0tLSBhL2Ry aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtYXJtYWRhOGsuYworKysgYi9kcml2ZXJzL3Bj aS9jb250cm9sbGVyL2R3Yy9wY2llLWFybWFkYThrLmMKQEAgLTI0OCwxMCArMjQ4LDggQEAgc3Rh dGljIGludCBhcm1hZGE4a19hZGRfcGNpZV9wb3J0KHN0cnVjdCBhcm1hZGE4a19wY2llICpwY2ll LAogCXBwLT5vcHMgPSAmYXJtYWRhOGtfcGNpZV9ob3N0X29wczsKIAogCXBwLT5pcnEgPSBwbGF0 Zm9ybV9nZXRfaXJxKHBkZXYsIDApOwotCWlmIChwcC0+aXJxIDwgMCkgewotCQlkZXZfZXJyKGRl diwgImZhaWxlZCB0byBnZXQgaXJxIGZvciBwb3J0XG4iKTsKKwlpZiAocHAtPmlycSA8IDApCiAJ CXJldHVybiBwcC0+aXJxOwotCX0KIAogCXJldCA9IGRldm1fcmVxdWVzdF9pcnEoZGV2LCBwcC0+ aXJxLCBhcm1hZGE4a19wY2llX2lycV9oYW5kbGVyLAogCQkJICAgICAgIElSUUZfU0hBUkVELCAi YXJtYWRhOGstcGNpZSIsIHBjaWUpOwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxl ci9kd2MvcGNpZS1hcnRwZWM2LmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWFy dHBlYzYuYwppbmRleCAyOGQ1YTEwOTUyMDAuLmQ0MjliZDJiMjQwNiAxMDA2NDQKLS0tIGEvZHJp dmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1hcnRwZWM2LmMKKysrIGIvZHJpdmVycy9wY2kv Y29udHJvbGxlci9kd2MvcGNpZS1hcnRwZWM2LmMKQEAgLTM4NywxMCArMzg3LDggQEAgc3RhdGlj IGludCBhcnRwZWM2X2FkZF9wY2llX3BvcnQoc3RydWN0IGFydHBlYzZfcGNpZSAqYXJ0cGVjNl9w Y2llLAogCiAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1BDSV9NU0kpKSB7CiAJCXBwLT5tc2lfaXJx ID0gcGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUocGRldiwgIm1zaSIpOwotCQlpZiAocHAtPm1zaV9p cnEgPCAwKSB7Ci0JCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgTVNJIGlycVxuIik7CisJ CWlmIChwcC0+bXNpX2lycSA8IDApCiAJCQlyZXR1cm4gcHAtPm1zaV9pcnE7Ci0JCX0KIAl9CiAK IAlwcC0+b3BzID0gJmFydHBlYzZfcGNpZV9ob3N0X29wczsKZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtaGlzdGIuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIv ZHdjL3BjaWUtaGlzdGIuYwppbmRleCA4MTFiNWM2ZDYyZWEuLjAwNjQzN2VhZGMzMSAxMDA2NDQK LS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1oaXN0Yi5jCisrKyBiL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtaGlzdGIuYwpAQCAtNDAyLDEwICs0MDIsOCBAQCBz dGF0aWMgaW50IGhpc3RiX3BjaWVfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikK IAogCWlmIChJU19FTkFCTEVEKENPTkZJR19QQ0lfTVNJKSkgewogCQlwcC0+bXNpX2lycSA9IHBs YXRmb3JtX2dldF9pcnFfYnluYW1lKHBkZXYsICJtc2kiKTsKLQkJaWYgKHBwLT5tc2lfaXJxIDwg MCkgewotCQkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0IE1TSSBJUlFcbiIpOworCQlpZiAo cHAtPm1zaV9pcnEgPCAwKQogCQkJcmV0dXJuIHBwLT5tc2lfaXJxOwotCQl9CiAJfQogCiAJaGlw Y2llLT5waHkgPSBkZXZtX3BoeV9nZXQoZGV2LCAicGh5Iik7CmRpZmYgLS1naXQgYS9kcml2ZXJz L3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWtpcmluLmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2llLWtpcmluLmMKaW5kZXggYzE5NjE3YTkxMmJkLi4yZTAxODFjZTY4OTUgMTAwNjQ0 Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUta2lyaW4uYworKysgYi9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWtpcmluLmMKQEAgLTQ1NSwxMSArNDU1LDggQEAg c3RhdGljIGludCBraXJpbl9wY2llX2FkZF9tc2koc3RydWN0IGR3X3BjaWUgKnBjaSwKIAogCWlm IChJU19FTkFCTEVEKENPTkZJR19QQ0lfTVNJKSkgewogCQlpcnEgPSBwbGF0Zm9ybV9nZXRfaXJx KHBkZXYsIDApOwotCQlpZiAoaXJxIDwgMCkgewotCQkJZGV2X2VycigmcGRldi0+ZGV2LAotCQkJ CSJmYWlsZWQgdG8gZ2V0IE1TSSBJUlEgKCVkKVxuIiwgaXJxKTsKKwkJaWYgKGlycSA8IDApCiAJ CQlyZXR1cm4gaXJxOwotCQl9CiAKIAkJcGNpLT5wcC5tc2lfaXJxID0gaXJxOwogCX0KZGlmZiAt LWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtc3BlYXIxM3h4LmMgYi9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXNwZWFyMTN4eC5jCmluZGV4IDdkMGNkZmQ4MTM4 Yi4uYWQ1ZDA4ZDE5OTI2IDEwMDY0NAotLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2llLXNwZWFyMTN4eC5jCisrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtc3Bl YXIxM3h4LmMKQEAgLTE5OCwxMCArMTk4LDkgQEAgc3RhdGljIGludCBzcGVhcjEzeHhfYWRkX3Bj aWVfcG9ydChzdHJ1Y3Qgc3BlYXIxM3h4X3BjaWUgKnNwZWFyMTN4eF9wY2llLAogCWludCByZXQ7 CiAKIAlwcC0+aXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKLQlpZiAocHAtPmlycSA8 IDApIHsKLQkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gZ2V0IGlycVxuIik7CisJaWYgKHBwLT5p cnEgPCAwKQogCQlyZXR1cm4gcHAtPmlycTsKLQl9CisKIAlyZXQgPSBkZXZtX3JlcXVlc3RfaXJx KGRldiwgcHAtPmlycSwgc3BlYXIxM3h4X3BjaWVfaXJxX2hhbmRsZXIsCiAJCQkgICAgICAgSVJR Rl9TSEFSRUQgfCBJUlFGX05PX1RIUkVBRCwKIAkJCSAgICAgICAic3BlYXIxMzQwLXBjaWUiLCBz cGVhcjEzeHhfcGNpZSk7CmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2llLXRlZ3JhMTk0LmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXRlZ3JhMTk0 LmMKaW5kZXggOTJiNzdmN2Q4MzU0Li43MDQ5ODY4OWQwYzAgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtdGVncmExOTQuYworKysgYi9kcml2ZXJzL3BjaS9jb250 cm9sbGVyL2R3Yy9wY2llLXRlZ3JhMTk0LmMKQEAgLTIxODksMTAgKzIxODksOCBAQCBzdGF0aWMg aW50IHRlZ3JhX3BjaWVfZHdfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAl9 CiAKIAlwcC0+aXJxID0gcGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUocGRldiwgImludHIiKTsKLQlp ZiAocHAtPmlycSA8IDApIHsKLQkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0IFwiaW50clwi IGludGVycnVwdFxuIik7CisJaWYgKHBwLT5pcnEgPCAwKQogCQlyZXR1cm4gcHAtPmlycTsKLQl9 CiAKIAlwY2llLT5icG1wID0gdGVncmFfYnBtcF9nZXQoZGV2KTsKIAlpZiAoSVNfRVJSKHBjaWUt PmJwbXApKQotLSAKMi4yNy4wCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF005C433E4 for ; Sun, 2 Aug 2020 14:26:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C00BF2075B for ; Sun, 2 Aug 2020 14:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726361AbgHBO0L (ORCPT ); Sun, 2 Aug 2020 10:26:11 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:38585 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726300AbgHBO0J (ORCPT ); Sun, 2 Aug 2020 10:26:09 -0400 Received: by mail-lj1-f194.google.com with SMTP id x9so37042930ljc.5; Sun, 02 Aug 2020 07:26:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SHzQyIKtZT048lWcLoYtmM5+43kERVs82uFH/nxs4dE=; b=Aac6+9cBjjArbp4iNhOOScUNPADybFYl9lIRys45xADDhdpxX4qgqO4wxfS4Ginh7y KX/mr2fZ33X6Ip9tku0RW/GbnhCY1ozDylpADkLst/1r1EIANtlGOk8/vSAu+jzb/uc1 Nh6GiYHVjH0sULW6nvo7CePCVZgXLEsIA2gjKtzpt/pwU/LhgSQKQHo1EsW+a9NUNDEp YiMl7aXbdNFciN9l1MZmhW9hTSDvx309GrSS0lIotUFKpAfP+GQbsPTMsKAtYZqBCIfP Fvy+Xgv4BZHshUXpYG5sh53vZwHMsv7gPA9SH9AswgWbMGJUoThSoeGv8r13ZaDbV7Be /FBw== X-Gm-Message-State: AOAM531tSOX/WPTmATwNjk9RN1ZTje7qvXibkm4SrdmJZVJGjEB3/lcw 3CgAnSjOzGOXYYWTS3Wdogc= X-Google-Smtp-Source: ABdhPJw9KYywa8ZVGNdkCZs9dJSVD2eLeBxLICm3DHiWvDH9oOY7/rpOjkFQkoP+VW0PAFb9uso9fw== X-Received: by 2002:a2e:9dd3:: with SMTP id x19mr2085928ljj.459.1596378365310; Sun, 02 Aug 2020 07:26:05 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id 193sm4214136lfa.90.2020.08.02.07.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 07:26:04 -0700 (PDT) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Jingoo Han , Kukjin Kim , Krzysztof Kozlowski , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Murali Karicheri , Yue Wang , Kevin Hilman , Thomas Petazzoni , Jesper Nilsson , Xiaowei Song , Binghui Wang , Pratyush Anand , Hou Zhiqiang , Linus Walleij , Toan Le , Ley Foon Tan , Shawn Lin , Heiko Stuebner , linux-amlogic@lists.infradead.org, linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, rfi@lists.rocketboards.org Subject: [PATCH 01/10] PCI: dwc: Remove dev_err() when handing an error from platform_get_irq() Date: Sun, 2 Aug 2020 14:25:53 +0000 Message-Id: <20200802142601.1635926-2-kw@linux.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200802142601.1635926-1-kw@linux.com> References: <20200802142601.1635926-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. This change is as per suggestion from Coccinelle: drivers/pci/controller/dwc/pcie-armada8k.c:252:2-9: line 252 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-kirin.c:459:3-10: line 459 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-imx6.c:872:3-10: line 872 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-artpec6.c:391:3-10: line 391 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-spear13xx.c:202:2-9: line 202 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-keystone.c:1254:2-9: line 1254 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-exynos.c:406:2-9: line 406 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-exynos.c:419:3-10: line 419 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-tegra194.c:2193:2-9: line 2193 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-histb.c:406:3-10: line 406 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-meson.c:492:3-10: line 492 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-dra7xx.c:633:2-9: line 633 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-dra7xx.c:875:2-9: line 875 is redundant because platform_get_irq() already prints an error Suggested-by: Bjorn Helgaas Signed-off-by: Krzysztof Wilczyński --- drivers/pci/controller/dwc/pci-dra7xx.c | 8 ++------ drivers/pci/controller/dwc/pci-exynos.c | 9 +++------ drivers/pci/controller/dwc/pci-imx6.c | 4 +--- drivers/pci/controller/dwc/pci-keystone.c | 4 +--- drivers/pci/controller/dwc/pci-meson.c | 4 +--- drivers/pci/controller/dwc/pcie-armada8k.c | 4 +--- drivers/pci/controller/dwc/pcie-artpec6.c | 4 +--- drivers/pci/controller/dwc/pcie-histb.c | 4 +--- drivers/pci/controller/dwc/pcie-kirin.c | 5 +---- drivers/pci/controller/dwc/pcie-spear13xx.c | 5 ++--- drivers/pci/controller/dwc/pcie-tegra194.c | 4 +--- 11 files changed, 15 insertions(+), 40 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 6184ebc9392d..66465dd69858 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -629,10 +629,8 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx, struct resource *res; pp->irq = platform_get_irq(pdev, 1); - if (pp->irq < 0) { - dev_err(dev, "missing IRQ resource\n"); + if (pp->irq < 0) return pp->irq; - } ret = dra7xx_pcie_init_irq_domain(pp); if (ret < 0) @@ -871,10 +869,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) pci->ops = &dw_pcie_ops; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "missing IRQ resource: %d\n", irq); + if (irq < 0) return irq; - } base = devm_platform_ioremap_resource_byname(pdev, "ti_conf"); if (IS_ERR(base)) diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c index c5043d951e80..f721fddc521e 100644 --- a/drivers/pci/controller/dwc/pci-exynos.c +++ b/drivers/pci/controller/dwc/pci-exynos.c @@ -402,10 +402,9 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep, int ret; pp->irq = platform_get_irq(pdev, 1); - if (pp->irq < 0) { - dev_err(dev, "failed to get irq\n"); + if (pp->irq < 0) return pp->irq; - } + ret = devm_request_irq(dev, pp->irq, exynos_pcie_irq_handler, IRQF_SHARED, "exynos-pcie", ep); if (ret) { @@ -415,10 +414,8 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep, if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq(pdev, 0); - if (pp->msi_irq < 0) { - dev_err(dev, "failed to get msi irq\n"); + if (pp->msi_irq < 0) return pp->msi_irq; - } } pp->ops = &exynos_pcie_host_ops; diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 8f08ae53f53e..aba0a1514a86 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -868,10 +868,8 @@ static int imx6_add_pcie_port(struct imx6_pcie *imx6_pcie, if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq_byname(pdev, "msi"); - if (pp->msi_irq < 0) { - dev_err(dev, "failed to get MSI irq\n"); + if (pp->msi_irq < 0) return pp->msi_irq; - } } pp->ops = &imx6_pcie_host_ops; diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 790679fdfa48..99df9aeece1f 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -1250,10 +1250,8 @@ static int __init ks_pcie_probe(struct platform_device *pdev) pci->version = version; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "missing IRQ resource: %d\n", irq); + if (irq < 0) return irq; - } ret = request_irq(irq, ks_pcie_err_irq_handler, IRQF_SHARED, "ks-pcie-error-irq", ks_pcie); diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c index ca59ba9e0ecd..4f183b96afbb 100644 --- a/drivers/pci/controller/dwc/pci-meson.c +++ b/drivers/pci/controller/dwc/pci-meson.c @@ -488,10 +488,8 @@ static int meson_add_pcie_port(struct meson_pcie *mp, if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq(pdev, 0); - if (pp->msi_irq < 0) { - dev_err(dev, "failed to get MSI IRQ\n"); + if (pp->msi_irq < 0) return pp->msi_irq; - } } pp->ops = &meson_pcie_host_ops; diff --git a/drivers/pci/controller/dwc/pcie-armada8k.c b/drivers/pci/controller/dwc/pcie-armada8k.c index 49596547e8c2..66ec21cd9487 100644 --- a/drivers/pci/controller/dwc/pcie-armada8k.c +++ b/drivers/pci/controller/dwc/pcie-armada8k.c @@ -248,10 +248,8 @@ static int armada8k_add_pcie_port(struct armada8k_pcie *pcie, pp->ops = &armada8k_pcie_host_ops; pp->irq = platform_get_irq(pdev, 0); - if (pp->irq < 0) { - dev_err(dev, "failed to get irq for port\n"); + if (pp->irq < 0) return pp->irq; - } ret = devm_request_irq(dev, pp->irq, armada8k_pcie_irq_handler, IRQF_SHARED, "armada8k-pcie", pcie); diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c index 28d5a1095200..d429bd2b2406 100644 --- a/drivers/pci/controller/dwc/pcie-artpec6.c +++ b/drivers/pci/controller/dwc/pcie-artpec6.c @@ -387,10 +387,8 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie, if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq_byname(pdev, "msi"); - if (pp->msi_irq < 0) { - dev_err(dev, "failed to get MSI irq\n"); + if (pp->msi_irq < 0) return pp->msi_irq; - } } pp->ops = &artpec6_pcie_host_ops; diff --git a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c index 811b5c6d62ea..006437eadc31 100644 --- a/drivers/pci/controller/dwc/pcie-histb.c +++ b/drivers/pci/controller/dwc/pcie-histb.c @@ -402,10 +402,8 @@ static int histb_pcie_probe(struct platform_device *pdev) if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq_byname(pdev, "msi"); - if (pp->msi_irq < 0) { - dev_err(dev, "Failed to get MSI IRQ\n"); + if (pp->msi_irq < 0) return pp->msi_irq; - } } hipcie->phy = devm_phy_get(dev, "phy"); diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c index c19617a912bd..2e0181ce6895 100644 --- a/drivers/pci/controller/dwc/pcie-kirin.c +++ b/drivers/pci/controller/dwc/pcie-kirin.c @@ -455,11 +455,8 @@ static int kirin_pcie_add_msi(struct dw_pcie *pci, if (IS_ENABLED(CONFIG_PCI_MSI)) { irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, - "failed to get MSI IRQ (%d)\n", irq); + if (irq < 0) return irq; - } pci->pp.msi_irq = irq; } diff --git a/drivers/pci/controller/dwc/pcie-spear13xx.c b/drivers/pci/controller/dwc/pcie-spear13xx.c index 7d0cdfd8138b..ad5d08d19926 100644 --- a/drivers/pci/controller/dwc/pcie-spear13xx.c +++ b/drivers/pci/controller/dwc/pcie-spear13xx.c @@ -198,10 +198,9 @@ static int spear13xx_add_pcie_port(struct spear13xx_pcie *spear13xx_pcie, int ret; pp->irq = platform_get_irq(pdev, 0); - if (pp->irq < 0) { - dev_err(dev, "failed to get irq\n"); + if (pp->irq < 0) return pp->irq; - } + ret = devm_request_irq(dev, pp->irq, spear13xx_pcie_irq_handler, IRQF_SHARED | IRQF_NO_THREAD, "spear1340-pcie", spear13xx_pcie); diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c index 92b77f7d8354..70498689d0c0 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -2189,10 +2189,8 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) } pp->irq = platform_get_irq_byname(pdev, "intr"); - if (pp->irq < 0) { - dev_err(dev, "Failed to get \"intr\" interrupt\n"); + if (pp->irq < 0) return pp->irq; - } pcie->bpmp = tegra_bpmp_get(dev); if (IS_ERR(pcie->bpmp)) -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= Subject: [PATCH 01/10] PCI: dwc: Remove dev_err() when handing an error from platform_get_irq() Date: Sun, 2 Aug 2020 14:25:53 +0000 Message-ID: <20200802142601.1635926-2-kw@linux.com> References: <20200802142601.1635926-1-kw@linux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200802142601.1635926-1-kw@linux.com> Sender: linux-pci-owner@vger.kernel.org To: Bjorn Helgaas Cc: Jingoo Han , Kukjin Kim , Krzysztof Kozlowski , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Murali Karicheri , Yue Wang , Kevin Hilman , Thomas Petazzoni , Jesper Nilsson , Xiaowei Song , Binghui Wang , Pratyush Anand , Hou Zhiqiang , Linus Walleij , Toan Le , Ley Foon Tan Shawn Lin List-Id: linux-rockchip.vger.kernel.org There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. This change is as per suggestion from Coccinelle: drivers/pci/controller/dwc/pcie-armada8k.c:252:2-9: line 252 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-kirin.c:459:3-10: line 459 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-imx6.c:872:3-10: line 872 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-artpec6.c:391:3-10: line 391 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-spear13xx.c:202:2-9: line 202 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-keystone.c:1254:2-9: line 1254 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-exynos.c:406:2-9: line 406 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-exynos.c:419:3-10: line 419 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-tegra194.c:2193:2-9: line 2193 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-histb.c:406:3-10: line 406 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-meson.c:492:3-10: line 492 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-dra7xx.c:633:2-9: line 633 is redundant because platform_get_irq() already prints an error drivers/pci/controller/dwc/pci-dra7xx.c:875:2-9: line 875 is redundant because platform_get_irq() already prints an error Suggested-by: Bjorn Helgaas Signed-off-by: Krzysztof Wilczyński --- drivers/pci/controller/dwc/pci-dra7xx.c | 8 ++------ drivers/pci/controller/dwc/pci-exynos.c | 9 +++------ drivers/pci/controller/dwc/pci-imx6.c | 4 +--- drivers/pci/controller/dwc/pci-keystone.c | 4 +--- drivers/pci/controller/dwc/pci-meson.c | 4 +--- drivers/pci/controller/dwc/pcie-armada8k.c | 4 +--- drivers/pci/controller/dwc/pcie-artpec6.c | 4 +--- drivers/pci/controller/dwc/pcie-histb.c | 4 +--- drivers/pci/controller/dwc/pcie-kirin.c | 5 +---- drivers/pci/controller/dwc/pcie-spear13xx.c | 5 ++--- drivers/pci/controller/dwc/pcie-tegra194.c | 4 +--- 11 files changed, 15 insertions(+), 40 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 6184ebc9392d..66465dd69858 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -629,10 +629,8 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx, struct resource *res; pp->irq = platform_get_irq(pdev, 1); - if (pp->irq < 0) { - dev_err(dev, "missing IRQ resource\n"); + if (pp->irq < 0) return pp->irq; - } ret = dra7xx_pcie_init_irq_domain(pp); if (ret < 0) @@ -871,10 +869,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) pci->ops = &dw_pcie_ops; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "missing IRQ resource: %d\n", irq); + if (irq < 0) return irq; - } base = devm_platform_ioremap_resource_byname(pdev, "ti_conf"); if (IS_ERR(base)) diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c index c5043d951e80..f721fddc521e 100644 --- a/drivers/pci/controller/dwc/pci-exynos.c +++ b/drivers/pci/controller/dwc/pci-exynos.c @@ -402,10 +402,9 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep, int ret; pp->irq = platform_get_irq(pdev, 1); - if (pp->irq < 0) { - dev_err(dev, "failed to get irq\n"); + if (pp->irq < 0) return pp->irq; - } + ret = devm_request_irq(dev, pp->irq, exynos_pcie_irq_handler, IRQF_SHARED, "exynos-pcie", ep); if (ret) { @@ -415,10 +414,8 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep, if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq(pdev, 0); - if (pp->msi_irq < 0) { - dev_err(dev, "failed to get msi irq\n"); + if (pp->msi_irq < 0) return pp->msi_irq; - } } pp->ops = &exynos_pcie_host_ops; diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 8f08ae53f53e..aba0a1514a86 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -868,10 +868,8 @@ static int imx6_add_pcie_port(struct imx6_pcie *imx6_pcie, if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq_byname(pdev, "msi"); - if (pp->msi_irq < 0) { - dev_err(dev, "failed to get MSI irq\n"); + if (pp->msi_irq < 0) return pp->msi_irq; - } } pp->ops = &imx6_pcie_host_ops; diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 790679fdfa48..99df9aeece1f 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -1250,10 +1250,8 @@ static int __init ks_pcie_probe(struct platform_device *pdev) pci->version = version; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "missing IRQ resource: %d\n", irq); + if (irq < 0) return irq; - } ret = request_irq(irq, ks_pcie_err_irq_handler, IRQF_SHARED, "ks-pcie-error-irq", ks_pcie); diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c index ca59ba9e0ecd..4f183b96afbb 100644 --- a/drivers/pci/controller/dwc/pci-meson.c +++ b/drivers/pci/controller/dwc/pci-meson.c @@ -488,10 +488,8 @@ static int meson_add_pcie_port(struct meson_pcie *mp, if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq(pdev, 0); - if (pp->msi_irq < 0) { - dev_err(dev, "failed to get MSI IRQ\n"); + if (pp->msi_irq < 0) return pp->msi_irq; - } } pp->ops = &meson_pcie_host_ops; diff --git a/drivers/pci/controller/dwc/pcie-armada8k.c b/drivers/pci/controller/dwc/pcie-armada8k.c index 49596547e8c2..66ec21cd9487 100644 --- a/drivers/pci/controller/dwc/pcie-armada8k.c +++ b/drivers/pci/controller/dwc/pcie-armada8k.c @@ -248,10 +248,8 @@ static int armada8k_add_pcie_port(struct armada8k_pcie *pcie, pp->ops = &armada8k_pcie_host_ops; pp->irq = platform_get_irq(pdev, 0); - if (pp->irq < 0) { - dev_err(dev, "failed to get irq for port\n"); + if (pp->irq < 0) return pp->irq; - } ret = devm_request_irq(dev, pp->irq, armada8k_pcie_irq_handler, IRQF_SHARED, "armada8k-pcie", pcie); diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c index 28d5a1095200..d429bd2b2406 100644 --- a/drivers/pci/controller/dwc/pcie-artpec6.c +++ b/drivers/pci/controller/dwc/pcie-artpec6.c @@ -387,10 +387,8 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie, if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq_byname(pdev, "msi"); - if (pp->msi_irq < 0) { - dev_err(dev, "failed to get MSI irq\n"); + if (pp->msi_irq < 0) return pp->msi_irq; - } } pp->ops = &artpec6_pcie_host_ops; diff --git a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c index 811b5c6d62ea..006437eadc31 100644 --- a/drivers/pci/controller/dwc/pcie-histb.c +++ b/drivers/pci/controller/dwc/pcie-histb.c @@ -402,10 +402,8 @@ static int histb_pcie_probe(struct platform_device *pdev) if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq = platform_get_irq_byname(pdev, "msi"); - if (pp->msi_irq < 0) { - dev_err(dev, "Failed to get MSI IRQ\n"); + if (pp->msi_irq < 0) return pp->msi_irq; - } } hipcie->phy = devm_phy_get(dev, "phy"); diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c index c19617a912bd..2e0181ce6895 100644 --- a/drivers/pci/controller/dwc/pcie-kirin.c +++ b/drivers/pci/controller/dwc/pcie-kirin.c @@ -455,11 +455,8 @@ static int kirin_pcie_add_msi(struct dw_pcie *pci, if (IS_ENABLED(CONFIG_PCI_MSI)) { irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, - "failed to get MSI IRQ (%d)\n", irq); + if (irq < 0) return irq; - } pci->pp.msi_irq = irq; } diff --git a/drivers/pci/controller/dwc/pcie-spear13xx.c b/drivers/pci/controller/dwc/pcie-spear13xx.c index 7d0cdfd8138b..ad5d08d19926 100644 --- a/drivers/pci/controller/dwc/pcie-spear13xx.c +++ b/drivers/pci/controller/dwc/pcie-spear13xx.c @@ -198,10 +198,9 @@ static int spear13xx_add_pcie_port(struct spear13xx_pcie *spear13xx_pcie, int ret; pp->irq = platform_get_irq(pdev, 0); - if (pp->irq < 0) { - dev_err(dev, "failed to get irq\n"); + if (pp->irq < 0) return pp->irq; - } + ret = devm_request_irq(dev, pp->irq, spear13xx_pcie_irq_handler, IRQF_SHARED | IRQF_NO_THREAD, "spear1340-pcie", spear13xx_pcie); diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c index 92b77f7d8354..70498689d0c0 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -2189,10 +2189,8 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) } pp->irq = platform_get_irq_byname(pdev, "intr"); - if (pp->irq < 0) { - dev_err(dev, "Failed to get \"intr\" interrupt\n"); + if (pp->irq < 0) return pp->irq; - } pcie->bpmp = tegra_bpmp_get(dev); if (IS_ERR(pcie->bpmp)) -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1518C433DF for ; Sun, 2 Aug 2020 14:28:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72DEB20759 for ; Sun, 2 Aug 2020 14:28:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l588oa8v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72DEB20759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fJU6miMSzk0CxBXJarKknLECrFsN83QskK+f57aetG0=; b=l588oa8vHOTU757osE1F3+Awt YzFp71+UPOBYyqjPF4ZzUdRiGphhGniU/5taUynCE08Hf6SK6StynOlIRu7AK5Pbf7HaKNdjYXfvx iIuHmOGTWDzxk+sn20c1GR3yMpg6GZkcY94jexZf0Bs/mLq1VQYMJ73kg0Yo57uDtpXK+G8/cwhq9 tSmLWu9CmojpR8U6ROakNmlFz8gvunyeWMOHcHAer1d9mgiVpXEvb2uFIHK5zcwkLcr5V/GocsQYM 06gPmJWwfO6hXDJPYt/Di4DreIlTC2VojV+gFrmqxtW4gPBL/x9cOMKS+kyyoNo45pPDGAL8cuVG/ ba7uQn5Hw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2EwN-00074t-9I; Sun, 02 Aug 2020 14:26:19 +0000 Received: from mail-lj1-f195.google.com ([209.85.208.195]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2EwC-0006zF-Eh; Sun, 02 Aug 2020 14:26:09 +0000 Received: by mail-lj1-f195.google.com with SMTP id v9so2518269ljk.6; Sun, 02 Aug 2020 07:26:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SHzQyIKtZT048lWcLoYtmM5+43kERVs82uFH/nxs4dE=; b=k2pcYRi+7E7uW442xq2GYSdDfs0TsfdKvFMqjbJNJZD4wwimV9HO3QuRddXwHTtMaq x4DMQezplxBD6H5g7pPZDPAFLvRJBMt/ugCmGi6BNPXMvZpXvCSSHrDL/Et//h48gMKq lJ6FzoAKjj+VXDeqRI9Pn0xaR+pX/FHaA8krA43XvlRFtAY5x2jiOc5q7JzeAZdbgIOc ShWqFe9w22Om7/mS6pad6S/Evp6oQxLbiKBxjEhMNY9qnhISjrcGd6R8GsHd/lYcf5VJ FfYbwEK3GmKtwGHKOgIhDMTJSjLgz3fnZFCaynbD7Tg4AYuYAO2twtVbGZm+qmyflwHs EsPg== X-Gm-Message-State: AOAM531Zgo7HuEJ5eTonpSuHm95/3YiZokdO3Tr94fuk8YlCA/zfBIy/ /BBXugWzpzmDrjp5T6nTILw= X-Google-Smtp-Source: ABdhPJw9KYywa8ZVGNdkCZs9dJSVD2eLeBxLICm3DHiWvDH9oOY7/rpOjkFQkoP+VW0PAFb9uso9fw== X-Received: by 2002:a2e:9dd3:: with SMTP id x19mr2085928ljj.459.1596378365310; Sun, 02 Aug 2020 07:26:05 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id 193sm4214136lfa.90.2020.08.02.07.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2020 07:26:04 -0700 (PDT) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Subject: [PATCH 01/10] PCI: dwc: Remove dev_err() when handing an error from platform_get_irq() Date: Sun, 2 Aug 2020 14:25:53 +0000 Message-Id: <20200802142601.1635926-2-kw@linux.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200802142601.1635926-1-kw@linux.com> References: <20200802142601.1635926-1-kw@linux.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200802_102608_591821_960D1295 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-pci@vger.kernel.org, Shawn Lin , Binghui Wang , linux-arm-kernel@axis.com, Ley Foon Tan , Thomas Petazzoni , Toan Le , Jesper Nilsson , linux-samsung-soc@vger.kernel.org, Kevin Hilman , Pratyush Anand , Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Kukjin Kim , Xiaowei Song , Hou Zhiqiang , Linus Walleij , Richard Zhu , Sascha Hauer , Yue Wang , Murali Karicheri , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingoo Han , rfi@lists.rocketboards.org, Shawn Guo , Lucas Stach Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlcmUgaXMgbm8gbmVlZCB0byBjYWxsIHRoZSBkZXZfZXJyKCkgZnVuY3Rpb24gZGlyZWN0bHkg dG8gcHJpbnQgYQpjdXN0b20gbWVzc2FnZSB3aGVuIGhhbmRsaW5nIGFuIGVycm9yIGZyb20gZWl0 aGVyIHRoZSBwbGF0Zm9ybV9nZXRfaXJxKCkKb3IgcGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUoKSBm dW5jdGlvbnMgYXMgYm90aCBhcmUgZ29pbmcgdG8gZGlzcGxheSBhbgphcHByb3ByaWF0ZSBlcnJv ciBtZXNzYWdlIGluIGNhc2Ugb2YgYSBmYWlsdXJlLgoKVGhpcyBjaGFuZ2UgaXMgYXMgcGVyIHN1 Z2dlc3Rpb24gZnJvbSBDb2NjaW5lbGxlOgoKICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2llLWFybWFkYThrLmM6MjUyOjItOTogbGluZSAyNTIgaXMKICByZWR1bmRhbnQgYmVjYXVzZSBw bGF0Zm9ybV9nZXRfaXJxKCkgYWxyZWFkeSBwcmludHMgYW4gZXJyb3IKCiAgZHJpdmVycy9wY2kv Y29udHJvbGxlci9kd2MvcGNpZS1raXJpbi5jOjQ1OTozLTEwOiBsaW5lIDQ1OSBpcwogIHJlZHVu ZGFudCBiZWNhdXNlIHBsYXRmb3JtX2dldF9pcnEoKSBhbHJlYWR5IHByaW50cyBhbiBlcnJvcgoK ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jOjg3MjozLTEwOiBsaW5lIDg3 MiBpcyByZWR1bmRhbnQKICBiZWNhdXNlIHBsYXRmb3JtX2dldF9pcnEoKSBhbHJlYWR5IHByaW50 cyBhbiBlcnJvcgoKICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWFydHBlYzYuYzoz OTE6My0xMDogbGluZSAzOTEgaXMKICByZWR1bmRhbnQgYmVjYXVzZSBwbGF0Zm9ybV9nZXRfaXJx KCkgYWxyZWFkeSBwcmludHMgYW4gZXJyb3IKCiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2Mv cGNpZS1zcGVhcjEzeHguYzoyMDI6Mi05OiBsaW5lIDIwMiBpcwogIHJlZHVuZGFudCBiZWNhdXNl IHBsYXRmb3JtX2dldF9pcnEoKSBhbHJlYWR5IHByaW50cyBhbiBlcnJvcgoKICBkcml2ZXJzL3Bj aS9jb250cm9sbGVyL2R3Yy9wY2kta2V5c3RvbmUuYzoxMjU0OjItOTogbGluZSAxMjU0IGlzCiAg cmVkdW5kYW50IGJlY2F1c2UgcGxhdGZvcm1fZ2V0X2lycSgpIGFscmVhZHkgcHJpbnRzIGFuIGVy cm9yCgogIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1leHlub3MuYzo0MDY6Mi05OiBs aW5lIDQwNiBpcyByZWR1bmRhbnQKICBiZWNhdXNlIHBsYXRmb3JtX2dldF9pcnEoKSBhbHJlYWR5 IHByaW50cyBhbiBlcnJvcgoKICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktZXh5bm9z LmM6NDE5OjMtMTA6IGxpbmUgNDE5IGlzCiAgcmVkdW5kYW50IGJlY2F1c2UgcGxhdGZvcm1fZ2V0 X2lycSgpIGFscmVhZHkgcHJpbnRzIGFuIGVycm9yCgogIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIv ZHdjL3BjaWUtdGVncmExOTQuYzoyMTkzOjItOTogbGluZSAyMTkzIGlzCiAgcmVkdW5kYW50IGJl Y2F1c2UgcGxhdGZvcm1fZ2V0X2lycSgpIGFscmVhZHkgcHJpbnRzIGFuIGVycm9yCgogIGRyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtaGlzdGIuYzo0MDY6My0xMDogbGluZSA0MDYgaXMK ICByZWR1bmRhbnQgYmVjYXVzZSBwbGF0Zm9ybV9nZXRfaXJxKCkgYWxyZWFkeSBwcmludHMgYW4g ZXJyb3IKCiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLW1lc29uLmM6NDkyOjMtMTA6 IGxpbmUgNDkyIGlzIHJlZHVuZGFudAogIGJlY2F1c2UgcGxhdGZvcm1fZ2V0X2lycSgpIGFscmVh ZHkgcHJpbnRzIGFuIGVycm9yCgogIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1kcmE3 eHguYzo2MzM6Mi05OiBsaW5lIDYzMyBpcyByZWR1bmRhbnQKICBiZWNhdXNlIHBsYXRmb3JtX2dl dF9pcnEoKSBhbHJlYWR5IHByaW50cyBhbiBlcnJvcgoKICBkcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2ktZHJhN3h4LmM6ODc1OjItOTogbGluZSA4NzUgaXMgcmVkdW5kYW50CiAgYmVjYXVz ZSBwbGF0Zm9ybV9nZXRfaXJxKCkgYWxyZWFkeSBwcmludHMgYW4gZXJyb3IKClN1Z2dlc3RlZC1i eTogQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNvbT4KU2lnbmVkLW9mZi1ieTogS3J6 eXN6dG9mIFdpbGN6ecWEc2tpIDxrd0BsaW51eC5jb20+Ci0tLQogZHJpdmVycy9wY2kvY29udHJv bGxlci9kd2MvcGNpLWRyYTd4eC5jICAgICB8IDggKystLS0tLS0KIGRyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaS1leHlub3MuYyAgICAgfCA5ICsrKy0tLS0tLQogZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpLWlteDYuYyAgICAgICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJv bGxlci9kd2MvcGNpLWtleXN0b25lLmMgICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxl ci9kd2MvcGNpLW1lc29uLmMgICAgICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9k d2MvcGNpZS1hcm1hZGE4ay5jICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2Mv cGNpZS1hcnRwZWM2LmMgICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNp ZS1oaXN0Yi5jICAgICB8IDQgKy0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1r aXJpbi5jICAgICB8IDUgKy0tLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtc3Bl YXIxM3h4LmMgfCA1ICsrLS0tCiBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXRlZ3Jh MTk0LmMgIHwgNCArLS0tCiAxMSBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA0MCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2kt ZHJhN3h4LmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktZHJhN3h4LmMKaW5kZXgg NjE4NGViYzkzOTJkLi42NjQ2NWRkNjk4NTggMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaS1kcmE3eHguYworKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2ktZHJhN3h4LmMKQEAgLTYyOSwxMCArNjI5LDggQEAgc3RhdGljIGludCBfX2luaXQgZHJhN3h4 X2FkZF9wY2llX3BvcnQoc3RydWN0IGRyYTd4eF9wY2llICpkcmE3eHgsCiAJc3RydWN0IHJlc291 cmNlICpyZXM7CiAKIAlwcC0+aXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAxKTsKLQlpZiAo cHAtPmlycSA8IDApIHsKLQkJZGV2X2VycihkZXYsICJtaXNzaW5nIElSUSByZXNvdXJjZVxuIik7 CisJaWYgKHBwLT5pcnEgPCAwKQogCQlyZXR1cm4gcHAtPmlycTsKLQl9CiAKIAlyZXQgPSBkcmE3 eHhfcGNpZV9pbml0X2lycV9kb21haW4ocHApOwogCWlmIChyZXQgPCAwKQpAQCAtODcxLDEwICs4 NjksOCBAQCBzdGF0aWMgaW50IF9faW5pdCBkcmE3eHhfcGNpZV9wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQogCXBjaS0+b3BzID0gJmR3X3BjaWVfb3BzOwogCiAJaXJxID0gcGxh dGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKLQlpZiAoaXJxIDwgMCkgewotCQlkZXZfZXJyKGRldiwg Im1pc3NpbmcgSVJRIHJlc291cmNlOiAlZFxuIiwgaXJxKTsKKwlpZiAoaXJxIDwgMCkKIAkJcmV0 dXJuIGlycTsKLQl9CiAKIAliYXNlID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlX2J5 bmFtZShwZGV2LCAidGlfY29uZiIpOwogCWlmIChJU19FUlIoYmFzZSkpCmRpZmYgLS1naXQgYS9k cml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktZXh5bm9zLmMgYi9kcml2ZXJzL3BjaS9jb250 cm9sbGVyL2R3Yy9wY2ktZXh5bm9zLmMKaW5kZXggYzUwNDNkOTUxZTgwLi5mNzIxZmRkYzUyMWUg MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1leHlub3MuYworKysg Yi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktZXh5bm9zLmMKQEAgLTQwMiwxMCArNDAy LDkgQEAgc3RhdGljIGludCBfX2luaXQgZXh5bm9zX2FkZF9wY2llX3BvcnQoc3RydWN0IGV4eW5v c19wY2llICplcCwKIAlpbnQgcmV0OwogCiAJcHAtPmlycSA9IHBsYXRmb3JtX2dldF9pcnEocGRl diwgMSk7Ci0JaWYgKHBwLT5pcnEgPCAwKSB7Ci0JCWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIGdl dCBpcnFcbiIpOworCWlmIChwcC0+aXJxIDwgMCkKIAkJcmV0dXJuIHBwLT5pcnE7Ci0JfQorCiAJ cmV0ID0gZGV2bV9yZXF1ZXN0X2lycShkZXYsIHBwLT5pcnEsIGV4eW5vc19wY2llX2lycV9oYW5k bGVyLAogCQkJCUlSUUZfU0hBUkVELCAiZXh5bm9zLXBjaWUiLCBlcCk7CiAJaWYgKHJldCkgewpA QCAtNDE1LDEwICs0MTQsOCBAQCBzdGF0aWMgaW50IF9faW5pdCBleHlub3NfYWRkX3BjaWVfcG9y dChzdHJ1Y3QgZXh5bm9zX3BjaWUgKmVwLAogCiAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1BDSV9N U0kpKSB7CiAJCXBwLT5tc2lfaXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKLQkJaWYg KHBwLT5tc2lfaXJxIDwgMCkgewotCQkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gZ2V0IG1zaSBp cnFcbiIpOworCQlpZiAocHAtPm1zaV9pcnEgPCAwKQogCQkJcmV0dXJuIHBwLT5tc2lfaXJxOwot CQl9CiAJfQogCiAJcHAtPm9wcyA9ICZleHlub3NfcGNpZV9ob3N0X29wczsKZGlmZiAtLWdpdCBh L2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMgYi9kcml2ZXJzL3BjaS9jb250 cm9sbGVyL2R3Yy9wY2ktaW14Ni5jCmluZGV4IDhmMDhhZTUzZjUzZS4uYWJhMGExNTE0YTg2IDEw MDY0NAotLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jCisrKyBiL2Ry aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMKQEAgLTg2OCwxMCArODY4LDggQEAg c3RhdGljIGludCBpbXg2X2FkZF9wY2llX3BvcnQoc3RydWN0IGlteDZfcGNpZSAqaW14Nl9wY2ll LAogCiAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1BDSV9NU0kpKSB7CiAJCXBwLT5tc2lfaXJxID0g cGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUocGRldiwgIm1zaSIpOwotCQlpZiAocHAtPm1zaV9pcnEg PCAwKSB7Ci0JCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgTVNJIGlycVxuIik7CisJCWlm IChwcC0+bXNpX2lycSA8IDApCiAJCQlyZXR1cm4gcHAtPm1zaV9pcnE7Ci0JCX0KIAl9CiAKIAlw cC0+b3BzID0gJmlteDZfcGNpZV9ob3N0X29wczsKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2Nv bnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2Mv cGNpLWtleXN0b25lLmMKaW5kZXggNzkwNjc5ZmRmYTQ4Li45OWRmOWFlZWNlMWYgMTAwNjQ0Ci0t LSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5jCisrKyBiL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5jCkBAIC0xMjUwLDEwICsxMjUwLDgg QEAgc3RhdGljIGludCBfX2luaXQga3NfcGNpZV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQogCXBjaS0+dmVyc2lvbiA9IHZlcnNpb247CiAKIAlpcnEgPSBwbGF0Zm9ybV9nZXRf aXJxKHBkZXYsIDApOwotCWlmIChpcnEgPCAwKSB7Ci0JCWRldl9lcnIoZGV2LCAibWlzc2luZyBJ UlEgcmVzb3VyY2U6ICVkXG4iLCBpcnEpOworCWlmIChpcnEgPCAwKQogCQlyZXR1cm4gaXJxOwot CX0KIAogCXJldCA9IHJlcXVlc3RfaXJxKGlycSwga3NfcGNpZV9lcnJfaXJxX2hhbmRsZXIsIElS UUZfU0hBUkVELAogCQkJICAia3MtcGNpZS1lcnJvci1pcnEiLCBrc19wY2llKTsKZGlmZiAtLWdp dCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1tZXNvbi5jIGIvZHJpdmVycy9wY2kv Y29udHJvbGxlci9kd2MvcGNpLW1lc29uLmMKaW5kZXggY2E1OWJhOWUwZWNkLi40ZjE4M2I5NmFm YmIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1tZXNvbi5jCisr KyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1tZXNvbi5jCkBAIC00ODgsMTAgKzQ4 OCw4IEBAIHN0YXRpYyBpbnQgbWVzb25fYWRkX3BjaWVfcG9ydChzdHJ1Y3QgbWVzb25fcGNpZSAq bXAsCiAKIAlpZiAoSVNfRU5BQkxFRChDT05GSUdfUENJX01TSSkpIHsKIAkJcHAtPm1zaV9pcnEg PSBwbGF0Zm9ybV9nZXRfaXJxKHBkZXYsIDApOwotCQlpZiAocHAtPm1zaV9pcnEgPCAwKSB7Ci0J CQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgTVNJIElSUVxuIik7CisJCWlmIChwcC0+bXNp X2lycSA8IDApCiAJCQlyZXR1cm4gcHAtPm1zaV9pcnE7Ci0JCX0KIAl9CiAKIAlwcC0+b3BzID0g Jm1lc29uX3BjaWVfaG9zdF9vcHM7CmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2llLWFybWFkYThrLmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWFy bWFkYThrLmMKaW5kZXggNDk1OTY1NDdlOGMyLi42NmVjMjFjZDk0ODcgMTAwNjQ0Ci0tLSBhL2Ry aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtYXJtYWRhOGsuYworKysgYi9kcml2ZXJzL3Bj aS9jb250cm9sbGVyL2R3Yy9wY2llLWFybWFkYThrLmMKQEAgLTI0OCwxMCArMjQ4LDggQEAgc3Rh dGljIGludCBhcm1hZGE4a19hZGRfcGNpZV9wb3J0KHN0cnVjdCBhcm1hZGE4a19wY2llICpwY2ll LAogCXBwLT5vcHMgPSAmYXJtYWRhOGtfcGNpZV9ob3N0X29wczsKIAogCXBwLT5pcnEgPSBwbGF0 Zm9ybV9nZXRfaXJxKHBkZXYsIDApOwotCWlmIChwcC0+aXJxIDwgMCkgewotCQlkZXZfZXJyKGRl diwgImZhaWxlZCB0byBnZXQgaXJxIGZvciBwb3J0XG4iKTsKKwlpZiAocHAtPmlycSA8IDApCiAJ CXJldHVybiBwcC0+aXJxOwotCX0KIAogCXJldCA9IGRldm1fcmVxdWVzdF9pcnEoZGV2LCBwcC0+ aXJxLCBhcm1hZGE4a19wY2llX2lycV9oYW5kbGVyLAogCQkJICAgICAgIElSUUZfU0hBUkVELCAi YXJtYWRhOGstcGNpZSIsIHBjaWUpOwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxl ci9kd2MvcGNpZS1hcnRwZWM2LmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWFy dHBlYzYuYwppbmRleCAyOGQ1YTEwOTUyMDAuLmQ0MjliZDJiMjQwNiAxMDA2NDQKLS0tIGEvZHJp dmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1hcnRwZWM2LmMKKysrIGIvZHJpdmVycy9wY2kv Y29udHJvbGxlci9kd2MvcGNpZS1hcnRwZWM2LmMKQEAgLTM4NywxMCArMzg3LDggQEAgc3RhdGlj IGludCBhcnRwZWM2X2FkZF9wY2llX3BvcnQoc3RydWN0IGFydHBlYzZfcGNpZSAqYXJ0cGVjNl9w Y2llLAogCiAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1BDSV9NU0kpKSB7CiAJCXBwLT5tc2lfaXJx ID0gcGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUocGRldiwgIm1zaSIpOwotCQlpZiAocHAtPm1zaV9p cnEgPCAwKSB7Ci0JCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgTVNJIGlycVxuIik7CisJ CWlmIChwcC0+bXNpX2lycSA8IDApCiAJCQlyZXR1cm4gcHAtPm1zaV9pcnE7Ci0JCX0KIAl9CiAK IAlwcC0+b3BzID0gJmFydHBlYzZfcGNpZV9ob3N0X29wczsKZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtaGlzdGIuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIv ZHdjL3BjaWUtaGlzdGIuYwppbmRleCA4MTFiNWM2ZDYyZWEuLjAwNjQzN2VhZGMzMSAxMDA2NDQK LS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1oaXN0Yi5jCisrKyBiL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtaGlzdGIuYwpAQCAtNDAyLDEwICs0MDIsOCBAQCBz dGF0aWMgaW50IGhpc3RiX3BjaWVfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikK IAogCWlmIChJU19FTkFCTEVEKENPTkZJR19QQ0lfTVNJKSkgewogCQlwcC0+bXNpX2lycSA9IHBs YXRmb3JtX2dldF9pcnFfYnluYW1lKHBkZXYsICJtc2kiKTsKLQkJaWYgKHBwLT5tc2lfaXJxIDwg MCkgewotCQkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0IE1TSSBJUlFcbiIpOworCQlpZiAo cHAtPm1zaV9pcnEgPCAwKQogCQkJcmV0dXJuIHBwLT5tc2lfaXJxOwotCQl9CiAJfQogCiAJaGlw Y2llLT5waHkgPSBkZXZtX3BoeV9nZXQoZGV2LCAicGh5Iik7CmRpZmYgLS1naXQgYS9kcml2ZXJz L3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWtpcmluLmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2llLWtpcmluLmMKaW5kZXggYzE5NjE3YTkxMmJkLi4yZTAxODFjZTY4OTUgMTAwNjQ0 Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUta2lyaW4uYworKysgYi9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWtpcmluLmMKQEAgLTQ1NSwxMSArNDU1LDggQEAg c3RhdGljIGludCBraXJpbl9wY2llX2FkZF9tc2koc3RydWN0IGR3X3BjaWUgKnBjaSwKIAogCWlm IChJU19FTkFCTEVEKENPTkZJR19QQ0lfTVNJKSkgewogCQlpcnEgPSBwbGF0Zm9ybV9nZXRfaXJx KHBkZXYsIDApOwotCQlpZiAoaXJxIDwgMCkgewotCQkJZGV2X2VycigmcGRldi0+ZGV2LAotCQkJ CSJmYWlsZWQgdG8gZ2V0IE1TSSBJUlEgKCVkKVxuIiwgaXJxKTsKKwkJaWYgKGlycSA8IDApCiAJ CQlyZXR1cm4gaXJxOwotCQl9CiAKIAkJcGNpLT5wcC5tc2lfaXJxID0gaXJxOwogCX0KZGlmZiAt LWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtc3BlYXIxM3h4LmMgYi9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXNwZWFyMTN4eC5jCmluZGV4IDdkMGNkZmQ4MTM4 Yi4uYWQ1ZDA4ZDE5OTI2IDEwMDY0NAotLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2llLXNwZWFyMTN4eC5jCisrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtc3Bl YXIxM3h4LmMKQEAgLTE5OCwxMCArMTk4LDkgQEAgc3RhdGljIGludCBzcGVhcjEzeHhfYWRkX3Bj aWVfcG9ydChzdHJ1Y3Qgc3BlYXIxM3h4X3BjaWUgKnNwZWFyMTN4eF9wY2llLAogCWludCByZXQ7 CiAKIAlwcC0+aXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKLQlpZiAocHAtPmlycSA8 IDApIHsKLQkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gZ2V0IGlycVxuIik7CisJaWYgKHBwLT5p cnEgPCAwKQogCQlyZXR1cm4gcHAtPmlycTsKLQl9CisKIAlyZXQgPSBkZXZtX3JlcXVlc3RfaXJx KGRldiwgcHAtPmlycSwgc3BlYXIxM3h4X3BjaWVfaXJxX2hhbmRsZXIsCiAJCQkgICAgICAgSVJR Rl9TSEFSRUQgfCBJUlFGX05PX1RIUkVBRCwKIAkJCSAgICAgICAic3BlYXIxMzQwLXBjaWUiLCBz cGVhcjEzeHhfcGNpZSk7CmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9w Y2llLXRlZ3JhMTk0LmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXRlZ3JhMTk0 LmMKaW5kZXggOTJiNzdmN2Q4MzU0Li43MDQ5ODY4OWQwYzAgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtdGVncmExOTQuYworKysgYi9kcml2ZXJzL3BjaS9jb250 cm9sbGVyL2R3Yy9wY2llLXRlZ3JhMTk0LmMKQEAgLTIxODksMTAgKzIxODksOCBAQCBzdGF0aWMg aW50IHRlZ3JhX3BjaWVfZHdfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAl9 CiAKIAlwcC0+aXJxID0gcGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUocGRldiwgImludHIiKTsKLQlp ZiAocHAtPmlycSA8IDApIHsKLQkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0IFwiaW50clwi IGludGVycnVwdFxuIik7CisJaWYgKHBwLT5pcnEgPCAwKQogCQlyZXR1cm4gcHAtPmlycTsKLQl9 CiAKIAlwY2llLT5icG1wID0gdGVncmFfYnBtcF9nZXQoZGV2KTsKIAlpZiAoSVNfRVJSKHBjaWUt PmJwbXApKQotLSAKMi4yNy4wCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=