From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
sudeep.dutt@intel.com, arnd@arndb.de,
vincent.whitchurch@axis.com, stable@vger.kernel.org
Subject: Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()
Date: Mon, 3 Aug 2020 07:12:40 -0400 [thread overview]
Message-ID: <20200803071234-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200802232812.16794-1-ashutosh.dixit@intel.com>
On Sun, Aug 02, 2020 at 04:28:12PM -0700, Ashutosh Dixit wrote:
> Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
>
> 551:58: warning: incorrect type in argument 1 (different address spaces)
> 551:58: expected void const volatile [noderef] __iomem *addr
> 551:58: got restricted __le64 *
> 560:49: warning: incorrect type in argument 1 (different address spaces)
> 560:49: expected struct mic_device_ctrl *dc
> 560:49: got struct mic_device_ctrl [noderef] __iomem *dc
> 579:49: warning: incorrect type in argument 1 (different address spaces)
> 579:49: expected struct mic_device_ctrl *dc
> 579:49: got struct mic_device_ctrl [noderef] __iomem *dc
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Sudeep Dutt <sudeep.dutt@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/misc/mic/vop/vop_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c
> index 85942f6717c5..25ed7d731701 100644
> --- a/drivers/misc/mic/vop/vop_main.c
> +++ b/drivers/misc/mic/vop/vop_main.c
> @@ -546,7 +546,7 @@ static int vop_match_desc(struct device *dev, void *data)
> return vdev->desc == (void __iomem *)data;
> }
>
> -static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl *dc)
> +static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl __iomem *dc)
> {
> return (struct _vop_vdev *)(unsigned long)readq(&dc->vdev);
> }
> --
> 2.26.2.108.g048abe1751
prev parent reply other threads:[~2020-08-03 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 23:28 [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev() Ashutosh Dixit
2020-08-03 4:24 ` Greg Kroah-Hartman
2020-08-03 4:26 ` Dixit, Ashutosh
2020-08-03 11:12 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803071234-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=ashutosh.dixit@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudeep.dutt@intel.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.