From: Catalin Marinas <catalin.marinas@arm.com>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64/fixmap: make notes of fixed_addresses more precisely
Date: Mon, 3 Aug 2020 12:53:45 +0100 [thread overview]
Message-ID: <20200803115344.GC6132@gaia> (raw)
In-Reply-To: <CAFgQCTvmdVzfqdTwrhmccsvNL_g5pdsqT_5kV9j9Rb7BjLoUsA@mail.gmail.com>
On Mon, Aug 03, 2020 at 10:07:16AM +0800, Pingfan Liu wrote:
> What about description like:
> diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h
> index f987b8a..4335800 100644
> --- a/arch/arm64/include/asm/fixmap.h
> +++ b/arch/arm64/include/asm/fixmap.h
> @@ -28,10 +28,9 @@
> * compile time, but to set the physical address only
> * in the boot process.
> *
> - * These 'compile-time allocated' memory buffers are
> - * page-sized. Use set_fixmap(idx,phys) to associate
> - * physical memory with fixmap indices.
> - *
> + * Each enum increment in these 'compile-time allocated'
> + * memory buffers is page-sized. Use set_fixmap(idx,phys)
> + * to associate physical memory with a fixmap index.
> */
It looks fine. Please send it as a separate patch. Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-08-03 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 13:43 [PATCH] arm64/fixmap: make notes of fixed_addresses more precisely Pingfan Liu
2020-07-30 11:09 ` Catalin Marinas
2020-07-31 2:47 ` Pingfan Liu
2020-07-31 12:13 ` Catalin Marinas
2020-08-03 2:07 ` Pingfan Liu
2020-08-03 11:53 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803115344.GC6132@gaia \
--to=catalin.marinas@arm.com \
--cc=kernelfans@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.