All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill O'Donnell <billodo@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eryu Guan <guaneryu@gmail.com>, xfs <linux-xfs@vger.kernel.org>,
	fstests <fstests@vger.kernel.org>,
	Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] xfs/{263,106} erase max warnings printout
Date: Mon, 3 Aug 2020 08:17:59 -0500	[thread overview]
Message-ID: <20200803131759.GA574548@redhat.com> (raw)
In-Reply-To: <20200730183533.GB67809@magnolia>

On Thu, Jul 30, 2020 at 11:35:33AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Both of these tests encode the xfs_quota output in the golden output.
> Now that we've changed xfs_quota to emit max warnings, we have to fix
> the test to avoid regressions.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> ---
>  tests/xfs/106 |    3 ++-
>  tests/xfs/263 |    4 +++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/xfs/106 b/tests/xfs/106
> index 7a71ec09..e6a9b3d1 100755
> --- a/tests/xfs/106
> +++ b/tests/xfs/106
> @@ -96,7 +96,8 @@ filter_state()
>  {
>  	_filter_quota | sed -e "s/Inode: #[0-9]* (0 blocks, 0 extents)/Inode: #[INO] (0 blocks, 0 extents)/g" \
>  			    -e "s/Inode: #[0-9]* ([0-9]* blocks, [0-9]* extents)/Inode: #[INO] (X blocks, Y extents)/g" \
> -			    -e "/[0-9][0-9]:[0-9][0-9]:[0-9][0-9]/s/ [0-9][0-9]:[0-9][0-9]:[0-9][0-9]//g"
> +			    -e "/[0-9][0-9]:[0-9][0-9]:[0-9][0-9]/s/ [0-9][0-9]:[0-9][0-9]:[0-9][0-9]//g" \
> +			    -e '/max warnings:/d'
>  }
>  
>  test_quot()
> diff --git a/tests/xfs/263 b/tests/xfs/263
> index 578f9ee7..2f23318d 100755
> --- a/tests/xfs/263
> +++ b/tests/xfs/263
> @@ -57,7 +57,9 @@ function option_string()
>  }
>  
>  filter_quota_state() {
> -	sed -e 's/Inode: #[0-9]\+/Inode #XXX/g' | _filter_scratch
> +	sed -e 's/Inode: #[0-9]\+/Inode #XXX/g' \
> +	    -e '/max warnings:/d' \
> +		| _filter_scratch
>  }
>  
>  function test_all_state()
> 


      reply	other threads:[~2020-08-03 13:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 18:35 [PATCH] xfs/{263,106} erase max warnings printout Darrick J. Wong
2020-08-03 13:17 ` Bill O'Donnell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803131759.GA574548@redhat.com \
    --to=billodo@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.