From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4662006289293956491==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: platform_get_irq: fix platform_get_irq.cocci warnings Date: Tue, 04 Aug 2020 05:07:28 +0800 Message-ID: <20200803210727.GA32944@ae86df0c824e> In-Reply-To: <202008040516.PQrIhI2L%lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============4662006289293956491== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: YueHaibing CC: "Greg Kroah-Hartman" CC: Stephen Boyd CC: Jassi Brar CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/mailbox/platform_mhu.c:141:3-10: line 141 is redundant because plat= form_get_irq() already prints an error Remove dev_err() messages after platform_get_irq*() failures Generated by: scripts/coccinelle/api/platform_get_irq.cocci Fixes: ca7ce5a2710a ("coccinelle: platform_get_irq: Fix parse error") CC: YueHaibing Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 3208167a865e862fff5045d7910387941ff7e114 commit: ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c coccinelle: platform_get_i= rq: Fix parse error :::::: branch date: 3 hours ago :::::: commit date: 11 months ago Please take the patch only if it's a positive warning. Thanks! platform_mhu.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/mailbox/platform_mhu.c +++ b/drivers/mailbox/platform_mhu.c @@ -138,7 +138,6 @@ static int platform_mhu_probe(struct pla mhu->chan[i].con_priv =3D &mhu->mlink[i]; mhu->mlink[i].irq =3D platform_get_irq(pdev, i); if (mhu->mlink[i].irq < 0) { - dev_err(dev, "failed to get irq%d\n", i); return mhu->mlink[i].irq; } mhu->mlink[i].rx_reg =3D mhu->base + platform_mhu_reg[i]; --===============4662006289293956491==--