From: Stefano Brivio <sbrivio@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Westphal <fw@strlen.de>,
Aaron Conole <aconole@redhat.com>,
Numan Siddique <nusiddiq@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Pravin B Shelar <pshelar@ovn.org>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Lourdes Pedrajas <lu@pplo.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/6] vxlan: Support for PMTU discovery on directly bridged links
Date: Tue, 4 Aug 2020 07:53:29 +0200 [thread overview]
Message-ID: <20200804075329.47dba2c8@elisabeth> (raw)
In-Reply-To: <2a4836b6-e435-953e-16b2-4dd8177ffeeb@gmail.com>
On Mon, 3 Aug 2020 17:48:48 -0600
David Ahern <dsahern@gmail.com> wrote:
> On 8/3/20 2:52 PM, Stefano Brivio wrote:
> > + err = skb_tunnel_check_pmtu(skb, ndst, VXLAN_HEADROOM,
> > + netif_is_bridge_port(dev) ||
> > + netif_is_ovs_port(dev));
>
> you have this check in a few places. Maybe a new helper like
> netif_is_any_bridge_port that can check both IFF flags in 1 go.
Ah, yes, good idea, added to 1/6 v2 as it's where it's needed now.
--
Stefano
next prev parent reply other threads:[~2020-08-04 5:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 20:52 [PATCH net-next 0/6] Support PMTU discovery with bridged UDP tunnels Stefano Brivio
2020-08-03 20:52 ` [PATCH net-next 1/6] ipv4: route: Ignore output interface in FIB lookup for PMTU route Stefano Brivio
2020-08-03 23:30 ` David Ahern
2020-08-04 5:52 ` Stefano Brivio
2020-08-03 20:52 ` [PATCH net-next 2/6] tunnels: PMTU discovery support for directly bridged IP packets Stefano Brivio
2020-08-03 23:44 ` David Ahern
2020-08-04 5:53 ` Stefano Brivio
2020-08-03 20:52 ` [PATCH net-next 3/6] vxlan: Support for PMTU discovery on directly bridged links Stefano Brivio
2020-08-03 23:48 ` David Ahern
2020-08-04 5:53 ` Stefano Brivio [this message]
2020-08-03 20:52 ` [PATCH net-next 4/6] geneve: " Stefano Brivio
2020-08-03 20:52 ` [PATCH net-next 5/6] selftests: pmtu.sh: Add tests for bridged UDP tunnels Stefano Brivio
2020-08-03 20:52 ` [PATCH net-next 6/6] selftests: pmtu.sh: Add tests for UDP tunnels handled by Open vSwitch Stefano Brivio
2020-08-03 23:28 ` [PATCH net-next 0/6] Support PMTU discovery with bridged UDP tunnels Florian Westphal
2020-08-03 23:46 ` David Ahern
2020-08-04 1:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804075329.47dba2c8@elisabeth \
--to=sbrivio@redhat.com \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=lu@pplo.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=nusiddiq@redhat.com \
--cc=pshelar@ovn.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.