From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C25C433E0 for ; Tue, 4 Aug 2020 15:10:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A3D12086A for ; Tue, 4 Aug 2020 15:10:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HQYFPsMg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A3D12086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vDC3OWp9x88nLUSizQbnYEAgNqsv2j9gNh38C4xzeyM=; b=HQYFPsMgMhhn9sG8Q5B21VEqU AsxBy6aqEf3ydJlV8FeO8RCkPOCs6BDi+FjOuB+IEtpyTIgI5bToUSFu4DvLQEpiiCKzdSzn450tL Eath/gZqJnwlsopEuo9IzqNOdxkWLdfZ0eWHEtoY4cqPgSj+IG0fX9jGPG47+5RBwKwYPdM55xVdT CF2zM3C8YhIevFIsb18iFqdafksdBEob3AX9Q5sQayTGOvlbv896/bFrvKvaQl7nDGUYDljXRkyTG t8i8WtECmbcSHTWsvAq9UCHjVBN1z0r5R/xGmx7Xyd0epbCS8FkFQz1Y/BrWKmypbgNtYPpAmNKQz qKhzxpKEg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2yYi-0004NN-Bp; Tue, 04 Aug 2020 15:08:56 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2yYf-0004M6-FB for linux-arm-kernel@lists.infradead.org; Tue, 04 Aug 2020 15:08:54 +0000 X-Originating-IP: 86.202.118.225 Received: from localhost (lfbn-lyo-1-23-225.w86-202.abo.wanadoo.fr [86.202.118.225]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id D16071C0006; Tue, 4 Aug 2020 15:08:41 +0000 (UTC) Date: Tue, 4 Aug 2020 17:08:41 +0200 From: Alexandre Belloni To: Claudiu.Beznea@microchip.com Subject: Re: [PATCH v2 2/3] ARM: at91: pm: add per soc validation of pm modes Message-ID: <20200804150841.GA10725@piout.net> References: <1596539258-20719-1-git-send-email-claudiu.beznea@microchip.com> <1596539258-20719-3-git-send-email-claudiu.beznea@microchip.com> <20200804114223.GC7836@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200804_110853_623603_33D77686 X-CRM114-Status: GOOD ( 21.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-arm-kernel@lists.infradead.org, wenyou.yang@atmel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/08/2020 15:00:38+0000, Claudiu.Beznea@microchip.com wrote: > > > On 04.08.2020 14:42, Alexandre Belloni wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > Hello, > > > > On 04/08/2020 14:07:37+0300, Claudiu Beznea wrote: > >> void __init at91rm9200_pm_init(void) > >> { > >> + static const int modes[] __initconst = { > > > > You don't need that to be static as it is now local to the function. > > > >> + AT91_PM_STANDBY, AT91_PM_ULP0 > >> + }; > >> + > >> if (!IS_ENABLED(CONFIG_SOC_AT91RM9200)) > >> return; > >> > >> + at91_pm_modes_validate(modes, ARRAY_SIZE(modes)); > > > > For rm9200 and at91sam9, I would not allow changing the pm_modes and > > simply enforce standby_mode = AT91_PM_STANDBY and suspend_mode = > > AT91_PM_ULP0.I don't think you have any user that ever changed that > > behaviour also that avoids increasing the boot time for those slow SoCs. > > OK, but bootargs is parsed at a moment when there is no information about > the machine that is running the code. And enforcing this in *_pm_init() > functions for rm9200 and at91sam9 may change suspend and standby mode that > user selected. If there is no user up to this moment there is still the > possibility of being one in the future. > So let's prevent users from doing that. Unused arguments are silently ignored which is exactly what we want to do. You won't make me believe there is actually a use case for swapping the standby and suspend meanings. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F3CFC433DF for ; Tue, 4 Aug 2020 15:08:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13AEE2086A for ; Tue, 4 Aug 2020 15:08:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729454AbgHDPIv (ORCPT ); Tue, 4 Aug 2020 11:08:51 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:52741 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728467AbgHDPIq (ORCPT ); Tue, 4 Aug 2020 11:08:46 -0400 X-Originating-IP: 86.202.118.225 Received: from localhost (lfbn-lyo-1-23-225.w86-202.abo.wanadoo.fr [86.202.118.225]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id D16071C0006; Tue, 4 Aug 2020 15:08:41 +0000 (UTC) Date: Tue, 4 Aug 2020 17:08:41 +0200 From: Alexandre Belloni To: Claudiu.Beznea@microchip.com Cc: Nicolas.Ferre@microchip.com, Ludovic.Desroches@microchip.com, wenyou.yang@atmel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] ARM: at91: pm: add per soc validation of pm modes Message-ID: <20200804150841.GA10725@piout.net> References: <1596539258-20719-1-git-send-email-claudiu.beznea@microchip.com> <1596539258-20719-3-git-send-email-claudiu.beznea@microchip.com> <20200804114223.GC7836@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2020 15:00:38+0000, Claudiu.Beznea@microchip.com wrote: > > > On 04.08.2020 14:42, Alexandre Belloni wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > Hello, > > > > On 04/08/2020 14:07:37+0300, Claudiu Beznea wrote: > >> void __init at91rm9200_pm_init(void) > >> { > >> + static const int modes[] __initconst = { > > > > You don't need that to be static as it is now local to the function. > > > >> + AT91_PM_STANDBY, AT91_PM_ULP0 > >> + }; > >> + > >> if (!IS_ENABLED(CONFIG_SOC_AT91RM9200)) > >> return; > >> > >> + at91_pm_modes_validate(modes, ARRAY_SIZE(modes)); > > > > For rm9200 and at91sam9, I would not allow changing the pm_modes and > > simply enforce standby_mode = AT91_PM_STANDBY and suspend_mode = > > AT91_PM_ULP0.I don't think you have any user that ever changed that > > behaviour also that avoids increasing the boot time for those slow SoCs. > > OK, but bootargs is parsed at a moment when there is no information about > the machine that is running the code. And enforcing this in *_pm_init() > functions for rm9200 and at91sam9 may change suspend and standby mode that > user selected. If there is no user up to this moment there is still the > possibility of being one in the future. > So let's prevent users from doing that. Unused arguments are silently ignored which is exactly what we want to do. You won't make me believe there is actually a use case for swapping the standby and suspend meanings. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com