From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D0AC433DF for ; Wed, 5 Aug 2020 03:44:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A8B92177B for ; Wed, 5 Aug 2020 03:44:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="vdCUijZK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qIlbbKG9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A8B92177B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C7E3A84A; Wed, 5 Aug 2020 05:43:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C7E3A84A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596599058; bh=A6H9OelnhQxAY0HAJly0kQRGX/lE9uiN1tn/nOW1Ujo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vdCUijZKXF0a7a8Lk43AJRK7A4eDsCvXocq2QuXSibW7jZg9m5dJI/IpOV7JK/ZHQ q2spg08gCEncofoLBTLcPnE1STku7+I5AWlCSUhBOfCj2l9NPP0cJx0i4kGX2NyO06 ZhzQNJKtuSriZbIA4h9RJWf+Z7P4buY3HqjgmMyo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 41FF0F801F7; Wed, 5 Aug 2020 05:43:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1AD9AF80218; Wed, 5 Aug 2020 05:43:27 +0200 (CEST) Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 16DDAF80112 for ; Wed, 5 Aug 2020 05:43:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 16DDAF80112 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qIlbbKG9" Received: by mail-pj1-x1043.google.com with SMTP id ep8so3555509pjb.3 for ; Tue, 04 Aug 2020 20:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iQ39NfCRpC8old6W/LK5W1TFVyUKRmxvr/lOL0aiW4s=; b=qIlbbKG9h9yj25xaWWwslH5pEhAoXFvHvxxdw1Lh1QPQZU8yZgiaKSSZO+XsBwLO3J G9rr6Qo+kjErZl0BXLMensSNIEAHM110mIuipHLfCax3qtPL4K3UOxdHndx4RxuWqTYC u5Lm+wo8vzZeubksd+gF5yl0FATX/WAkjgvQBr8N5sgvFRwkFtjOivoNTaGHqKs/kVS+ 5ksKFDdTm3OyzEH/RgiiTds8n0fs+AUtam5cKALYneqHx0XA+juoBXXQAc5k2hDdO37d av8tQClndNBX0wGCNWWreOaQJ/aExs5UDhWiK9b1oQO5knq08q+RZZw57834nQAxNvB8 R3Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iQ39NfCRpC8old6W/LK5W1TFVyUKRmxvr/lOL0aiW4s=; b=Wy/d0hQREamgZLCmP6BI2H6OjIu2wITxzgyWj0m9LNrpAKhT0t0B8lYjYdlvkh4AII D0PmGIGuFpJUD0Orkc0USFtkgvRpGO4pkABiEvpYdItKYcsaiuinXByFDsPKvlfygnkr jwq4FHHEltWEE/URur+O5z43PqcfPeSDnWCwNhVHt1KTNmohJjVxUOjom+zj0aYTlelm LUk0Dl6ssHgDA62tC8wX7NDc2E82mKn655eiEOaHRqvp9r9/jLGCaNI49ICXcRheD6+D FqVLWGYah7cMEmgCxTnKHpsgfrPqGH9Xjistx8BbE3ooMejlh2tpSZdFEub8pYP6Gv2B uj1A== X-Gm-Message-State: AOAM532h0NzxH5s59P0ZdYB8BrHga8cwZm8v7Ed8sqn6HTJXIdl0Yokc bL5/TgkjXiySmpYAWCCpv/M= X-Google-Smtp-Source: ABdhPJxqLYWvll9i8XBUjWuZrkB2d4SKoLlGUSOgZFb5VKeAkUJl9BcJtGw96aePleICT4meo2KXVQ== X-Received: by 2002:a17:902:9f85:: with SMTP id g5mr1222539plq.13.1596598994895; Tue, 04 Aug 2020 20:43:14 -0700 (PDT) Received: from Asurada-Nvidia (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id b13sm879344pjl.7.2020.08.04.20.43.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Aug 2020 20:43:14 -0700 (PDT) Date: Tue, 4 Aug 2020 20:43:00 -0700 From: Nicolin Chen To: Shengjiu Wang Subject: Re: [PATCH v2 1/2] ASoC: fsl_sai: Clean code for synchronous mode Message-ID: <20200805034300.GA10174@Asurada-Nvidia> References: <1596594233-13489-1-git-send-email-shengjiu.wang@nxp.com> <1596594233-13489-2-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596594233-13489-2-git-send-email-shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org, festevam@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Aug 05, 2020 at 10:23:52AM +0800, Shengjiu Wang wrote: > Tx synchronous with Rx: The RMR is the word mask register, it is used > to mask any word in the frame, it is not relating to clock generation, > So it is no need to be changed when Tx is going to be enabled. > > Rx synchronous with Tx: The TMR is the word mask register, it is used > to mask any word in the frame, it is not relating to clock generation, > So it is no need to be changed when Rx is going to be enabled. > > Signed-off-by: Shengjiu Wang Can you rename the PATCH subject to something more specific? For example, "Drop TMR/RMR settings for synchronous mode". Please add this once it's addressed: Reviewed-by: Nicolin Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1896C433E0 for ; Wed, 5 Aug 2020 03:44:56 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 615FE2177B for ; Wed, 5 Aug 2020 03:44:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qIlbbKG9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 615FE2177B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BLyDj65jszDqLR for ; Wed, 5 Aug 2020 13:44:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::1044; helo=mail-pj1-x1044.google.com; envelope-from=nicoleotsuka@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=qIlbbKG9; dkim-atps=neutral Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BLyBv0XKNzDqW3 for ; Wed, 5 Aug 2020 13:43:18 +1000 (AEST) Received: by mail-pj1-x1044.google.com with SMTP id ha11so3561776pjb.1 for ; Tue, 04 Aug 2020 20:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iQ39NfCRpC8old6W/LK5W1TFVyUKRmxvr/lOL0aiW4s=; b=qIlbbKG9h9yj25xaWWwslH5pEhAoXFvHvxxdw1Lh1QPQZU8yZgiaKSSZO+XsBwLO3J G9rr6Qo+kjErZl0BXLMensSNIEAHM110mIuipHLfCax3qtPL4K3UOxdHndx4RxuWqTYC u5Lm+wo8vzZeubksd+gF5yl0FATX/WAkjgvQBr8N5sgvFRwkFtjOivoNTaGHqKs/kVS+ 5ksKFDdTm3OyzEH/RgiiTds8n0fs+AUtam5cKALYneqHx0XA+juoBXXQAc5k2hDdO37d av8tQClndNBX0wGCNWWreOaQJ/aExs5UDhWiK9b1oQO5knq08q+RZZw57834nQAxNvB8 R3Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iQ39NfCRpC8old6W/LK5W1TFVyUKRmxvr/lOL0aiW4s=; b=Uw+EV09EgtK6DzlAE58IQIwdbPRIU6dlDkMOJjYo8UG4TukAHjOVHfE4EJPOut2Q+m cRKYaJTSZx48oqF07u1SaQFq8KfpFkiZTNb+IUXP4w86vwjXFqSp9LhejE+b34wbDTSK u0EI2SWHbILKKQTAuWnwdks7rO+RXGnRO4m1I3c0irHQylspPTf5NSeY4pI7dqD4Sk7o i6xPIow/4A/jTK8NZvEdXPwj0z0OcOKc6A2vQ87FvX+4LOLpQzPrBhGZL6uiVQCrrMmr 9grfYe01DP1ZGhw0L27Plbx4YpJvva6oqhsz5SoCpFjgUoPsKEACDPXXDBMYpXrXlZol ul/g== X-Gm-Message-State: AOAM53132kc1WLXe6qul5zv/jFBfpYexXSxFYuYJRnAeMIvwnD+ja9sA 7d9nA5q7eELkPUFCkBagvgU= X-Google-Smtp-Source: ABdhPJxqLYWvll9i8XBUjWuZrkB2d4SKoLlGUSOgZFb5VKeAkUJl9BcJtGw96aePleICT4meo2KXVQ== X-Received: by 2002:a17:902:9f85:: with SMTP id g5mr1222539plq.13.1596598994895; Tue, 04 Aug 2020 20:43:14 -0700 (PDT) Received: from Asurada-Nvidia (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id b13sm879344pjl.7.2020.08.04.20.43.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Aug 2020 20:43:14 -0700 (PDT) Date: Tue, 4 Aug 2020 20:43:00 -0700 From: Nicolin Chen To: Shengjiu Wang Subject: Re: [PATCH v2 1/2] ASoC: fsl_sai: Clean code for synchronous mode Message-ID: <20200805034300.GA10174@Asurada-Nvidia> References: <1596594233-13489-1-git-send-email-shengjiu.wang@nxp.com> <1596594233-13489-2-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596594233-13489-2-git-send-email-shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz, broonie@kernel.org, festevam@gmail.com, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Aug 05, 2020 at 10:23:52AM +0800, Shengjiu Wang wrote: > Tx synchronous with Rx: The RMR is the word mask register, it is used > to mask any word in the frame, it is not relating to clock generation, > So it is no need to be changed when Tx is going to be enabled. > > Rx synchronous with Tx: The TMR is the word mask register, it is used > to mask any word in the frame, it is not relating to clock generation, > So it is no need to be changed when Rx is going to be enabled. > > Signed-off-by: Shengjiu Wang Can you rename the PATCH subject to something more specific? For example, "Drop TMR/RMR settings for synchronous mode". Please add this once it's addressed: Reviewed-by: Nicolin Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7CF1C433DF for ; Wed, 5 Aug 2020 03:43:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6A242177B for ; Wed, 5 Aug 2020 03:43:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qIlbbKG9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726645AbgHEDnQ (ORCPT ); Tue, 4 Aug 2020 23:43:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbgHEDnP (ORCPT ); Tue, 4 Aug 2020 23:43:15 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C673C06174A for ; Tue, 4 Aug 2020 20:43:15 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id l60so3742486pjb.3 for ; Tue, 04 Aug 2020 20:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iQ39NfCRpC8old6W/LK5W1TFVyUKRmxvr/lOL0aiW4s=; b=qIlbbKG9h9yj25xaWWwslH5pEhAoXFvHvxxdw1Lh1QPQZU8yZgiaKSSZO+XsBwLO3J G9rr6Qo+kjErZl0BXLMensSNIEAHM110mIuipHLfCax3qtPL4K3UOxdHndx4RxuWqTYC u5Lm+wo8vzZeubksd+gF5yl0FATX/WAkjgvQBr8N5sgvFRwkFtjOivoNTaGHqKs/kVS+ 5ksKFDdTm3OyzEH/RgiiTds8n0fs+AUtam5cKALYneqHx0XA+juoBXXQAc5k2hDdO37d av8tQClndNBX0wGCNWWreOaQJ/aExs5UDhWiK9b1oQO5knq08q+RZZw57834nQAxNvB8 R3Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iQ39NfCRpC8old6W/LK5W1TFVyUKRmxvr/lOL0aiW4s=; b=o0yAD7Cu+6O+USHUHZIZp0LhVFNcoONwW+4wjz+1dfuh8SyM57TIkuSpQsfi5DTmWY YSO3s+PxMmT5+4wLRAS+fG0IvWO78d5HRknWlxsqRUWv7J2ORMpAMg76uMoNeQT8kiet kUvxj/fB8s63mqUZEBiSFTokL0xazanYTIvPAjmbf3E90x4WG6GRyjeGOCvDPfpC9GG8 UO9k8BUj7bGLTPKj0s7nAJZb1FHbdYqjX2IOoG2tzK3rYk4hGxZUTdkgpxoOJEaxksRX tpCNkgGLsmOOhGQMVXlH83QAbVhjRjWMtOdP9cSTkhFCYgXJ9TRJsmzr/UoDBXQW4BXP n1SQ== X-Gm-Message-State: AOAM530CAXpBRp6JfgegRLLYg2VGwQGKt+iXAdYyrlwYieplaB1JwCQB Bmz5xccwiEf/yztFTGLbGPI= X-Google-Smtp-Source: ABdhPJxqLYWvll9i8XBUjWuZrkB2d4SKoLlGUSOgZFb5VKeAkUJl9BcJtGw96aePleICT4meo2KXVQ== X-Received: by 2002:a17:902:9f85:: with SMTP id g5mr1222539plq.13.1596598994895; Tue, 04 Aug 2020 20:43:14 -0700 (PDT) Received: from Asurada-Nvidia (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id b13sm879344pjl.7.2020.08.04.20.43.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Aug 2020 20:43:14 -0700 (PDT) Date: Tue, 4 Aug 2020 20:43:00 -0700 From: Nicolin Chen To: Shengjiu Wang Cc: timur@kernel.org, Xiubo.Lee@gmail.com, festevam@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ASoC: fsl_sai: Clean code for synchronous mode Message-ID: <20200805034300.GA10174@Asurada-Nvidia> References: <1596594233-13489-1-git-send-email-shengjiu.wang@nxp.com> <1596594233-13489-2-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596594233-13489-2-git-send-email-shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2020 at 10:23:52AM +0800, Shengjiu Wang wrote: > Tx synchronous with Rx: The RMR is the word mask register, it is used > to mask any word in the frame, it is not relating to clock generation, > So it is no need to be changed when Tx is going to be enabled. > > Rx synchronous with Tx: The TMR is the word mask register, it is used > to mask any word in the frame, it is not relating to clock generation, > So it is no need to be changed when Rx is going to be enabled. > > Signed-off-by: Shengjiu Wang Can you rename the PATCH subject to something more specific? For example, "Drop TMR/RMR settings for synchronous mode". Please add this once it's addressed: Reviewed-by: Nicolin Chen