From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BECFC433E0 for ; Wed, 5 Aug 2020 04:12:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEB5F208C7 for ; Wed, 5 Aug 2020 04:12:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="jqGUJEki"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gbgGmYgF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEB5F208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 135F284A; Wed, 5 Aug 2020 06:11:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 135F284A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596600747; bh=6pH+PTeRNk0jjL6wNA+XeI7NoSH1g/MXgiGlg5PBFi0=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jqGUJEkiw6ZxmNdVvZcX0/4cMLnqd0nB0lPro8YZ/4zSeT3SK3AWK/GEvMmjQvgoA WJpY80zlIseJhHoitYPxMMrz/mM/ZV4O9qT/yPWqeI8fjuIxcyUx6P4jisD4+r83mp INEtS+/WXNe4/00F4HQOyxiYPzj234+3LaWUq7wM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 81CEBF801F7; Wed, 5 Aug 2020 06:11:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 00F12F80218; Wed, 5 Aug 2020 06:11:33 +0200 (CEST) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8C235F80112 for ; Wed, 5 Aug 2020 06:11:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8C235F80112 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gbgGmYgF" Received: by mail-pl1-x644.google.com with SMTP id o1so24549957plk.1 for ; Tue, 04 Aug 2020 21:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hxlzhilvpbhmfegLmBqfpD7CzDK63zsBFUHMpLeOrf8=; b=gbgGmYgF0YdpUhrBT8h1liSj6kuTwlC09ocfWaO9eU591HVmlnn6hPetkmf8DTum1C C846wjQ71ar6b4ov/10B1KDvxHju+an47hQbzDQUasqRTkIZZCGe0LixtP1tlZ2Z3hHn AQznHxv1cBeKx0Urr4pBV6hGdRKoF6luQGbvpgrkaR4s67QjIW9QcDZ75tJ4RaFZWfNM D/nME9nSSyN3Hm79JBIdOZT/dgrKl/Z7u/BgmLir2lxu+p40to+W0krkBfzmUkt/D1A3 OO/X4H8EXfiPS4XFlwKi0TS5vJ+dtgfdSeyAfIMR+w1b9+/YoYD04ANWhfZ3RYyNIx+n PBsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hxlzhilvpbhmfegLmBqfpD7CzDK63zsBFUHMpLeOrf8=; b=ORK5wWrSpkfMAx5t2paU/HKN1wiIaNG5Az6zu1pK0fh1gOrSWtlSLoaj+W+pF/+ODa WBFRFgaDhLCotDvcY27tWkwBo7jaoch3Kk9jpeWKe3bvflL6J53rGp9PCLgRPsUjyUoX 7aTYHdCeJZzlkB9xYobwXI7H8pv+SnOlnBzwYUF7nw4IjMGxoqLqdZq1YA2Xqx8i2m8B wZ2QI/OLTJBcm3Mg6m04eCe7Pvnuk/N2/06StIkFdiKYaFYF4ClU5+/Al/oWyGqg6EC8 /k5sLp9jTq80MrawGWte39K5o3km1kmCqq69zAmj7b4Zr8M/LB7K3oGcwTp1zgr8xijG YLCA== X-Gm-Message-State: AOAM532RxHE7X2IWoJRaiv7i5Mvis1DqnXtPjjqRs+q3pjzcvigvtj0e NzbI5WOmCNnNgRdvPJDNqx0= X-Google-Smtp-Source: ABdhPJzpXE7rX9+PiFNYZWRcw3RheNt5DShOYBGze0ylmEzhCuKl6oc5Z0S0RvMEH6h/H7A7bvvoOA== X-Received: by 2002:a17:902:9001:: with SMTP id a1mr1377741plp.124.1596600683704; Tue, 04 Aug 2020 21:11:23 -0700 (PDT) Received: from Asurada-Nvidia (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id x127sm1108891pfd.86.2020.08.04.21.11.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Aug 2020 21:11:23 -0700 (PDT) Date: Tue, 4 Aug 2020 21:11:11 -0700 From: Nicolin Chen To: Shengjiu Wang Subject: Re: [PATCH v2 2/2] ASoC: fsl_sai: Refine enable and disable sequence for synchronous mode Message-ID: <20200805041111.GB10174@Asurada-Nvidia> References: <1596594233-13489-1-git-send-email-shengjiu.wang@nxp.com> <1596594233-13489-3-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596594233-13489-3-git-send-email-shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org, festevam@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Aug 05, 2020 at 10:23:53AM +0800, Shengjiu Wang wrote: > Tx synchronous with Rx: > The TCSR.TE is no need to enabled when only Rx is going to be enabled. > Check if need to disable RSCR.RE before disabling TCSR.TE. > > Rx synchronous with Tx: > The RCSR.RE is no need to enabled when only Tx is going to be enabled. > Check if need to disable TSCR.RE before disabling RCSR.TE. Please add to the commit log more context such as what we have discussed: what's the problem of the current driver, and why we _have_to_ apply this change though it's sightly against what RM recommends. (If thing is straightforward, it's okay to make the text short. Yet I believe that this change deserves more than these lines.) One info that you should mention -- also the main reason why I'm convinced to add this change: trigger() is still in the shape of the early version where we only supported one operation mode -- Tx synchronous with Rx. So we need an update for other modes. > Signed-off-by: Shengjiu Wang The git-diff part looks good, please add this in next ver.: Reviewed-by: Nicolin Chen Btw, the new fsl_sai_dir_is_synced() can be probably applied to other places with a followup patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 726ADC433E0 for ; Wed, 5 Aug 2020 04:13:21 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28BEF208C7 for ; Wed, 5 Aug 2020 04:13:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gbgGmYgF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28BEF208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BLysW0H8yzDqRk for ; Wed, 5 Aug 2020 14:13:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::641; helo=mail-pl1-x641.google.com; envelope-from=nicoleotsuka@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=gbgGmYgF; dkim-atps=neutral Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BLyqM3QpFzDqHR for ; Wed, 5 Aug 2020 14:11:27 +1000 (AEST) Received: by mail-pl1-x641.google.com with SMTP id u10so15038464plr.7 for ; Tue, 04 Aug 2020 21:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hxlzhilvpbhmfegLmBqfpD7CzDK63zsBFUHMpLeOrf8=; b=gbgGmYgF0YdpUhrBT8h1liSj6kuTwlC09ocfWaO9eU591HVmlnn6hPetkmf8DTum1C C846wjQ71ar6b4ov/10B1KDvxHju+an47hQbzDQUasqRTkIZZCGe0LixtP1tlZ2Z3hHn AQznHxv1cBeKx0Urr4pBV6hGdRKoF6luQGbvpgrkaR4s67QjIW9QcDZ75tJ4RaFZWfNM D/nME9nSSyN3Hm79JBIdOZT/dgrKl/Z7u/BgmLir2lxu+p40to+W0krkBfzmUkt/D1A3 OO/X4H8EXfiPS4XFlwKi0TS5vJ+dtgfdSeyAfIMR+w1b9+/YoYD04ANWhfZ3RYyNIx+n PBsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hxlzhilvpbhmfegLmBqfpD7CzDK63zsBFUHMpLeOrf8=; b=HAWEhOxwb9JkRAbcu2ZrO5zmZdytkyVQ8j+RDP9VmoPYlETKek3XWUZJUuJm2BWzJ8 IcJO+9Wt49wHx7t8oqgCjDuTbNrSRrGmuhfE5QTypMHkxtwLULr6h8VR+lIOhsS7ss/L jBdHcXmYm/4Bd/f1RwEeV0pU7nm5m+rXFmqfmKELwARgftBG6s2ObG6Fg8tkC4fMtXld EHF7I1haVJMnNLVbg02sMd39P34bG6MFDjYDczBvrLAL1DHNkxJ2RARIdepfx+3vgjNn FSvVEXQtSbSvhKGmdd8fk+vwq5+R2WXLV+JwDe6HyItpta6wnnipoeJvUf0n0W0kzwFx uKFw== X-Gm-Message-State: AOAM53132A3NDwdtSxpRfe5IScZ2zZ49ljRpDx8n9r9xGo3C+SThZHqk oU7bettVgv8E/jYUDf3Wsdw= X-Google-Smtp-Source: ABdhPJzpXE7rX9+PiFNYZWRcw3RheNt5DShOYBGze0ylmEzhCuKl6oc5Z0S0RvMEH6h/H7A7bvvoOA== X-Received: by 2002:a17:902:9001:: with SMTP id a1mr1377741plp.124.1596600683704; Tue, 04 Aug 2020 21:11:23 -0700 (PDT) Received: from Asurada-Nvidia (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id x127sm1108891pfd.86.2020.08.04.21.11.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Aug 2020 21:11:23 -0700 (PDT) Date: Tue, 4 Aug 2020 21:11:11 -0700 From: Nicolin Chen To: Shengjiu Wang Subject: Re: [PATCH v2 2/2] ASoC: fsl_sai: Refine enable and disable sequence for synchronous mode Message-ID: <20200805041111.GB10174@Asurada-Nvidia> References: <1596594233-13489-1-git-send-email-shengjiu.wang@nxp.com> <1596594233-13489-3-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596594233-13489-3-git-send-email-shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, timur@kernel.org, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz, broonie@kernel.org, festevam@gmail.com, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Aug 05, 2020 at 10:23:53AM +0800, Shengjiu Wang wrote: > Tx synchronous with Rx: > The TCSR.TE is no need to enabled when only Rx is going to be enabled. > Check if need to disable RSCR.RE before disabling TCSR.TE. > > Rx synchronous with Tx: > The RCSR.RE is no need to enabled when only Tx is going to be enabled. > Check if need to disable TSCR.RE before disabling RCSR.TE. Please add to the commit log more context such as what we have discussed: what's the problem of the current driver, and why we _have_to_ apply this change though it's sightly against what RM recommends. (If thing is straightforward, it's okay to make the text short. Yet I believe that this change deserves more than these lines.) One info that you should mention -- also the main reason why I'm convinced to add this change: trigger() is still in the shape of the early version where we only supported one operation mode -- Tx synchronous with Rx. So we need an update for other modes. > Signed-off-by: Shengjiu Wang The git-diff part looks good, please add this in next ver.: Reviewed-by: Nicolin Chen Btw, the new fsl_sai_dir_is_synced() can be probably applied to other places with a followup patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED3DC433E0 for ; Wed, 5 Aug 2020 04:11:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44C01208C7 for ; Wed, 5 Aug 2020 04:11:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gbgGmYgF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbgHEELY (ORCPT ); Wed, 5 Aug 2020 00:11:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbgHEELY (ORCPT ); Wed, 5 Aug 2020 00:11:24 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4065CC06174A for ; Tue, 4 Aug 2020 21:11:24 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id w17so24518655ply.11 for ; Tue, 04 Aug 2020 21:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hxlzhilvpbhmfegLmBqfpD7CzDK63zsBFUHMpLeOrf8=; b=gbgGmYgF0YdpUhrBT8h1liSj6kuTwlC09ocfWaO9eU591HVmlnn6hPetkmf8DTum1C C846wjQ71ar6b4ov/10B1KDvxHju+an47hQbzDQUasqRTkIZZCGe0LixtP1tlZ2Z3hHn AQznHxv1cBeKx0Urr4pBV6hGdRKoF6luQGbvpgrkaR4s67QjIW9QcDZ75tJ4RaFZWfNM D/nME9nSSyN3Hm79JBIdOZT/dgrKl/Z7u/BgmLir2lxu+p40to+W0krkBfzmUkt/D1A3 OO/X4H8EXfiPS4XFlwKi0TS5vJ+dtgfdSeyAfIMR+w1b9+/YoYD04ANWhfZ3RYyNIx+n PBsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hxlzhilvpbhmfegLmBqfpD7CzDK63zsBFUHMpLeOrf8=; b=A/PraC7SAokqaYdKRbv9docyq+fZrYfo0FJQBRahp4wDG/dnIrExJ/irXNDtJXg5dZ x6gALQY66fpToxGagpktejG3fWycF7B99P7geAEC5C0ORpumNGZ3U1AoWIyYSZOgLlpY qx4Cb+qBcMtiHGIMq2q840P6BCROEztyEHnLfC0pT7PtDbQmdxyKrMjtyzKmsxZwZVWH ZzYppPbaTkHcoApOEI9HVJZKz5wRqRh0lumHZLaEX/pXZINbAs75dW1V9z7wYM0WiyP0 hPa+dYGqwqT2v0Nf/d/erm2mqPdbQ13fsCwz9t0+DAMv3K5rpdweR4+YB04zb0CF59AY c28g== X-Gm-Message-State: AOAM531arEcHXcl0Lj1sVykn72ym2H9WRgKUfo2p7KDx31ugrMRyYdC4 6dPU2uWqPeRd+lMciKvscrXwSRCzNaw= X-Google-Smtp-Source: ABdhPJzpXE7rX9+PiFNYZWRcw3RheNt5DShOYBGze0ylmEzhCuKl6oc5Z0S0RvMEH6h/H7A7bvvoOA== X-Received: by 2002:a17:902:9001:: with SMTP id a1mr1377741plp.124.1596600683704; Tue, 04 Aug 2020 21:11:23 -0700 (PDT) Received: from Asurada-Nvidia (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id x127sm1108891pfd.86.2020.08.04.21.11.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Aug 2020 21:11:23 -0700 (PDT) Date: Tue, 4 Aug 2020 21:11:11 -0700 From: Nicolin Chen To: Shengjiu Wang Cc: timur@kernel.org, Xiubo.Lee@gmail.com, festevam@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] ASoC: fsl_sai: Refine enable and disable sequence for synchronous mode Message-ID: <20200805041111.GB10174@Asurada-Nvidia> References: <1596594233-13489-1-git-send-email-shengjiu.wang@nxp.com> <1596594233-13489-3-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1596594233-13489-3-git-send-email-shengjiu.wang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2020 at 10:23:53AM +0800, Shengjiu Wang wrote: > Tx synchronous with Rx: > The TCSR.TE is no need to enabled when only Rx is going to be enabled. > Check if need to disable RSCR.RE before disabling TCSR.TE. > > Rx synchronous with Tx: > The RCSR.RE is no need to enabled when only Tx is going to be enabled. > Check if need to disable TSCR.RE before disabling RCSR.TE. Please add to the commit log more context such as what we have discussed: what's the problem of the current driver, and why we _have_to_ apply this change though it's sightly against what RM recommends. (If thing is straightforward, it's okay to make the text short. Yet I believe that this change deserves more than these lines.) One info that you should mention -- also the main reason why I'm convinced to add this change: trigger() is still in the shape of the early version where we only supported one operation mode -- Tx synchronous with Rx. So we need an update for other modes. > Signed-off-by: Shengjiu Wang The git-diff part looks good, please add this in next ver.: Reviewed-by: Nicolin Chen Btw, the new fsl_sai_dir_is_synced() can be probably applied to other places with a followup patch.