From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554A0C433DF for ; Wed, 5 Aug 2020 05:16:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D636020842 for ; Wed, 5 Aug 2020 05:16:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="tdkBjsCp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AFmxb7f8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D636020842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4CE4884A; Wed, 5 Aug 2020 07:15:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4CE4884A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596604591; bh=/n77pfE4a+GOKvicmljT/QtRWcD5OcaFIdllbQ5Y/wY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tdkBjsCpmE9iVHhFxNqjNGNTRAtEV+JhUXtJG0YMWzQywMqQIgdIKXGRmRBwKserZ 5akYtVYb2SzdYqLaXbE1yu12QjAMnSq2cGVDsiNeXdQkWZ0gbJMiKY9upE3DWN+mqO 00AtyKgpTufm5mOWwLU8xK6OhOyMlqQW3hYzTyAI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CDE5AF80124; Wed, 5 Aug 2020 07:15:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 519EEF80218; Wed, 5 Aug 2020 07:15:39 +0200 (CEST) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F3AD3F800B7 for ; Wed, 5 Aug 2020 07:15:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F3AD3F800B7 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AFmxb7f8" Received: by mail-pg1-x541.google.com with SMTP id j19so23747169pgm.11 for ; Tue, 04 Aug 2020 22:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/n77pfE4a+GOKvicmljT/QtRWcD5OcaFIdllbQ5Y/wY=; b=AFmxb7f8d9u4khyrON5HeLJwb1Qw5QvNvEXE0doBoJbYvgEvXafs8WeN9n7auMuuAF VXPoMIf1mSknY/cVdcBCMW8L6eBpi4J7dwrN5Zi5PLjH2PUm8Lm7V2AYxw+rb8ThXBik KLVB5HrUo+2v2qtsNCpehTNZab+H5ACdib6DdIPEi78GG/7snFgF+lh5TBGT6HNOd3xU ynDWad+UVkv0Xo5MvddZnnu5tENt9XHaqz9D1HtZzAGoWAnepvaHLfsVnBRgKBv6RWsk USORzkHoGh/7EGz5XAWvITM5OjG1m4qrxdoQSKJAubGvkJ+0kEmsUD31VGsdMKqjH5++ mSWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/n77pfE4a+GOKvicmljT/QtRWcD5OcaFIdllbQ5Y/wY=; b=ncizUy8HiBhaFUgkxBV/wseC0pqLMm27onIJX60v4R/CJ68QIVNLEzkpw6j+4sSYfs eU4SQV+rxNhqFNq8ryibEwgj49hyH8hQv3+i8I3+VyS/7YmBK43jP+QY2JSI1tGoGw9T AjSBwhTPffuNDKg+nhvm4vRt9QaC2vJFKCUfpQTlkWUNY2zefWhB898dAJr81TLAzM7C wURGwa9ssAPlXFXgLY9/tKftU96iJytXkWo3SGXHmt1wYzt6v+YKX657iMVUdYMKfHiS j2DQbfrC80/n0ADiDcDu57L8YbTIxidQUNyt5fyETOUG9+f0N5Hj2o0X8M1xJw1/y3M3 VDMA== X-Gm-Message-State: AOAM5300buTK8G7SovWy6KJRfSXJUQc3mhDrdhV92grf+ZnRAgJ8bSYh ykfuNP7cAEEGBUPy9KYVLl4ZeOTieok= X-Google-Smtp-Source: ABdhPJznedC2BZI3gT80R+gKb4MGfnESYyp4nkwqsAQ81pws/5kKeVDVr8qut1B0dpAbnle7RGQ0Gw== X-Received: by 2002:a05:6a00:14d3:: with SMTP id w19mr1664143pfu.92.1596604526362; Tue, 04 Aug 2020 22:15:26 -0700 (PDT) Received: from Asurada-Nvidia (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id h5sm1322799pfq.146.2020.08.04.22.15.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Aug 2020 22:15:26 -0700 (PDT) Date: Tue, 4 Aug 2020 22:15:12 -0700 From: Nicolin Chen To: Shengjiu Wang Subject: Re: [PATCH v2 2/2] ASoC: fsl_sai: Refine enable and disable sequence for synchronous mode Message-ID: <20200805051511.GA29129@Asurada-Nvidia> References: <1596594233-13489-1-git-send-email-shengjiu.wang@nxp.com> <1596594233-13489-3-git-send-email-shengjiu.wang@nxp.com> <20200805041111.GB10174@Asurada-Nvidia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Cc: Linux-ALSA , Timur Tabi , Xiubo Li , Fabio Estevam , Shengjiu Wang , Takashi Iwai , Liam Girdwood , Mark Brown , linuxppc-dev@lists.ozlabs.org, linux-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Aug 05, 2020 at 01:03:37PM +0800, Shengjiu Wang wrote: > > Btw, the new fsl_sai_dir_is_synced() can be probably applied to > > other places with a followup patch. > Do you mean move it to the beginning of this file? There are other existing places testing "sync[tx] && !sync[!tx]" so you may submit another change to replace them. But, yea, will be a good idea to move that helper function to the top. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E9A0C433E0 for ; Wed, 5 Aug 2020 05:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C14A222CA0 for ; Wed, 5 Aug 2020 05:15:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AFmxb7f8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726221AbgHEFP1 (ORCPT ); Wed, 5 Aug 2020 01:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgHEFP0 (ORCPT ); Wed, 5 Aug 2020 01:15:26 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E20B8C06174A for ; Tue, 4 Aug 2020 22:15:26 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id s15so12210514pgc.8 for ; Tue, 04 Aug 2020 22:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/n77pfE4a+GOKvicmljT/QtRWcD5OcaFIdllbQ5Y/wY=; b=AFmxb7f8d9u4khyrON5HeLJwb1Qw5QvNvEXE0doBoJbYvgEvXafs8WeN9n7auMuuAF VXPoMIf1mSknY/cVdcBCMW8L6eBpi4J7dwrN5Zi5PLjH2PUm8Lm7V2AYxw+rb8ThXBik KLVB5HrUo+2v2qtsNCpehTNZab+H5ACdib6DdIPEi78GG/7snFgF+lh5TBGT6HNOd3xU ynDWad+UVkv0Xo5MvddZnnu5tENt9XHaqz9D1HtZzAGoWAnepvaHLfsVnBRgKBv6RWsk USORzkHoGh/7EGz5XAWvITM5OjG1m4qrxdoQSKJAubGvkJ+0kEmsUD31VGsdMKqjH5++ mSWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/n77pfE4a+GOKvicmljT/QtRWcD5OcaFIdllbQ5Y/wY=; b=jylU1EaeS4nLBF25OwsBAj+7bXv0lymH71MzS8QTq36lf3dY2qA/L852dXSTPixDj1 Q2Decygf3/FAs+jPSFeCZMfXDzZsC51bDO6bJIdXMYSNenPJM9JYO5fnMFYLp9NSdbkr IR7TDLk32FdDGWLkkFbK9nppEBSFRb40bSqxDpD2ztXDiQdgPXcv+pZ70WVCABxWxyq9 A4I30kTLz+K8Q9ckGmhXQj+vZMbIB9BwPCKn2sgZnMqpOm14vA5FdorgodOcX58tIYFM tqc1i4J3fjn0mSUyMRGLiQIeC8l7WwuIPpLwRtLo/SnOMn8/YQ7N3/VPGHAWxF3S/ctc WW0Q== X-Gm-Message-State: AOAM5318gPqf05LtPrCIBR9R91PWFAlS69Nw9rM+EBNpmuXlOUKHHZk8 RX78uTdvE8DV4i3+r7npKjc= X-Google-Smtp-Source: ABdhPJznedC2BZI3gT80R+gKb4MGfnESYyp4nkwqsAQ81pws/5kKeVDVr8qut1B0dpAbnle7RGQ0Gw== X-Received: by 2002:a05:6a00:14d3:: with SMTP id w19mr1664143pfu.92.1596604526362; Tue, 04 Aug 2020 22:15:26 -0700 (PDT) Received: from Asurada-Nvidia (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id h5sm1322799pfq.146.2020.08.04.22.15.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Aug 2020 22:15:26 -0700 (PDT) Date: Tue, 4 Aug 2020 22:15:12 -0700 From: Nicolin Chen To: Shengjiu Wang Cc: Shengjiu Wang , Linux-ALSA , Timur Tabi , Xiubo Li , linuxppc-dev@lists.ozlabs.org, Takashi Iwai , Liam Girdwood , Mark Brown , Fabio Estevam , linux-kernel Subject: Re: [PATCH v2 2/2] ASoC: fsl_sai: Refine enable and disable sequence for synchronous mode Message-ID: <20200805051511.GA29129@Asurada-Nvidia> References: <1596594233-13489-1-git-send-email-shengjiu.wang@nxp.com> <1596594233-13489-3-git-send-email-shengjiu.wang@nxp.com> <20200805041111.GB10174@Asurada-Nvidia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2020 at 01:03:37PM +0800, Shengjiu Wang wrote: > > Btw, the new fsl_sai_dir_is_synced() can be probably applied to > > other places with a followup patch. > Do you mean move it to the beginning of this file? There are other existing places testing "sync[tx] && !sync[!tx]" so you may submit another change to replace them. But, yea, will be a good idea to move that helper function to the top.