From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Ajay Gupta <ajayg@nvidia.com>, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24()
Date: Wed, 5 Aug 2020 11:28:42 +0200 [thread overview]
Message-ID: <20200805092842.GL1229@kunai> (raw)
In-Reply-To: <20200716145319.53773-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Thu, Jul 16, 2020 at 05:53:19PM +0300, Andy Shevchenko wrote:
> This makes the driver code slightly easier to read.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Ajay, any comments?
> drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
> index f480105000b8..f9a69b109e5c 100644
> --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
> +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
> @@ -125,8 +125,7 @@ static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8 *data, u16 len)
> put_unaligned_be16(val, data);
> break;
> case 3:
> - put_unaligned_be16(val >> 8, data);
> - data[2] = val;
> + put_unaligned_be24(val, data);
> break;
> case 4:
> put_unaligned_be32(val, data);
> --
> 2.27.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-05 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 14:53 [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24() Andy Shevchenko
2020-08-05 9:28 ` Wolfram Sang [this message]
2020-08-06 5:18 ` Ajay Gupta
2020-09-21 10:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805092842.GL1229@kunai \
--to=wsa+renesas@sang-engineering.com \
--cc=ajayg@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.