From: Kevin Wolf <kwolf@redhat.com>
To: Ying Fang <fangying1@huawei.com>
Cc: alex.chen@huawei.com, zhang.zhanghailiang@huawei.com,
qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters
Date: Thu, 6 Aug 2020 11:13:26 +0200 [thread overview]
Message-ID: <20200806091326.GC17753@linux.fritz.box> (raw)
In-Reply-To: <20200805023826.184-1-fangying1@huawei.com>
Am 05.08.2020 um 04:38 hat Ying Fang geschrieben:
> From: fangying <fangying1@huawei.com>
>
> When qemu or qemu-nbd process uses a qcow2 image and configured with
> 'cache = none', it will write to the qcow2 image with a cache to cache
> L2 tables, however the process will not use L2 tables without explicitly
> calling the flush command or closing the mirror flash into the disk.
> Which may cause the disk data inconsistent with the written data for
> a long time. If an abnormal process exit occurs here, the issued written
> data will be lost.
>
> Therefore, in order to keep data consistency we need to flush the changes
> to the L2 entry to the disk in time for the newly allocated cluster.
>
> Signed-off-by: Ying Fang <fangying1@huawei.com>
If you want to have data safely written to the disk after each write
request, you need to use cache=writethrough/directsync (in other words,
aliases that are equivalent to setting -device ...,write-cache=off).
Note that this will have a major impact on write performance.
cache=none means bypassing the kernel page cache (O_DIRECT), but not
flushing after each write request.
Kevin
next prev parent reply other threads:[~2020-08-06 11:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 2:38 [PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters Ying Fang
2020-08-05 2:43 ` no-reply
2020-08-06 9:01 ` Ying Fang
2020-08-06 9:04 ` Daniel P. Berrangé
2020-08-06 9:13 ` Kevin Wolf [this message]
2020-08-07 7:42 ` Ying Fang
2020-08-07 8:13 ` Kevin Wolf
2020-08-14 2:26 ` Ying Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806091326.GC17753@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=alex.chen@huawei.com \
--cc=fangying1@huawei.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.