From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 6 Aug 2020 13:46:45 -0400 From: Vivek Goyal Message-ID: <20200806174645.GG367847@redhat.com> References: <20200727161841.GA54539@redhat.com> <20200806174129.GK2711@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200806174129.GK2711@work-vm> Subject: Re: [Virtio-fs] [PATCH] virtiofsd: Disable remote posix locks by default List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: "misono.tomohiro@fujitsu.com" , virtio-fs-list , "qemu-devel@nongnu.org" On Thu, Aug 06, 2020 at 06:41:29PM +0100, Dr. David Alan Gilbert wrote: > * misono.tomohiro@fujitsu.com (misono.tomohiro@fujitsu.com) wrote: > > > Right now we enable remote posix locks by default. That means when guest does a posix lock it sends request to server > > > (virtiofsd). But currently we only support non-blocking posix lock and return -EOPNOTSUPP for blocking version. > > > > > > This means that existing applications which are doing blocking posix locks get -EOPNOTSUPP and fail. To avoid this, > > > people have been running virtiosd with option "-o no_posix_lock". For new users it is still a surprise and trial and error > > > takes them to this option. > > > > > > Given posix lock implementation is not complete in virtiofsd, disable it by default. This means that posix locks will work > > > with-in applications in a guest but not across guests. Anyway we don't support sharing filesystem among different guests > > > yet in virtiofs so this should not lead to any kind of surprise or regression and will make life little easier for virtiofs users. > > > > > > Reported-by: Aa Aa > > > Suggested-by: Miklos Szeredi > > > Signed-off-by: Vivek Goyal > > > --- > > > tools/virtiofsd/passthrough_ll.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > We should update docs/tools/virtiofsd.rst as well. Given that: > > Reviewed-by: Misono Tomohiro > > Fixed up the doc. Aha.. Looks like we were looking at this at the same time. Thanks for taking care of this Dave. Vivek