From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ACF4C433DF for ; Fri, 7 Aug 2020 11:29:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 310252177B for ; Fri, 7 Aug 2020 11:29:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WnRYJ+Ga" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 310252177B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8262B6E108; Fri, 7 Aug 2020 11:29:21 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D13F6E108 for ; Fri, 7 Aug 2020 11:29:20 +0000 (UTC) Received: from coco.lan (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E71C72075D; Fri, 7 Aug 2020 11:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596799760; bh=2JO2qwpAelZwwN528SuEDP5/1BeDcXQDZwzFngk84Mg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WnRYJ+GaYJUsUT1XcKXM1hxTWAAVWjVPJ9Mz64glMrlMGtb4SFiQTL3VDutmtW+KR 6YnfVbTEP0Dx3+oJ7Oe7N8ChP9LyKemQ3AwB5VANkYujn3vwqVG0TW7cpB2RrI8b1l O703VSR0SYxMqQPuLFR8xKJ0rIhyGUD93qkK7ims= Date: Fri, 7 Aug 2020 13:29:16 +0200 From: Mauro Carvalho Chehab To: Sam Ravnborg Subject: Re: DRM/KMS experimental drivers for HiKey 970 Message-ID: <20200807132916.70772823@coco.lan> In-Reply-To: <20200807085943.GA966139@ravnborg.org> References: <20200805105137.2b272efc@coco.lan> <20200807092418.57843051@coco.lan> <20200807085943.GA966139@ravnborg.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel , mani@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Em Fri, 7 Aug 2020 10:59:43 +0200 Sam Ravnborg escreveu: > Hi Mauro. > > > > > I know. What can be done is to send a diff at patch 00/xx with > > the entire history for each driver folded, in order to easy > > for reviewers. > Personnaly this would be preferred as I assume the history is a lot of > forth and back rather than incremental logical changes. Actually, it is not that bad. The changes at the code are incremental. I suspect that the initial patch is actually a folded changeset for the Linaro's 4.9 Kernel tree. The changes afterwards happened inside the Linaro tree, more or less following the usual one patch per logical change approach. On the top of that, there are the changes I did myself, in order to port it from 4.9. Having those at the history helps a lot, in the case I made any mistake on such ports. > No promises of any useful reviews though... A review on the folded change should be enough. In case of doubts about something, the detailed changeset could be useful, specially to help identifying eventual mistakes I could have done during the port. Anyway, my plan is to first get the non-DRM changesets reviewed, as I may need to modify some things depending on the feedback from the other subsystems. Thanks, Mauro _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel