From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Lew <clew@codeaurora.org>
Cc: Deepak Kumar Singh <deesin@codeaurora.org>,
bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
Arun Kumar Neelakantam <aneela@codeaurora.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
"open list:REMOTE PROCESSOR MESSAGING (RPMSG) SUBSYSTEM"
<linux-remoteproc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V7 2/4] rpmsg: Guard against null endpoint ops in destroy
Date: Sat, 8 Aug 2020 07:55:18 +0200 [thread overview]
Message-ID: <20200808055518.GF1037591@kroah.com> (raw)
In-Reply-To: <e7fc6957-5065-9dbc-2f2d-d24893fead63@codeaurora.org>
On Fri, Aug 07, 2020 at 05:33:53PM -0700, Chris Lew wrote:
> Hi Greg,
>
> On 8/7/2020 12:59 AM, Greg KH wrote:
> > On Wed, Jun 24, 2020 at 10:15:19PM +0530, Deepak Kumar Singh wrote:
> > > From: Chris Lew <clew@codeaurora.org>
> > >
> > > In RPMSG GLINK the chrdev device will allocate an ept as part of the
> > > rpdev creation. This device will not register endpoint ops even though
> > > it has an allocated ept. Protect against the case where the device is
> > > being destroyed.
> > >
> > > Signed-off-by: Chris Lew <clew@codeaurora.org>
> > > Signed-off-by: Deepak Kumar Singh <deesin@codeaurora.org>
> > > Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
> >
> > Should this be marked for stable kernels?
> >
> > And if so, what commit does this fix? Any reason the Fixes: tag was not
> > used here?
> >
>
> The crash that this fixes doesn't show up unless one of the previous patches
> in the series is applied.
>
> [PATCH V6 3/5] rpmsg: glink: Add support for rpmsg glink chrdev
>
> I'm not sure if the fixes tag should apply to this change or one of the
> commits to the base rpmsg code.
That's a different series, why not merge this patch with that one so
there is no need for a fix if none of this has been merged yet?
> > And what happened to this series? I don't see it in linux-next, did the
> > maintainer ignore it?
> >
>
> I believe most of the review feedback for the series has been addressed by
> Deepak. There is one remaining action item for me and Deepak to provide more
> concrete evidence that the first patch in the series is needed.
>
> [PATCH V6 1/5] rpmsg: glink: Use complete_all for open states
Ok, thanks, just didn't want to see this get forgotten...
greg k-h
next prev parent reply other threads:[~2020-08-08 5:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1593017121-7953-1-git-send-email-deesin@codeaurora.org>
2020-06-24 16:45 ` [PATCH V7 1/4] rpmsg: glink: Use complete_all for open states Deepak Kumar Singh
2020-09-15 5:00 ` patchwork-bot+linux-remoteproc
2020-06-24 16:45 ` [PATCH V7 2/4] rpmsg: Guard against null endpoint ops in destroy Deepak Kumar Singh
2020-08-07 7:59 ` Greg KH
2020-08-08 0:33 ` Chris Lew
2020-08-08 5:55 ` Greg KH [this message]
2020-06-24 16:45 ` [PATCH V7 3/4] rpmsg: glink: Add support for rpmsg glink chrdev Deepak Kumar Singh
2020-06-24 16:45 ` [PATCH V7 4/4] rpmsg: glink: Expose rpmsg name attr for glink Deepak Kumar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808055518.GF1037591@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aneela@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=deesin@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.