From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E231CC433DF for ; Sat, 8 Aug 2020 10:25:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B389B2087C for ; Sat, 8 Aug 2020 10:25:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uFKsFYty" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B389B2087C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C8BA6E204; Sat, 8 Aug 2020 10:25:01 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAAA06E204 for ; Sat, 8 Aug 2020 10:24:59 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1080B20748; Sat, 8 Aug 2020 10:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596882298; bh=EzN2OPCQKm6E+fKW7n/naWHLH9Bx9qn5xJ62OMUy8CQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uFKsFYtyHMVteYWuEaR3uiMrRe+WU8WysWPeJoiHdrWUpz32eUimcJyjRrcE63efN s9h21FXvSTUcGfKkZJ4NS4vI6RgJvQ1IsAc+Qg90hUe0nhWuemot8N3PATbAob4yHz 9qwR503jn7ZVcuR/CcuJClCWHdwhTHp305Qu4ngk= Date: Sat, 8 Aug 2020 12:25:12 +0200 From: Greg KH To: Daniel Vetter Subject: Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree? Message-ID: <20200808102512.GA3039253@kroah.com> References: <159680700523135@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof Kozlowski , dri-devel , armijn@tjaldur.nl, Gerd Hoffmann , Thomas Zimmermann , Alex Deucher , Dave Airlie , stable , Sam Ravnborg , Thomas Gleixner , Emil Velikov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Aug 08, 2020 at 11:13:54AM +0200, Daniel Vetter wrote: > On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann wrote: > > > > Hi > > > > Am 07.08.20 um 15:30 schrieb gregkh@linuxfoundation.org: > > > The patch below was submitted to be applied to the 5.8-stable tree. > > > > > > I fail to see how this patch meets the stable kernel rules as found at > > > Documentation/process/stable-kernel-rules.rst. > > > > > > I could be totally wrong, and if so, please respond to > > > and let me know why this patch should be > > > applied. Otherwise, it is now dropped from my patch queues, never to be > > > seen again. > > > > Sorry for the noise. There's no reason this should go into stable. > > We have a little script in our maintainer toolbox for bugfixes, which > generates the Fixes: line, adds everyone from the original commit to > the cc: list and also adds Cc: stable if that sha1 the patch fixes is > in a release already. > > I guess we trained people a bit too much on using Fixes: tags like > that with the tooling, since they often do that for checkpatch stuff > and spelling fixes like this here too. I think the autoselect bot also > loves Fixes: tags a bit too much for its own good. > > Not sure what to do, since telling people to "please sprinkle less > Fixes: tags" doesn't sound great either. I also don't want to tell > people to use the maintainer toolbox less, the autogenerated cc: list > is generally the right thing to do. Maybe best if the stable team > catches the obvious ones before adding them to the stable queue, if > you're ok with that Greg? As I think this is the first time that I've had this problem for a DRM submission, I don't think it's a big issue yet at all, so whatever you are doing today is fine. I do think that the number of patches submitted for stable for drm-related issues feels very very low given the rate of change and number of overall patches you all submit to the kernel, so if anything, you all should be increasing the number of times you tag stuff for stable, not reducing it :) thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2693CC433DF for ; Sat, 8 Aug 2020 10:25:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1C462087C for ; Sat, 8 Aug 2020 10:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596882300; bh=EzN2OPCQKm6E+fKW7n/naWHLH9Bx9qn5xJ62OMUy8CQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mkWCT5SOANDpPsdJL6TX6zAtbCuDEgxA0xVg5tnU4SYo8H4yrBQHKlp1VMeq1Kwou onlVFmHk2M2tF033RCRr84YZem+8GbWxjv+BdlAFBlt7bqtlNV9COX5GG2JcL22ZKY r+dzE7s+TYA/zhzVNgYMF8QSgUhqLEnXgltjHe7M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726190AbgHHKY7 (ORCPT ); Sat, 8 Aug 2020 06:24:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:33012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbgHHKY7 (ORCPT ); Sat, 8 Aug 2020 06:24:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1080B20748; Sat, 8 Aug 2020 10:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596882298; bh=EzN2OPCQKm6E+fKW7n/naWHLH9Bx9qn5xJ62OMUy8CQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uFKsFYtyHMVteYWuEaR3uiMrRe+WU8WysWPeJoiHdrWUpz32eUimcJyjRrcE63efN s9h21FXvSTUcGfKkZJ4NS4vI6RgJvQ1IsAc+Qg90hUe0nhWuemot8N3PATbAob4yHz 9qwR503jn7ZVcuR/CcuJClCWHdwhTHp305Qu4ngk= Date: Sat, 8 Aug 2020 12:25:12 +0200 From: Greg KH To: Daniel Vetter Cc: Thomas Zimmermann , dri-devel , Dave Airlie , Alex Deucher , armijn@tjaldur.nl, Emil Velikov , Gerd Hoffmann , Krzysztof Kozlowski , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Sam Ravnborg , stable , Thomas Gleixner Subject: Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree? Message-ID: <20200808102512.GA3039253@kroah.com> References: <159680700523135@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sat, Aug 08, 2020 at 11:13:54AM +0200, Daniel Vetter wrote: > On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann wrote: > > > > Hi > > > > Am 07.08.20 um 15:30 schrieb gregkh@linuxfoundation.org: > > > The patch below was submitted to be applied to the 5.8-stable tree. > > > > > > I fail to see how this patch meets the stable kernel rules as found at > > > Documentation/process/stable-kernel-rules.rst. > > > > > > I could be totally wrong, and if so, please respond to > > > and let me know why this patch should be > > > applied. Otherwise, it is now dropped from my patch queues, never to be > > > seen again. > > > > Sorry for the noise. There's no reason this should go into stable. > > We have a little script in our maintainer toolbox for bugfixes, which > generates the Fixes: line, adds everyone from the original commit to > the cc: list and also adds Cc: stable if that sha1 the patch fixes is > in a release already. > > I guess we trained people a bit too much on using Fixes: tags like > that with the tooling, since they often do that for checkpatch stuff > and spelling fixes like this here too. I think the autoselect bot also > loves Fixes: tags a bit too much for its own good. > > Not sure what to do, since telling people to "please sprinkle less > Fixes: tags" doesn't sound great either. I also don't want to tell > people to use the maintainer toolbox less, the autogenerated cc: list > is generally the right thing to do. Maybe best if the stable team > catches the obvious ones before adding them to the stable queue, if > you're ok with that Greg? As I think this is the first time that I've had this problem for a DRM submission, I don't think it's a big issue yet at all, so whatever you are doing today is fine. I do think that the number of patches submitted for stable for drm-related issues feels very very low given the rate of change and number of overall patches you all submit to the kernel, so if anything, you all should be increasing the number of times you tag stuff for stable, not reducing it :) thanks, greg k-h