From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Dilip Kota <eswara.kota@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
linux-spi@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 20/21] spi: lantiq: fix: Rx overflow error in full duplex mode
Date: Sat, 8 Aug 2020 19:39:40 -0400 [thread overview]
Message-ID: <20200808233941.3619277-20-sashal@kernel.org> (raw)
In-Reply-To: <20200808233941.3619277-1-sashal@kernel.org>
From: Dilip Kota <eswara.kota@linux.intel.com>
[ Upstream commit 661ccf2b3f1360be50242726f7c26ced6a9e7d52 ]
In full duplex mode, rx overflow error is observed. To overcome the error,
wait until the complete data got received and proceed further.
Fixes: 17f84b793c01 ("spi: lantiq-ssc: add support for Lantiq SSC SPI controller")
Signed-off-by: Dilip Kota <eswara.kota@linux.intel.com>
Link: https://lore.kernel.org/r/efb650b0faa49a00788c4e0ca8ef7196bdba851d.1594957019.git.eswara.kota@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/spi/spi-lantiq-ssc.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/spi/spi-lantiq-ssc.c b/drivers/spi/spi-lantiq-ssc.c
index d5976615d924b..dc740b5f720ba 100644
--- a/drivers/spi/spi-lantiq-ssc.c
+++ b/drivers/spi/spi-lantiq-ssc.c
@@ -187,6 +187,7 @@ struct lantiq_ssc_spi {
unsigned int tx_fifo_size;
unsigned int rx_fifo_size;
unsigned int base_cs;
+ unsigned int fdx_tx_level;
};
static u32 lantiq_ssc_readl(const struct lantiq_ssc_spi *spi, u32 reg)
@@ -484,6 +485,7 @@ static void tx_fifo_write(struct lantiq_ssc_spi *spi)
u32 data;
unsigned int tx_free = tx_fifo_free(spi);
+ spi->fdx_tx_level = 0;
while (spi->tx_todo && tx_free) {
switch (spi->bits_per_word) {
case 2 ... 8:
@@ -512,6 +514,7 @@ static void tx_fifo_write(struct lantiq_ssc_spi *spi)
lantiq_ssc_writel(spi, data, LTQ_SPI_TB);
tx_free--;
+ spi->fdx_tx_level++;
}
}
@@ -523,6 +526,13 @@ static void rx_fifo_read_full_duplex(struct lantiq_ssc_spi *spi)
u32 data;
unsigned int rx_fill = rx_fifo_level(spi);
+ /*
+ * Wait until all expected data to be shifted in.
+ * Otherwise, rx overrun may occur.
+ */
+ while (rx_fill != spi->fdx_tx_level)
+ rx_fill = rx_fifo_level(spi);
+
while (rx_fill) {
data = lantiq_ssc_readl(spi, LTQ_SPI_RB);
--
2.25.1
next prev parent reply other threads:[~2020-08-08 23:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 23:39 [PATCH AUTOSEL 4.19 01/21] x86/mce/inject: Fix a wrong assignment of i_mce.status Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 02/21] sched/fair: Fix NOHZ next idle balance Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 03/21] sched: correct SD_flags returned by tl->sd_flags() Sasha Levin
[not found] ` <20200808233941.3619277-1-sashal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 04/21] arm64: dts: rockchip: fix rk3368-lion gmac reset gpio Sasha Levin
2020-08-08 23:39 ` Sasha Levin
2020-08-08 23:39 ` Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 05/21] arm64: dts: rockchip: fix rk3399-puma vcc5v0-host gpio Sasha Levin
2020-08-08 23:39 ` Sasha Levin
2020-08-08 23:39 ` Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 06/21] arm64: dts: rockchip: fix rk3399-puma gmac reset gpio Sasha Levin
2020-08-08 23:39 ` Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 07/21] EDAC: Fix reference count leaks Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 08/21] arm64: dts: qcom: msm8916: Replace invalid bias-pull-none property Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 09/21] crypto: ccree - fix resource leak on error path Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 10/21] firmware: arm_scmi: Fix SCMI genpd domain probing Sasha Levin
2020-08-08 23:39 ` Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 11/21] arm64: dts: exynos: Fix silent hang after boot on Espresso Sasha Levin
2020-08-08 23:39 ` Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 12/21] clk: scmi: Fix min and max rate when registering clocks with discrete rates Sasha Levin
2020-08-08 23:39 ` Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 13/21] m68k: mac: Don't send IOP message until channel is idle Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 14/21] m68k: mac: Fix IOP status/control register writes Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 15/21] platform/x86: intel-hid: Fix return value check in check_acpi_dev() Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 16/21] platform/x86: intel-vbtn: " Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 17/21] ARM: dts: gose: Fix ports node name for adv7180 Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 18/21] ARM: dts: gose: Fix ports node name for adv7612 Sasha Levin
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 19/21] ARM: at91: pm: add missing put_device() call in at91_pm_sram_init() Sasha Levin
2020-08-08 23:39 ` Sasha Levin
2020-08-08 23:39 ` Sasha Levin [this message]
2020-08-08 23:39 ` [PATCH AUTOSEL 4.19 21/21] ARM: socfpga: PM: add missing put_device() call in socfpga_setup_ocram_self_refresh() Sasha Levin
2020-08-08 23:39 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808233941.3619277-20-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=eswara.kota@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.